Re: Proposal: Drop support for Internet Explorer
Hi On Thu, Apr 9, 2020 at 12:26 AM Darren Duncan wrote: > If its hard to know how many people are actually using Internet Explorer: > > You could make the next release of pgAdmin display a message occasionally > to > users of Internet Explorer saying that Internet Explorer will no longer be > officially supported in a future version, and when that version comes the > message says now no longer supported. > > You can then see how many people contact you about this to express concern. > Good idea. I've hacked up a patch to warn users if they're using a deprecated or unsupported browser. CCing Akshay for a review :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company Warn_if_using_a_deprecated_or_unsupported_browser.patch Description: Binary data
[pgAdmin4][RM#2813] Do not prompt for database server password once user saves it
Hi, There was an issue where the user used trust mode to connect to the database server and saves a blank password, and next time when the user tries to connect from pgadmin, pgadmin again asks for the password. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2813.diff Description: Binary data
pgAdmin 4 commit: Added support of Foreign Tables to the Schema Diff. F
Added support of Foreign Tables to the Schema Diff. Fixes #5263 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31f255b541f745f0b5a68d9733744e352c1faa94 Modified Files -- docs/en_US/release_notes_4_21.rst | 1 + .../databases/schemas/foreign_tables/__init__.py | 137 +++-- .../foreign_tables/sql/9.2_plus/get_columns.sql| 2 +- .../sql/9.5_plus/foreign_table_schema_diff.sql | 76 .../foreign_tables/sql/9.5_plus/get_columns.sql| 2 +- .../foreign_tables/sql/9.5_plus/update.sql | 11 ++ .../schemas/tables/compound_triggers/__init__.py | 4 +- .../databases/schemas/tables/rules/__init__.py | 4 +- .../databases/schemas/tables/triggers/__init__.py | 4 +- web/pgadmin/tools/schema_diff/directory_compare.py | 26 ++-- .../tools/schema_diff/tests/pg/10_plus/source.sql | 104 .../tools/schema_diff/tests/pg/10_plus/target.sql | 106 .../tools/schema_diff/tests/pg/11_plus/source.sql | 104 .../tools/schema_diff/tests/pg/11_plus/target.sql | 106 .../tools/schema_diff/tests/pg/12_plus/source.sql | 104 .../tools/schema_diff/tests/pg/12_plus/target.sql | 106 .../tools/schema_diff/tests/pg/9.2_plus/source.sql | 104 .../tools/schema_diff/tests/pg/9.2_plus/target.sql | 106 .../schema_diff/tests/ppas/10_plus/source.sql | 110 - .../schema_diff/tests/ppas/10_plus/target.sql | 110 - .../schema_diff/tests/ppas/9.2_plus/source.sql | 106 +++- .../schema_diff/tests/ppas/9.2_plus/target.sql | 108 +++- 22 files changed, 1510 insertions(+), 31 deletions(-)
pgAdmin 4 commit: Fixed API/RESQL test cases for View/MView failed due
Fixed API/RESQL test cases for View/MView failed due to #5053 commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fecf3915c564b1c3c1531fecc2739d88e53af991 Modified Files -- .../servers/databases/schemas/views/__init__.py| 2 +- .../pg/9.4_plus/alter_view_add_some_priv_msql.sql | 4 .../schemas/views/tests/pg/9.4_plus/tests.json | 18 -- .../ppas/9.4_plus/alter_view_add_some_priv_msql.sql| 4 .../schemas/views/tests/ppas/9.4_plus/tests.json | 18 -- 5 files changed, 1 insertion(+), 45 deletions(-)
pgAdmin 4 commit: Fixed typo
Fixed typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c8646f99c0bbb2ddd1e89e677fe8a7fc227cb062 Modified Files -- web/pgadmin/tools/schema_diff/tests/ppas/10_plus/source.sql | 4 ++-- web/pgadmin/tools/schema_diff/tests/ppas/10_plus/target.sql | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Re: Proposal: Drop support for Internet Explorer
The patch looks good as much as I understand it, but this raises an important question: How should one best handle minority browsers that may be completely modern but you may not specifically know about them? Such as the newer crop of browsers that emphasize stronger privacy or may have fewer identifiers? While going on a whitelist as the patch essentially does for known good browsers is conservative, I feel that an alteration would be good. I propose dividing the browsers/environments into 3 categories, which are recognized-supported, recognized-unsupported, and unrecognized. So the unsupported older versions of supported browsers get a stronger message encouraging a browser switch as they are recognized as unsupported, while unrecognized browsers get a different weaker message saying they weren't recognized so we can't determine if they'd work; both can point to the list of known supported browsers. Related to this, there could be an application toggle that affects the unrecognized category where users can basically say, yes I understand you don't recognize this browser, please hide the warning, or something like that. Also, it probably goes without saying, but the code/templates will need to be structured in such a way that the warning message uses about plain as possible HTML so that if the browser doesn't support displaying the UI in general it can at least display the message. -- Darren Duncan On 2020-04-09 4:36 a.m., Dave Page wrote: Hi On Thu, Apr 9, 2020 at 12:26 AM Darren Duncan wrote: If its hard to know how many people are actually using Internet Explorer: You could make the next release of pgAdmin display a message occasionally to users of Internet Explorer saying that Internet Explorer will no longer be officially supported in a future version, and when that version comes the message says now no longer supported. You can then see how many people contact you about this to express concern. Good idea. I've hacked up a patch to warn users if they're using a deprecated or unsupported browser. CCing Akshay for a review :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Proposal: Drop support for Internet Explorer
On Thu, Apr 9, 2020 at 11:57 PM Darren Duncan wrote: > The patch looks good as much as I understand it, but this raises an > important > question: > > How should one best handle minority browsers that may be completely modern > but > you may not specifically know about them? Such as the newer crop of > browsers > that emphasize stronger privacy or may have fewer identifiers? > > While going on a whitelist as the patch essentially does for known good > browsers > is conservative, I feel that an alteration would be good. > > I propose dividing the browsers/environments into 3 categories, which are > recognized-supported, recognized-unsupported, and unrecognized. > > So the unsupported older versions of supported browsers get a stronger > message > encouraging a browser switch as they are recognized as unsupported, while > unrecognized browsers get a different weaker message saying they weren't > recognized so we can't determine if they'd work; both can point to the > list of > known supported browsers. > > I do agree with this suggestion. > Related to this, there could be an application toggle that affects the > unrecognized category where users can basically say, yes I understand you > don't > recognize this browser, please hide the warning, or something like that. > > Also, it probably goes without saying, but the code/templates will need to > be > structured in such a way that the warning message uses about plain as > possible > HTML so that if the browser doesn't support displaying the UI in general > it can > at least display the message. > > -- Darren Duncan > > On 2020-04-09 4:36 a.m., Dave Page wrote: > > Hi > > > > On Thu, Apr 9, 2020 at 12:26 AM Darren Duncan wrote: > > > > If its hard to know how many people are actually using Internet > Explorer: > > > > You could make the next release of pgAdmin display a message > occasionally to > > users of Internet Explorer saying that Internet Explorer will no > longer be > > officially supported in a future version, and when that version > comes the > > message says now no longer supported. > > > > You can then see how many people contact you about this to express > concern. > > > > > > Good idea. I've hacked up a patch to warn users if they're using a > deprecated or > > unsupported browser. > > > > CCing Akshay for a review :-) > > > > -- > > Dave Page > > Blog: http://pgsnake.blogspot.com > > Twitter: @pgsnake > > > > EnterpriseDB UK: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > >
[pgAdmin][RM5227] Cannot add user
Hi Hackers, Attached is the patch to fix following user management related issues: 1) Unable to add a user when there are many users. The dialog went blank. Fixed. 2) Error message did not have a close button. Fixed. 3) When clicked on the add button, then cursor will focus on the email box of the new row for convenience. 4) When the dialog opens, the cursor will focus on the search text box. 5) By default, "User" role will be selected when adding a new user. Also removed an empty option in the roles dropdown. 6) When the search filter is applied and we try to add an already existing user, the validation is done only on the filtered data and not on all the users data. This is fixed. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM5227.patch Description: Binary data
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
Hi Akshay, On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi wrote: > Hi Khushboo > > Schema Diff test cases are failing with this patch. Please fix and resend > the patch. > > Can you please re-verify as I don't think schema diff test cases are failing due to this patch. Thanks, Khushboo > On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym >> properties does not show OID. >> >> As per the current implementation, we completely ignored OID and instead >> considered the name as the unique field, now with this patch OID will be >> used as an unique id and also will display OID in the properties tab. >> >> Thanks, >> Khushboo >> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* >
[pgAdmin][RM3972] Standard OSX keyboard behaviour in Query Tool.
Hi Hackers, Please find a patch, which fixes following OSX native keyboard shortcuts in Query Tool. 1. option+arrow (L/R) should skip by "word" 2. option+arrow (up/down) should go up/down one line 3. shift+option+arrow (L/R) should select/highlight by "word" -- Thanks, Nagesh RM3972.patch Description: Binary data
[pgAdmin][RM4969] JSONB and JSON field editing
Hi Hackers, Attached is the patch fix issue for jsonb and json field editing. Making the field blank throws a validation error. The patch will set json, jsonb to null when set to blank. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4969.patch Description: Binary data
