pgAdmin 4 commit: [Accessibility] Use semantic markup to mark emphasize
[Accessibility] Use semantic markup to mark emphasized or special text. Reference: https://www.w3.org/TR/WCAG20-TECHS/H49.html Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=073e310a5a2f05b32a454a9fc6904dd0b12b0ba0 Modified Files -- web/pgadmin/about/templates/about/index.html | 12 ++-- .../pgagent/schedules/static/js/pga_schedule.js | 4 ++-- .../servers/pgagent/steps/static/js/pga_jobstep.js | 2 +- .../browser/templates/browser/master_password.html | 2 +- web/pgadmin/misc/static/explain/js/explain.js| 20 ++-- .../tools/grant_wizard/static/js/grant_wizard.js | 2 +- .../tools/schema_diff/static/js/schema_diff_ui.js| 2 +- 7 files changed, 22 insertions(+), 22 deletions(-)
pgAdmin 4 commit: Using the 'gettext' as oppose to '_', which is not de
Using the 'gettext' as oppose to '_', which is not defined in the file Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f0847b95dcb9eb73f6027d491e55d2b9e76c70f Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
Hi Khushboo Schema Diff test cases are failing with this patch. Please fix and resend the patch. On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym > properties does not show OID. > > As per the current implementation, we completely ignored OID and instead > considered the name as the unique field, now with this patch OID will be > used as an unique id and also will display OID in the properties tab. > > Thanks, > Khushboo > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Using the 'gettext' as oppose to '_', which is not de
Using the 'gettext' as oppose to '_', which is not defined in these files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a84a62def860cbb11fda2476cf1d1818dfac0f08 Modified Files -- .../browser/server_groups/servers/databases/casts/__init__.py | 6 +++--- .../browser/server_groups/servers/databases/extensions/__init__.py | 2 +- .../servers/databases/foreign_data_wrappers/__init__.py | 4 +++- 3 files changed, 7 insertions(+), 5 deletions(-)
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym > properties does not show OID. > > As per the current implementation, we completely ignored OID and instead > considered the name as the unique field, now with this patch OID will be > used as an unique id and also will display OID in the properties tab. > Question is: When we rename a synonym, does it create a new OID, or keep the same? -- Ashesh > > Thanks, > Khushboo > >
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi wrote: > On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym >> properties does not show OID. >> >> As per the current implementation, we completely ignored OID and instead >> considered the name as the unique field, now with this patch OID will be >> used as an unique id and also will display OID in the properties tab. >> > Question is: When we rename a synonym, does it create a new OID, or keep > the same? > > We can not rename a synonym, must drop it and recreate it. > -- Ashesh > >> >> Thanks, >> Khushboo >> >>
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
Hi Khushboo View/MView test also failing with the commit of #5053. Please fix those as well and send a combined patch. On Wed, Apr 8, 2020 at 12:47 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym >>> properties does not show OID. >>> >>> As per the current implementation, we completely ignored OID and instead >>> considered the name as the unique field, now with this patch OID will be >>> used as an unique id and also will display OID in the properties tab. >>> >> Question is: When we rename a synonym, does it create a new OID, or keep >> the same? >> >> We can not rename a synonym, must drop it and recreate it. > > >> -- Ashesh >> >>> >>> Thanks, >>> Khushboo >>> >>> -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: [Domain] Existing expression will expression will alw
[Domain] Existing expression will expression will always result into false Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6c03a6b75db88461efa5064326559e01899f2b4 Modified Files -- .../server_groups/servers/databases/schemas/domains/static/js/domain.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: [COLLATIONS] Do not assign the paramter values, use s
[COLLATIONS] Do not assign the paramter values, use separate variable for new value Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=068b81224559c0b841c84bd6b9e8721979aa5a19 Modified Files -- .../databases/schemas/collations/__init__.py | 23 +- 1 file changed, 14 insertions(+), 9 deletions(-)
pgAdmin 4 commit: [Packages] Fixed a typo
[Packages] Fixed a typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7afa30d0ca51e311169aad05da638f44016c91f Modified Files -- .../server_groups/servers/databases/schemas/packages/__init__.py| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: [Functions] Fixed typos:
[Functions] Fixed typos: - 'gettext' should be used as '_' is not defined - Identical expressions should not be used on both sides of a binary operator. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14f21921bb0fbe48aa766c2e4b6847ed15362396 Modified Files -- .../server_groups/servers/databases/schemas/functions/__init__.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)
pgAdmin 4 commit: [TABLES] Do not assign the paramter values, use separ
[TABLES] Do not assign the paramter values, use separate variable for new value Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b3e1f1e65c32555dcbd788ea880de27053595a6 Modified Files -- .../server_groups/servers/databases/schemas/tables/__init__.py| 8 1 file changed, 4 insertions(+), 4 deletions(-)
pgAdmin 4 commit: [Exclusion Constraint] Fixed an typo - it should have
[Exclusion Constraint] Fixed an typo - it should have been assignment Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c693d158e15287fd391fe2e637a6041978733a2 Modified Files -- .../constraints/exclusion_constraint/static/js/exclusion_constraint.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: [EDB Package Functions] [Functions] Fixed typos:
[EDB Package Functions] [Functions] Fixed typos: - 'gettext' should be used as '_' is not defined - Identical expressions should not be used on both sides of a binary operator. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8fe344c2686cab26047250aecdd9da0bd2bc4b17 Modified Files -- .../servers/databases/schemas/packages/edbfuncs/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgAdmin 4 commit: [FTS Configuration] Fixed an typo - it should have be
[FTS Configuration] Fixed an typo - it should have been assignment Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29ae6dfbf64f69beea5038ad53b7cd4adea69711 Modified Files -- .../databases/schemas/fts_configurations/static/js/fts_configuration.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: [Rules] Removing unnecessary 'if' condition
[Rules] Removing unnecessary 'if' condition Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8fe687eb5505df5ad4fe7bbd37f8aa5f1dea955a Modified Files -- .../servers/databases/schemas/tables/rules/__init__.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)
Re: Proposal: Drop support for Internet Explorer
On Tue, Apr 7, 2020 at 1:34 PM richard coleman wrote: > Dave, > > Seeing that IE isn't standards compliant and not only is not being further > developed, but Microsoft is actively discouraging its use, it is probably > time to drop support for it. > > I would caution *against* using browser analytics as any sort of proxy for > use. Since pgAdmin 4 lacks a UI of its own, I rely on an instance of > Chromium (or Vivalidi, or Firefox, depending on the machine) to run pgAdmin > under. In every case, the browser that I am *running* pgAdmin 4 under is > *not* the same browser that I use to browse websites, and so would never > show up in your analytics. > Understood. Analytics are just one source of information, and certainly not conclusive as you point out. My suspicion is that your situation is not the norm for most people, but that really is just a suspicion. > > Just something to keep in mind, > > rik. > > On Tue, Apr 7, 2020 at 8:00 AM Dave Page wrote: > >> >> >> On Tue, Apr 7, 2020 at 12:41 PM Dave Caughey wrote: >> >>> Check the analytics... I think you'll find dropping it is a non-issue. >>> In my own web service, I found that IE (all versions) constituted only >>> about 1% of my users. >>> >> >> Good point - 1.9% of the visitors to the website were on IE this week. >> 1.8 of those were on IE11. We even had one hit from IE5... >> >> By comparison, 72% of users were on Chrome, 13% on Firefox, with 5.5% >> each for Safari and Edge. >> >> >>> >>> So I dropped support for IE (since it was preventing me from fully >>> adopting ES6), and there was not a single complaint from my users. >>> >>> Cheers, >>> Dave >>> >>> On Tue., Apr. 7, 2020, 3:36 a.m. Dave Page, wrote: >>> All, Internet Explorer has long been superseded by Microsoft Edge, and even that has recently moved to using Chromium as it's core engine. Version 11 was originally released in 2013, and though Microsoft have committed to supporting it until 2025, as far as I can tell there have been no notable new features in almost it's entire lifetime, and certainly in recent years Microsoft have only been releasing security fixes. As you can imagine, supporting Internet Explorer has a non-trivial cost to it for the pgAdmin project. Not only do we need to test with it as well as Edge, but we also need to write code, CSS and HTML that is fully compatible with what essentially is a 7 year old browser. By comparison, for all other browsers we typically aim to support releases no more than 2 years old. I therefore propose that we officially drop support for Internet Explorer. Practically this means that we would not test with it, and anyone reporting a bug with it would be told to use an alternate browser. Objections/comments please? Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Various misc fixes:
Various misc fixes: - Using the 'gettext' as oppose to '_', which is not defined - Define missing variables - Fixed escape character in string with double quote - Removed some dead code in a test case - Removed unnecessary self assignment Includes some fixes for Accessibility improvements - Use semantic markup to mark emphasized or special text - Added hidden legend in for better screen reader support Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9f6baac72d94570f1ae8d7792f9735397dd0d99 Modified Files -- .../browser/server_groups/servers/__init__.py | 2 +- .../servers/databases/schemas/packages/__init__.py | 3 ++- .../servers/resource_groups/__init__.py| 4 +-- .../server_groups/servers/roles/tests/utils.py | 31 +- .../server_groups/servers/tablespaces/__init__.py | 4 +-- web/pgadmin/misc/file_manager/__init__.py | 3 --- web/pgadmin/settings/__init__.py | 2 +- .../templates/security/change_password.html| 3 ++- .../templates/security/forgot_password.html| 1 + web/pgadmin/templates/security/panel.html | 2 +- web/pgadmin/templates/security/reset_password.html | 1 + .../tools/debugger/templates/debugger/direct.html | 12 - web/pgadmin/tools/schema_diff/__init__.py | 12 - web/pgadmin/tools/search_objects/__init__.py | 2 +- web/pgadmin/tools/sqleditor/__init__.py| 5 +--- 15 files changed, 28 insertions(+), 59 deletions(-)
pgAdmin 4 commit: Fixed a typo in previous commit
Fixed a typo in previous commit Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa7ced4ef1eb9e1cb7c9b4505416be36ba681d52 Modified Files -- web/pgadmin/tools/schema_diff/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Fixed pep8 issue
Fixed pep8 issue Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=775e61c248ca2d85c6b992bef337146cb4d0646d Modified Files -- .../server_groups/servers/databases/casts/__init__.py | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-)
pgAdmin 4 commit: Moved the ip-address check functionality to a separat
Moved the ip-address check functionality to a separate file to improve the maintainability of the code. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a34f61b24209cc4abc1bced1d30ce0ef1cbe57f Modified Files -- .../browser/server_groups/servers/__init__.py | 42 +++ web/pgadmin/utils/ip.py| 61 ++ 2 files changed, 69 insertions(+), 34 deletions(-)
pgAdmin 4 commit: Fixed expected output status code, as 410 should be t
Fixed expected output status code, as 410 should be the status code for the object (CAST) not exists in the database server. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a550b569ff5aadb8c2d99cbef4a4233ab00e413 Modified Files -- .../server_groups/servers/databases/casts/tests/cast_test_data.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 - next gettext usage fixes
Hello, I fixed next gettext usage: - fixed gettext usage with .format() only for original text with %s - fixed typos - fixed translation yes/no buttons in dialog - improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs to be translated in Czech language as 'zrušit' but in another sentence as 'zrušení') - added gettext for text translations Diff file is attached. Best regards, Libor M. E-mail: libor...@gmail.com GitHub: https://github.com/liborm85 pgadmin4_gettext_fixes2.diff Description: Binary data
Re: Proposal: Drop support for Internet Explorer
If its hard to know how many people are actually using Internet Explorer: You could make the next release of pgAdmin display a message occasionally to users of Internet Explorer saying that Internet Explorer will no longer be officially supported in a future version, and when that version comes the message says now no longer supported. You can then see how many people contact you about this to express concern. -- Darren Duncan
Re: RM4292 - Dark mode support for Windows/macOS
Neel, Can you please review/test it? On Wed, Apr 8, 2020 at 9:08 PM Dave Page wrote: > The attached patch detects if dark mode is enabled on Windows (10+)/macOS > (10.14+) at server start, and styles the runtime accordingly. It doesn't > dynamically switch if the user changes their preferences. > > Linux builds continue to use the standard styling from Qt. > > NOTE: I've tested this on macOS, but my Windows build system is playing up > at the moment. Akshay, can you have someone on your team test it please? I > believe the code should work; it's just a case of reading a reg key and > then doing the same thing as on macOS to set the theme accordingly. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
