Fix in switch cell tab navigation
Hi Hackers,
Attached is the patch for below minor fix in the switch cell tab navigation:
After pressing the tab key on switch cell, sometimes focus doesn't go to
the immediate next editable cell. It goes to the different cell for
fraction of seconds and again comes to the next editable cell.
Please review.
Regards,
Ganesh Jaybhay
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index 230d7ce56..61127ddb1 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -206,7 +206,7 @@ define([
renderable = Backgrid.callByNeed(cell.column.renderable(), cell.column, cell.model);
editable = Backgrid.callByNeed(cell.column.editable(), cell.column, model);
if(cell && cell.$el.hasClass('edit-cell') &&
- !cell.$el.hasClass('privileges') || cell.$el.hasClass('delete-cell')) {
+ !cell.$el.hasClass('privileges') || cell.$el.hasClass('delete-cell') || cell.$el.hasClass('subgrid-cell')) {
model.trigger('backgrid:next', m, n, false);
if(cell.$el.hasClass('delete-cell')) {
setTimeout(function(){
@@ -717,7 +717,11 @@ define([
gotoCell = e.shiftKey ? self.$el.prev() : self.$el.next();
}
-if (gotoCell) {
+if (gotoCell && gotoCell.length > 0) {
+ if(gotoCell.hasClass('editable')){
+e.preventDefault();
+e.stopPropagation();
+ }
let command = new Backgrid.Command({
key: 'Tab',
keyCode: 9,
@@ -727,12 +731,8 @@ define([
setTimeout(function() {
// When we have Editable Cell
if (gotoCell.hasClass('editable') && gotoCell.hasClass('edit-cell')) {
- e.preventDefault();
- e.stopPropagation();
gotoCell.trigger('focus');
} else if (gotoCell.hasClass('editable')) {
- e.preventDefault();
- e.stopPropagation();
setTimeout(function() {
self.model.trigger('backgrid:edited', self.model,
self.column, command);
Re: Fix in switch cell tab navigation
Hi Ganesh, You have put a check on *subgrid-cell* class, which does not exist in the entire source code. Also, can you please let me know of any module which you have tested, so I can test accordingly though the code for the same looks good to me. Thanks, Khushboo On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for below minor fix in the switch cell tab > navigation: > > After pressing the tab key on switch cell, sometimes focus doesn't go to > the immediate next editable cell. It goes to the different cell for > fraction of seconds and again comes to the next editable cell. > > Please review. > > Regards, > Ganesh Jaybhay >
[pgAdmin][RM5292] Alertify header buttons focus color issue
Hi Hackers, Please find a patch which includes 1. Use *btn-secondary* styles for all buttons in alertify dialog header. 2. Added *!default *for $active-border variable, so that it can be overridden if required. 3. Added entry for *.scss *in .editorconfig -- Thanks, Nagesh RM5292.patch Description: Binary data
Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Hi Nagesh, I cannot see any change related to $active-border variable apart from !default. Plus, $active-border should not be allowed to edit. It is a structural variable and not a variable which affects theme change. Please revert the $active-border change and send the patch. On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope wrote: > Hi Hackers, > > Please find a patch which includes > >1. Use *btn-secondary* styles for all buttons in alertify dialog >header. >2. Added *!default *for $active-border variable, so that it can be >overridden if required. >3. Added entry for *.scss *in .editorconfig > > -- > Thanks, > Nagesh > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: Fix in switch cell tab navigation
Hi Khushboo, I have removed the condition added for subgrid-cell. Please find the attached updated patch Regards, Ganesh Jaybhay On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Ganesh, > > You have put a check on *subgrid-cell* class, which does not exist in the > entire source code. > Also, can you please let me know of any module which you have tested, so I > can test accordingly though the code for the same looks good to me. > > Thanks, > Khushboo > > > On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay < > ganesh.jayb...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for below minor fix in the switch cell tab >> navigation: >> >> After pressing the tab key on switch cell, sometimes focus doesn't go to >> the immediate next editable cell. It goes to the different cell for >> fraction of seconds and again comes to the next editable cell. >> >> Please review. >> >> Regards, >> Ganesh Jaybhay >> > switch_cell_navigation_v1.patch Description: Binary data
pgAdmin 4 commit: Fixed an issue where focus doesn't go to the immediat
Fixed an issue where focus doesn't go to the immediate next editable cell after pressing the tab key on switch cell. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c0b229b144a46b3c3b0abf99ebf68f3247d24b4 Author: Ganesh Jaybhay Modified Files -- web/pgadmin/static/js/backgrid.pgadmin.js | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)
Re: Fix in switch cell tab navigation
Thanks, patch applied. On Thu, Mar 26, 2020 at 10:30 AM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Khushboo, > > I have removed the condition added for subgrid-cell. Please find the > attached updated patch > > Regards, > Ganesh Jaybhay > > On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Ganesh, >> >> You have put a check on *subgrid-cell* class, which does not exist in >> the entire source code. >> Also, can you please let me know of any module which you have tested, so >> I can test accordingly though the code for the same looks good to me. >> >> Thanks, >> Khushboo >> >> >> On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay < >> ganesh.jayb...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for below minor fix in the switch cell tab >>> navigation: >>> >>> After pressing the tab key on switch cell, sometimes focus doesn't go to >>> the immediate next editable cell. It goes to the different cell for >>> fraction of seconds and again comes to the next editable cell. >>> >>> Please review. >>> >>> Regards, >>> Ganesh Jaybhay >>> >> -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Please find an updated patch, which fixes review comments. On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Nagesh, > > I cannot see any change related to $active-border variable apart from > !default. Plus, $active-border should not be allowed to edit. It is a > structural variable and not a variable which affects theme change. > Please revert the $active-border change and send the patch. > > On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope < > nagesh.dh...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find a patch which includes >> >>1. Use *btn-secondary* styles for all buttons in alertify dialog >>header. >>2. Added *!default *for $active-border variable, so that it can be >>overridden if required. >>3. Added entry for *.scss *in .editorconfig >> >> -- >> Thanks, >> Nagesh >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Nagesh RM5292_v2.patch Description: Binary data
