Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view
Hi Akshay, On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi wrote: > Hi Khushboo > > Following are the review comments: > >- Fix the PEP8 issue. >- Drop query should be part of the jinja template for consistency. >Currently, it is added through the python file. > > The Delete query is already in the template file, I have just reused the delete call and merged the SQL queries in the python file. > >- Any changes in the view code should not warn the user "Changing the >columns in a view requires dropping" and we should not drop the view. >For example, I have only change the WHERE clause or added 'ORDER BY'. > > I have tested but couldn't reproduce this issue. Can you please let me know the proper use case? Thanks, Khushboo > > > On Tue, Jan 14, 2020 at 10:27 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM #5053 - Getting an error while >> changing the columns in the existing view. >> >> PostgreSQL doesn't allow to change the view columns. So, while performing >> this task the existing view should be dropped first and then recreate it >> and also user will get a warning first. >> >> Thanks, >> Khushboo >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* >
Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view
Hi Khushboo On Tue, Mar 24, 2020 at 1:47 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are the review comments: >> >>- Fix the PEP8 issue. >>- Drop query should be part of the jinja template for consistency. >>Currently, it is added through the python file. >> >> The Delete query is already in the template file, I have just reused the > delete call and merged the SQL queries in the python file. > >> >>- Any changes in the view code should not warn the user "Changing the >>columns in a view requires dropping" and we should not drop the view. >>For example, I have only change the WHERE clause or added 'ORDER BY'. >> >> I have tested but couldn't reproduce this issue. Can you please let me > know the proper use case? > Create a view with 'SELECT 1;' as code. Then change the code to 'SELECT 1234;' and click on the Save button. Warning popup is displayed "Changing the columns in a view". Click on the 'Yes' button and check the OID of the view. You will get the same OID, it means view is not recreated. I have observed below error in the browser while changing the code: view.js:241 Uncaught TypeError: Cannot read property 'replace' of undefined at child.onChange (view.js:241) at HTMLDivElement.dispatch (jquery.js:5237) at HTMLDivElement.elemData.handle (jquery.js:5044) > Thanks, > Khushboo > >> >> > >> On Tue, Jan 14, 2020 at 10:27 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch for RM #5053 - Getting an error while >>> changing the columns in the existing view. >>> >>> PostgreSQL doesn't allow to change the view columns. So, while >>> performing this task the existing view should be dropped first and then >>> recreate it and also user will get a warning first. >>> >>> Thanks, >>> Khushboo >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]
Please disregard my previous patch, attached the updated patch. :) On Tue, Mar 24, 2020 at 10:32 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Please disregard my previous patch, attached the updated patch. > > On Tue, Mar 24, 2020 at 10:29 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >> >> On Tue, Mar 17, 2020 at 4:11 PM Dave Page wrote: >> >>> Hi >>> >>> On Tue, Mar 17, 2020 at 10:24 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi Dave, Thanks for the review. On Tue, Mar 17, 2020 at 3:42 PM Dave Page wrote: > Hi > > 30 second read of the first version of the patch... > > - Please move the configuration into config.py. Users should never > have to modify a distributed file (it messes up packaging). I don't see > any > reason to use a different file just for auth config. > > There are many settings for the LDAP, and in the future we will add other external sources also, so I thought it would be better if we have different file for the authentication. >>> >>> Sure, but our config file is small compared to many. Splitting things >>> out is more confusing for users. If they want to do that themselves of >>> course, they can add a config_local.py file which includes other files as >>> needed. >>> >> Fixed. >> >>> >>> - I think all config options should be prefixed with LDAP_ as we may > have things like CERT_FILE for other purposes too. > > Sure. >>> Done. >> >>> - I don't see any test cases. > > I will think about this, as right now no idea how to write test cases for this. >>> >>> It should be fairly straightforward to write tests for some of the >>> functions in the auth classes. For testing the actual LDAP stuff, we >>> probably need to add LDAP config options to test_config.json, and only if >>> present, run the tests. That would probably need to support a list of LDAP >>> servers, so we can test with different configurations (LDAP, LDAPS, >>> LDAP_STARTTLS, AD etc). >>> >>> >> Done. >> >> Thanks, >> Khushboo >> >>> Thanks. > > Thanks, Khushboo > > On Tue, Mar 17, 2020 at 8:55 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to support LDAP Authentication in >> Server mode. >> To test the patch, config_auth.py needs to be configured for LDAP >> configurations. The config settings are explained in this file in detail. >> After configuring the parameters, start the pgadmin server in Server mode >> and connect with LDAP server with the valid user via login page. >> >> I have tested this patch with ldap and ldap + ssl/tls. With the TLS, >> I have used the default config of ldap3 without certificates. >> >> @Dave, can you please review this patch, as you have a better >> understanding of LDAP and you can easily pointed out if I have missed >> anything. >> >> Note: For the document update I will create the task and assign to >> Nidhi for the same. >> >> Thanks, >> Khushboo >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> RM_2186_v1.patch Description: Binary data
pgAdmin 4 commit: Use NodeJS v12.
Use NodeJS v12. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17d0d5e0a2fabae075cb01f6b076a3550f0f3d04 Modified Files -- pkg/debian/setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Don't offer to configure Apache on Redhat platforms a
Don't offer to configure Apache on Redhat platforms as there's nothing to do. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f97d29243d5a400bfba82bd7cce3de3743446c0d Modified Files -- pkg/linux/setup-web.sh | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-)
