Re: [pgAdmin][RM4764][Accessibility] Allow screen-reader to read relationship attributes in nested elements
Hi Hackers, Attached is the patch on top of initial patch for: - screen reader to read elements in radio modern control - minor accessibility(aria-label) additions at few missing places - Radiocontrol to have different ids for each options Please review. Regards, Ganesh Jaybhay On Tue, Dec 17, 2019 at 1:25 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Dec 13, 2019 at 12:09 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to: >> 1) Read relationship for tab, tabpanels and tables under it. Similar >> changes are done for subnode controls. >> 2) Add role="img" for font icons, per - >> https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA24.html >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > RM4764_v1.patch Description: Binary data
[pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform.
Hi, PFA patch to fix the issue with chrome driver download utility due to which it was failing on Ubuntu 18.04 with following error. (venv3_pg) murtuza@ubuntu:~/projects/pgadmin4/tools (master)$ python get_chromedriver.py /opt/google/chrome/chrome /tmp The specified Chrome executable output an unexpected version string: Google Chrome 80.0.3987.132 unknown . -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4942.diff Description: Binary data
pgAdmin 4 commit: Fixed chrome driver download utility issue for Ubuntu
Fixed chrome driver download utility issue for Ubuntu. Fixes #4942 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7cc30e32168aefe2925631291b71ada457320619 Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_20.rst | 1 + tools/get_chromedriver.py | 5 + 2 files changed, 6 insertions(+)
Re: [pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform.
Thanks, patch applied. On Wed, Mar 11, 2020 at 3:38 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue with chrome driver download utility due to > which it was failing on Ubuntu 18.04 with following error. > > (venv3_pg) murtuza@ubuntu:~/projects/pgadmin4/tools (master)$ python > get_chromedriver.py /opt/google/chrome/chrome /tmp > The specified Chrome executable output an unexpected version string: > Google Chrome 80.0.3987.132 unknown > . > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed some accessibility issues:
Fixed some accessibility issues: 1) Screen reader to read elements in radio modern control. 2) Aria-label additions at few missing places. 3) Radiocontrol to have different ids for each option. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6586be5158f49b76d0d578ca3642a5af42e8d5b3 Author: Ganesh Jaybhay Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 9 + web/pgadmin/static/js/backgrid.pgadmin.js | 8 ++-- web/pgadmin/static/vendor/backform/backform.js | 4 ++-- 3 files changed, 13 insertions(+), 8 deletions(-)
Re: [pgAdmin][RM4764][Accessibility] Allow screen-reader to read relationship attributes in nested elements
Thanks, patch applied. On Wed, Mar 11, 2020 at 2:43 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch on top of initial patch for: > >- screen reader to read elements in radio modern control >- minor accessibility(aria-label) additions at few missing places >- Radiocontrol to have different ids for each options > > Please review. > > Regards, > Ganesh Jaybhay > > On Tue, Dec 17, 2019 at 1:25 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Fri, Dec 13, 2019 at 12:09 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to: >>> 1) Read relationship for tab, tabpanels and tables under it. Similar >>> changes are done for subnode controls. >>> 2) Add role="img" for font icons, per - >>> https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA24.html >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
