pgAdmin 4 commit: Set Active query details subnode control as read-only
Set Active query details subnode control as read-only instead of disabled for accessibility. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ed3cd248beab20b421297c107a7d1e9dba21925 Author: Nagesh Dhope Modified Files -- web/pgadmin/dashboard/static/js/dashboard.js | 8 1 file changed, 4 insertions(+), 4 deletions(-)
Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified
Thanks, patch applied. On Fri, Mar 6, 2020 at 12:21 PM Nagesh Dhope wrote: > Hi Akshay, > Please find a patch to make controls under *Active query details* subnode > read-only on the dashboard. > > > On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch to include dialogs (create/edit) for all >>> the nodes. >>> Kindly review. >>> >>> On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Aditya As per discussion, we should visit all the nodes create/edit dialog and make the controls read-only wherever appropriate. On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow input controls to be set as readonly > instead of disabled. > I've also changed the code for the nodes to make sure properties tab > have readonly fields wherever applicable. This will allow tab navigation > in > properties tab and also allow screen readers to read it. > Please note that, I've not visited each and every node create/edit > dialog to identify what should be readonly or what should be disabled as > it > depends on business logic. The patch is mainly for the properties tab. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fix an accessibility issue to maximize the panel for
Fix an accessibility issue to maximize the panel for all alertify dialog. Fixes #5143 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82155cd859cc5d8a2165c9ed2db25815751698c5 Author: Pradip Parkale Modified Files -- docs/en_US/release_notes.rst | 1 + docs/en_US/release_notes_4_20.rst | 20 + web/pgadmin/about/static/js/about.js | 12 ++-- web/pgadmin/static/js/alertify.pgadmin.defaults.js | 23 +-- web/pgadmin/static/js/alertify/dialog_wrapper.js | 8 - .../tools/grant_wizard/static/js/grant_wizard.js | 34 -- 6 files changed, 82 insertions(+), 16 deletions(-)
Re: [pgAdmin][RM5154] [Accessibility] : Alertify
Thanks, patch applied.
On Thu, Mar 5, 2020 at 6:02 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:
> Hi Hackers,
> Please find the updated patch for RM5143.
>
>
> On Tue, Feb 25, 2020 at 6:26 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Feb 25, 2020 at 3:32 PM Pradip Parkale <
>> pradip.park...@enterprisedb.com> wrote:
>>
>>> Hi Akshay/Aditya,
>>>
>>> Please find the updated patch. I have accommodated all the changes.
>>>
>>>
>>> On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Pradip,
-
commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content
div.active'));
+
$(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus();
Use the same common function with
commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will
handle the focus.
>>> Fixed.
>>>
Also, make the required changes mentioned on the pull request -
https://github.com/EnterpriseDB/AlertifyJS/pull/1
>>> Fixed.
>>>
On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
> Hi Aditya
>
> Can you please review this patch.
>
> On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <
> pradip.park...@enterprisedb.com> wrote:
>
>> Please find the attached patch.
>>
>> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Forgot to attach the patch?
>>>
>>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale <
>>> pradip.park...@enterprisedb.com> wrote:
>>>
Hi Hackers,
Attached is a patch for accessibility issue related Alertifyjs.
1. Added hidden label to satisfy accessibility.
2. Added label with sr-only class.
3. Added tabindex to move the mouse control to the maximize
button using the tab key.
Please note that this patch also includes the fix for the
RM-5143 Accessibility issue to maximize the panel for backup and
restore
windows and all other places.
--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation
>>> --
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>>
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> QMG, EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> QMG, EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
