pgAdmin 4 commit: Improvements in the UI for both default and dark them
Improvements in the UI for both default and dark themes. Fixes #5133 Improve the style of the highlighted code after query execution for Dark mode. Fixes #4996. Changed background pattern for geometry viewer to use #fff for all themes. Fixes #5077 Changed the color of selected and hovered item for Select2 dropdown, also tweak the appearance of the tags in multi-select boxes. Fixes #4955 Fixed Firefox monospaced issue by updating the font to the latest version. Fixes #5184 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bad590e9e70a7e93ad17efcdc21d23d8fcf393c Author: Aditya Toshniwal Modified Files -- docs/en_US/event_trigger_dialog.rst| 12 ++--- docs/en_US/images/event_trigger_definition.png | Bin 56808 -> 55290 bytes docs/en_US/release_notes_4_19.rst | 7 ++- .../event_triggers/static/js/event_trigger.js | 12 +++-- .../schemas/synonyms/static/js/synonym.js | 2 +- .../schemas/tables/columns/static/js/column.js | 4 +- .../server_groups/servers/roles/static/js/role.js | 7 ++- .../server_groups/servers/static/js/privilege.js | 23 +--- .../servers/templates/servers/password.html| 14 ++--- .../servers/templates/servers/tunnel_password.html | 21 web/pgadmin/browser/static/js/browser.js | 8 +-- web/pgadmin/browser/static/js/collection.js| 19 --- web/pgadmin/browser/static/js/node.js | 4 +- web/pgadmin/browser/static/js/wizard.js| 2 +- web/pgadmin/dashboard/static/js/dashboard.js | 18 +++ web/pgadmin/dashboard/static/scss/_dashboard.scss | 2 +- .../misc/statistics/static/js/statistics.js| 2 +- web/pgadmin/preferences/static/js/preferences.js | 4 +- web/pgadmin/static/fonts/SourceCodePro-Bold.ttf| Bin 120504 -> 191568 bytes web/pgadmin/static/fonts/SourceCodePro-Regular.ttf | Bin 120548 -> 192740 bytes web/pgadmin/static/js/backform.pgadmin.js | 47 +--- web/pgadmin/static/js/backgrid.pgadmin.js | 2 +- .../static/js/sqleditor/history/query_history.js | 2 +- .../js/sqleditor/history/query_history_entries.js | 9 ++-- web/pgadmin/static/scss/_aci_tree.overrides.scss | 2 +- web/pgadmin/static/scss/_backgrid.overrides.scss | 23 +++- web/pgadmin/static/scss/_bootstrap.overrides.scss | 15 ++ web/pgadmin/static/scss/_codemirror.overrides.scss | 2 +- web/pgadmin/static/scss/_pgadmin.style.scss| 37 +++-- web/pgadmin/static/scss/_select2.overrides.scss| 23 ++-- .../static/scss/resources/_default.variables.scss | 28 +++--- .../scss/resources/_theme.variables.scss.sample| 59 +++-- .../scss/resources/dark/_theme.variables.scss | 11 ++-- web/pgadmin/static/vendor/backform/backform.js | 16 +++--- .../static/vendor/backgrid/backgrid-select-all.js | 10 +++- .../tools/datagrid/templates/datagrid/index.html | 2 +- .../tools/grant_wizard/static/js/grant_wizard.js | 15 +- .../tools/maintenance/static/js/maintenance.js | 6 +-- .../tools/schema_diff/static/css/schema_diff.css | 9 +++- .../schema_diff/static/js/schema_diff.backform.js | 8 +-- .../tools/schema_diff/static/js/schema_diff.js | 2 +- .../tools/schema_diff/static/js/schema_diff_ui.js | 2 +- .../schema_diff/static/scss/_schema_diff.scss | 41 +- .../schema_diff/templates/schema_diff/index.html | 12 +++-- .../tools/sqleditor/static/css/sqleditor.css | 4 ++ .../tools/sqleditor/static/scss/_sqleditor.scss| 5 ++ 46 files changed, 370 insertions(+), 183 deletions(-)
Re: [pgAdmin][RM5154] [Accessibility] : Alertify
Hi Pradip,
-
commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content
div.active'));
+
$(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus();
Use the same common function with
commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will
handle the focus.
Also, make the required changes mentioned on the pull request -
https://github.com/EnterpriseDB/AlertifyJS/pull/1
On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi
wrote:
> Hi Aditya
>
> Can you please review this patch.
>
> On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <
> pradip.park...@enterprisedb.com> wrote:
>
>> Please find the attached patch.
>>
>> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Forgot to attach the patch?
>>>
>>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale <
>>> pradip.park...@enterprisedb.com> wrote:
>>>
Hi Hackers,
Attached is a patch for accessibility issue related Alertifyjs.
1. Added hidden label to satisfy accessibility.
2. Added label with sr-only class.
3. Added tabindex to move the mouse control to the maximize button
using the tab key.
Please note that this patch also includes the fix for the
RM-5143 Accessibility issue to maximize the panel for backup and restore
windows and all other places.
--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation
>>> --
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>>
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> QMG, EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
[pgAdmin][RM5215] ERROR: syntax error at or near "NOTHING" display if user change event valu
Hi Hackers, Attached is the patch to fix of #5215 which is a regression of #5115. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM5215.patch Description: Binary data
Re: [pgAdmin][RM5215] ERROR: syntax error at or near "NOTHING" display if user change event valu
Hi Hackers, Please ignore the previous patch. I've updated the patch to add more test related to the fix. On Mon, Feb 24, 2020 at 3:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix of #5215 which is a regression of #5115. > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM5215.patch Description: Binary data
pgAdmin 4 commit: Fix syntax error when changing the event type for the
Fix syntax error when changing the event type for the existing rule. It is a regression of #5115. Fixes #5215 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd07e0c868cd12186671a088b2ca7f1479141c40 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_19.rst | 3 +- .../default/alter_insert_event_rule_nothing.sql| 10 +++ .../alter_insert_event_rule_nothing_msql.sql | 4 +++ .../alter_insert_event_rule_nothing_update.sql | 10 +++ ...alter_insert_event_rule_nothing_update_msql.sql | 4 +++ .../schemas/tables/rules/tests/default/test.json | 32 ++ .../schemas/tables/templates/rules/sql/update.sql | 15 +- 7 files changed, 65 insertions(+), 13 deletions(-)
Re: [pgAdmin][RM5215] ERROR: syntax error at or near "NOTHING" display if user change event valu
Thanks, patch applied. On Mon, Feb 24, 2020 at 5:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please ignore the previous patch. I've updated the patch to add more test > related to the fix. > > On Mon, Feb 24, 2020 at 3:44 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix of #5215 which is a regression of #5115. >> Please review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fix the docker build.
Fix the docker build. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=787c11efda8c08f078ccae10065da8cb12f4b16b Modified Files -- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
