Re: [pgAdmin][RM5115] RULE SQL incorrectly generated
Thanks, patch applied. On Fri, Feb 21, 2020 at 3:10 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the SQL parsing issue in rules. The command > and statements were parsed incorrectly. > Also fixed issue where removing command or statements altogether was not > generating modified SQL and so was not saving. > Test cases added and changed accordingly. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fix an issue where command and statements were parsed
Fix an issue where command and statements were parsed incorrectly for Rules. Fixes #5115 Fixed issue where removing command or statements altogether was not generating modified SQL. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a44f17a2fcdca20611fdaea0cb1e8b633e4e81bc Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_19.rst | 3 +- .../schemas/tables/rules/static/js/rule.js | 8 ++-- .../tests/default/alter_delete_event_rule.sql | 4 +- .../tests/default/alter_delete_event_rule_msql.sql | 4 +- .../tests/default/alter_insert_event_rule.sql | 6 +-- .../default/alter_insert_event_rule_complex.sql| 17 +++ .../alter_insert_event_rule_complex_msql.sql | 8 .../tests/default/alter_insert_event_rule_msql.sql | 6 +-- .../tests/default/alter_update_event_rule.sql | 6 +-- .../tests/default/alter_update_event_rule_msql.sql | 6 +-- .../tests/default/create_delete_event_rule.sql | 3 +- .../default/create_delete_event_rule_msql.sql | 3 +- .../tests/default/create_insert_event_rule.sql | 6 +-- .../default/create_insert_event_rule_msql.sql | 6 +-- .../tests/default/create_update_event_rule.sql | 6 +-- .../default/create_update_event_rule_msql.sql | 6 +-- .../schemas/tables/rules/tests/default/test.json | 11 + .../schemas/tables/templates/rules/sql/create.sql | 16 +++ .../tables/templates/rules/sql/properties.sql | 4 +- .../schemas/tables/templates/rules/sql/update.sql | 16 --- .../servers/databases/schemas/utils.py | 53 +- 21 files changed, 124 insertions(+), 74 deletions(-)
pgAdmin 4 commit: Ensure that AlertifyJS should not be visible as a tit
Ensure that AlertifyJS should not be visible as a title for alert dialog. Fixes #5058 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29c236c33d05d07b1d8bce78f60a98cae684a676 Modified Files -- docs/en_US/release_notes_4_19.rst | 1 + web/pgadmin/static/js/backgrid.pgadmin.js | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
