pgAdmin 4 commit: 1) Added labels and titles after parsing and validati

2020-01-31 Thread Akshay Joshi
1) Added labels and titles after parsing and validating all the pgAdmin4 web 
pages for accessibility. Fixes #4770
2) Fixed an issue where Save Password controlĀ disappears after clicking on it 
while creating a server. Fixes #5116

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=210bbfdbe180ee221d69f30c86ac97ccde5c41fb
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_4_18.rst  |   7 +-
.../servers/databases/schemas/static/js/schema.js  |   2 +-
.../server_groups/servers/roles/static/js/role.js  |   2 +-
.../server_groups/servers/static/js/variable.js|   4 +-
web/pgadmin/browser/static/js/browser.js   |   2 +-
web/pgadmin/browser/static/js/collection.js|   6 +-
web/pgadmin/browser/static/js/menu.js  |   2 +-
web/pgadmin/static/css/style.css   |   2 +-
web/pgadmin/static/js/backform.pgadmin.js  |  28 +-
web/pgadmin/static/vendor/backform/backform.js |  10 +-
.../static/vendor/backgrid/backgrid-select-all.css |  12 +
.../static/vendor/backgrid/backgrid-select-all.js  | 296 +
web/webpack.shim.js|   2 +-
13 files changed, 346 insertions(+), 29 deletions(-)



Re: [pgAdmin][RM4770] [Accessibility]Parse & validate the web pages

2020-01-31 Thread Akshay Joshi
Thanks, patch applied.

On Wed, Jan 29, 2020 at 6:41 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi All,
>
> Attached is a patch for accessibility issues. I have added a label, title,
> and put some condition wherever required.
>
> Please note that this patch also includes the fix for RM5116 - Save
> Password' label disappears after clicking on it while creating a server.
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


[pgAdmin4][Patch] - Schema Diff Fixes

2020-01-31 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the below schema diff issues:

1. Comparison result of 2 exact identical Trigger Functions is different
2. EPAS 12: Table comparison with the compound trigger shown as different,
but all SQL panels are blank
3. Compound trigger properties panel is not opening
4. The DDL difference of the table containing the foreign key is not
accurate
5. The DDL difference of the view which refers the table from schema is not
accurate
6. DDL comparison fails if we have procedure with plpgsql in source and
edbsql in target

Thanks,
Khushboo


schema_diff_fixes_part2.patch
Description: Binary data


pgAdmin 4 commit: Fixed following issue of schema diff tool:

2020-01-31 Thread Akshay Joshi
Fixed following issue of schema diff tool:
 1. Comparison result of 2 exact identical Trigger Functions is different
 2. EPAS 12: Table comparison with the compound trigger shown as different, but 
all SQL panels are blank
 3. Compound trigger properties panel is not opening
 4. The DDL difference of the table containing the foreign key is not accurate
 5. The DDL difference of the view which refers the table from schema is not 
accurate
 6. DDL comparison fails if we have procedure with plpgsql in source and edbsql 
in target

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b1c8abd2fe09a23f2a259cd24ad6ad81e0b8205
Author: Khushboo Vashi 

Modified Files
--
.../databases/schemas/functions/__init__.py|  4 +--
.../trigger_functions/pg/sql/11_plus/update.sql|  2 +-
.../trigger_functions/pg/sql/9.2_plus/update.sql   |  2 +-
.../trigger_functions/pg/sql/9.5_plus/update.sql   |  2 +-
.../trigger_functions/pg/sql/default/update.sql|  2 +-
.../trigger_functions/ppas/sql/9.2_plus/update.sql |  2 +-
.../trigger_functions/ppas/sql/9.5_plus/update.sql |  2 +-
.../trigger_functions/ppas/sql/default/update.sql  |  2 +-
.../schemas/tables/compound_triggers/__init__.py   | 38 --
.../tables/constraints/foreign_key/utils.py| 17 --
.../databases/schemas/tables/triggers/__init__.py  |  3 +-
.../servers/databases/schemas/views/__init__.py|  6 
.../tools/schema_diff/static/js/schema_diff_ui.js  |  5 +--
13 files changed, 54 insertions(+), 33 deletions(-)



pgAdmin 4 commit: Update message catalogs.

2020-01-31 Thread Akshay Joshi
Update message catalogs.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96b0d85189aa1e142c66be535c2bcd8662605388

Modified Files
--
web/pgadmin/messages.pot   | 2503 +++---
.../translations/de/LC_MESSAGES/messages.mo|  Bin 91541 -> 91541 bytes
.../translations/de/LC_MESSAGES/messages.po| 2519 +++---
.../translations/es/LC_MESSAGES/messages.mo|  Bin 133515 -> 132662 bytes
.../translations/es/LC_MESSAGES/messages.po| 2547 +++---
.../translations/fr/LC_MESSAGES/messages.mo|  Bin 178458 -> 166037 bytes
.../translations/fr/LC_MESSAGES/messages.po| 3623 +++-
.../translations/it/LC_MESSAGES/messages.mo|  Bin 176141 -> 163708 bytes
.../translations/it/LC_MESSAGES/messages.po| 3607 ++-
.../translations/ja/LC_MESSAGES/messages.mo|  Bin 176367 -> 175367 bytes
.../translations/ja/LC_MESSAGES/messages.po| 2531 +++---
.../translations/ko/LC_MESSAGES/messages.mo|  Bin 114778 -> 114645 bytes
.../translations/ko/LC_MESSAGES/messages.po| 2521 +++---
.../translations/pl/LC_MESSAGES/messages.mo|  Bin 117854 -> 116965 bytes
.../translations/pl/LC_MESSAGES/messages.po| 2546 +++---
.../translations/ru/LC_MESSAGES/messages.mo|  Bin 153364 -> 152168 bytes
.../translations/ru/LC_MESSAGES/messages.po| 2544 +++---
.../translations/zh/LC_MESSAGES/messages.mo|  Bin 136869 -> 136102 bytes
.../translations/zh/LC_MESSAGES/messages.po| 2528 +++---
19 files changed, 14785 insertions(+), 12684 deletions(-)



Re: [pgAdmin4][Patch] - Schema Diff Fixes

2020-01-31 Thread Akshay Joshi
Thanks, patch applied.

On Fri, Jan 31, 2020 at 5:55 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the below schema diff issues:
>
> 1. Comparison result of 2 exact identical Trigger Functions is different
> 2. EPAS 12: Table comparison with the compound trigger shown as
> different, but all SQL panels are blank
> 3. Compound trigger properties panel is not opening
> 4. The DDL difference of the table containing the foreign key is not
> accurate
> 5. The DDL difference of the view which refers the table from schema is
> not accurate
> 6. DDL comparison fails if we have procedure with plpgsql in source and
> edbsql in target
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Translators: Release next week

2020-01-31 Thread Akshay Joshi
Hi Translators,

We will have a release next week, so updates to translations before release
would be helpful. The template and catalogs have been updated in git.

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*