[pgAdmin4][RM#5047] Add tab navigation for tabs under explain panel in query tool
Hi Hackers, Please find the attached minor fix for tab navigation of graphical, analysis and statistics tabs under explain panel in query tool. Kindly review. Regards, Ganesh Jaybhay RM5047.patch Description: Binary data
[RM4772] [Accessibility] aria-label in missing places
Hi Hackers, I have added an aria-label attribute where ever it is missing. PFA for the same. -- Thanks, Nagesh pgadmin_aria_label_v2.patch Description: Binary data
pgAdmin 4 commit: Added tab navigation for tabs under explain panel in
Added tab navigation for tabs under explain panel in query tool. Fixes #5047. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc5287bd9fa8d1b8048094dd90fe37ca6ec8ccdc Author: Ganesh Jaybhay Modified Files -- docs/en_US/release_notes_4_17.rst | 3 ++- web/pgadmin/misc/static/explain/js/explain.js | 4 ++-- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 6 ++ 3 files changed, 10 insertions(+), 3 deletions(-)
pgAdmin 4 commit: Added aria-label attribute wherever missing for acces
Added aria-label attribute wherever missing for accessibility. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c4dff057fcb44dda760bebe0ae085d0960091ba Author: Nagesh Dhope Modified Files -- web/pgadmin/browser/static/js/toolbar.js | 5 - web/pgadmin/browser/static/js/wizard.js | 8 web/pgadmin/preferences/static/js/preferences.js | 1 + web/pgadmin/static/js/alertify.pgadmin.defaults.js| 2 ++ web/pgadmin/static/js/backform.pgadmin.js | 4 ++-- web/pgadmin/static/js/backgrid.pgadmin.js | 2 +- web/pgadmin/static/js/sqleditor/filter_dialog.js | 1 + web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js | 1 + web/pgadmin/tools/datagrid/static/js/show_data.js | 1 + web/pgadmin/tools/datagrid/templates/datagrid/index.html | 4 ++-- web/pgadmin/tools/debugger/templates/debugger/direct.html | 6 ++ web/pgadmin/tools/maintenance/static/js/maintenance.js| 1 + web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js | 1 + 13 files changed, 27 insertions(+), 10 deletions(-)
Re: [RM4772] [Accessibility] aria-label in missing places
Thanks, patch applied. On Tue, Dec 31, 2019 at 7:17 PM Nagesh Dhope wrote: > Hi Hackers, > I have added an aria-label attribute where ever it is missing. PFA for the > same. > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][RM#5047] Add tab navigation for tabs under explain panel in query tool
Thanks, patch applied. On Tue, Dec 31, 2019 at 3:09 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached minor fix for tab navigation of graphical, > analysis and statistics tabs under explain panel in query tool. > > Kindly review. > > Regards, > Ganesh Jaybhay > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Added support for on-demand loading of items in Selec
Added support for on-demand loading of items in Select2. Fixes #5038. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=737f8375fb463f1ee4592fb3af2d65bcbf8082a2 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_17.rst | 1 + web/pgadmin/browser/static/js/node.ui.js | 51 +++ web/pgadmin/static/js/backform.pgadmin.js | 13 ++-- web/pgadmin/static/js/backgrid.pgadmin.js | 7 + 4 files changed, 70 insertions(+), 2 deletions(-)
Re: [pgAdmin][RM5038] Select2 enhancement - Load items on demand (scroll)
Thanks, patch applied. On Tue, Dec 24, 2019 at 1:01 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to enhance select2 used in pgAdmin. The select2 > dropdown will show only a few items when opened initially. On scrolling it > will show others. Searching will work as before. This will reduce the > number of DOM nodes on page. > Note that, individual controls can disable the behaviour if desired by > passing onDemandLoad:false for select2 options. It is enabled by default. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table
Hi Akshay, On Tue, Dec 31, 2019 at 1:28 PM Akshay Joshi wrote: > Hi Aditya > > I have applied the patch and found one issue collection nodes are visible > twice under the child node of the partition table. Please fix that. > I tried to simulate this. But I'm not facing issue. Can you please verify once again ? > [image: Screenshot 2019-12-31 at 1.24.26 PM.png] > > On Wed, Dec 25, 2019 at 4:59 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the issue where it was not possible to add >> constraints, index, rules, triggers and compound triggers on child tables >> of a partitioned table. >> The problem was with URLs formed which also included parent table OID, >> which was not needed. The code is changed to add "url_jump_after_node" >> param to skip after a certain node, which will will skip all the value >> between jump_after_node to the last node, excluding jump_after_node and the >> last node. Partitioned table itself is a "table" and can be multilevel. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
pgAdmin 4 commit: Ensure that constraints, indexes, rules, triggers, an
Ensure that constraints, indexes, rules, triggers, and compound triggers should be created on partitions. Fixes #4842. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=febbd729ec766ff75348924e70a492a697d644fe Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_17.rst | 1 + .../schemas/tables/compound_triggers/__init__.py | 2 +- .../compound_triggers/static/js/compound_trigger.js| 1 + .../check_constraint/static/js/check_constraint.js | 1 + .../static/js/exclusion_constraint.js | 1 + .../constraints/foreign_key/static/js/foreign_key.js | 6 -- .../index_constraint/static/js/primary_key.js | 1 + .../index_constraint/static/js/unique_constraint.js| 1 + .../tables/constraints/static/js/constraints.js| 1 + .../schemas/tables/indexes/static/js/index.js | 4 .../databases/schemas/tables/rules/static/js/rule.js | 1 + .../schemas/tables/triggers/static/js/trigger.js | 3 ++- web/pgadmin/browser/static/js/node.js | 18 ++ web/pgadmin/browser/static/js/node.ui.js | 8 +--- web/pgadmin/static/js/backform.pgadmin.js | 2 +- 15 files changed, 39 insertions(+), 12 deletions(-)
Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table
Hi Aditya I have removed the generated folder and it works. Thanks, patch applied. On Wed, Jan 1, 2020 at 11:58 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > On Tue, Dec 31, 2019 at 1:28 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> I have applied the patch and found one issue collection nodes are visible >> twice under the child node of the partition table. Please fix that. >> > I tried to simulate this. But I'm not facing issue. Can you please verify > once again ? > >> [image: Screenshot 2019-12-31 at 1.24.26 PM.png] >> >> On Wed, Dec 25, 2019 at 4:59 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix the issue where it was not possible to add >>> constraints, index, rules, triggers and compound triggers on child tables >>> of a partitioned table. >>> The problem was with URLs formed which also included parent table OID, >>> which was not needed. The code is changed to add "url_jump_after_node" >>> param to skip after a certain node, which will will skip all the value >>> between jump_after_node to the last node, excluding jump_after_node and the >>> last node. Partitioned table itself is a "table" and can be multilevel. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
