Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-20 Thread Ashesh Vashi
Have you seen any improvements in performance?

On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to use https://pypi.org/project/cheroot/ instead of
> current flask dev server. cheroot is a stable production ready server.
> Plus, flask dev server is not recommended for production.
> Code is changed to use cheroot only when DEBUG is False, otherwise you the
> default flask server.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


[pgAdmin4][Patch] - 5023 - Refactoring SQL of View and Materialized View.

2019-12-20 Thread Khushboo Vashi
Hi,

Please find the attached small patch of refactoring SQL of views module. RM
-5023

Thanks,
Khushboo


views.patch
Description: Binary data


[pgAdmin4][RM#4772] Add aria-label attribute to buttons used in graphical explain plan

2019-12-20 Thread Murtuza Zabuawala
Hi,

PFA patch for adding aria-label to buttons used in graphical explain plan
section.

- Fixed another minor issue where we will only use dialog tab navigator
keyboard shortcuts only on visible tabs.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin4.diff
Description: Binary data


Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-20 Thread Aditya Toshniwal
Hi Ashesh,

I had tried with - https://newrelic.com/ API to check Flask app
performance. To be honest, there was not a great difference in the
performance.
Per new relic, cheroot used slightly less CPU, with more RPM and, with less
response time.
Anyway, flask is still not recommended and cheroot looks a good option as
it is pure python and supports almost all OS.

On Fri, Dec 20, 2019 at 1:34 PM Ashesh Vashi 
wrote:

> Have you seen any improvements in performance?
>
> On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to use https://pypi.org/project/cheroot/ instead
>> of current flask dev server. cheroot is a stable production ready server.
>> Plus, flask dev server is not recommended for production.
>> Code is changed to use cheroot only when DEBUG is False, otherwise you
>> the default flask server.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


pgAdmin 4 commit: 1) Refactored SQL of Table's and it's child nodes. Fi

2019-12-20 Thread Akshay Joshi
1) Refactored SQL of Table's and it's child nodes. Fixes #4988.
2) Ensure that the error message should not be displayed if Tablespace is not 
selected while creating the index. Fixes #5008.
3) Fix an issue where operator, access method and operator class is not visible 
for exclusion constraints. Fixes #5009.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ea3eabc3c75282c31051b5a4a7e5ee8a5d319c00

Modified Files
--
docs/en_US/release_notes_4_17.rst  |  5 +-
.../servers/databases/schemas/tables/__init__.py   | 50 +++
.../databases/schemas/tables/columns/utils.py  | 25 
.../constraints/exclusion_constraint/utils.py  | 73 ++
.../schemas/tables/indexes/static/js/index.js  |  6 --
.../sql/11_plus/properties.sql |  2 -
.../sql/default/properties.sql |  2 -
.../index_constraint/sql/11_plus/properties.sql|  3 -
.../index_constraint/sql/default/properties.sql|  3 -
9 files changed, 99 insertions(+), 70 deletions(-)



pgAdmin 4 commit: Refactored SQL of Views and Materialized Views. Fixes

2019-12-20 Thread Akshay Joshi
Refactored SQL of Views and Materialized Views. Fixes #5023.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f495af7a766713da460d8f1738a13638219f896c
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_4_17.rst| 1 +
.../schemas/views/templates/views/pg/9.3_plus/sql/properties.sql | 1 -
.../schemas/views/templates/views/pg/9.4_plus/sql/properties.sql | 1 -
.../schemas/views/templates/views/ppas/9.1_plus/sql/properties.sql   | 1 -
.../schemas/views/templates/views/ppas/9.3_plus/sql/properties.sql   | 1 -
.../schemas/views/templates/views/ppas/9.4_plus/sql/properties.sql   | 1 -
6 files changed, 1 insertion(+), 5 deletions(-)



Re: [pgAdmin4][Patch] - 5023 - Refactoring SQL of View and Materialized View.

2019-12-20 Thread Akshay Joshi
Thanks, patch applied.

On Fri, Dec 20, 2019 at 3:40 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached small patch of refactoring SQL of views module.
> RM -5023
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*