Re: Re : [BUG #4943]
++pgadmin-hackers
Hi Karan,
It is good to know that you're contributing.
I would suggest {server name}/{db name} as name instead of did is better
for UX. You can get the db name from conn object and server name using the
sid (refer - web/pgadmin/browser/server_groups/servers/__init__.py)
On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar wrote:
> Hi,
>
> I have been working on #4943 ("Database connected" success message itself
> is not enough) added by you on pgAdmin4 issues.
> I want to know what details of database should be included in success
> message.(i have added 'did')
>
> The success message can be modified by altering json response in the
> connect method in file
> PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.
> please have a look at the screenshots attached.
>
> original:
> info=_( "Database connected.")
> new:
> info=_("Postgres version/{0} Database connected.".format(did))
>
> Regards,
> Karan
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
[pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table
Hi Hackers, Attached is the patch to fix an issue where just clicking on an empty textbox like fill factor in tables dialog considers it a change and so the save button is enabled. The fix is common will apply at other places also. Kindly review. -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4506.patch Description: Binary data
pgAdmin 4 commit: Added statistics and storage information in reverse e
Added statistics and storage information in reverse engineering SQL of table/column. Fixes #4982. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f15db03ec38a729b7f591d87e6f8efb314a75b50 Modified Files -- docs/en_US/release_notes_4_16.rst | 2 ++ .../tables/columns/tests/10_plus/alter_column_char.sql| 6 ++ .../schemas/tables/columns/tests/10_plus/test.json| 2 +- .../tables/columns/tests/12_plus/alter_column_char.sql| 6 ++ .../schemas/tables/columns/tests/12_plus/test.json| 2 +- .../tables/columns/tests/default/alter_column_char.sql| 6 ++ .../schemas/tables/columns/tests/default/test.json| 2 +- .../tables/templates/columns/sql/10_plus/create.sql | 14 ++ .../tables/templates/columns/sql/10_plus/update.sql | 4 ++-- .../tables/templates/columns/sql/12_plus/create.sql | 14 ++ .../tables/templates/columns/sql/9.2_plus/update.sql | 4 ++-- .../tables/templates/columns/sql/default/create.sql | 14 ++ .../tables/templates/columns/sql/default/update.sql | 4 ++-- .../tables/templates/tables/sql/10_plus/create.sql| 15 +++ .../tables/templates/tables/sql/12_plus/create.sql| 15 +++ .../tables/templates/tables/sql/default/create.sql| 15 +++ 16 files changed, 116 insertions(+), 9 deletions(-)
Re: [pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table
Hi Aditya The issue has not been resolved. Remove fill factor it won't generate MSQL. Please verify and fix it. On Mon, Dec 9, 2019 at 3:33 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix an issue where just clicking on an > empty textbox like fill factor in tables dialog considers it a change and > so the save button is enabled. > The fix is common will apply at other places also. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fix XSS issue in explain and explain analyze for tabl
Fix XSS issue in explain and explain analyze for table and type which contain HTML. Fixes #4947. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb26ca0e46e9947977937654e935cb974fd989f1 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_16.rst | 1 + web/pgadmin/misc/static/explain/js/explain.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
pgAdmin 4 commit: Update version for release.
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a87b1387a8d34fe439cbb3d2c82318709f6b512 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
french translation update
Hello for upcoming release Fred messages-fr.tar.xz Description: application/xz-compressed-tar
Re: Re : [BUG #4943]
Hi Karan,
Kindly add a hyphen between the message and names, create a patch to
pgAdmin hackers(check cc).
Kindly also run the test cases and pep8 before sending.
On Mon, Dec 9, 2019, 20:17 Karan Takalkar wrote:
> I have updated the success message.
> Please check the screenshots attached.
> Should i make a patch?
>
> Regards,
> Karan
>
> On Mon, 9 Dec, 2019, 3:25 PM Aditya Toshniwal, <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> ++pgadmin-hackers
>>
>> Hi Karan,
>>
>> It is good to know that you're contributing.
>> I would suggest {server name}/{db name} as name instead of did is better
>> for UX. You can get the db name from conn object and server name using the
>> sid (refer - web/pgadmin/browser/server_groups/servers/__init__.py)
>>
>>
>> On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar
>> wrote:
>>
>>> Hi,
>>>
>>> I have been working on #4943 ("Database connected" success message
>>> itself is not enough) added by you on pgAdmin4 issues.
>>> I want to know what details of database should be included in success
>>> message.(i have added 'did')
>>>
>>> The success message can be modified by altering json response in the
>>> connect method in file
>>> PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.
>>> please have a look at the screenshots attached.
>>>
>>> original:
>>> info=_( "Database connected.")
>>> new:
>>> info=_("Postgres version/{0} Database connected.".format(did))
>>>
>>> Regards,
>>> Karan
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
pgAdmin 4 commit: Update French translation.
Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=324722359550443ac51b3daf1e9baba9801ac3f5 Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.po| 1275 +--- 1 file changed, 327 insertions(+), 948 deletions(-)
Re: french translation update
Thanks, patch applied. On Mon, Dec 9, 2019 at 8:22 PM wrote: > > Hello > for upcoming release > Fred > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin4 v4.16 candidate builds
Hi All, pgAdmin4 v4.16 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-12-09-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table
Hi Hackers, Attached is the updated patch. The modified SQL missed the reset clause for FILLFACTOR. That's added now. I've changed the int/numeric field validation to disallow spaces in the form field. Currently, fill factor allows spaces and fails while saving as "invalid value". Also, added min and max for fill factor in Mview dialog. All the test cases are passing. Kindly review. On Mon, Dec 9, 2019 at 4:30 PM Akshay Joshi wrote: > Hi Aditya > > The issue has not been resolved. Remove fill factor it won't generate > MSQL. Please verify and fix it. > > On Mon, Dec 9, 2019 at 3:33 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix an issue where just clicking on an >> empty textbox like fill factor in tables dialog considers it a change and >> so the save button is enabled. >> The fix is common will apply at other places also. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4506_v2.patch Description: Binary data
