pgAdmin 4 commit: Fix 'Could not find the object on the server.' error
Fix 'Could not find the object on the server.' error while refreshing the check constraint. Fixes #4966. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9110703aaa100840b7bed4820c3a6c59884b0c7b Modified Files -- docs/en_US/release_notes_4_16.rst | 1 + .../databases/schemas/tables/constraints/check_constraint/__init__.py | 1 + .../schemas/tables/templates/check_constraint/sql/9.2_plus/nodes.sql | 3 ++- .../schemas/tables/templates/check_constraint/sql/default/nodes.sql| 3 ++- 4 files changed, 6 insertions(+), 2 deletions(-)
Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the
I intentionally didn't change that one as I wasn't sure what icon would be better. I'm far from convinced that it should also be a play icon. On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to change toolbar icon for opening query tool inline > with execute button change. > Icon for table filter button on the toolbar is also changed as below: > [image: toolbar.png] > > On Tue, Dec 3, 2019 at 7:15 AM Dave Page wrote: > >> Use a 'play' icon for the Execute Query button in the Query Tool for >> greater consistency with other applications. Fixes #4711 >> >> Branch >> -- >> master >> >> Details >> --- >> >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2bd5e6ee7c41d5fc2f4ee0036042ac79ff9320 >> >> Modified Files >> -- >> docs/en_US/release_notes_4_16.rst| 1 + >> web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +- >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the
Hi Dave, I've sent a patch for the new icon. It is not a play icon but thoughts on the sent patch ? Below is the icon: [image: toolbar.png] On Tue, Dec 3, 2019 at 4:09 PM Dave Page wrote: > I intentionally didn't change that one as I wasn't sure what icon would be > better. I'm far from convinced that it should also be a play icon. > > On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to change toolbar icon for opening query tool >> inline with execute button change. >> Icon for table filter button on the toolbar is also changed as below: >> [image: toolbar.png] >> >> On Tue, Dec 3, 2019 at 7:15 AM Dave Page wrote: >> >>> Use a 'play' icon for the Execute Query button in the Query Tool for >>> greater consistency with other applications. Fixes #4711 >>> >>> Branch >>> -- >>> master >>> >>> Details >>> --- >>> >>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2bd5e6ee7c41d5fc2f4ee0036042ac79ff9320 >>> >>> Modified Files >>> -- >>> docs/en_US/release_notes_4_16.rst| 1 + >>> web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +- >>> 2 files changed, 2 insertions(+), 1 deletion(-) >>> >>> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: Fixes for pgAdmin feature tests
Hi Team, PFA patch for feature tests containing following fixes- 1. Modified the get_chromedriver utility for supporting python version below 3.5. 2. Handled some exceptions getting intermittently on some databases. 3. Generalized some functions with additional parameters. 4. Disabled the auto-expansion of the children nodes for maintaining the synchronization. On Thu, Nov 21, 2019 at 5:22 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Nov 21, 2019 at 3:40 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> Attach is the patch for feature test fix containing the following: >> 1. Handled click event in query tool due to intermediate clicking issue. >> 2. Observed that the database is not getting created in a test case, so >> failed the test case there only. >> >> On Wed, Nov 20, 2019 at 1:09 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal < >>> shubham.agar...@enterprisedb.com> wrote: >>> Hi Team, PFA feature test fixture patch containing the following things: 1. Added an attribute 'data-click-counter' in query execute button which gets incremented once query button is clicked up to 9 and then reset to 0. This is added just to support automation. 2. Locator for login_group_role is added and used to expand tree. 3. Functions for enabling and disable auto_commit and auto_rollback are made more precise. 4. Some scrolling problem is addressed in view_data_dml_query test. 5. Handled the stale element reference exception in query_tool_journey_test Regards, Shubham Agarwal On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Thanks, patch applied > > On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> >> PFA feature test fixture patch containing the following fixes: >> 1. Process watcher loading logs fix >> 2. Auto commit/rollback issue in query_tool_tests >> 3. Fixed the scrolling issue while verifying values in a table. >> 4. Modified some functions in pgadmin_page.py >> >> On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < >>> shubham.agar...@enterprisedb.com> wrote: >>> Hi Team, PFA patch containing some more fixes for random feature test failures. Thanks and regards, Shubham Agarwal On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Thanks, patch applied with a minor change. Menu for 'Delete Drop' > server has been changed to 'Remove Server' which causes all the test > cases > failing on my machine. > > On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> >> Attached is the patch containing fixes for the failed feature >> test cases. >> This patch contains- >> 1. Newly created function for traversing the browser tree. >> 2. Some synchronization issue fixes. >> 3. Modified locators. >> 4. Test cases fix for the recent commits. >> >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>>
pgAdmin 4 commit: Fix an issue where the inherited table name with quot
Fix an issue where the inherited table name with quotes did not escape correctly. Fixes #4985. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7cc79fab1241ca023d868ab2fc85cceef674ff9 Modified Files -- docs/en_US/release_notes_4_16.rst | 1 + web/pgadmin/static/js/backform.pgadmin.js | 13 ++--- 2 files changed, 7 insertions(+), 7 deletions(-)
pgAdmin 4 commit: Fixed following issues for feature test:
Fixed following issues for feature test: 1. Modified the get_chromedriver utility for supporting python version below 3.5. 2. Handled some exceptions getting intermittently on some databases. 3. Generalized some functions with additional parameters. 4. Disabled the auto-expansion of the children nodes for maintaining the synchronization. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5093e6db5e7a36f27229dd480a92ec2f27074b14 Author: Shubham Agarwal Modified Files -- tools/get_chromedriver.py | 23 ++- .../feature_tests/pg_datatype_validation_test.py | 6 +-- .../pg_utilities_backup_restore_test.py| 9 +++-- .../query_tool_auto_complete_tests.py | 8 ++-- web/pgadmin/feature_tests/query_tool_tests.py | 11 +++-- web/regression/feature_utils/pgadmin_page.py | 34 +--- .../python_test_utils/test_gui_helper.py | 17 web/regression/python_test_utils/test_utils.py | 47 +- 8 files changed, 94 insertions(+), 61 deletions(-)
Re: Fixes for pgAdmin feature tests
Thanks, patch applied. On Tue, Dec 3, 2019 at 6:09 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > > PFA patch for feature tests containing following fixes- > > 1. Modified the get_chromedriver utility for supporting python version > below 3.5. > 2. Handled some exceptions getting intermittently on some databases. > 3. Generalized some functions with additional parameters. > 4. Disabled the auto-expansion of the children nodes for maintaining the > synchronization. > > On Thu, Nov 21, 2019 at 5:22 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Thu, Nov 21, 2019 at 3:40 PM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Team, >>> Attach is the patch for feature test fix containing the following: >>> 1. Handled click event in query tool due to intermediate clicking issue. >>> 2. Observed that the database is not getting created in a test case, so >>> failed the test case there only. >>> >>> On Wed, Nov 20, 2019 at 1:09 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Thanks, patch applied. On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA feature test fixture patch containing the following things: > > 1. Added an attribute 'data-click-counter' in query execute button > which gets incremented once query button is clicked up to 9 and then reset > to 0. This is added just to support automation. > 2. Locator for login_group_role is added and used to expand tree. > 3. Functions for enabling and disable auto_commit and auto_rollback > are made more precise. > 4. Some scrolling problem is addressed in view_data_dml_query test. > 5. Handled the stale element reference exception in > query_tool_journey_test > > Regards, > Shubham Agarwal > > On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied >> >> On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> PFA feature test fixture patch containing the following fixes: >>> 1. Process watcher loading logs fix >>> 2. Auto commit/rollback issue in query_tool_tests >>> 3. Fixed the scrolling issue while verifying values in a table. >>> 4. Modified some functions in pgadmin_page.py >>> >>> On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Thanks, patch applied. On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA patch containing some more fixes for random feature test > failures. > > Thanks and regards, > Shubham Agarwal > > On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied with a minor change. Menu for 'Delete Drop' >> server has been changed to 'Remove Server' which causes all the test >> cases >> failing on my machine. >> >> On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Attached is the patch containing fixes for the failed feature >>> test cases. >>> This patch contains- >>> 1. Newly created function for traversing the browser tree. >>> 2. Some synchronization issue fixes. >>> 3. Modified locators. >>> 4. Test cases fix for the recent commits. >>> >>> -- >>> Thanks & Regards, >>> Shubham Agarwal >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Thanks & Regards, >>> Shubham Agarwal >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >
RM4939 - Running in the container as non-root user
The attached patch fixes $SUBJECT. I'm a little concerned about upgrades though, mostly when using mapped storage or session data. Fahar, can you test such scenarios please? Patch review is also needed please :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4939.diff Description: Binary data
Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the
Hi Dave, Should I commit this patch, are you happy with the new icons? On Tue, Dec 3, 2019 at 4:13 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > I've sent a patch for the new icon. It is not a play icon but thoughts on > the sent patch ? Below is the icon: > [image: toolbar.png] > > On Tue, Dec 3, 2019 at 4:09 PM Dave Page wrote: > >> I intentionally didn't change that one as I wasn't sure what icon would >> be better. I'm far from convinced that it should also be a play icon. >> >> On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to change toolbar icon for opening query tool >>> inline with execute button change. >>> Icon for table filter button on the toolbar is also changed as below: >>> [image: toolbar.png] >>> >>> On Tue, Dec 3, 2019 at 7:15 AM Dave Page wrote: >>> Use a 'play' icon for the Execute Query button in the Query Tool for greater consistency with other applications. Fixes #4711 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2bd5e6ee7c41d5fc2f4ee0036042ac79ff9320 Modified Files -- docs/en_US/release_notes_4_16.rst| 1 + web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
