pgAdmin 4 commit: Updated the json file name from 'servers.json' to 'pg
Updated the json file name from 'servers.json' to 'pgadmin4/servers.json' in the container deployment section of the documentation. Fixes #4836. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a03b8b4f761efe4176f78f1394c1a63d5f56f706 Author: Abhilasha Narendra Modified Files -- docs/en_US/container_deployment.rst | 4 ++-- docs/en_US/release_notes_4_16.rst | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)
Re: [pgAdmin][RM4836] Wrong default value in Container Deployment section of documentation
Thanks, patch applied. On Fri, Nov 22, 2019 at 6:35 PM Abhilasha Narendra < abhilasha.naren...@enterprisedb.com> wrote: > Hi Hackers, > > I have updated the content of 'container_deployment.rst' file, as approved > by Dave over email. PFA the patch. > > Regards, > Abhilasha > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View
Thanks, patch applied. On Sat, Nov 23, 2019 at 12:37 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Akshay, > > Please find the correction done in this updated patch based on your review > comments. > > Regards, > Rahul Shirsat. > > On Thu, Nov 21, 2019 at 1:08 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> Some more review comments: >> >>- Don't create new file test_view.json as I tested and committed the >>old code. >>- Remove hardcoded "oid: 17869" from JSON file. >>- MSQL endpoints and file name missing in some test cases. >>- Cover all the controls in create and alter as much as possible. >> >> >> On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Rahul >>> >>> Test cases failing on all EPAS servers. Please fix and send the patch >>> again. >>> >>> On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat < >>> rahul.shir...@enterprisedb.com> wrote: >>> Hi Hackers, I have attached the patch for RE-SQL/MSQL test cases for View as well as Materialized View. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Add Reverse Engineered and Modified SQL tests for Mat
Add Reverse Engineered and Modified SQL tests for Materialized Views. Fixes #4696. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a39dedc62d15e15977e43a6a73a391d803d453f Author: Rahul Shirsat Modified Files -- docs/en_US/release_notes_4_16.rst | 1 + .../templates/mviews/pg/9.3_plus/sql/create.sql| 7 +- .../templates/mviews/pg/9.4_plus/sql/create.sql| 7 +- .../templates/mviews/pg/9.4_plus/sql/update.sql| 25 +- .../templates/mviews/ppas/9.3_plus/sql/acl.sql | 1 + .../templates/mviews/ppas/9.3_plus/sql/create.sql | 7 +- .../templates/mviews/ppas/9.3_plus/sql/update.sql | 22 +- .../templates/views/ppas/9.4_plus/sql/acl.sql | 1 + .../views/tests/pg/9.4_plus/alter_mview.sql| 19 +- .../pg/9.4_plus/alter_mview_add_fillfactor.sql | 16 + .../9.4_plus/alter_mview_add_fillfactor_msql.sql | 6 + .../9.4_plus/alter_mview_add_table_parameter.sql | 17 + .../alter_mview_add_table_parameter_msql.sql | 4 + .../tests/pg/9.4_plus/alter_mview_definition.sql | 12 + .../pg/9.4_plus/alter_mview_definition_msql.sql| 4 + .../pg/9.4_plus/alter_mview_drop_all_priv.sql | 17 + .../pg/9.4_plus/alter_mview_drop_all_priv_msql.sql | 1 + .../views/tests/pg/9.4_plus/alter_mview_msql.sql | 1 + .../alter_mview_remove_table_parameter.sql | 16 + .../alter_mview_remove_table_parameter_msql.sql| 6 + .../schemas/views/tests/pg/9.4_plus/alter_view.sql | 2 - .../tests/pg/9.4_plus/alter_view_add_some_priv.sql | 19 ++ .../pg/9.4_plus/alter_view_add_some_priv_msql.sql | 1 + .../tests/pg/9.4_plus/alter_view_definition.sql| 18 ++ .../pg/9.4_plus/alter_view_definition_msql.sql | 4 + .../tests/pg/9.4_plus/alter_view_delete_priv.sql | 18 ++ .../pg/9.4_plus/alter_view_delete_priv_msql.sql| 1 + .../views/tests/pg/9.4_plus/alter_view_msql.sql| 7 + .../views/tests/pg/9.4_plus/create_mview.sql | 16 +- .../views/tests/pg/9.4_plus/create_mview_msql.sql | 11 + .../views/tests/pg/9.4_plus/create_view_msql.sql | 12 + .../views/tests/pg/9.4_plus/test_mview.json| 341 +++-- .../schemas/views/tests/pg/9.4_plus/tests.json | 106 ++- .../views/tests/ppas/11_plus/alter_mview.sql | 18 ++ .../ppas/11_plus/alter_mview_add_fillfactor.sql| 16 + .../11_plus/alter_mview_add_fillfactor_msql.sql| 6 + .../11_plus/alter_mview_add_table_parameter.sql| 17 + .../alter_mview_add_table_parameter_msql.sql | 4 + .../tests/ppas/11_plus/alter_mview_definition.sql | 12 + .../ppas/11_plus/alter_mview_definition_msql.sql | 4 + .../ppas/11_plus/alter_mview_drop_all_priv.sql | 17 + .../11_plus/alter_mview_drop_all_priv_msql.sql | 1 + .../views/tests/ppas/11_plus/alter_mview_msql.sql | 1 + .../11_plus/alter_mview_remove_table_parameter.sql | 16 + .../alter_mview_remove_table_parameter_msql.sql| 6 + .../views/tests/ppas/11_plus/alter_view.sql| 18 ++ .../ppas/11_plus/alter_view_add_some_priv.sql | 19 ++ .../ppas/11_plus/alter_view_add_some_priv_msql.sql | 1 + .../tests/ppas/11_plus/alter_view_definition.sql | 18 ++ .../ppas/11_plus/alter_view_definition_msql.sql| 4 + .../tests/ppas/11_plus/alter_view_delete_priv.sql | 18 ++ .../ppas/11_plus/alter_view_delete_priv_msql.sql | 1 + .../views/tests/ppas/11_plus/alter_view_msql.sql | 7 + .../views/tests/ppas/11_plus/create_mview.sql | 15 + .../views/tests/ppas/11_plus/create_mview_msql.sql | 11 + .../views/tests/ppas/11_plus/create_view.sql | 17 + .../views/tests/ppas/11_plus/create_view_msql.sql | 12 + .../views/tests/ppas/11_plus/test_mview.json | 256 .../schemas/views/tests/ppas/11_plus/tests.json| 178 +++ .../views/tests/ppas/9.4_plus/alter_mview.sql | 19 +- .../ppas/9.4_plus/alter_mview_add_fillfactor.sql | 16 + .../9.4_plus/alter_mview_add_fillfactor_msql.sql | 6 + .../9.4_plus/alter_mview_add_table_parameter.sql | 17 + .../alter_mview_add_table_parameter_msql.sql | 4 + .../tests/ppas/9.4_plus/alter_mview_definition.sql | 12 + .../ppas/9.4_plus/alter_mview_definition_msql.sql | 4 + .../ppas/9.4_plus/alter_mview_drop_all_priv.sql| 17 + .../9.4_plus/alter_mview_drop_all_priv_msql.sql| 1 + .../views/tests/ppas/9.4_plus/alter_mview_msql.sql | 1 + .../alter_mview_remove_table_parameter.sql | 16 + .../alter_mview_remove_table_parameter_msql.sql| 6 + .../views/tests/ppas/9.4_plus/alter_view.sql | 12 +- .../ppas/9.4_plus/alter_view_add_some_priv.sql | 19 ++ .../9.4_plus/alter_view_add_some_priv_msql.sql | 1 + .../tests/ppas/9.4_plus/alter_view_definition.sql | 18 ++ .../ppas/9.4_plus/alter_view_definition_msql.sql | 4 + .../tests/ppas/9.4_plus/alter_view_delete_priv.sql | 18 ++ .../ppas/9.4_plus/alter_view_delete_priv_msql.sql | 1 + .../views/tests/ppas/9.4_plus/alter_view_msq