Re: Fixes for pgAdmin feature tests
Hi Team, Attach is the patch for feature test fix containing the following: 1. Handled click event in query tool due to intermediate clicking issue. 2. Observed that the database is not getting created in a test case, so failed the test case there only. On Wed, Nov 20, 2019 at 1:09 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> PFA feature test fixture patch containing the following things: >> >> 1. Added an attribute 'data-click-counter' in query execute button which >> gets incremented once query button is clicked up to 9 and then reset to 0. >> This is added just to support automation. >> 2. Locator for login_group_role is added and used to expand tree. >> 3. Functions for enabling and disable auto_commit and auto_rollback are >> made more precise. >> 4. Some scrolling problem is addressed in view_data_dml_query test. >> 5. Handled the stale element reference exception in >> query_tool_journey_test >> >> Regards, >> Shubham Agarwal >> >> On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, patch applied >>> >>> On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal < >>> shubham.agar...@enterprisedb.com> wrote: >>> Hi Team, PFA feature test fixture patch containing the following fixes: 1. Process watcher loading logs fix 2. Auto commit/rollback issue in query_tool_tests 3. Fixed the scrolling issue while verifying values in a table. 4. Modified some functions in pgadmin_page.py On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Thanks, patch applied. > > On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> PFA patch containing some more fixes for random feature test failures. >> >> Thanks and regards, >> Shubham Agarwal >> >> On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, patch applied with a minor change. Menu for 'Delete Drop' >>> server has been changed to 'Remove Server' which causes all the test >>> cases >>> failing on my machine. >>> >>> On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < >>> shubham.agar...@enterprisedb.com> wrote: >>> Hi Team, Attached is the patch containing fixes for the failed feature test cases. This patch contains- 1. Newly created function for traversing the browser tree. 2. Some synchronization issue fixes. 3. Modified locators. 4. Test cases fix for the recent commits. -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company feature_test_fix_v5.patch Description: Binary data
Re: [pgAdmin][RM4818] Unable to handle loss of connection to server
Hi Aditya Following are the review comments: - Update the timeout in the comment section from 30 seconds to 10 seconds in aff1436e3c8c_.py. - Asking for the database server password even if it is saved. Reproduction steps: - Connect to the database server, saved the password. - Disabled the network. Try to connect to the database server. - Enable the network, try to connect to the database server. - No error/spinner visible on GUI when the database server is connected using SSH Tunnel. Reproduction steps: - Connect to the database server with SSH Tunnel, saved both the password. - Disabled the network and Reset the Layout. - Expand the Servers node and try to connect the same database server. On Thu, Nov 21, 2019 at 11:58 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > I forgot to mention, I've also changed the dashboard code. The dashboard > was sending graph data requests, but when the server lost connection the > requests remains pending for longer time. Because of this the server gets > flooded with lot of pending request and in turn slowing down the entire > application. > Code is changed so that only a certain number of requests remain pending > (currently 3), above which the request won't be sent. > > On Thu, Nov 21, 2019 at 11:50 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the updated patch to fix the review comments. >> Please note, there is some problem with psycopg2/libpq where it hangs >> when network is lost - https://github.com/psycopg/psycopg2/issues/561 >> I've also changed the code to make connections after the "Servers" node >> is expanded to fix - RM4933, so that the servers are listed first. >> >> Kindly review. >> >> On Fri, Nov 15, 2019 at 2:34 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Following are the review comments: >>> >>>1. The default connection timeout should be *10* seconds. >>>2. In case the network is disabled and when we expand the "Servers" >>>node the database server(for which network is disabled) should be shown >>> in >>>the disconnected state. >>>3. For the above case when you try to connect to the server and at >>>the same time trying to fetch the properties of the valid database >>> server, >>>it takes long time to fetch it. >>>4. Case when the network is disabled, the database servers password >>>is saved and pgAdmin4 tries to connect the server, after connection >>>timeout, there is no message to the user, only spinner gets disappeared. >>> We >>>should show a message. >>>5. We should improve the error messages "timeout expired" and >>>"Connection to the servers has been lost." to the more meaningful >>> messages >>>like "Check the network settings, check the firewall status." >>>6. Install database server on Windows and Enable Windows Firewall. >>>Try to connect to the same database server. Spinner is not showing, as a >>>user I am not able to understand is there any action started at the >>> backend >>>or not. As a user, I'll keep trying to connect multiple times and after >>> the >>>connection timeout of each request dialog pops up. >>> >>> >>> On Thu, Nov 14, 2019 at 12:15 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the workaround patch to set the default connection timeout to 30 seconds instead of the current value of infinite - 0, zero. The input is present in the server properties dialogs advanced tab. The workaround applies to the RM4724 as well. The permanent solution would be to expand the nodes asynchronously - https://redmine.postgresql.org/issues/4933 Also fixed a bug where sql editor is not closing if the server is disconnected in between. Kindly review. -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed following feature tests:
Fixed following feature tests: 1) Handled click event in query tool due to intermediate clicking issue. 2) Observed that the database is not getting created in a test case, so failed the test case there only. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae462ed0f26ddc19e4cf6e29806c937e11b0 Author: Shubham Agarwal Modified Files -- web/pgadmin/feature_tests/pg_utilities_backup_restore_test.py | 6 +- web/pgadmin/feature_tests/view_data_dml_queries.py| 4 +--- web/regression/feature_utils/pgadmin_page.py | 5 + 3 files changed, 7 insertions(+), 8 deletions(-)
Re: Fixes for pgAdmin feature tests
Thanks, patch applied. On Thu, Nov 21, 2019 at 3:40 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > Attach is the patch for feature test fix containing the following: > 1. Handled click event in query tool due to intermediate clicking issue. > 2. Observed that the database is not getting created in a test case, so > failed the test case there only. > > On Wed, Nov 20, 2019 at 1:09 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Team, >>> PFA feature test fixture patch containing the following things: >>> >>> 1. Added an attribute 'data-click-counter' in query execute button which >>> gets incremented once query button is clicked up to 9 and then reset to 0. >>> This is added just to support automation. >>> 2. Locator for login_group_role is added and used to expand tree. >>> 3. Functions for enabling and disable auto_commit and auto_rollback are >>> made more precise. >>> 4. Some scrolling problem is addressed in view_data_dml_query test. >>> 5. Handled the stale element reference exception in >>> query_tool_journey_test >>> >>> Regards, >>> Shubham Agarwal >>> >>> On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Thanks, patch applied On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > > PFA feature test fixture patch containing the following fixes: > 1. Process watcher loading logs fix > 2. Auto commit/rollback issue in query_tool_tests > 3. Fixed the scrolling issue while verifying values in a table. > 4. Modified some functions in pgadmin_page.py > > On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Team, >>> PFA patch containing some more fixes for random feature test >>> failures. >>> >>> Thanks and regards, >>> Shubham Agarwal >>> >>> On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Thanks, patch applied with a minor change. Menu for 'Delete Drop' server has been changed to 'Remove Server' which causes all the test cases failing on my machine. On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > > Attached is the patch containing fixes for the failed feature test > cases. > This patch contains- > 1. Newly created function for traversing the browser tree. > 2. Some synchronization issue fixes. > 3. Modified locators. > 4. Test cases fix for the recent commits. > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Thanks & Regards, >>> Shubham Agarwal >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Thanks & Regards, >>> Shubham Agarwal >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
