pgAdmin 4 commit: Fix vulnerability issue for package 'mem', which is a
Fix vulnerability issue for package 'mem', which is a dependency module for eclint. Remove unused eclint module from the package.json Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bb845817d671e873a2f4ef65b03f10943ddd79c4 Modified Files -- libraries.txt|1 - web/package.json |1 - web/yarn.lock| 1351 ++ 3 files changed, 339 insertions(+), 1014 deletions(-)
pgAdmin 4 commit: Fixed issue where Dark Theme is unavailable in python
Fixed issue where Dark Theme is unavailable in python wheel distro. pgAdmin wheel distro is not having pgadmin.themes.json file in 'web/pgadmin/misc/themes' directory, so it's better to refer this file from the generated directory. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5316a28e6c2a56642b8ef5c993ae2546ab7b2135 Author: Aditya Toshniwal Modified Files -- web/pgadmin/misc/themes/__init__.py | 2 ++ 1 file changed, 2 insertions(+)
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Thanks, patch applied. On Wed, Nov 20, 2019 at 11:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run > bundle" and is copied to generated directory also. This file is required > for themes to show up. > Currently, pgadmin.themes.json file is referred > from web/pgadmin/misc/themes directory by the app. It is better to refer > from generated directory instead so that it is not missed in the pgAdmin > distribution phase. The pgAdmin 4.15 wheel distro is not having this file > in web/pgadmin/misc/themes directory and so themes are not available in it. > Attached is the patch to fix this. > > > On Wed, Nov 13, 2019 at 11:36 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Wed, Nov 13, 2019 at 10:46 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to set browser autofill color. I've used primary >>> light color to highlight autofill. Note that, this works only on webkit >>> browsers. >>> Kindly review. >>> >>> On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Dave, On Tue, Nov 12, 2019 at 7:29 PM Dave Page wrote: > > > On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to customize the scrollbar styling. A new SASS >> variable added - $scrollbar-base-color is added to change the color as >> per >> theme. >> Please note, customization of scrollbar works only in webkit browsers >> like Chrome, Safari. Mozilla does not have any way to customize. >> > > That looks much nicer :-). > > One more issue I just spotted - I'm guessing it's specific to Alertify > dialogues: > > [image: Screenshot 2019-11-12 at 13.57.34.png] > This is your browser autofill which is changing the color and not the issue with the dialogs. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Thanks all! On Wed, Nov 20, 2019 at 4:37 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Nov 20, 2019 at 11:59 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run >> bundle" and is copied to generated directory also. This file is required >> for themes to show up. >> Currently, pgadmin.themes.json file is referred >> from web/pgadmin/misc/themes directory by the app. It is better to refer >> from generated directory instead so that it is not missed in the pgAdmin >> distribution phase. The pgAdmin 4.15 wheel distro is not having this file >> in web/pgadmin/misc/themes directory and so themes are not available in it. >> Attached is the patch to fix this. >> >> >> On Wed, Nov 13, 2019 at 11:36 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Wed, Nov 13, 2019 at 10:46 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch to set browser autofill color. I've used primary light color to highlight autofill. Note that, this works only on webkit browsers. Kindly review. On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Nov 12, 2019 at 7:29 PM Dave Page wrote: > >> >> >> On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to customize the scrollbar styling. A new SASS >>> variable added - $scrollbar-base-color is added to change the color as >>> per >>> theme. >>> Please note, customization of scrollbar works only in webkit >>> browsers like Chrome, Safari. Mozilla does not have any way to >>> customize. >>> >> >> That looks much nicer :-). >> >> One more issue I just spotted - I'm guessing it's specific to >> Alertify dialogues: >> >> [image: Screenshot 2019-11-12 at 13.57.34.png] >> > This is your browser autofill which is changing the color and not the > issue with the dialogs. > >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4818] Unable to handle loss of connection to server
Hi Hackers, Attached is the updated patch to fix the review comments. Please note, there is some problem with psycopg2/libpq where it hangs when network is lost - https://github.com/psycopg/psycopg2/issues/561 I've also changed the code to make connections after the "Servers" node is expanded to fix - RM4933, so that the servers are listed first. Kindly review. On Fri, Nov 15, 2019 at 2:34 PM Akshay Joshi wrote: > Hi Aditya > > Following are the review comments: > >1. The default connection timeout should be *10* seconds. >2. In case the network is disabled and when we expand the "Servers" >node the database server(for which network is disabled) should be shown in >the disconnected state. >3. For the above case when you try to connect to the server and at >the same time trying to fetch the properties of the valid database server, >it takes long time to fetch it. >4. Case when the network is disabled, the database servers password >is saved and pgAdmin4 tries to connect the server, after connection >timeout, there is no message to the user, only spinner gets disappeared. We >should show a message. >5. We should improve the error messages "timeout expired" and >"Connection to the servers has been lost." to the more meaningful messages >like "Check the network settings, check the firewall status." >6. Install database server on Windows and Enable Windows Firewall. Try >to connect to the same database server. Spinner is not showing, as a user I >am not able to understand is there any action started at the backend or >not. As a user, I'll keep trying to connect multiple times and after the >connection timeout of each request dialog pops up. > > > On Thu, Nov 14, 2019 at 12:15 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the workaround patch to set the default connection timeout to >> 30 seconds instead of the current value of infinite - 0, zero. The input is >> present in the server properties dialogs advanced tab. The workaround >> applies to the RM4724 as well. >> The permanent solution would be to expand the nodes asynchronously - >> https://redmine.postgresql.org/issues/4933 >> >> Also fixed a bug where sql editor is not closing if the server is >> disconnected in between. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4818_v2.patch Description: Binary data
Re: [pgAdmin][RM4818] Unable to handle loss of connection to server
Hi, I forgot to mention, I've also changed the dashboard code. The dashboard was sending graph data requests, but when the server lost connection the requests remains pending for longer time. Because of this the server gets flooded with lot of pending request and in turn slowing down the entire application. Code is changed so that only a certain number of requests remain pending (currently 3), above which the request won't be sent. On Thu, Nov 21, 2019 at 11:50 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to fix the review comments. > Please note, there is some problem with psycopg2/libpq where it hangs when > network is lost - https://github.com/psycopg/psycopg2/issues/561 > I've also changed the code to make connections after the "Servers" node is > expanded to fix - RM4933, so that the servers are listed first. > > Kindly review. > > On Fri, Nov 15, 2019 at 2:34 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Following are the review comments: >> >>1. The default connection timeout should be *10* seconds. >>2. In case the network is disabled and when we expand the "Servers" >>node the database server(for which network is disabled) should be shown in >>the disconnected state. >>3. For the above case when you try to connect to the server and at >>the same time trying to fetch the properties of the valid database server, >>it takes long time to fetch it. >>4. Case when the network is disabled, the database servers password >>is saved and pgAdmin4 tries to connect the server, after connection >>timeout, there is no message to the user, only spinner gets disappeared. >> We >>should show a message. >>5. We should improve the error messages "timeout expired" and >>"Connection to the servers has been lost." to the more meaningful messages >>like "Check the network settings, check the firewall status." >>6. Install database server on Windows and Enable Windows Firewall. >>Try to connect to the same database server. Spinner is not showing, as a >>user I am not able to understand is there any action started at the >> backend >>or not. As a user, I'll keep trying to connect multiple times and after >> the >>connection timeout of each request dialog pops up. >> >> >> On Thu, Nov 14, 2019 at 12:15 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the workaround patch to set the default connection timeout >>> to 30 seconds instead of the current value of infinite - 0, zero. The input >>> is present in the server properties dialogs advanced tab. The workaround >>> applies to the RM4724 as well. >>> The permanent solution would be to expand the nodes asynchronously - >>> https://redmine.postgresql.org/issues/4933 >>> >>> Also fixed a bug where sql editor is not closing if the server is >>> disconnected in between. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View
Hi Rahul Some more review comments: - Don't create new file test_view.json as I tested and committed the old code. - Remove hardcoded "oid: 17869" from JSON file. - MSQL endpoints and file name missing in some test cases. - Cover all the controls in create and alter as much as possible. On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi wrote: > Hi Rahul > > Test cases failing on all EPAS servers. Please fix and send the patch > again. > > On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I have attached the patch for RE-SQL/MSQL test cases for View as well as >> Materialized View. >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
