Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View
Hi Rahul Test cases failing on all EPAS servers. Please fix and send the patch again. On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > I have attached the patch for RE-SQL/MSQL test cases for View as well as > Materialized View. > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi Hackers, pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run bundle" and is copied to generated directory also. This file is required for themes to show up. Currently, pgadmin.themes.json file is referred from web/pgadmin/misc/themes directory by the app. It is better to refer from generated directory instead so that it is not missed in the pgAdmin distribution phase. The pgAdmin 4.15 wheel distro is not having this file in web/pgadmin/misc/themes directory and so themes are not available in it. Attached is the patch to fix this. On Wed, Nov 13, 2019 at 11:36 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Nov 13, 2019 at 10:46 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to set browser autofill color. I've used primary >> light color to highlight autofill. Note that, this works only on webkit >> browsers. >> Kindly review. >> >> On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Nov 12, 2019 at 7:29 PM Dave Page wrote: >>> On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to customize the scrollbar styling. A new SASS > variable added - $scrollbar-base-color is added to change the color as per > theme. > Please note, customization of scrollbar works only in webkit browsers > like Chrome, Safari. Mozilla does not have any way to customize. > That looks much nicer :-). One more issue I just spotted - I'm guessing it's specific to Alertify dialogues: [image: Screenshot 2019-11-12 at 13.57.34.png] >>> This is your browser autofill which is changing the color and not the >>> issue with the dialogs. >>> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4348.part6.patch Description: Binary data
Re: Fixes for pgAdmin feature tests
Hi Team, PFA feature test fixture patch containing the following things: 1. Added an attribute 'data-click-counter' in query execute button which gets incremented once query button is clicked up to 9 and then reset to 0. This is added just to support automation. 2. Locator for login_group_role is added and used to expand tree. 3. Functions for enabling and disable auto_commit and auto_rollback are made more precise. 4. Some scrolling problem is addressed in view_data_dml_query test. 5. Handled the stale element reference exception in query_tool_journey_test Regards, Shubham Agarwal On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi wrote: > Thanks, patch applied > > On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> >> PFA feature test fixture patch containing the following fixes: >> 1. Process watcher loading logs fix >> 2. Auto commit/rollback issue in query_tool_tests >> 3. Fixed the scrolling issue while verifying values in a table. >> 4. Modified some functions in pgadmin_page.py >> >> On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < >>> shubham.agar...@enterprisedb.com> wrote: >>> Hi Team, PFA patch containing some more fixes for random feature test failures. Thanks and regards, Shubham Agarwal On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Thanks, patch applied with a minor change. Menu for 'Delete Drop' > server has been changed to 'Remove Server' which causes all the test cases > failing on my machine. > > On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> >> Attached is the patch containing fixes for the failed feature test >> cases. >> This patch contains- >> 1. Newly created function for traversing the browser tree. >> 2. Some synchronization issue fixes. >> 3. Modified locators. >> 4. Test cases fix for the recent commits. >> >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company feature_test_fix_v4.patch Description: Binary data
pgAdmin 4 commit: Fix some more feature tests:
Fix some more feature tests: 1. Added an attribute 'data-click-counter' in query execute button which gets incremented once query button is clicked up to 9 and then reset to 0. This is added just to support automation. 2. Locator for login_group_role is added and used to expand tree. 3. Functions for enabling and disable auto_commit and auto_rollback are made more precise. 4. Some scrolling problem is addressed in view_data_dml_query test. 5. Handled the stale element reference exception in query_tool_journey_test Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=425cc2a96653a0d8babcdab536ef91d6c2f20da0 Author: Shubham Agarwal Modified Files -- .../feature_tests/query_tool_journey_test.py | 9 ++- web/pgadmin/feature_tests/query_tool_tests.py | 48 +++- web/pgadmin/feature_tests/view_data_dml_queries.py | 7 +-- .../feature_tests/xss_checks_roles_control_test.py | 4 +- .../tools/datagrid/templates/datagrid/index.html | 2 +- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 4 ++ web/regression/feature_utils/pgadmin_page.py | 64 +- web/regression/feature_utils/tree_area_locators.py | 4 ++ 8 files changed, 82 insertions(+), 60 deletions(-)
Re: Fixes for pgAdmin feature tests
Thanks, patch applied. On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA feature test fixture patch containing the following things: > > 1. Added an attribute 'data-click-counter' in query execute button which > gets incremented once query button is clicked up to 9 and then reset to 0. > This is added just to support automation. > 2. Locator for login_group_role is added and used to expand tree. > 3. Functions for enabling and disable auto_commit and auto_rollback are > made more precise. > 4. Some scrolling problem is addressed in view_data_dml_query test. > 5. Handled the stale element reference exception in query_tool_journey_test > > Regards, > Shubham Agarwal > > On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied >> >> On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> PFA feature test fixture patch containing the following fixes: >>> 1. Process watcher loading logs fix >>> 2. Auto commit/rollback issue in query_tool_tests >>> 3. Fixed the scrolling issue while verifying values in a table. >>> 4. Modified some functions in pgadmin_page.py >>> >>> On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Thanks, patch applied. On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA patch containing some more fixes for random feature test failures. > > Thanks and regards, > Shubham Agarwal > > On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied with a minor change. Menu for 'Delete Drop' >> server has been changed to 'Remove Server' which causes all the test >> cases >> failing on my machine. >> >> On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Attached is the patch containing fixes for the failed feature test >>> cases. >>> This patch contains- >>> 1. Newly created function for traversing the browser tree. >>> 2. Some synchronization issue fixes. >>> 3. Modified locators. >>> 4. Test cases fix for the recent commits. >>> >>> -- >>> Thanks & Regards, >>> Shubham Agarwal >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Thanks & Regards, >>> Shubham Agarwal >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
