Re: pgAdmin4 v4.15 candidate builds
Hi Akshay, Showstopper issue reported for Docker: https://redmine.postgresql.org/issues/4924 On Tue, Nov 12, 2019 at 10:38 AM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.15 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-11-12-1/ > > *Note*:- Windows build is failed I am looking into it. > > Fahar, can you please verify it for release on Thursday. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Fahar Abbas QMG EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: *live:fahar.abbas* Website: www.enterprisedb.com
pgAdmin 4 commit: Further changes to the welcome dashboard for theme cu
Further changes to the welcome dashboard for theme customization. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=636ab296693609b618b04aae4dc791b31512e0e4 Author: Aditya Toshniwal Modified Files -- web/pgadmin/dashboard/static/scss/_dashboard.scss | 15 +- .../templates/dashboard/welcome_dashboard.html | 62 -- .../static/scss/resources/_default.variables.scss | 4 +- .../scss/resources/dark/_theme.variables.scss | 4 +- 4 files changed, 77 insertions(+), 8 deletions(-)
pgAdmin 4 commit: Fixed docker container exit issue occurs due to chang
Fixed docker container exit issue occurs due to change in Gunicorn's latest version. Updated Dockerfile and hardcoded Gunicorn version to 19.9.0 Fixes #4924 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb87920bbb326ca3b53e917b3a3c07491c62168e Modified Files -- Dockerfile| 2 +- docs/en_US/release_notes_4_15.rst | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
Re: Fixes for pgAdmin feature tests
Hi Team, PFA patch containing some more fixes for random feature test failures. Thanks and regards, Shubham Agarwal On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi wrote: > Thanks, patch applied with a minor change. Menu for 'Delete Drop' server > has been changed to 'Remove Server' which causes all the test cases failing > on my machine. > > On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> >> Attached is the patch containing fixes for the failed feature test cases. >> This patch contains- >> 1. Newly created function for traversing the browser tree. >> 2. Some synchronization issue fixes. >> 3. Modified locators. >> 4. Test cases fix for the recent commits. >> >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company feature_tests_fix_v2.patch Description: Binary data
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to customize the scrollbar styling. A new SASS > variable added - $scrollbar-base-color is added to change the color as per > theme. > Please note, customization of scrollbar works only in webkit browsers like > Chrome, Safari. Mozilla does not have any way to customize. > That looks much nicer :-). One more issue I just spotted - I'm guessing it's specific to Alertify dialogues: [image: Screenshot 2019-11-12 at 13.57.34.png] -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Customize the scrollbar stying. Added new SASS variab
Customize the scrollbar stying. Added new SASS variable to change the color as per theme. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e04d5e23b028eb2fc4cdf512170b7e172d5040 Author: Aditya Toshniwal Modified Files -- web/pgadmin/static/scss/_codemirror.overrides.scss | 26 ++ web/pgadmin/static/scss/_pgadmin.style.scss| 17 ++ .../static/scss/resources/_default.variables.scss | 4 ++-- .../scss/resources/dark/_theme.variables.scss | 3 +-- 4 files changed, 46 insertions(+), 4 deletions(-)
Re: Translators: Release next week
hi hackers here's the french translation update for upcoming version Fred - Mail original - De: "Akshay Joshi" À: "pgadmin-hackers" Envoyé: Vendredi 8 Novembre 2019 14:20:59 Objet: Translators: Release next week Hi Translators, We will have a release next week, so updates to translations before release would be helpful. The template and catalogs have been updated in git. -- Thanks & Regards Akshay Joshi Sr. Software Architect EnterpriseDB Software India Private Limited Mobile: +91 976-788-8246 messages.tar.xz Description: application/xz-compressed-tar
pgAdmin 4 commit: Update French translation.
Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=00ebc587957569ae3b6fcbded36e6d5f13b5e3c4 Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 159261 -> 176531 bytes .../translations/fr/LC_MESSAGES/messages.po| 1705 ++-- 2 files changed, 868 insertions(+), 837 deletions(-)
Re: Translators: Release next week
Thanks, patch applied. On Tue, Nov 12, 2019 at 7:56 PM wrote: > hi hackers > here's the french translation update for upcoming version > Fred > > -- > *De: *"Akshay Joshi" > *À: *"pgadmin-hackers" > *Envoyé: *Vendredi 8 Novembre 2019 14:20:59 > *Objet: *Translators: Release next week > > Hi Translators, > > We will have a release next week, so updates to translations before > release would be helpful. The template and catalogs have been updated in > git. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: pgAdmin4 v4.15 candidate builds
Hi Fahar We have fixed the showstopper issue for Docker. Updated candidate builds and sources can be found at https://developer.pgadmin.org/builds/2019-11-12-2/ Please verify it. On Tue, Nov 12, 2019 at 3:05 PM Fahar Abbas wrote: > Hi Akshay, > > Showstopper issue reported for Docker: > https://redmine.postgresql.org/issues/4924 > > On Tue, Nov 12, 2019 at 10:38 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All, >> >> pgAdmin4 v4.15 candidate builds and source can be found at >> https://developer.pgadmin.org/builds/2019-11-12-1/ >> >> *Note*:- Windows build is failed I am looking into it. >> >> Fahar, can you please verify it for release on Thursday. >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Fahar Abbas > QMG > EnterpriseDB Corporation > Phone Office: +92-51-835-8874 > Phone Direct: +92-51-8466803 > Mobile: +92-333-5409707 > Skype ID: *live:fahar.abbas* > Website: www.enterprisedb.com > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi Dave, On Tue, Nov 12, 2019 at 7:29 PM Dave Page wrote: > > > On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to customize the scrollbar styling. A new SASS >> variable added - $scrollbar-base-color is added to change the color as per >> theme. >> Please note, customization of scrollbar works only in webkit browsers >> like Chrome, Safari. Mozilla does not have any way to customize. >> > > That looks much nicer :-). > > One more issue I just spotted - I'm guessing it's specific to Alertify > dialogues: > > [image: Screenshot 2019-11-12 at 13.57.34.png] > This is your browser autofill which is changing the color and not the issue with the dialogs. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi Hackers, Attached is the patch to set browser autofill color. I've used primary light color to highlight autofill. Note that, this works only on webkit browsers. Kindly review. On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Nov 12, 2019 at 7:29 PM Dave Page wrote: > >> >> >> On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to customize the scrollbar styling. A new SASS >>> variable added - $scrollbar-base-color is added to change the color as per >>> theme. >>> Please note, customization of scrollbar works only in webkit browsers >>> like Chrome, Safari. Mozilla does not have any way to customize. >>> >> >> That looks much nicer :-). >> >> One more issue I just spotted - I'm guessing it's specific to Alertify >> dialogues: >> >> [image: Screenshot 2019-11-12 at 13.57.34.png] >> > This is your browser autofill which is changing the color and not the > issue with the dialogs. > >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4348.part5_autofill.patch Description: Binary data
pgAdmin 4 commit: Fixed feature tests related to process watcher.
Fixed feature tests related to process watcher. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b568cfce286e58433fb2e9758174ee0eb88c025 Author: Shubham Agarwal Modified Files -- web/pgadmin/feature_tests/browser_tool_bar_test.py | 9 -- .../feature_tests/pg_datatype_validation_test.py | 5 +++- .../pg_utilities_backup_restore_test.py| 4 +-- .../feature_tests/pg_utilities_maintenance_test.py | 7 +++-- web/pgadmin/feature_tests/query_tool_tests.py | 35 -- .../feature_tests/table_ddl_feature_test.py| 5 +++- web/pgadmin/feature_tests/view_data_dml_queries.py | 11 +-- .../xss_checks_panels_and_query_tool_test.py | 5 +++- .../xss_checks_pgadmin_debugger_test.py| 5 +++- web/regression/feature_utils/pgadmin_page.py | 30 +++ web/regression/feature_utils/tree_area_locators.py | 5 .../python_test_utils/test_gui_helper.py | 2 +- web/regression/python_test_utils/test_utils.py | 1 + 13 files changed, 88 insertions(+), 36 deletions(-)
Re: Fixes for pgAdmin feature tests
Thanks, patch applied. On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA patch containing some more fixes for random feature test failures. > > Thanks and regards, > Shubham Agarwal > > On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied with a minor change. Menu for 'Delete Drop' server >> has been changed to 'Remove Server' which causes all the test cases failing >> on my machine. >> >> On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Attached is the patch containing fixes for the failed feature test cases. >>> This patch contains- >>> 1. Newly created function for traversing the browser tree. >>> 2. Some synchronization issue fixes. >>> 3. Modified locators. >>> 4. Test cases fix for the recent commits. >>> >>> -- >>> Thanks & Regards, >>> Shubham Agarwal >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Set browser autofill color as primary light to highli
Set browser autofill color as primary light to highlight autofill. This works only on WebKit browsers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=42cd2a2276c1d0bea750a05b7f6f131995b61ae3 Author: Aditya Toshniwal Modified Files -- web/pgadmin/static/scss/_pgadmin.style.scss | 16 1 file changed, 16 insertions(+)
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Thanks, patch applied. On Wed, Nov 13, 2019 at 10:46 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to set browser autofill color. I've used primary > light color to highlight autofill. Note that, this works only on webkit > browsers. > Kindly review. > > On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Nov 12, 2019 at 7:29 PM Dave Page wrote: >> >>> >>> >>> On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch to customize the scrollbar styling. A new SASS variable added - $scrollbar-base-color is added to change the color as per theme. Please note, customization of scrollbar works only in webkit browsers like Chrome, Safari. Mozilla does not have any way to customize. >>> >>> That looks much nicer :-). >>> >>> One more issue I just spotted - I'm guessing it's specific to Alertify >>> dialogues: >>> >>> [image: Screenshot 2019-11-12 at 13.57.34.png] >>> >> This is your browser autofill which is changing the color and not the >> issue with the dialogs. >> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*