Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi
On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote:
>
>>
>>
>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote:
>>
>>>
>>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
Thanks, patch applied.
On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the updated patch with few more changes and corrections.
> Kindly review.
>
>>> I've committed a couple of minor tweaks - one to remove a space, e.g.
>>>
>>> gettext('A page refresh is required to apply the theme. Do you wish to
>>> refresh the page now ?'),
>>>
>>> is now:
>>>
>>> gettext('A page refresh is required to apply the theme. Do you wish to
>>> refresh the page now?'),
>>>
>>> And another change to fix the word wrapping in the README which was
>>> totally different from the rest of the file.
>>>
>>> Thanks!
>>>
>>
>> Oh, and do we need all the code in config.py? I really didn't even want a
>> config option in there to turn theming on or off (what's the point?), let
>> alone 20 new lines.
>>
> The code is added after the config_local and config_distro is loaded. So,
> user won't be able to disable it unless he directly changes the config.py.
>
That is clearly wrong and needs to be fixed. config_local and config_distro
should be able to override anything in config.py.
But... why allow the themes to be updated or disabled at all? It's not like
a non-developer can add new ones, and it's not a security issue that an
administrator might need to control. In fact, it's arguably an
accessibility feature, for those whose eyes (like mine) last the day better
with a darker theme.
Let's remove it entirely please. I don't see any good reason to have any of
that in config.py.
Thanks.
> I'll reduce the code a bit.
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi Dave,
On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote:
> Hi
>
> On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote:
>>
>>>
>>>
>>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote:
>>>
On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
> Thanks, patch applied.
>
> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch with few more changes and corrections.
>> Kindly review.
>>
>
I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to
refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to
refresh the page now?'),
And another change to fix the word wrapping in the README which was
totally different from the rest of the file.
Thanks!
>>>
>>> Oh, and do we need all the code in config.py? I really didn't even want
>>> a config option in there to turn theming on or off (what's the point?), let
>>> alone 20 new lines.
>>>
>> The code is added after the config_local and config_distro is loaded. So,
>> user won't be able to disable it unless he directly changes the config.py.
>>
>
> That is clearly wrong and needs to be fixed. config_local and
> config_distro should be able to override anything in config.py.
>
> But... why allow the themes to be updated or disabled at all? It's not
> like a non-developer can add new ones, and it's not a security issue that
> an administrator might need to control. In fact, it's arguably an
> accessibility feature, for those whose eyes (like mine) last the day better
> with a darker theme.
>
> Let's remove it entirely please. I don't see any good reason to have any
> of that in config.py.
>
Intention is not to allow disabling the themes, but it's the feature
implementation code. I'll move out the code.
>
> Thanks.
>
>
>> I'll reduce the code a bit.
>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi Hackers,
Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components
more clearly. Few of the controls were missing the privileges of dark
theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and
moved to miscellaneous under a new package - Themes. Thank you @Ashesh Vashi
for inputs on that.
Kindly review.
On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote:
>
>> Hi
>>
>> On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote:
>>>
On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote:
>
> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the updated patch with few more changes and corrections.
>>> Kindly review.
>>>
>>
> I've committed a couple of minor tweaks - one to remove a space, e.g.
>
> gettext('A page refresh is required to apply the theme. Do you wish to
> refresh the page now ?'),
>
> is now:
>
> gettext('A page refresh is required to apply the theme. Do you wish to
> refresh the page now?'),
>
> And another change to fix the word wrapping in the README which was
> totally different from the rest of the file.
>
> Thanks!
>
Oh, and do we need all the code in config.py? I really didn't even want
a config option in there to turn theming on or off (what's the point?), let
alone 20 new lines.
>>> The code is added after the config_local and config_distro is loaded.
>>> So, user won't be able to disable it unless he directly changes the
>>> config.py.
>>>
>>
>> That is clearly wrong and needs to be fixed. config_local and
>> config_distro should be able to override anything in config.py.
>>
>> But... why allow the themes to be updated or disabled at all? It's not
>> like a non-developer can add new ones, and it's not a security issue that
>> an administrator might need to control. In fact, it's arguably an
>> accessibility feature, for those whose eyes (like mine) last the day better
>> with a darker theme.
>>
>> Let's remove it entirely please. I don't see any good reason to have any
>> of that in config.py.
>>
> Intention is not to allow disabling the themes, but it's the feature
> implementation code. I'll move out the code.
>
>>
>> Thanks.
>>
>>
>>> I'll reduce the code a bit.
>>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
RM4348.part2.patch
Description: Binary data
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi,
Kindly hold on with the patch. Few more changes required per review by @Ashesh
Vashi .
On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the patch for further improvements in the Dark theme colors.
> Gray shades and other colors are changed to identify different components
> more clearly. Few of the controls were missing the privileges of dark
> theme, fixed that.
> Few dashboard graph related changes.
> As suggested, theme related code changes is removed from config.py and
> moved to miscellaneous under a new package - Themes. Thank you @Ashesh
> Vashi for inputs on that.
>
> Kindly review.
>
> On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote:
>>
>>> Hi
>>>
>>> On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Dave,
On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote:
>
>
> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote:
>
>>
>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Hackers,
Attached is the updated patch with few more changes and corrections.
Kindly review.
>>>
>> I've committed a couple of minor tweaks - one to remove a space, e.g.
>>
>> gettext('A page refresh is required to apply the theme. Do you wish to
>> refresh the page now ?'),
>>
>> is now:
>>
>> gettext('A page refresh is required to apply the theme. Do you wish to
>> refresh the page now?'),
>>
>> And another change to fix the word wrapping in the README which was
>> totally different from the rest of the file.
>>
>> Thanks!
>>
>
> Oh, and do we need all the code in config.py? I really didn't even
> want a config option in there to turn theming on or off (what's the
> point?), let alone 20 new lines.
>
The code is added after the config_local and config_distro is loaded.
So, user won't be able to disable it unless he directly changes the
config.py.
>>>
>>> That is clearly wrong and needs to be fixed. config_local and
>>> config_distro should be able to override anything in config.py.
>>>
>>> But... why allow the themes to be updated or disabled at all? It's not
>>> like a non-developer can add new ones, and it's not a security issue that
>>> an administrator might need to control. In fact, it's arguably an
>>> accessibility feature, for those whose eyes (like mine) last the day better
>>> with a darker theme.
>>>
>>> Let's remove it entirely please. I don't see any good reason to have any
>>> of that in config.py.
>>>
>> Intention is not to allow disabling the themes, but it's the feature
>> implementation code. I'll move out the code.
>>
>>>
>>> Thanks.
>>>
>>>
I'll reduce the code a bit.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
pgAdmin 4 commit: Fixed API and RESQL test cases for Compound Trigger a
Fixed API and RESQL test cases for Compound Trigger after the recent changes in EPAS 12. EPAS 12 Changes: Fix server crash when the compound trigger has both row and statement-level triggers having WHEN clause containing NEW/OLD vars. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7282e15ee27b970d2d20f679ab4f06a9a98ec312 Modified Files -- .../tests/ppas/12_plus/alter_event_comment_code.sql | 6 -- .../tests/ppas/12_plus/create_for_insert_with_when.sql | 6 -- .../tables/compound_triggers/tests/ppas/12_plus/test.json| 4 ++-- .../tables/compound_triggers/tests/test_compound_triggers_add.py | 9 +++-- 4 files changed, 5 insertions(+), 20 deletions(-)
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi Hackers,
Attached is the updated patch.
Kindly review.
On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
> Kindly hold on with the patch. Few more changes required per review by @Ashesh
> Vashi .
>
> On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for further improvements in the Dark theme colors.
>> Gray shades and other colors are changed to identify different components
>> more clearly. Few of the controls were missing the privileges of dark
>> theme, fixed that.
>> Few dashboard graph related changes.
>> As suggested, theme related code changes is removed from config.py and
>> moved to miscellaneous under a new package - Themes. Thank you @Ashesh
>> Vashi for inputs on that.
>>
>> Kindly review.
>>
>> On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote:
>>>
Hi
On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote:
>
>>
>>
>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote:
>>
>>>
>>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
Thanks, patch applied.
On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the updated patch with few more changes and
> corrections.
> Kindly review.
>
>>> I've committed a couple of minor tweaks - one to remove a space, e.g.
>>>
>>> gettext('A page refresh is required to apply the theme. Do you wish to
>>> refresh the page now ?'),
>>>
>>> is now:
>>>
>>> gettext('A page refresh is required to apply the theme. Do you wish to
>>> refresh the page now?'),
>>>
>>> And another change to fix the word wrapping in the README which was
>>> totally different from the rest of the file.
>>>
>>> Thanks!
>>>
>>
>> Oh, and do we need all the code in config.py? I really didn't even
>> want a config option in there to turn theming on or off (what's the
>> point?), let alone 20 new lines.
>>
> The code is added after the config_local and config_distro is loaded.
> So, user won't be able to disable it unless he directly changes the
> config.py.
>
That is clearly wrong and needs to be fixed. config_local and
config_distro should be able to override anything in config.py.
But... why allow the themes to be updated or disabled at all? It's not
like a non-developer can add new ones, and it's not a security issue that
an administrator might need to control. In fact, it's arguably an
accessibility feature, for those whose eyes (like mine) last the day better
with a darker theme.
Let's remove it entirely please. I don't see any good reason to have
any of that in config.py.
>>> Intention is not to allow disabling the themes, but it's the feature
>>> implementation code. I'll move out the code.
>>>
Thanks.
> I'll reduce the code a bit.
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
RM4348.part2_v2.patch
Description: Binary data
pgAdmin 4 commit: 1) Further styling tweaks for Dark Theme.
1) Further styling tweaks for Dark Theme. 2) Theme related code changes are removed from config.py and moved to miscellaneous under a new package - "themes". Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c1c682402aca0cbd8fc5aa6c70b0221fb7ff93a6 Author: Aditya Toshniwal Modified Files -- .gitignore | 2 +- web/config.py | 19 --- web/pgadmin.themes.json| 7 +++ web/pgadmin/__init__.py| 16 ++ web/pgadmin/dashboard/static/js/charting.js| 4 ++ web/pgadmin/dashboard/static/scss/_dashboard.scss | 19 +-- web/pgadmin/misc/__init__.py | 9 ++-- web/pgadmin/misc/themes/__init__.py| 49 ++ web/pgadmin/static/js/backform.pgadmin.js | 2 +- web/pgadmin/static/js/utils.js | 1 + web/pgadmin/static/scss/_backgrid.overrides.scss | 19 +-- web/pgadmin/static/scss/_pgadmin.style.scss| 6 +-- web/pgadmin/static/scss/_webcabin.pgadmin.scss | 6 +-- .../static/scss/resources/_default.variables.scss | 21 ++-- .../scss/resources/_theme.variables.scss.sample| 8 +++ .../scss/resources/dark/_theme.variables.scss | 58 -- .../tools/datagrid/templates/datagrid/index.html | 2 +- .../tools/sqleditor/static/css/sqleditor.css | 1 + .../tools/sqleditor/static/scss/_sqleditor.scss| 27 ++ web/webpack.config.js | 2 +- 20 files changed, 171 insertions(+), 107 deletions(-)
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Thanks, patch applied.
As per discussion with Aditya, we have removed customized scroll bars for
the time being as they are not clearly visible with some of the components.
On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the updated patch.
> Kindly review.
>
> On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Kindly hold on with the patch. Few more changes required per review by
>> @Ashesh
>> Vashi .
>>
>> On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch for further improvements in the Dark theme colors.
>>> Gray shades and other colors are changed to identify different
>>> components more clearly. Few of the controls were missing the privileges of
>>> dark theme, fixed that.
>>> Few dashboard graph related changes.
>>> As suggested, theme related code changes is removed from config.py and
>>> moved to miscellaneous under a new package - Themes. Thank you @Ashesh
>>> Vashi for inputs on that.
>>>
>>> Kindly review.
>>>
>>> On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Dave,
On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote:
> Hi
>
> On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote:
>>
>>>
>>>
>>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote:
>>>
On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
> Thanks, patch applied.
>
> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch with few more changes and
>> corrections.
>> Kindly review.
>>
>
I've committed a couple of minor tweaks - one to remove a space,
e.g.
gettext('A page refresh is required to apply the theme. Do you wish to
refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to
refresh the page now?'),
And another change to fix the word wrapping in the README which was
totally different from the rest of the file.
Thanks!
>>>
>>> Oh, and do we need all the code in config.py? I really didn't even
>>> want a config option in there to turn theming on or off (what's the
>>> point?), let alone 20 new lines.
>>>
>> The code is added after the config_local and config_distro is loaded.
>> So, user won't be able to disable it unless he directly changes the
>> config.py.
>>
>
> That is clearly wrong and needs to be fixed. config_local and
> config_distro should be able to override anything in config.py.
>
> But... why allow the themes to be updated or disabled at all? It's not
> like a non-developer can add new ones, and it's not a security issue that
> an administrator might need to control. In fact, it's arguably an
> accessibility feature, for those whose eyes (like mine) last the day
> better
> with a darker theme.
>
> Let's remove it entirely please. I don't see any good reason to have
> any of that in config.py.
>
Intention is not to allow disabling the themes, but it's the feature
implementation code. I'll move out the code.
>
> Thanks.
>
>
>> I'll reduce the code a bit.
>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr.
pgAdmin 4 commit: Ensure compatibility with older versions of Sphinx.
Ensure compatibility with older versions of Sphinx. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=314990447cb6c8765093b05fd17914a2bc14b4fb Modified Files -- docs/en_US/theme/pgadmin4/layout.html | 206 +- 1 file changed, 5 insertions(+), 201 deletions(-)
pgAdmin 4 commit: Support older versions of Sphinx
Support older versions of Sphinx Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=664d9a214473b0bdeb5764f50bcdadae08d1fb12 Modified Files -- docs/en_US/theme/pgadmin4/layout.html | 37 ++- 1 file changed, 19 insertions(+), 18 deletions(-)
pgAdmin 4 commit: Remove extra whitespace.
Remove extra whitespace. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b00ad03360d978596f6048aaccc5c856074e78b Modified Files -- docs/en_US/theme/pgadmin4/layout.html | 5 - 1 file changed, 5 deletions(-)
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi
That's looking a lot better. I see a couple of issues (screenshots
attached):
- The combo box on the query tool toolbar isn't dark.
- The tagline on the dashboard logo isn't readable.
A couple of other thoughts:
- The guide lines on the graphs are still too bright. Let's make them the
same colour as the graph boarders please.
- The header bar foreground colour and the dividing white line below it
seem quite harsh. Are they pure white? They should be softened a little bit.
Thanks!
On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi
wrote:
> Thanks, patch applied.
>
> As per discussion with Aditya, we have removed customized scroll bars for
> the time being as they are not clearly visible with some of the components.
>
> On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch.
>> Kindly review.
>>
>> On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Kindly hold on with the patch. Few more changes required per review by
>>> @Ashesh
>>> Vashi .
>>>
>>> On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Hackers,
Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different
components more clearly. Few of the controls were missing the privileges of
dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and
moved to miscellaneous under a new package - Themes. Thank you @Ashesh
Vashi for inputs on that.
Kindly review.
On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote:
>
>> Hi
>>
>> On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote:
>>>
On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote:
>
> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the updated patch with few more changes and
>>> corrections.
>>> Kindly review.
>>>
>>
> I've committed a couple of minor tweaks - one to remove a space,
> e.g.
>
> gettext('A page refresh is required to apply the theme. Do you wish
> to refresh the page now ?'),
>
> is now:
>
> gettext('A page refresh is required to apply the theme. Do you wish
> to refresh the page now?'),
>
> And another change to fix the word wrapping in the README which
> was totally different from the rest of the file.
>
> Thanks!
>
Oh, and do we need all the code in config.py? I really didn't even
want a config option in there to turn theming on or off (what's the
point?), let alone 20 new lines.
>>> The code is added after the config_local and config_distro is
>>> loaded. So, user won't be able to disable it unless he directly changes
>>> the
>>> config.py.
>>>
>>
>> That is clearly wrong and needs to be fixed. config_local and
>> config_distro should be able to override anything in config.py.
>>
>> But... why allow the themes to be updated or disabled at all? It's
>> not like a non-developer can add new ones, and it's not a security issue
>> that an administrator might need to control. In fact, it's arguably an
>> accessibility feature, for those whose eyes (like mine) last the day
>> better
>> with a darker theme.
>>
>> Let's remove it entirely please. I don't see any good reason to have
>> any of that in config.py.
>>
> Intention is not to allow disabling the themes, but it's the feature
> implementation code. I'll move out the code.
>
>>
>> Thanks.
>>
>>
>>> I'll reduce the code a bit.
>>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Dave Page
>> B
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi Dave,
On Mon, Nov 11, 2019, 20:33 Dave Page wrote:
> Hi
>
> That's looking a lot better. I see a couple of issues (screenshots
> attached):
>
> - The combo box on the query tool toolbar isn't dark.
>
I'm not sure why you are not able to see it but I've changed it. Try a
python restart.
> - The tagline on the dashboard logo isn't readable.
>
Yes because that's an SVG image. We may need to make it completely from
HTML.
>
> A couple of other thoughts:
>
> - The guide lines on the graphs are still too bright. Let's make them the
> same colour as the graph boarders please.
>
There is technical limitation here. To change those grid lines based on
theme we need to import variables in JS. I didn't find a way to dynamically
load SASS variables based on theme.
So I chose color which would work for both dark and black backgrounds and
is hard coded in JS.
>
> - The header bar foreground colour and the dividing white line below it
> seem quite harsh. Are they pure white? They should be softened a little bit.
>
I'll check the color, but AFAIR it's not pure white.
>
> Thanks!
>
> On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> As per discussion with Aditya, we have removed customized scroll bars for
>> the time being as they are not clearly visible with some of the components.
>>
>> On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the updated patch.
>>> Kindly review.
>>>
>>> On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi,
Kindly hold on with the patch. Few more changes required per review by
@Ashesh
Vashi .
On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the patch for further improvements in the Dark theme
> colors.
> Gray shades and other colors are changed to identify different
> components more clearly. Few of the controls were missing the privileges
> of
> dark theme, fixed that.
> Few dashboard graph related changes.
> As suggested, theme related code changes is removed from config.py and
> moved to miscellaneous under a new package - Themes. Thank you @Ashesh
> Vashi for inputs on that.
>
> Kindly review.
>
> On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote:
>>
>>> Hi
>>>
>>> On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Dave,
On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote:
>
>
> On Thu, Nov 7, 2019 at 2:18 PM Dave Page
> wrote:
>
>>
>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Hackers,
Attached is the updated patch with few more changes and
corrections.
Kindly review.
>>>
>> I've committed a couple of minor tweaks - one to remove a space,
>> e.g.
>>
>> gettext('A page refresh is required to apply the theme. Do you wish
>> to refresh the page now ?'),
>>
>> is now:
>>
>> gettext('A page refresh is required to apply the theme. Do you wish
>> to refresh the page now?'),
>>
>> And another change to fix the word wrapping in the README which
>> was totally different from the rest of the file.
>>
>> Thanks!
>>
>
> Oh, and do we need all the code in config.py? I really didn't even
> want a config option in there to turn theming on or off (what's the
> point?), let alone 20 new lines.
>
The code is added after the config_local and config_distro is
loaded. So, user won't be able to disable it unless he directly
changes the
config.py.
>>>
>>> That is clearly wrong and needs to be fixed. config_local and
>>> config_distro should be able to override anything in config.py.
>>>
>>> But... why allow the themes to be updated or disabled at all? It's
>>> not like a non-developer can add new ones, and it's not a security issue
>>> that an administrator might need to control. In fact, it's arguably an
>>> accessibility feature, for those whose eyes (like mine) last the day
>>> better
>>> with a darker theme.
>>>
>>> Let's remove it entirely
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Hi
On Mon, Nov 11, 2019 at 3:11 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Mon, Nov 11, 2019, 20:33 Dave Page wrote:
>
>> Hi
>>
>> That's looking a lot better. I see a couple of issues (screenshots
>> attached):
>>
>> - The combo box on the query tool toolbar isn't dark.
>>
> I'm not sure why you are not able to see it but I've changed it. Try a
> python restart.
>
I've done a make clean/make bundle, restarted Python, and done a hard
reload in the browser to no joy. FYI, I'm running in Chrome 78.0.3904.70 on
macOS.
> - The tagline on the dashboard logo isn't readable.
>>
> Yes because that's an SVG image. We may need to make it completely from
> HTML.
>
Can we have an alternate image? Maybe if it's served through a flask route
and we look for /logo.png?t=dark or something like that to select the image
version?
>
>> A couple of other thoughts:
>>
>> - The guide lines on the graphs are still too bright. Let's make them the
>> same colour as the graph boarders please.
>>
> There is technical limitation here. To change those grid lines based on
> theme we need to import variables in JS. I didn't find a way to dynamically
> load SASS variables based on theme.
> So I chose color which would work for both dark and black backgrounds and
> is hard coded in JS.
>
Urgh, OK. We'll need to think about that then.
>
>> - The header bar foreground colour and the dividing white line below it
>> seem quite harsh. Are they pure white? They should be softened a little bit.
>>
> I'll check the color, but AFAIR it's not pure white.
>
OK, thanks!
>
>> Thanks!
>>
>> On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> As per discussion with Aditya, we have removed customized scroll bars
>>> for the time being as they are not clearly visible with some of the
>>> components.
>>>
>>> On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Hackers,
Attached is the updated patch.
Kindly review.
On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
> Kindly hold on with the patch. Few more changes required per review by
> @Ashesh
> Vashi .
>
> On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for further improvements in the Dark theme
>> colors.
>> Gray shades and other colors are changed to identify different
>> components more clearly. Few of the controls were missing the privileges
>> of
>> dark theme, fixed that.
>> Few dashboard graph related changes.
>> As suggested, theme related code changes is removed from config.py
>> and moved to miscellaneous under a new package - Themes. Thank you
>> @Ashesh
>> Vashi for inputs on that.
>>
>> Kindly review.
>>
>> On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote:
>>>
Hi
On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Thu, Nov 7, 2019 at 7:56 PM Dave Page
> wrote:
>
>>
>>
>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page
>> wrote:
>>
>>>
>>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
Thanks, patch applied.
On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the updated patch with few more changes and
> corrections.
> Kindly review.
>
>>> I've committed a couple of minor tweaks - one to remove a space,
>>> e.g.
>>>
>>> gettext('A page refresh is required to apply the theme. Do you wish
>>> to refresh the page now ?'),
>>>
>>> is now:
>>>
>>> gettext('A page refresh is required to apply the theme. Do you wish
>>> to refresh the page now?'),
>>>
>>> And another change to fix the word wrapping in the README which
>>> was totally different from the rest of the file.
>>>
>>> Thanks!
>>>
>>
>> Oh, and do we need all the code in config.py? I really didn't
>> even want a config option in there to turn theming on or off (what's
>> the
>> point?), let alone 20 new lines.
>>
> The code is added after the config_local and config_distro is
> loa
pgAdmin 4 commit: Update version for release.
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a03c42bd4071eb8f700ade52b841396ba0f6585 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
pgAdmin4 v4.15 candidate builds
Hi All, pgAdmin4 v4.15 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-11-12-1/ *Note*:- Windows build is failed I am looking into it. Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
