[RM#4906][pgAdmin4] Fix context menu keyboard shortcut issue with Firefox
Hello, PFA patch to fix the issue where keyboard shortcut for context menu is not working when using Firefox on CestOS7. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4906.diff Description: Binary data
pgAdmin 4 commit: 1) Added support for custom theme creation and select
1) Added support for custom theme creation and selection. Fixes #4348. 2) Added Dark(Beta) UI Theme option. Fixes #3741. 3) Fix an issue where a black arrow-kind image is displaying at the background of browser tree images. Fixes #4171 Changes include: 1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown. It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes. On saving, a dialog appears to ask for refresh. 2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after the bundle. 3) Correction of SASS variables at few places and few other CSS corrections. 4) Added iconfont-webpack-plugin, which will convert all the SVG files(monochrome) used as icons for buttons to font icons. This will allow us to change the color of the icon by using CSS color property. 5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of theme CSS files as CSS in .css files will not change with the change of SASS variables. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8180403f976ee0d759631e7539205548dbdd2d6c Author: Aditya Toshniwal Modified Files -- .gitignore | 1 + README | 13 + docs/en_US/images/preferences_misc_themes.png | Bin 0 -> 103490 bytes .../images/preferences_misc_user_language.png | Bin 50432 -> 74731 bytes docs/en_US/preferences.rst | 8 + docs/en_US/release_notes_4_15.rst | 5 +- web/config.py | 21 ++ web/package.json | 4 + web/pgadmin/__init__.py| 20 +- .../server_groups/servers/static/css/servers.css | 11 +- .../servers/static/scss/_servers.scss | 9 + web/pgadmin/browser/static/css/browser.css | 5 + web/pgadmin/browser/static/img/drop_cascade.svg| 20 ++ web/pgadmin/browser/static/js/collection.js| 2 +- web/pgadmin/browser/static/js/toolbar.js | 6 +- web/pgadmin/browser/static/scss/_browser.scss | 3 +- web/pgadmin/dashboard/static/css/dashboard.css | 17 -- web/pgadmin/dashboard/static/scss/_dashboard.scss | 22 +- web/pgadmin/misc/__init__.py | 36 ++- .../misc/bgprocess/static/scss/_bgprocess.scss | 2 +- .../misc/file_manager/static/css/file_manager.css | 6 - .../file_manager/static/scss/_file_manager.scss| 50 +--- web/pgadmin/misc/static/explain/js/explain.js | 2 +- web/pgadmin/misc/static/explain/scss/_explain.scss | 29 +- web/pgadmin/preferences/static/js/preferences.js | 31 ++- web/pgadmin/static/img/drop_cascade.svg| 28 -- web/pgadmin/static/img/load-node.gif | Bin 1728 -> 0 bytes web/pgadmin/static/img/loader-small.svg| 18 ++ web/pgadmin/static/js/backform.pgadmin.js | 13 + web/pgadmin/static/js/sqleditor_utils.js | 10 +- web/pgadmin/static/scss/_aci_tree.overrides.scss | 126 ++--- web/pgadmin/static/scss/_alert.scss| 2 +- web/pgadmin/static/scss/_alertify.overrides.scss | 9 + web/pgadmin/static/scss/_backgrid.overrides.scss | 14 +- web/pgadmin/static/scss/_bootstrap.overrides.scss | 12 +- web/pgadmin/static/scss/_codemirror.overrides.scss | 43 ++- web/pgadmin/static/scss/_pgadmin.style.scss| 61 ++-- web/pgadmin/static/scss/_select2.overrides.scss| 29 +- web/pgadmin/static/scss/_webcabin.pgadmin.scss | 28 +- web/pgadmin/static/scss/pgadmin.scss | 3 - .../static/scss/resources/_default.style.scss | 18 +- .../static/scss/resources/_default.variables.scss | 195 +++-- .../static/scss/resources/_pgadmin.variables.scss | 0 .../scss/resources/_theme.variables.scss.sample| 74 + web/pgadmin/static/scss/resources/_utils.scss | 9 - .../scss/resources/dark/_theme.variables.scss | 73 + .../static/scss/resources/dark/dark_preview.png| Bin 0 -> 55602 bytes .../static/scss/resources/pgadmin.resources.scss | 2 - .../static/scss/resources/standard_preview.png | Bin 0 -> 33349 bytes web/pgadmin/templates/base.html| 3 +- .../tools/datagrid/templates/datagrid/index.html | 104 +++ .../tools/sqleditor/static/css/sqleditor.css | 73 + web/pgadmin/tools/sqleditor/static/img/commit.svg | 23 +- web/pgadmin/tools/sqleditor/static/img/connect.svg | 24 +- .../tools/sqleditor/static/img/disconnect.svg | 25 +- .../tools/sqleditor/static/img/rollback.svg| 23 +- .../sqleditor/static/img/save_data_changes.svg | 36 ++- .../tools/sqleditor/static/img/view_data.svg | 35 ++- .../tools/sqleditor/static/
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Thanks, patch applied. On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch with few more changes and corrections. > Kindly review. > > On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to introduce theme options in pgAdmin. >> Changes include: >> 1) New theme option in preferences - Miscellaneous -> Themes. You can >> select the theme from the dropdown. It also has a preview of the theme just >> below the dropdown. Note that, a page refresh is needed to apply changes. >> On saving, a dialog appears to ask for refresh. >> 2) You can create your own theme and submit to hackers. README is updated >> to help you create a theme. Theme will be available only after bundle. >> 3) Correction of SASS variables at few places and few other CSS >> corrections. >> 4) Added iconfont-webpack-plugin, which will convert all the svg >> files(monochrome) used as icons for buttons to font icons. This will allow >> us to change the color of icon by using CSS color property. >> 5) All the .css files will bundle into a separate file now- >> pgadmin.style.css. This will help reduce the size of theme css files as CSS >> in .css files will not change with the change of SASS variables. >> 6) "Dark Beta" theme added as a new theme option. >> >> How theme is built ? >> Webpack config is changed to achieve it. On running yarn run bundle, code >> will read all the directories in web/pgadmin/static/scss/resources which >> will be considered as theme dirs, build a separate css for every theme and >> then create a file named pgadmin.themes.json which will have all the >> information required. >> >> The patch also fixes RM4173, where there some issue with arrow icons in >> browser tree. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Correct the issue number for the previous commit. Fix
Correct the issue number for the previous commit. Fixes #4173 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f98136cd99b5372e2382515df08061645d5f4661 Modified Files -- docs/en_US/release_notes_4_15.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Quick tweak to increase the contrast of dark mode a l
Quick tweak to increase the contrast of dark mode a little prior to a real review of the colours tomorrow. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ebf7948c6e99dfa30e2d602ae687c8089e6f236 Modified Files -- web/pgadmin/static/scss/resources/dark/_theme.variables.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Fix wrapping.
Fix wrapping. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3c3e802ca1f628d0af7a141092281146d0d7565 Modified Files -- README | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-)
pgAdmin 4 commit: Remove extra space.
Remove extra space. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9961a6c1011ec8d1b9cbd077bd096425959920ed Modified Files -- web/pgadmin/preferences/static/js/preferences.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi
wrote:
> Thanks, patch applied.
>
> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch with few more changes and corrections.
>> Kindly review.
>>
>
I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to
refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to
refresh the page now?'),
And another change to fix the word wrapping in the README which was totally
different from the rest of the file.
Thanks!
>> On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to introduce theme options in pgAdmin.
>>> Changes include:
>>> 1) New theme option in preferences - Miscellaneous -> Themes. You can
>>> select the theme from the dropdown. It also has a preview of the theme just
>>> below the dropdown. Note that, a page refresh is needed to apply changes.
>>> On saving, a dialog appears to ask for refresh.
>>> 2) You can create your own theme and submit to hackers. README is
>>> updated to help you create a theme. Theme will be available only after
>>> bundle.
>>> 3) Correction of SASS variables at few places and few other CSS
>>> corrections.
>>> 4) Added iconfont-webpack-plugin, which will convert all the svg
>>> files(monochrome) used as icons for buttons to font icons. This will allow
>>> us to change the color of icon by using CSS color property.
>>> 5) All the .css files will bundle into a separate file now-
>>> pgadmin.style.css. This will help reduce the size of theme css files as CSS
>>> in .css files will not change with the change of SASS variables.
>>> 6) "Dark Beta" theme added as a new theme option.
>>>
>>> How theme is built ?
>>> Webpack config is changed to achieve it. On running yarn run bundle,
>>> code will read all the directories in web/pgadmin/static/scss/resources
>>> which will be considered as theme dirs, build a separate css for every
>>> theme and then create a file named pgadmin.themes.json which will have all
>>> the information required.
>>>
>>> The patch also fixes RM4173, where there some issue with arrow icons in
>>> browser tree.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgAdmin 4 commit: Tone down the primary FG colour in dark mode a touch.
Tone down the primary FG colour in dark mode a touch. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c192393b051fe2959a25896809b636841e66a3e Modified Files -- web/pgadmin/static/scss/resources/dark/_theme.variables.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote:
>
> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi
> wrote:
>
>> Thanks, patch applied.
>>
>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the updated patch with few more changes and corrections.
>>> Kindly review.
>>>
>>
> I've committed a couple of minor tweaks - one to remove a space, e.g.
>
> gettext('A page refresh is required to apply the theme. Do you wish to
> refresh the page now ?'),
>
> is now:
>
> gettext('A page refresh is required to apply the theme. Do you wish to
> refresh the page now?'),
>
> And another change to fix the word wrapping in the README which was
> totally different from the rest of the file.
>
> Thanks!
>
Oh, and do we need all the code in config.py? I really didn't even want a
config option in there to turn theming on or off (what's the point?), let
alone 20 new lines.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add navigation links to the bottom of the docs, and e
Add navigation links to the bottom of the docs, and embiggen the font a touch. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=475a717cd664eed8bc9fc0f196e86a6b5b616407 Modified Files -- docs/en_US/theme/pgadmin4/layout.html | 231 - docs/en_US/theme/pgadmin4/static/style.css | 20 ++- 2 files changed, 244 insertions(+), 7 deletions(-)
