pgAdmin 4 commit: popen() function strips the quotes from the arguments

2019-10-10 Thread Akshay Joshi 
popen() function strips the quotes from the arguments, so backup fails
for the schema name that needs quoting.

Code is changed to add escapers.

Fixes #4590

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d056a94f0c30b44c4bab680a63f318de3226e958
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_14.rst  |  1 +
web/pgadmin/misc/bgprocess/__init__.py | 15 ++
web/pgadmin/misc/bgprocess/process_executor.py | 32 ++
.../setup/tests/test_export_import_servers.py  |  4 +--
web/pgadmin/tools/backup/__init__.py   | 15 +++---
5 files changed, 55 insertions(+), 12 deletions(-)

Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting

2019-10-10 Thread Akshay Joshi 
Thanks, patch applied.

On Wed, Oct 9, 2019 at 2:21 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the updated patch. Tested on MacOS, Windows 7, Ubuntu 16 and
> works fine.
> Kindly review.
>
> On Wed, Oct 9, 2019 at 1:48 PM Akshay Joshi 
> wrote:
>
>> Hi Aditya
>>
>> I have tried your patch on MAC. Backup job is completed successfully but
>> got the following message:
>> pg_dump: last built-in OID is 16383
>> pg_dump: no matching schemas were found
>>
>> Please verify it once again and send the modified patch.
>>
>> On Tue, Oct 8, 2019 at 5:46 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Turned out to be an issue only on Mac. Backup works fine for other OS.
>>> Attached is the patch to fix the issue on Mac. Code is changed to add
>>> extra pairs of quotes wherever required on MacOS.
>>>
>>> Kindly review.
>>>
>>> On Thu, Oct 3, 2019 at 3:53 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch to fix the schema backup with names that requires
 double quotes.
 Command line has special meaning for double quotes and so the command
 is run without the double quotes if applied on objects. Code is changed to
 add extra pairs of quotes to save our object quotes.

 Also fixed a test case which was failing if certain paths had spaces in
 between.

 Kindly review.

 --
 Thanks and Regards,
 Aditya Toshniwal
 Sr. Software Engineer | EnterpriseDB India | Pune
 "Don't Complain about Heat, Plant a TREE"

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fix issue where VALID foreign keys show as NOT VALID

2019-10-10 Thread Akshay Joshi 
Fix issue where VALID foreign keys show as NOT VALID in the SQL tab for tables.

Corrected the condition for valid foreign key.

Fixes #4791

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3e11bd3903fb4ad05b583040519a207c0abadb1

Modified Files
--
docs/en_US/release_notes_4_14.rst   | 1 +
.../schemas/tables/templates/tables/sql/macros/constraints.macro| 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)