pgAdmin 4 commit: Don't use Python to get the app details from the Make
Don't use Python to get the app details from the Makefile. Fixes #4757 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1b0139c9bba85cd88530a7522aeef226b3b0da0 Modified Files -- Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
Hi On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow pgAdmin to work behind proxy with its in > built server. I have used werkzeug fixer - > https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix > Does this work with both X-Scheme and X-Forwarded-Proto headers as discussed? I assume (as you haven't removed it) that it works in conjunction with the existing reverse proxy code? Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
Hi, On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: > Hi > > On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to allow pgAdmin to work behind proxy with its in >> built server. I have used werkzeug fixer - >> https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix >> > > Does this work with both X-Scheme and X-Forwarded-Proto headers as > discussed? > The proxy fix work for all standard X-Forwarded-* headers. X-Scheme is not used anywhere, X-Forwarded-Proto is more robust. > > I assume (as you haven't removed it) that it works in conjunction with the > existing reverse proxy code? > Yes it should. > > Thanks! > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: > >> Hi >> >> On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to allow pgAdmin to work behind proxy with its in >>> built server. I have used werkzeug fixer - >>> https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix >>> >> >> Does this work with both X-Scheme and X-Forwarded-Proto headers as >> discussed? >> > The proxy fix work for all standard X-Forwarded-* headers. X-Scheme is not > used anywhere, X-Forwarded-Proto is more robust. > Right, but our existing code uses X-Scheme (as per old advice since removed from the Flask website - see RM3149), and users have deployments that will be setup that way. We need to fall back to X-Scheme if it is present but X-Forwarded-Proto is not, to avoid breaking their installations. > >> I assume (as you haven't removed it) that it works in conjunction with >> the existing reverse proxy code? >> > Yes it should. > Cool :-) > >> Thanks! >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: > > > On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch to allow pgAdmin to work behind proxy with its in built server. I have used werkzeug fixer - https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix >>> >>> Does this work with both X-Scheme and X-Forwarded-Proto headers as >>> discussed? >>> >> The proxy fix work for all standard X-Forwarded-* headers. X-Scheme is >> not used anywhere, X-Forwarded-Proto is more robust. >> > > Right, but our existing code uses X-Scheme (as per old advice since > removed from the Flask website - see RM3149), and users have deployments > that will be setup that way. We need to fall back to X-Scheme if it is > present but X-Forwarded-Proto is not, to avoid breaking their installations. > OK. I'll make the required changes and send you an updated patch. > > >> >>> I assume (as you haven't removed it) that it works in conjunction with >>> the existing reverse proxy code? >>> >> Yes it should. >> > > Cool :-) > > >> >>> Thanks! >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
Hi, We need to make it configurable, we don't require middleware when we are running in Desktop mode. On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: > > > On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch to allow pgAdmin to work behind proxy with its in built server. I have used werkzeug fixer - https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix >>> >>> Does this work with both X-Scheme and X-Forwarded-Proto headers as >>> discussed? >>> >> The proxy fix work for all standard X-Forwarded-* headers. X-Scheme is >> not used anywhere, X-Forwarded-Proto is more robust. >> > > Right, but our existing code uses X-Scheme (as per old advice since > removed from the Flask website - see RM3149), and users have deployments > that will be setup that way. We need to fall back to X-Scheme if it is > present but X-Forwarded-Proto is not, to avoid breaking their installations. > > >> >>> I assume (as you haven't removed it) that it works in conjunction with >>> the existing reverse proxy code? >>> >> Yes it should. >> > > Cool :-) > > >> >>> Thanks! >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
Sure, but is it going to make any real difference? I'd rather have it "just work" if possible. This isn't like compression which we expect to use noticable CPU cycles. On Thu, Sep 19, 2019 at 11:39 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > We need to make it configurable, we don't require middleware when we are > running in Desktop mode. > > On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: > >> >> >> On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: >>> Hi On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow pgAdmin to work behind proxy with its > in built server. I have used werkzeug fixer - > https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix > Does this work with both X-Scheme and X-Forwarded-Proto headers as discussed? >>> The proxy fix work for all standard X-Forwarded-* headers. X-Scheme is >>> not used anywhere, X-Forwarded-Proto is more robust. >>> >> >> Right, but our existing code uses X-Scheme (as per old advice since >> removed from the Flask website - see RM3149), and users have deployments >> that will be setup that way. We need to fall back to X-Scheme if it is >> present but X-Forwarded-Proto is not, to avoid breaking their installations. >> >> >>> I assume (as you haven't removed it) that it works in conjunction with the existing reverse proxy code? >>> Yes it should. >>> >> >> Cool :-) >> >> >>> Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
It is small improvement we can do to avoid overhead of checking headers in each HTTP requests for proxies. On Thu, Sep 19, 2019 at 4:12 PM Dave Page wrote: > Sure, but is it going to make any real difference? I'd rather have it > "just work" if possible. > > This isn't like compression which we expect to use noticable CPU cycles. > > On Thu, Sep 19, 2019 at 11:39 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> We need to make it configurable, we don't require middleware when we are >> running in Desktop mode. >> >> On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: >> >>> >>> >>> On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi, On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: > Hi > > On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to allow pgAdmin to work behind proxy with its >> in built server. I have used werkzeug fixer - >> https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix >> > > Does this work with both X-Scheme and X-Forwarded-Proto headers as > discussed? > The proxy fix work for all standard X-Forwarded-* headers. X-Scheme is not used anywhere, X-Forwarded-Proto is more robust. >>> >>> Right, but our existing code uses X-Scheme (as per old advice since >>> removed from the Flask website - see RM3149), and users have deployments >>> that will be setup that way. We need to fall back to X-Scheme if it is >>> present but X-Forwarded-Proto is not, to avoid breaking their installations. >>> >>> > I assume (as you haven't removed it) that it works in conjunction with > the existing reverse proxy code? > Yes it should. >>> >>> Cool :-) >>> >>> > Thanks! > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
If we can do it automatically at startup based on whether or not the Python code thinks we're running under Desktop mode or not, then I suppose it's a win. That would replace one test per request with one test at startup. It'll still be a minute difference, but every little bit helps I guess. On Thu, Sep 19, 2019 at 11:50 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > It is small improvement we can do to avoid overhead of checking headers in > each HTTP requests for proxies. > > > On Thu, Sep 19, 2019 at 4:12 PM Dave Page wrote: > >> Sure, but is it going to make any real difference? I'd rather have it >> "just work" if possible. >> >> This isn't like compression which we expect to use noticable CPU cycles. >> >> On Thu, Sep 19, 2019 at 11:39 AM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> We need to make it configurable, we don't require middleware when we are >>> running in Desktop mode. >>> >>> On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: >>> On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: > >> Hi >> >> On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to allow pgAdmin to work behind proxy with its >>> in built server. I have used werkzeug fixer - >>> https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix >>> >> >> Does this work with both X-Scheme and X-Forwarded-Proto headers as >> discussed? >> > The proxy fix work for all standard X-Forwarded-* headers. X-Scheme is > not used anywhere, X-Forwarded-Proto is more robust. > Right, but our existing code uses X-Scheme (as per old advice since removed from the Flask website - see RM3149), and users have deployments that will be setup that way. We need to fall back to X-Scheme if it is present but X-Forwarded-Proto is not, to avoid breaking their installations. > >> I assume (as you haven't removed it) that it works in conjunction >> with the existing reverse proxy code? >> > Yes it should. > Cool :-) > >> Thanks! >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
On Thu, Sep 19, 2019 at 4:24 PM Dave Page wrote: > If we can do it automatically at startup based on whether or not the > Python code thinks we're running under Desktop mode or not, then I suppose > it's a win. That would replace one test per request with one test at > startup. It'll still be a minute difference, but every little bit helps I > guess. > OK. I'll try. > > On Thu, Sep 19, 2019 at 11:50 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> It is small improvement we can do to avoid overhead of checking headers >> in each HTTP requests for proxies. >> >> >> On Thu, Sep 19, 2019 at 4:12 PM Dave Page wrote: >> >>> Sure, but is it going to make any real difference? I'd rather have it >>> "just work" if possible. >>> >>> This isn't like compression which we expect to use noticable CPU cycles. >>> >>> On Thu, Sep 19, 2019 at 11:39 AM Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> Hi, We need to make it configurable, we don't require middleware when we are running in Desktop mode. On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: > > > On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch to allow pgAdmin to work behind proxy with its in built server. I have used werkzeug fixer - https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix >>> >>> Does this work with both X-Scheme and X-Forwarded-Proto headers as >>> discussed? >>> >> The proxy fix work for all standard X-Forwarded-* headers. X-Scheme >> is not used anywhere, X-Forwarded-Proto is more robust. >> > > Right, but our existing code uses X-Scheme (as per old advice since > removed from the Flask website - see RM3149), and users have deployments > that will be setup that way. We need to fall back to X-Scheme if it is > present but X-Forwarded-Proto is not, to avoid breaking their > installations. > > >> >>> I assume (as you haven't removed it) that it works in conjunction >>> with the existing reverse proxy code? >>> >> Yes it should. >> > > Cool :-) > > >> >>> Thanks! >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is
Hi Hackers, Attached is the updated patch. The patch will enhance the existing reverse proxy feature using ProxyFix. It is compatible with existing X-Scheme option. Plus, as suggested, the reverse proxy feature will be applied only if SERVER_MODE is True. Kindly review. On Thu, Sep 19, 2019 at 4:26 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Thu, Sep 19, 2019 at 4:24 PM Dave Page wrote: > >> If we can do it automatically at startup based on whether or not the >> Python code thinks we're running under Desktop mode or not, then I suppose >> it's a win. That would replace one test per request with one test at >> startup. It'll still be a minute difference, but every little bit helps I >> guess. >> > OK. I'll try. > >> >> On Thu, Sep 19, 2019 at 11:50 AM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> It is small improvement we can do to avoid overhead of checking headers >>> in each HTTP requests for proxies. >>> >>> >>> On Thu, Sep 19, 2019 at 4:12 PM Dave Page wrote: >>> Sure, but is it going to make any real difference? I'd rather have it "just work" if possible. This isn't like compression which we expect to use noticable CPU cycles. On Thu, Sep 19, 2019 at 11:39 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > We need to make it configurable, we don't require middleware when we > are running in Desktop mode. > > On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: > >> >> >> On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: >>> Hi On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow pgAdmin to work behind proxy with > its in built server. I have used werkzeug fixer - > https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix > Does this work with both X-Scheme and X-Forwarded-Proto headers as discussed? >>> The proxy fix work for all standard X-Forwarded-* headers. X-Scheme >>> is not used anywhere, X-Forwarded-Proto is more robust. >>> >> >> Right, but our existing code uses X-Scheme (as per old advice since >> removed from the Flask website - see RM3149), and users have deployments >> that will be setup that way. We need to fall back to X-Scheme if it is >> present but X-Forwarded-Proto is not, to avoid breaking their >> installations. >> >> >>> I assume (as you haven't removed it) that it works in conjunction with the existing reverse proxy code? >>> Yes it should. >>> >> >> Cool :-) >> >> >>> Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4755_v2.patch Description: Binary data
[pgAdmin][RM4756] pgAdmin does not load completely if loaded in an iframe
Hi Hackers, Attached is the patch to allow pgAdmin to open in iframe. This patch also fixes #4561 (which was rejected :P) where pgAdmin was not working when opened using an html link and not directly. The RM has a sample html file to test things. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4756.patch Description: Binary data
Re: pgAdmin4 v4.13 candidate builds
Hi Akshay, One Round of testing has been done, Can you please publish pgadmin4? Kind Regards, On Tue, Sep 17, 2019 at 1:03 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.13 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-09-17-1/ > > Fahar, can you please verify it for release on Thursday. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Fahar Abbas QMG EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: *live:fahar.abbas* Website: www.enterprisedb.com
pgAdmin 4 v4.13 released
The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.13. This release of pgAdmin 4 includes over 46 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_13.html. pgAdmin is the leading Open Source graphical management tool for PostgreSQL. For more information, please see: https://www.pgadmin.org/ Notable changes in this release include: - Added Gather Merge, Named Tuple Store Scan and Table Function Scan icon for explain module. - Don't wait for the database connection before rendering the Query Tool UI, for improved UX. - Allow configuration options to be set from the environment in the container distribution. - Ensure editable and read-only columns in Query Tool should be identified by icons and tooltips in the column header. - Add an Italian translation. - Refactor Dockerfile to avoid needing to run supporting scripts (i.e. 'docker build .' will work) and minimise layers. - Ensure Boolean columns should be editable using keyboard keys. - Fix error while importing data to a table using Import/Export dialog and providing "Not null columns" option. - Fix an issue where oid column should not be pasted when copy/paste row is used on query output containing the oid column. - Ensure port and username should not be mandatory when a service is provided. - Unescape HTML entities in database names in the Query Tool title bar. - Fix PGADMIN_SERVER_JSON_FILE environment variable support in the container. - Ensure sequence with negative value should be created Builds for Windows and macOS are available now, along with a Python Wheel, Docker Container and source code tarball from: https://www.pgadmin.org/download/ RPM and DEB packages are expected to be available on the postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project
pgAdmin 4 commit: Add Reverse Engineered and Modified SQL tests for Uni
Add Reverse Engineered and Modified SQL tests for Unique Constraints. Fixes
#4628
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=faa623658035de48bf10820b8664284036ac3269
Modified Files
--
docs/en_US/release_notes.rst | 1 +
docs/en_US/release_notes_4_14.rst | 18 +++
...ex_constraint.sql => alter_pkey_constraint.sql} | 6 +-
.../alter_pkey_constraint_msql.sql}| 4 +-
.../alter_pkey_constraint_with_index.sql} | 6 +-
.../alter_pkey_constraint_with_index_msql.sql} | 4 +-
...lfactor.sql => alter_pkey_reset_fillfactor.sql} | 6 +-
...or.sql => alter_pkey_reset_fillfactor_msql.sql} | 0
.../tests/11_plus/alter_unique_constraint.sql | 12 ++
.../tests/11_plus/alter_unique_constraint_msql.sql | 6 +
.../11_plus/alter_unique_constraint_with_index.sql | 11 ++
.../alter_unique_constraint_with_index_msql.sql| 6 +
.../11_plus/alter_unique_reset_fillfactor.sql | 12 ++
.../11_plus/alter_unique_reset_fillfactor_msql.sql | 2 +
.../create_msql_index_constraint_with_index.sql| 6 -
...x_constraint.sql => create_pkey_constraint.sql} | 6 +-
...straint.sql => create_pkey_constraint_msql.sql} | 4 +-
...x.sql => create_pkey_constraint_with_index.sql} | 6 +-
.../create_pkey_constraint_with_index_msql.sql | 5 +
.../tests/11_plus/create_unique_constraint.sql | 12 ++
.../11_plus/create_unique_constraint_msql.sql | 8 ++
.../create_unique_constraint_with_index.sql| 10 ++
.../create_unique_constraint_with_index_msql.sql | 5 +
.../11_plus/{test.json => test_primary_key.json} | 25 ++--
.../tests/11_plus/test_unique_constraint.json | 132 +
...ex_constraint.sql => alter_pkey_constraint.sql} | 6 +-
.../alter_pkey_constraint_msql.sql}| 4 +-
.../alter_pkey_constraint_with_index.sql} | 6 +-
.../alter_pkey_constraint_with_index_msql.sql} | 4 +-
...lfactor.sql => alter_pkey_reset_fillfactor.sql} | 6 +-
...or.sql => alter_pkey_reset_fillfactor_msql.sql} | 0
.../tests/default/alter_unique_constraint.sql | 11 ++
.../tests/default/alter_unique_constraint_msql.sql | 6 +
.../default/alter_unique_constraint_with_index.sql | 11 ++
.../alter_unique_constraint_with_index_msql.sql| 6 +
.../default/alter_unique_reset_fillfactor.sql | 11 ++
.../default/alter_unique_reset_fillfactor_msql.sql | 2 +
.../create_msql_index_constraint_with_index.sql| 6 -
...x_constraint.sql => create_pkey_constraint.sql} | 6 +-
...straint.sql => create_pkey_constraint_msql.sql} | 4 +-
...x.sql => create_pkey_constraint_with_index.sql} | 6 +-
.../create_pkey_constraint_with_index_msql.sql | 5 +
.../tests/default/create_unique_constraint.sql | 11 ++
.../default/create_unique_constraint_msql.sql | 7 ++
.../create_unique_constraint_with_index.sql| 10 ++
.../create_unique_constraint_with_index_msql.sql | 5 +
.../default/{test.json => test_primary_key.json} | 25 ++--
.../tests/default/test_unique_constraint.json | 127
48 files changed, 522 insertions(+), 76 deletions(-)
