MSQL tests for Roles node
Hi, PFA patch to add MSQL tests for roles node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4415_roles_msql_tests.diff Description: Binary data
pgAdmin 4 commit: Update Japanese translation.
Update Japanese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e7759f1d57a9afb2b740fbc11c870a6be9de855 Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 171772 -> 172397 bytes .../translations/ja/LC_MESSAGES/messages.po| 56 ++--- 2 files changed, 48 insertions(+), 8 deletions(-)
Re: [pgAdmin4][Patch] - RM 4742 - Can not create Primary key with Index & 4624 - RE-SQL/MSQL test cases for Primary Keys
Hi Akshay, Please find the attached updated patch. On Fri, Sep 13, 2019 at 6:10 PM Akshay Joshi wrote: > Hi Khushboo > > Following are my review comments: > >- Test cases failed on every server. > > Fixed. > >- Delete table scenario is missing in check_constraints and >index_constraints. > > It is not necessary though I have added. > >- Scenario "Primary Key Constraint with Index" is missing in the >11_plus folder, it is available in the default folder. > > Added. > >- Found one issue when we remove fill factor no MSQL is generated and >got the error "can't execute an empty query". > > Fixed the existing issue for the Primary key. > >- Index is not visible in the properties dialog when we create primary >key using index. > > Whenever the Primary key is created using Index, the index name is changed to PK's name. So, I have hide the Index field from the Properties and Edit dialogue. Thanks, Khushboo > >- > > > On Fri, Sep 13, 2019 at 2:41 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix below RMs. >> >> 1. #4742 - Primary Key Dialog: Can not create Primary key with Index >> 2. #4624 - Add RE-SQL/MSQL test cases for Primary Keys >> >> Thanks, >> Khushboo >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > RM_4624_4742_v1.patch Description: Binary data
Re: Japanese translation (September 2019 - 2)
Thanks, patch applied On Sat, Sep 14, 2019 at 10:52 AM fn ln wrote: > Hello. > Updated translation for upcoming version 4.13 is in attachment. > messages.pot was taken from git 2acd2a56. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Added MSQL test cases for Roles.
Added MSQL test cases for Roles. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d923dcf98bd466289f49d6d74f6a7bf6e24f641c Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/roles/__init__.py| 7 ++--- .../9.1_plus/alter_login_role_description.msql | 1 + .../tests/9.1_plus/alter_login_role_name.msql | 2 ++ .../tests/9.1_plus/alter_login_role_options.msql | 11 +++ .../tests/9.1_plus/alter_role_description.msql | 1 + .../roles/tests/9.1_plus/alter_role_name.msql | 2 ++ .../roles/tests/9.1_plus/alter_role_options.msql | 11 +++ .../roles/tests/9.1_plus/create_login_role.msql| 9 ++ .../servers/roles/tests/9.1_plus/create_role.msql | 9 ++ .../servers/roles/tests/9.1_plus/test.json | 34 +++--- .../9.4_plus/alter_login_role_description.msql | 1 + .../tests/9.4_plus/alter_login_role_name.msql | 2 ++ .../tests/9.4_plus/alter_login_role_options.msql | 11 +++ .../tests/9.4_plus/alter_role_description.msql | 1 + .../roles/tests/9.4_plus/alter_role_name.msql | 2 ++ .../roles/tests/9.4_plus/alter_role_options.msql | 11 +++ .../roles/tests/9.4_plus/create_login_role.msql| 9 ++ .../servers/roles/tests/9.4_plus/create_role.msql | 9 ++ .../servers/roles/tests/9.4_plus/test.json | 30 ++- 19 files changed, 141 insertions(+), 22 deletions(-)
pgAdmin 4 commit: 1) Add Reverse Engineered and Modified SQL tests for
1) Add Reverse Engineered and Modified SQL tests for Primary Keys. Fixes #4624. 2) Ensure Primary Key should be created with Index. Fixes #4742. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa668856f780883fd9e2d70188e070c1a89b33b1 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_13.rst | 4 +- .../check_constraint/tests/Default/test.json | 7 ++ .../constraints/index_constraint/__init__.py | 3 +- .../index_constraint/static/js/primary_key.js | 7 +- .../tests/11_plus/alter_index_constraint.sql | 13 +++ .../11_plus/alter_index_constraint_with_index.sql | 11 ++ .../tests/11_plus/alter_msql_index_constraint.sql | 6 + .../alter_msql_index_constraint_with_index.sql | 6 + .../tests/11_plus/alter_msql_reset_fillfactor.sql | 2 + .../tests/11_plus/alter_reset_fillfactor.sql | 12 ++ .../tests/11_plus/create_index_constraint.sql | 12 ++ .../11_plus/create_index_constraint_with_index.sql | 10 ++ .../tests/11_plus/create_msql_index_constraint.sql | 8 ++ .../create_msql_index_constraint_with_index.sql| 6 + .../index_constraint/tests/11_plus/test.json | 129 + .../tests/default/alter_index_constraint.sql | 12 ++ .../default/alter_index_constraint_with_index.sql | 11 ++ .../tests/default/alter_msql_index_constraint.sql | 6 + .../alter_msql_index_constraint_with_index.sql | 6 + .../tests/default/alter_msql_reset_fillfactor.sql | 2 + .../tests/default/alter_reset_fillfactor.sql | 11 ++ .../tests/default/create_index_constraint.sql | 11 ++ .../default/create_index_constraint_with_index.sql | 10 ++ .../tests/default/create_msql_index_constraint.sql | 7 ++ .../create_msql_index_constraint_with_index.sql| 6 + .../index_constraint/tests/default/test.json | 124 .../index_constraint/sql/11_plus/create.sql| 8 +- .../index_constraint/sql/default/create.sql| 4 +- .../index_constraint/sql/default/update.sql| 3 + 29 files changed, 444 insertions(+), 13 deletions(-)
Re: [pgAdmin4][Patch] - RM 4742 - Can not create Primary key with Index & 4624 - RE-SQL/MSQL test cases for Primary Keys
Thanks, patch applied. On Mon, Sep 16, 2019 at 11:36 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Fri, Sep 13, 2019 at 6:10 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are my review comments: >> >>- Test cases failed on every server. >> >> Fixed. > >> >>- Delete table scenario is missing in check_constraints and >>index_constraints. >> >> It is not necessary though I have added. > >> >>- Scenario "Primary Key Constraint with Index" is missing in the >>11_plus folder, it is available in the default folder. >> >> Added. > >> >>- Found one issue when we remove fill factor no MSQL is generated and >>got the error "can't execute an empty query". >> >> Fixed the existing issue for the Primary key. > >> >>- Index is not visible in the properties dialog when we create >>primary key using index. >> >> Whenever the Primary key is created using Index, the index name is > changed to PK's name. > So, I have hide the Index field from the Properties and Edit dialogue. > > Thanks, > Khushboo > >> >>- >> >> >> On Fri, Sep 13, 2019 at 2:41 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix below RMs. >>> >>> 1. #4742 - Primary Key Dialog: Can not create Primary key with Index >>> 2. #4624 - Add RE-SQL/MSQL test cases for Primary Keys >>> >>> Thanks, >>> Khushboo >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: MSQL tests for Roles node
Thanks, patch applied. On Sun, Sep 15, 2019 at 7:10 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add MSQL tests for roles node. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
