pgAdmin 4 commit: 1) Add Reverse Engineered and Modified SQL tests for

2019-09-06 Thread Akshay Joshi
1) Add Reverse Engineered and Modified SQL tests for Indexes. Fixes #4621
2) Fix modified SQL for Index when reset the value of Fill factor and 
Clustered?. Fixes #4702
3) Fix reversed engineered SQL for btree Index when provided sort order and 
NULLs. Fixes #4703

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e4e8b3e5ae134eab50cec94c7e05caf63de872f

Modified Files
--
docs/en_US/release_notes_4_13.rst  |   5 +-
.../databases/schemas/tables/indexes/__init__.py   |  23 +-
.../default/alter_name_fillfactor_comment.sql  |  15 ++
.../default/alter_name_fillfactor_comment_msql.sql |  11 +
.../default/alter_reset_fillfactor_cluster.sql |  11 +
.../alter_reset_fillfactor_cluster_msql.sql|   5 +
.../tests/default/create_btree_asc_null_first.sql  |  13 ++
.../default/create_btree_asc_null_first_msql.sql   |   9 +
.../tests/default/create_btree_asc_null_last.sql   |  13 ++
.../default/create_btree_asc_null_last_msql.sql|   9 +
.../tests/default/create_btree_desc_null_first.sql |   8 +
.../default/create_btree_desc_null_first_msql.sql  |   4 +
.../tests/default/create_btree_desc_null_last.sql  |  13 ++
.../default/create_btree_desc_null_last_msql.sql   |   9 +
.../indexes/tests/default/create_hash_index.sql|   8 +
.../tests/default/create_hash_index_msql.sql   |   4 +
.../tables/indexes/tests/default/test_indexes.json | 251 +
.../indexes/sql/11_plus/column_details.sql |   4 +-
.../templates/indexes/sql/11_plus/create.sql   |   4 +-
.../indexes/sql/default/column_details.sql |   4 +-
.../templates/indexes/sql/default/create.sql   |   4 +-
.../templates/indexes/sql/default/update.sql   |  16 +-
22 files changed, 429 insertions(+), 14 deletions(-)



MSQL test cases for Extension node

2019-09-06 Thread Nagesh Dhope
Hi,
Please find a patch for MSQL test cases for Extension node

-- 
Thanks,
Nagesh


extensions_msql.patch
Description: Binary data


pgAdmin 4 commit: Added MSQL test cases for Extension.

2019-09-06 Thread Akshay Joshi
Added MSQL test cases for Extension.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9f26e7ed2000ae72029ea75716d94e409fb513a5
Author: Nagesh Dhope 

Modified Files
--
.../extensions/tests/9.4_plus/msql_alter_extension_schema.sql  |  2 ++
.../extensions/tests/9.4_plus/msql_alter_extension_version.sql |  2 ++
.../tests/9.4_plus/msql_create_extension_with_all_options.sql  |  3 +++
.../9.4_plus/msql_create_extension_with_default_schema.sql |  2 ++
.../servers/databases/extensions/tests/9.4_plus/tests.json | 10 +-
.../extensions/tests/9.5_plus/msql_alter_extension_schema.sql  |  2 ++
.../tests/9.5_plus/msql_create_extension_with_all_options.sql  |  3 +++
.../servers/databases/extensions/tests/9.5_plus/tests.json |  6 +-
.../extensions/tests/9.6_plus/msql_alter_extension_schema.sql  |  2 ++
.../extensions/tests/9.6_plus/msql_alter_extension_version.sql |  2 ++
.../tests/9.6_plus/msql_create_extension_with_all_options.sql  |  3 +++
.../9.6_plus/msql_create_extension_with_default_schema.sql |  2 ++
.../servers/databases/extensions/tests/9.6_plus/tests.json | 10 +-
13 files changed, 46 insertions(+), 3 deletions(-)



Re: MSQL test cases for Extension node

2019-09-06 Thread Akshay Joshi
Thanks patch applied.

On Fri, Sep 6, 2019 at 3:01 PM Nagesh Dhope 
wrote:

> Hi,
> Please find a patch for MSQL test cases for Extension node
>
> --
> Thanks,
> Nagesh
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


MSQL test cases for FTS Dictionaries.

2019-09-06 Thread Nagesh Dhope
Hi,
Please find a patch for MSQL test cases for FTS Dictionaries.

-- 
Thanks,
Nagesh


fts_dictionaries_msql.patch
Description: Binary data


pgAdmin 4 commit: Update feature test to support changed editor options

2019-09-06 Thread Dave Page
Update feature test to support changed editor options.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=72505b27cb1c34fca98a03af3aa4b16d8d5e8b02

Modified Files
--
web/pgadmin/feature_tests/pg_datatype_validation_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Basic setup for auto update implemented.

2019-09-06 Thread Aditya Toshniwal
Basic setup for auto update implemented.
TODO:
1) Change the update check URL per pgadmin.org
2) Put everyting in README on how to test in dev

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=063c29fd7664a2ed0535da6a515ad41f5810fab1

Modified Files
--
Makefile|   3 +
electron/.eslintrc.js   |   1 +
electron/package.json   |  15 +++--
electron/src/check_python_server.js |  13 ++--
electron/src/dev-app-update.yml |   4 ++
electron/src/index.js   |  35 +++---
electron/src/logger.js  |  17 +++--
electron/src/updater.js |  77 ++
electron/yarn.lock  | 123 +++-
pkg/mac/build-electron.sh   |  68 
pkg/yarn.lock   |   4 ++
yarn.lock   |   4 ++
12 files changed, 284 insertions(+), 80 deletions(-)



pgAdmin 4 commit: Add msql tests for FTS Dictionaries

2019-09-06 Thread Dave Page
Add msql tests for FTS Dictionaries

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db06dd0275bed5ab34decef74aeeb6cebc93772f
Author: Nagesh Dhope 

Modified Files
--
.../msql_alter_fts_dictionary_delete_options.sql   |  2 +
.../default/msql_alter_fts_dictionary_options.sql  |  8 ++
.../tests/default/msql_create_fts_dictionary.sql   |  3 +
.../fts_dictionaries/tests/default/tests.json  | 12 ++-
.../views/tests/pg/9.4_plus/alter_mview.sql| 13 
.../views/tests/pg/9.4_plus/create_mview.sql   | 17 +
.../views/tests/pg/9.4_plus/test_mview.json| 87 ++
.../views/tests/ppas/9.4_plus/alter_mview.sql  | 13 
.../views/tests/ppas/9.4_plus/create_mview.sql | 17 +
.../views/tests/ppas/9.4_plus/test_mview.json  | 87 ++
10 files changed, 256 insertions(+), 3 deletions(-)



Re: MSQL test cases for FTS Dictionaries.

2019-09-06 Thread Dave Page
Thanks, committed.

On Fri, Sep 6, 2019 at 1:25 PM Nagesh Dhope 
wrote:

> Hi,
> Please find a patch for MSQL test cases for FTS Dictionaries.
>
> --
> Thanks,
> Nagesh
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Bug in handling OID numbers, surfacing with numbers > 2^31?

2019-09-06 Thread Erwin Brandstetter
Hi developers!

It would seem that pgAdmin4 pastes OID numbers as numeric literals instead
of string literals, if this report can be trusted:

https://dba.stackexchange.com/questions/247119/unable-to-output-data-from-tables-in-pgadmin-due-to-missing-oid-operator

Leads to sneaky errors with OIDs beyond 2^31. Details in the added answer
there. I did not recreate the issue as its hard to fake those OIDs.

Do you want me to add a bug report in Redmine?

Regards
Erwin