pgAdmin 4 commit: Improve error handling when python process fails to s

2019-09-04 Thread Aditya Toshniwal
Improve error handling when python process fails to start.
Do not quit app if python process fails to start. Instead, allow the user to 
change configuration like python path and app path. Added a restart menu in 
case user wants to restart the app after config changes.
Menu changes, configure window changes.

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0176cea20265e960932139024751c86fc591e950

Modified Files
--
electron/.eslintignore|   7 +
electron/package.json |   8 +-
electron/src/configure_preload.js |  14 ++
electron/src/configure_store.js   |  28 ++-
electron/src/configure_ui.html|  81 +++---
electron/src/configure_ui.js  |  83 --
electron/src/constants.js |   8 +
electron/src/index.js | 293 ++
electron/src/ipc_event.js |  31 +++
electron/yarn.lock| 512 +-
10 files changed, 876 insertions(+), 189 deletions(-)



pgAdmin 4 commit: Further stabilisation and code refinement.

2019-09-04 Thread Aditya Toshniwal
Further stabilisation and code refinement.

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5949ef276d760a5b57ae859bb5fac0d97db9fc11

Modified Files
--
electron/src/configure_ui.html |  8 +++
electron/src/configure_ui.js   | 26 +---
electron/src/constants.js  |  1 +
electron/src/index.js  | 52 +---
electron/src/logger.js | 54 +++---
5 files changed, 91 insertions(+), 50 deletions(-)



pgAdmin 4 commit: Add Reverse Engineered and Modified SQL tests for For

2019-09-04 Thread Akshay Joshi
Add Reverse Engineered and Modified SQL tests for Foreign Tables. Fixes #4618.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5e54f20578c9620c6b92a442c13c79c00a3db3a8

Modified Files
--
docs/en_US/release_notes_4_13.rst  |   1 +
.../databases/schemas/foreign_tables/__init__.py   |   5 +
.../foreign_tables/sql/12_plus/get_constraints.sql |   3 +-
.../templates/foreign_tables/sql/9.2_plus/acl.sql  |   3 +-
.../foreign_tables/sql/9.2_plus/update.sql |  37 ++-
.../foreign_tables/sql/9.5_plus/update.sql |  42 ++--
.../tests/pg/9.2_plus/alter_add_opts.sql   |  16 ++
.../tests/pg/9.2_plus/alter_add_opts_msql.sql  |   5 +
.../tests/pg/9.2_plus/alter_add_priv.sql   |  20 ++
.../tests/pg/9.2_plus/alter_add_priv_msql.sql  |   1 +
.../tests/pg/9.2_plus/alter_col_opts.sql   |  19 ++
.../tests/pg/9.2_plus/alter_col_opts_msql.sql  |  14 ++
.../pg/9.2_plus/alter_comment_add_columns.sql  |  15 ++
.../pg/9.2_plus/alter_comment_add_columns_msql.sql |   8 +
.../tests/pg/9.2_plus/alter_remove_opts_priv.sql   |  17 ++
.../pg/9.2_plus/alter_remove_opts_priv_msql.sql|   4 +
.../create_foreign_table_with_all_options.sql  |  20 ++
.../create_foreign_table_with_all_options_msql.sql |  14 ++
.../tests/pg/9.2_plus/test_foreign_table.json  | 242 +++
.../tests/pg/9.5_plus/alter_add_cons_opts.sql  |  19 ++
.../tests/pg/9.5_plus/alter_add_cons_opts_msql.sql |   8 +
.../tests/pg/9.5_plus/alter_add_priv.sql   |  23 ++
.../tests/pg/9.5_plus/alter_add_priv_msql.sql  |   1 +
.../tests/pg/9.5_plus/alter_col_opts.sql   |  22 ++
.../tests/pg/9.5_plus/alter_col_opts_msql.sql  |  14 ++
.../pg/9.5_plus/alter_comment_add_columns.sql  |  15 ++
.../pg/9.5_plus/alter_comment_add_columns_msql.sql |   8 +
.../pg/9.5_plus/alter_remove_opts_priv_cons.sql|  17 ++
.../9.5_plus/alter_remove_opts_priv_cons_msql.sql  |   7 +
.../create_foreign_table_with_all_options.sql  |  23 ++
.../create_foreign_table_with_all_options_msql.sql |  17 ++
.../tests/pg/9.5_plus/test_foreign_table.json  | 264 +
.../tests/ppas/9.2_plus/alter_add_opts.sql |  16 ++
.../tests/ppas/9.2_plus/alter_add_opts_msql.sql|   5 +
.../tests/ppas/9.2_plus/alter_add_priv.sql |  20 ++
.../tests/ppas/9.2_plus/alter_add_priv_msql.sql|   1 +
.../tests/ppas/9.2_plus/alter_col_opts.sql |  19 ++
.../tests/ppas/9.2_plus/alter_col_opts_msql.sql|  14 ++
.../ppas/9.2_plus/alter_comment_add_columns.sql|  15 ++
.../9.2_plus/alter_comment_add_columns_msql.sql|   8 +
.../tests/ppas/9.2_plus/alter_remove_opts_priv.sql |  17 ++
.../ppas/9.2_plus/alter_remove_opts_priv_msql.sql  |   4 +
.../create_foreign_table_with_all_options.sql  |  20 ++
.../create_foreign_table_with_all_options_msql.sql |  14 ++
.../tests/ppas/9.2_plus/test_foreign_table.json| 242 +++
.../tests/ppas/9.5_plus/alter_add_cons_opts.sql|  19 ++
.../ppas/9.5_plus/alter_add_cons_opts_msql.sql |   8 +
.../tests/ppas/9.5_plus/alter_add_priv.sql |  23 ++
.../tests/ppas/9.5_plus/alter_add_priv_msql.sql|   1 +
.../tests/ppas/9.5_plus/alter_col_opts.sql |  22 ++
.../tests/ppas/9.5_plus/alter_col_opts_msql.sql|  14 ++
.../ppas/9.5_plus/alter_comment_add_columns.sql|  15 ++
.../9.5_plus/alter_comment_add_columns_msql.sql|   8 +
.../ppas/9.5_plus/alter_remove_opts_priv_cons.sql  |  17 ++
.../9.5_plus/alter_remove_opts_priv_cons_msql.sql  |   7 +
.../create_foreign_table_with_all_options.sql  |  23 ++
.../create_foreign_table_with_all_options_msql.sql |  17 ++
.../tests/ppas/9.5_plus/test_foreign_table.json| 264 +
58 files changed, 1714 insertions(+), 43 deletions(-)



pgAdmin 4 commit: Add editor options for plain text mode and to disable

2019-09-04 Thread Dave Page
Add editor options for plain text mode and to disable block folding to
workaround rendering speed issues in CodeMirror with very large scripts.
Fixes #4631.

Re-arrange editor options in the Preferences dialogue to tidy things up.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1c2ba72f02cbcd77c224dc4d8e1b894d1ee2071f
Author: Aditya Toshniwal 

Modified Files
--
.../images/preferences_sql_auto_completion.png | Bin 61789 -> 81322 bytes
docs/en_US/images/preferences_sql_csv_output.png   | Bin 80860 -> 102587 bytes
docs/en_US/images/preferences_sql_display.png  | Bin 119186 -> 144123 bytes
docs/en_US/images/preferences_sql_editor.png   | Bin 0 -> 187992 bytes
docs/en_US/images/preferences_sql_explain.png  | Bin 59844 -> 87439 bytes
.../images/preferences_sql_keyboard_shortcuts.png  | Bin 87211 -> 106337 bytes
docs/en_US/images/preferences_sql_options.png  | Bin 135446 -> 146312 bytes
docs/en_US/images/preferences_sql_results_grid.png | Bin 60244 -> 77124 bytes
docs/en_US/preferences.rst |  49 +-
docs/en_US/release_notes_4_13.rst  |   1 +
.../codemirror/addon/fold/pgadmin-sqlfoldcode.js   |  54 +--
.../static/js/sqleditor/query_tool_preferences.js  |   9 +
web/pgadmin/tools/debugger/static/js/direct.js |   9 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |   9 +-
.../sqleditor/utils/query_tool_preferences.py  |  96 ++--
web/yarn.lock  | 495 +++--
16 files changed, 375 insertions(+), 347 deletions(-)



Re: [pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undo an edit

2019-09-04 Thread Dave Page
Thanks, committed!

On Tue, Sep 3, 2019 at 7:01 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the updated patch to include documentation updates.
>
> On Tue, Sep 3, 2019 at 10:26 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Sep 2, 2019 at 6:28 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Mon, Sep 2, 2019 at 11:05 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch to:
 1) Optimise code folding code for better performance.
 2) Moved all editor related preferences like Font size, Tab size, Brace
 matching, etc. from options to a new category "Editor" .
 3) Added two new preferences - Plain editor mode (text/plain), Disable
 code folding.
 4) Codemirror has its own limitations and lags for long text line.
 Using plain editor mode will help improve the speed as it does not have the
 overhead of syntax highlighting and code folding. Optionally, one can
 disable code folding in normal SQL mode.

>>>
>>> Cool. Attached is an update which tweaks the strings on the Preferences
>>> panel. You'll find that useful when you add the missing screenshots and doc
>>> updates :-)
>>>
>> Thanks. Will send the updated patch. :)
>>
>>>
>>> Thanks!
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgAdmin 4 commit: Modified RE-SQL/MSQL test cases of foreign tables for

2019-09-04 Thread Akshay Joshi
Modified RE-SQL/MSQL test cases of foreign tables for EPAS 9.4 and 9.5

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9eff2e99263ac4bb265b6ae1827451e6ad327a17

Modified Files
--
.../{9.5_plus => 9.6_plus}/alter_add_cons_opts.sql |  0
.../alter_add_cons_opts_msql.sql   |  0
.../pg/{9.5_plus => 9.6_plus}/alter_add_priv.sql   |  0
.../{9.5_plus => 9.6_plus}/alter_add_priv_msql.sql |  0
.../pg/{9.5_plus => 9.6_plus}/alter_col_opts.sql   |  0
.../{9.5_plus => 9.6_plus}/alter_col_opts_msql.sql |  0
.../alter_comment_add_columns.sql  |  0
.../alter_comment_add_columns_msql.sql |  0
.../alter_remove_opts_priv_cons.sql|  0
.../alter_remove_opts_priv_cons_msql.sql   |  0
.../create_foreign_table_with_all_options.sql  |  0
.../create_foreign_table_with_all_options_msql.sql |  0
.../{9.5_plus => 9.6_plus}/test_foreign_table.json |  0
.../tests/ppas/9.2_plus/alter_add_opts.sql | 16 -
.../tests/ppas/9.2_plus/alter_add_opts_msql.sql|  5 --
.../tests/ppas/9.2_plus/alter_add_priv.sql |  7 +-
.../{alter_col_opts.sql => alter_column.sql}   |  7 +-
.../alter_column_msql.sql} |  3 -
.../ppas/9.2_plus/alter_comment_add_columns.sql|  4 +-
.../9.2_plus/alter_comment_add_columns_msql.sql|  4 +-
.../ppas/9.2_plus/alter_remove_opts_priv_msql.sql  |  4 --
..._remove_opts_priv.sql => alter_remove_priv.sql} |  7 +-
.../tests/ppas/9.2_plus/alter_remove_priv_msql.sql |  1 +
.../create_foreign_table_with_all_options.sql  |  3 +-
.../create_foreign_table_with_all_options_msql.sql |  3 +-
.../tests/ppas/9.2_plus/test_foreign_table.json| 81 +-
.../{9.5_plus => 9.6_plus}/alter_add_cons_opts.sql |  0
.../alter_add_cons_opts_msql.sql   |  0
.../ppas/{9.5_plus => 9.6_plus}/alter_add_priv.sql |  0
.../{9.5_plus => 9.6_plus}/alter_add_priv_msql.sql |  0
.../ppas/{9.5_plus => 9.6_plus}/alter_col_opts.sql |  0
.../{9.2_plus => 9.6_plus}/alter_col_opts_msql.sql |  0
.../alter_comment_add_columns.sql  |  0
.../alter_comment_add_columns_msql.sql |  0
.../alter_remove_opts_priv_cons.sql|  0
.../alter_remove_opts_priv_cons_msql.sql   |  0
.../create_foreign_table_with_all_options.sql  |  0
.../create_foreign_table_with_all_options_msql.sql |  0
.../{9.5_plus => 9.6_plus}/test_foreign_table.json |  0
39 files changed, 54 insertions(+), 91 deletions(-)