Re: RM 4463 - MSQL test cases for domain node

[Neel Patel]

Hi,

Please find attached updated patch. I have tested with PG 9.4, PG 10 & EPAS
10.
Do review it and let me know in case of any failures.

Thanks,
Neel Patel

On Fri, Aug 23, 2019 at 1:52 PM Dave Page  wrote:

> Hi
>
> On Wed, Aug 21, 2019 at 8:58 AM Neel Patel 
> wrote:
>
>> Hi,
>>
>> Please find attached patch that will add more resql test cases and msql
>> test cases for domain node.
>>
>>- Covered test cases for Length, Precision and Collation.
>>- Also added msql test cases.
>>
>> While writing resql test cases for domain node, I found one more issue
>> RM-4644 . I have sent
>> separate patch for the same.
>>
>
> I'm getting the following error with this patch:
>
> ==
> ERROR: runTest
> (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
> Reverse Engineered SQL Test Cases
> --
> Traceback (most recent call last):
>   File
> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
> 126, in runTest
> self.execute_test_case(scenarios)
>   File
> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
> 204, in execute_test_case
> if not self.check_msql(scenario, object_id):
>   File
> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
> 329, in check_msql
> object_id)
>   File
> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
> 178, in get_url
> object_url = url_for(rule.endpoint, **options)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/helpers.py",
> line 356, in url_for
> return appctx.app.handle_url_build_error(error, endpoint, values)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/app.py",
> line 2061, in handle_url_build_error
> reraise(exc_type, exc_value, tb)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/_compat.py",
> line 35, in reraise
> raise value
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/helpers.py",
> line 345, in url_for
> force_external=external)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/werkzeug/routing.py",
> line 1776, in build
> raise BuildError(endpoint, values, method, self)
> werkzeug.routing.BuildError: Could not build url for endpoint
> 'NODE-domain.msql_id' with values ['did', 'gid', 'scid', 'sid']. Did you
> forget to specify values ['doid']?
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_4463_V3.patch
Description: Binary data

pgAdmin 4 commit: Added MSQL test cases for Domain.

[Akshay Joshi]

Added MSQL test cases for Domain.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ca65d7cfeaa52f58edc6eff5dd96a1b73aea360
Author: Neel Patel 

Modified Files
--
.../schemas/domains/tests/default/test.json|  69 -
.../{ => pg}/default/alter_domain_comment.sql  |  10 +-
.../default/alter_domain_default_expression.sql|  10 +-
.../tests/{ => pg}/default/alter_domain_name.sql   |  10 +-
.../{ => pg}/default/alter_domain_null_type.sql|  10 +-
.../domains/tests/pg/default/create_domain.sql |  20 
.../default/create_domain_numeric.sql} |   9 +-
.../tests/pg/default/msql_alter_domain_comment.sql |   2 +
.../msql_alter_domain_default_expression.sql   |   2 +
.../tests/pg/default/msql_alter_domain_name.sql|   2 +
.../pg/default/msql_alter_domain_null_type.sql |   2 +
.../tests/pg/default/msql_create_domain.sql|  16 +++
.../pg/default/msql_create_domain_numeric.sql  |   9 ++
.../schemas/domains/tests/pg/default/test.json | 114 +
.../tests/ppas/default/alter_domain_comment.sql|  20 
.../default/alter_domain_default_expression.sql|  19 
.../tests/ppas/default/alter_domain_name.sql   |  19 
.../tests/ppas/default/alter_domain_null_type.sql  |  19 
.../domains/tests/ppas/default/create_domain.sql   |  20 
.../tests/ppas/default/create_domain_numeric.sql   |  13 +++
.../ppas/default/msql_alter_domain_comment.sql |   2 +
.../msql_alter_domain_default_expression.sql   |   2 +
.../tests/ppas/default/msql_alter_domain_name.sql  |   2 +
.../ppas/default/msql_alter_domain_null_type.sql   |   2 +
.../tests/ppas/default/msql_create_domain.sql  |  16 +++
.../ppas/default/msql_create_domain_numeric.sql|   9 ++
.../schemas/domains/tests/ppas/default/test.json   | 114 +
27 files changed, 455 insertions(+), 87 deletions(-)

pgAdmin 4 commit: Increase cache control max age for static files to im

[Akshay Joshi]

Increase cache control max age for static files to improve performance over 
longer run. Fixes #4681

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc91a7c7b2f7ad9c952ba0fa44900f2b2debbc68
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_13.rst | 3 ++-
web/config.py | 3 +++
2 files changed, 5 insertions(+), 1 deletion(-)

Re: [pgAdmin][RM4681] Increase cache control max age for static files

[Akshay Joshi]

Thanks patch applied.

On Thu, Aug 29, 2019 at 11:18 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

>
> On Thu, Aug 29, 2019 at 10:59 AM Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Wed, Aug 28, 2019 at 1:32 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to increase cache control max age (in http header)
>>> for static files to improve performance over longer run.
>>> By default it is 43200 seconds (12 hrs), which means that the static
>>> files like vendor.js, etc. will be fetched again from server after 12hrs.
>>> This is not required as these files won't change.
>>>
>>> Kindly review.
>>>
>> I have done the review, it looks good to me.
>> I have only concern about - with this change the caching will be done for
>> at least 1 year. I am still kind of confused, what should be the caching
>> time?
>>
>> But - we can go ahead with this change.
>>
> Thank you Ashesh. I had set it to a year as the user may not upgrade
> pgAdmin with every release. Plus, we have cache busting mechanism (version
> appended to URL). Nevertheless, we can may be set it to 30 days ( 2592000
> seconds), which is the release cycle interval for pgAdmin.
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>
>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*