Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

[Aditya Toshniwal]

Hi Hackers,

Attached is the updated patch.
The patch also includes some RE-SQL log additions and a change in resql
code where msql was failing if scenario data had dict data types. Code is
changed to convert dict to string before forming the URL.

Kindly review.

On Thu, Aug 29, 2019 at 11:28 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Kindly hold on with the patch. I think I have missed few things. :P
> Will send an updated patch.
>
> On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch containing further changes to sequences RE-SQL test
>> cases. Changes include MSQL test cases, ACL test cases and allow run
>> sequences test cases on EPAS servers.
>>
>> Kindly review.
>>
>> On Mon, Jul 15, 2019 at 7:26 PM Dave Page  wrote:
>>
>>> Thanks, committed.
>>>
>>> On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch to add RE-SQL test cases for sequences. When
 running the test cases, I also found an issue (#4470
 ). The fix for it is
 included in the patch.

 Kindly review.

 --
 Thanks and Regards,
 Aditya Toshniwal
 Software Engineer | EnterpriseDB India | Pune
 "Don't Complain about Heat, Plant a TREE"

>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM4469.part2_v2.patch
Description: Binary data

[pgAdmin][RM4663] Query history throws python exception on python 2.7

[Aditya Toshniwal]

Hi Hackers,

Attached is the tiny patch to fix exception on python 2.7 in query history.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM4663.patch
Description: Binary data

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

[Akshay Joshi]

Thanks patch applied.

On Thu, Aug 29, 2019 at 12:29 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the updated patch.
> The patch also includes some RE-SQL log additions and a change in resql
> code where msql was failing if scenario data had dict data types. Code is
> changed to convert dict to string before forming the URL.
>
> Kindly review.
>
> On Thu, Aug 29, 2019 at 11:28 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Kindly hold on with the patch. I think I have missed few things. :P
>> Will send an updated patch.
>>
>> On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch containing further changes to sequences RE-SQL
>>> test cases. Changes include MSQL test cases, ACL test cases and allow run
>>> sequences test cases on EPAS servers.
>>>
>>> Kindly review.
>>>
>>> On Mon, Jul 15, 2019 at 7:26 PM Dave Page  wrote:
>>>
 Thanks, committed.

 On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to add RE-SQL test cases for sequences. When
> running the test cases, I also found an issue (#4470
> ). The fix for it is
> included in the patch.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Added MSQL test cases for Sequences and cover missing

[Akshay Joshi]

Added MSQL test cases for Sequences and cover missing ACL RE-SQL test cases.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6da1cf25cb2e9385af7bbc716a218f4f61c6d42
Author: Aditya Toshniwal 

Modified Files
--
.../templates/sequences/sql/default/acl.sql|   1 +
.../templates/sequences/sql/default/update.sql |   2 +-
.../schemas/sequences/tests/pg/10_plus/test.json   |  49 
.../tests/pg/default/alter_seq_comment_msql.sql|   2 +
.../tests/pg/default/alter_seq_privs_add.sql   |  21 
.../tests/pg/default/alter_seq_privs_add_msql.sql  |   1 +
.../tests/pg/default/alter_seq_privs_remove.sql|  19 +++
.../pg/default/alter_seq_privs_remove_msql.sql |   1 +
.../tests/pg/default/alter_seq_privs_update.sql|  21 
.../pg/default/alter_seq_privs_update_msql.sql |   2 +
.../tests/pg/default/alter_seq_props_msql.sql  |   8 ++
.../tests/pg/default/create_sequence_msql.sql  |   9 ++
.../schemas/sequences/tests/pg/default/test.json   |  49 
.../tests/pg/default/test_sequences_pg.json| 134 +
.../10_plus => ppas/default}/alter_seq_comment.sql |   2 +-
.../tests/ppas/default/alter_seq_comment_msql.sql  |   2 +
.../tests/ppas/default/alter_seq_privs_add.sql |  21 
.../ppas/default/alter_seq_privs_add_msql.sql  |   1 +
.../tests/ppas/default/alter_seq_privs_remove.sql  |  19 +++
.../ppas/default/alter_seq_privs_remove_msql.sql   |   1 +
.../tests/ppas/default/alter_seq_privs_update.sql  |  21 
.../ppas/default/alter_seq_privs_update_msql.sql   |   2 +
.../10_plus => ppas/default}/alter_seq_props.sql   |   2 +-
.../tests/ppas/default/alter_seq_props_msql.sql|   8 ++
.../10_plus => ppas/default}/create_sequence.sql   |   2 +-
.../tests/ppas/default/create_sequence_msql.sql|   9 ++
.../tests/ppas/default/test_sequences_ppas.json| 134 +
web/regression/re_sql/tests/test_resql.py  |  12 +-
28 files changed, 452 insertions(+), 103 deletions(-)

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Schemas. Fixes #

[Akshay Joshi]

Add Reverse Engineered SQL tests for Schemas. Fixes #4575

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e0c53e7d1dfdb68a55c8aca30d4e59a37c913724

Modified Files
--
docs/en_US/release_notes_4_13.rst  |   1 +
.../templates/schemas/pg/9.2_plus/sql/acl.sql  |   3 +-
.../templates/schemas/pg/default/sql/acl.sql   |   3 +-
.../templates/schemas/ppas/9.1_plus/sql/acl.sql|   3 +-
.../templates/schemas/ppas/9.2_plus/sql/acl.sql|   3 +-
.../tests/pg/9.2_plus/alter_schema_add_priv.sql|  22 ++
.../pg/9.2_plus/alter_schema_add_priv_msql.sql |  13 +
.../tests/pg/9.2_plus/alter_schema_drop_priv.sql   |  14 ++
.../pg/9.2_plus/alter_schema_drop_priv_msql.sql|   5 +
.../tests/pg/9.2_plus/alter_schema_name.sql|   9 +
.../tests/pg/9.2_plus/alter_schema_name_msql.sql   |   2 +
.../pg/9.2_plus/create_schema_all_options.sql  |  25 ++
.../pg/9.2_plus/create_schema_all_options_msql.sql |  18 ++
.../pg/9.2_plus/create_schema_with_comment.sql |   9 +
.../9.2_plus/create_schema_with_comment_msql.sql   |   4 +
.../schemas/tests/pg/9.2_plus/test_schema.json | 272 +
.../tests/ppas/9.2_plus/alter_schema_add_priv.sql  |  22 ++
.../ppas/9.2_plus/alter_schema_add_priv_msql.sql   |  17 ++
.../tests/ppas/9.2_plus/alter_schema_drop_priv.sql |  14 ++
.../ppas/9.2_plus/alter_schema_drop_priv_msql.sql  |   7 +
.../tests/ppas/9.2_plus/alter_schema_name.sql  |   9 +
.../tests/ppas/9.2_plus/alter_schema_name_msql.sql |   2 +
.../ppas/9.2_plus/create_schema_all_options.sql|  25 ++
.../9.2_plus/create_schema_all_options_msql.sql|  18 ++
.../ppas/9.2_plus/create_schema_with_comment.sql   |   9 +
.../9.2_plus/create_schema_with_comment_msql.sql   |   4 +
.../schemas/tests/ppas/9.2_plus/test_schema.json   | 272 +
web/regression/re_sql/tests/test_resql.py  |   7 +-
28 files changed, 807 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Fix exception in query history for python 2.7. Fixes

[Akshay Joshi]

Fix exception in query history for python 2.7. Fixes #4663

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47f26cc3779b45066a47fd4d891c98ff301f0e4c
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_13.rst  | 1 +
web/pgadmin/tools/sqleditor/utils/query_history.py | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)

Re: [pgAdmin][RM4663] Query history throws python exception on python 2.7

[Akshay Joshi]

Thanks patch applied.

On Thu, Aug 29, 2019 at 1:19 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the tiny patch to fix exception on python 2.7 in query history.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*