Re: Resql test cases for views and fix for bug: 4650
Hi Usman I have modified the code, please work on the following test cases: - No test case for privileges at all. - We should add alter test cases for check_option, security_barrier and privileges. Attached is the modified patch, please continue your work on it. On Tue, Aug 27, 2019 at 12:12 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Just a correction, bug reference in above mail should be *4486* instead > of *4650*. > > On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar < > usman.muzaf...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find here attached patch for sql re engineering test cases for >> views node. As part of this patch I have also incorported followings >> >>- Fix for bug # 4650 >>- Also modified views/template/create.sql due to which, apparently >>same output and input was not matching for test cases. >> >> Following are verified before sending the patch >> >>- yarn run pep8 >>- verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and >>ppas 9.4 to 11. >> >> >> -- >> >> >> Thanks, >> >> Usman Muzaffar >> QA Team >> EnterpriseDB Corporation >> > > > -- > > > Thanks, > > Usman Muzaffar > QA Team > EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* Modified_4576.patch Description: Binary data
Re: pgAdmin4 Feature Tests intermittent failures fix
Hi Akshay,
PFA the patch with fixed review comments.
On Thu, Aug 22, 2019 at 4:26 PM Shubham Agarwal <
shubham.agar...@enterprisedb.com> wrote:
> Yes, I agreed too.
> The only thinking was if the test case objective is to check the debugger,
> then it should fail instead of skipping it to come into direct notice.
> If the only test case for debugger gets skip, then the functionality will
> never be tested.
>
> On Thu, Aug 22, 2019 at 4:06 PM Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Thu, Aug 22, 2019 at 4:04 PM Dave Page wrote:
>>
>>>
>>>
>>> On Thu, Aug 22, 2019 at 11:26 AM Shubham Agarwal <
>>> shubham.agar...@enterprisedb.com> wrote:
>>>
Hi Akshay,
Thanks for the overall review and comments.
From the logs and screenshot shared by you, it is cleared that the
debugger plugin is not installed for PG12 server, hence resulting in the
failures of "xss_checks_pgadmin_debugger_test.py" test case.
Please install and re-execute the test cases.
>>>
>>> It should skip the test if that's the case.
>>>
>> +1
>>
>> -- Thanks, Ashesh
>>
>>>
>>>
The rest of the issues need some debugging since I have never
encountered these failures while executing on Jenkins.
Thanks and regards,
Shubham Agarwal
On Thu, Aug 22, 2019 at 2:45 PM Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:
> On Thu, Aug 22, 2019 at 2:43 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Aug 22, 2019 at 2:41 PM Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Akshay,
>>>
>>> On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
Nice work!
>>> It's big patch, and also improvement over last status.
>>> Can we commit the patch, as to avoid any merging issues later?
>>>
>>
>>Sure will do that.
>>
> Thanks
>
> -- Ashesh
>
>>
>>> -- Thanks, Ashesh
>>>
I have run the feature test couple of times on EPAS 9.6, 11, 12 and
PG 9.4, 10, 11, 12. Following are the review comments:
- Following test cases are failing every time on *EPAS 12:*
- Explain query with JIT stats... fails with error "*no such
element: Unable to locate element:
{"method":"xpath","selector":"//*[contains(string(), 'JIT')]"}*
"
- Following test cases are failing every time on *PG 12*:
- History query sources and generated queries toggle...ERROR
- Tests to check if Debugger is vulnerable to XSS ... ERROR
- We have *retry_count* in "browser_tool_bar_test.py" and
"file_manager_test.py" file. Can we make a generic function and
pass the
locator and retry_count it would be good.
- We have also import WebDriverWait in so many files can we
have one generic class or function for all the wait events. We will
pass
the required timeout and the locator if possible.
On Wed, Aug 21, 2019 at 4:18 PM Shubham Agarwal <
shubham.agar...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the patch for fixing the intermittent failures
> encountered while executing the test cases multiple times.
>
> Please review the patch.
>
> --
> Thanks & Regards,
> Shubham Agarwal
> EnterpriseDB Corporation
>
> The Postgres Database Company
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation
The Postgres Database Company
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
> --
> Thanks & Regards,
> Shubham Agarwal
> EnterpriseDB Corporation
>
> The Postgres Database Company
>
--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation
The Postgres Database Company
feature_test_fix_v1.patch
Description: Binary data
[pgAdmin][RM4674] User can not launch query tool window if user name contain html characters
Hi Hackers, Attached is the patch to fix the issue. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4674.patch Description: Binary data
pgAdmin 4 commit: Fixed timezone issue in RE-SQL test cases for Roles.
Fixed timezone issue in RE-SQL test cases for Roles. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28b741a13a1eeab42e52ba75aca4881e766d8f88 Modified Files -- .../tests/9.4_plus/alter_login_role_options.sql| 2 +- .../roles/tests/9.4_plus/alter_role_options.sql| 2 +- .../servers/roles/tests/9.4_plus/test.json | 6 ++-- web/regression/re_sql/tests/test_resql.py | 40 +- 4 files changed, 45 insertions(+), 5 deletions(-)
Re: Resql test cases for views and fix for bug: 4650
Hi, Please find here updated patch with the above required test cases. Please review and commit the changes On Tue, Aug 27, 2019 at 12:44 PM Akshay Joshi wrote: > Hi Usman > > I have modified the code, please work on the following test cases: > >- No test case for privileges at all. >- We should add alter test cases for check_option, security_barrier >and privileges. > > Attached is the modified patch, please continue your work on it. > > On Tue, Aug 27, 2019 at 12:12 PM Usman Muzaffar < > usman.muzaf...@enterprisedb.com> wrote: > >> Just a correction, bug reference in above mail should be *4486* instead >> of *4650*. >> >> On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar < >> usman.muzaf...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find here attached patch for sql re engineering test cases for >>> views node. As part of this patch I have also incorported followings >>> >>>- Fix for bug # 4650 >>>- Also modified views/template/create.sql due to which, apparently >>>same output and input was not matching for test cases. >>> >>> Following are verified before sending the patch >>> >>>- yarn run pep8 >>>- verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and >>>ppas 9.4 to 11. >>> >>> >>> -- >>> >>> >>> Thanks, >>> >>> Usman Muzaffar >>> QA Team >>> EnterpriseDB Corporation >>> >> >> >> -- >> >> >> Thanks, >> >> Usman Muzaffar >> QA Team >> EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks, Usman Muzaffar QA Team EnterpriseDB Corporation view_re_sql_testcases_v3.patch Description: Binary data
pgAdmin 4 commit: Fix query tool launch error if user name contain html
Fix query tool launch error if user name contain html characters. Fixes #4674 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2e5ed937ea686f4d1e9c391a3ab2411cafb Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_13.rst| 3 ++- web/pgadmin/tools/datagrid/static/js/datagrid.js | 2 +- web/pgadmin/tools/datagrid/static/js/datagrid_panel_title.js | 2 +- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-)
Re: [pgAdmin][RM4674] User can not launch query tool window if user name contain html characters
Thanks patch applied. On Tue, Aug 27, 2019 at 4:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue. > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4487] Boolean data type is not editable in view data
Thanks patch applied. On Mon, Aug 26, 2019 at 4:23 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix two issues: > 1) 4487 - Boolean data type is not editable in view data > 2) 3778 - No keyboard key to edit boolean column in "View/Edit Data" > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: 1) Ensure Boolean columns should be editable using ke
1) Ensure Boolean columns should be editable using keyboard keys. Fixes #3778 2) Ensure Boolean columns should be editable in View/Edit data and Query Tool. Fixes #4487 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06ad6b8ba8152639865fa74ed635efb432c05748 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_13.rst | 2 ++ web/pgadmin/static/js/slickgrid/editors.js | 32 +++--- 2 files changed, 22 insertions(+), 12 deletions(-)
[pgAdmin][RM4381] Problem with data editing when using "View/Edit Data" to tables with OID
Hi Hackers, Attached is the patch to fix an issue where, oid column should not be pasted when copy/paste row is used on query output containing the oid column. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4381.patch Description: Binary data
