[pgAdmin][RM4577] "string indices must be integers" displayed if click on PostgreSQL internal columns
Hi Hackers, Attached is the patch to fix the error "string indices must be integers" displayed if clicked on PostgreSQL internal columns under the columns node. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4577.patch Description: Binary data
pgAdmin 4 commit: Ensure editable and read-only columns in Query Tool s
Ensure editable and read-only columns in Query Tool should be identified by icons and tooltips in the column header. Fixes #4667 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8f7d5ac6fd1625ec8d27300b9a1c5319fc22446 Author: Yosry Muhammad Modified Files -- docs/en_US/editgrid.rst| 4 +- docs/en_US/images/query_tool_editable_columns.png | Bin 0 -> 31676 bytes docs/en_US/query_tool.rst | 22 +++- docs/en_US/release_notes_4_13.rst | 3 +- .../feature_tests/query_tool_journey_test.py | 72 -- web/pgadmin/static/js/sqleditor_utils.js | 30 - web/pgadmin/tools/sqleditor/__init__.py| 45 ++- web/pgadmin/tools/sqleditor/command.py | 20 ++- .../tools/sqleditor/static/css/sqleditor.css | 4 +- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 38 -- .../sqleditor/sql/default/get_columns.sql | 2 +- .../tools/sqleditor/utils/get_column_types.py | 57 .../utils/is_query_resultset_updatable.py | 145 +++-- .../tests/test_is_query_resultset_updatable.py | 91 ++--- web/regression/feature_utils/locators.py | 8 ++ 15 files changed, 411 insertions(+), 130 deletions(-)
pgAdmin 4 commit: Fix an error that could be seen when click on any sys
Fix an error that could be seen when click on any system column of a table. Fixes #4577 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ab4d7e8dd68021641fbc448728f9bcfb1fc9e9 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_13.rst | 1 + .../servers/databases/schemas/tables/columns/__init__.py | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-)
Re: [pgAdmin][RM4577] "string indices must be integers" displayed if click on PostgreSQL internal columns
Thanks patch applied. On Mon, Aug 26, 2019 at 12:46 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the error "string indices must be integers" > displayed if clicked on PostgreSQL internal columns under the columns node. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin][RM4487] Boolean data type is not editable in view data
Hi Hackers, Attached is the patch to fix two issues: 1) 4487 - Boolean data type is not editable in view data 2) 3778 - No keyboard key to edit boolean column in "View/Edit Data" Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4487_3778.patch Description: Binary data
pgAdmin 4 commit: Modified RE-SQL test to cover Password, Account Expir
Modified RE-SQL test to cover Password, Account Expire, Connection Limit and Variables for Roles. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ddc9cc889b52d6d2ee264f8a1515bc014c2232f Author: Murtuza Zabuawala Modified Files -- .../roles/tests/9.1_plus/alter_login_role_options.sql | 6 +- .../roles/tests/9.1_plus/alter_role_options.sql| 7 --- .../servers/roles/tests/9.1_plus/test.json | 18 ++ .../roles/tests/9.4_plus/alter_login_role_options.sql | 6 +- .../roles/tests/9.4_plus/alter_role_options.sql| 6 +- .../servers/roles/tests/9.4_plus/test.json | 18 ++ 6 files changed, 47 insertions(+), 14 deletions(-)
Resql test cases for views and fix for bug: 4650
Hi Hackers, Please find here attached patch for sql re engineering test cases for views node. As part of this patch I have also incorported followings - Fix for bug # 4650 - Also modified views/template/create.sql due to which, apparently same output and input was not matching for test cases. Following are verified before sending the patch - yarn run pep8 - verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and ppas 9.4 to 11. -- Thanks, Usman Muzaffar QA Team EnterpriseDB Corporation view_re_sql_testcases_v2.patch Description: Binary data
Re: Resql test cases for views and fix for bug: 4650
Just a correction, bug reference in above mail should be *4486* instead of *4650*. On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for sql re engineering test cases for > views node. As part of this patch I have also incorported followings > >- Fix for bug # 4650 >- Also modified views/template/create.sql due to which, apparently >same output and input was not matching for test cases. > > Following are verified before sending the patch > >- yarn run pep8 >- verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and ppas >9.4 to 11. > > > -- > > > Thanks, > > Usman Muzaffar > QA Team > EnterpriseDB Corporation > -- Thanks, Usman Muzaffar QA Team EnterpriseDB Corporation
