[Patch]: RM-4644 - Length and Precision control for domain node

[Neel Patel]

Hi,

Please find attached patch to fix RM-4644 - Length and Precision control
should enable/disable based on change in data type.

Do review it and let me know for comment.

Thanks,
Neel Patel


RM-4644.patch
Description: Binary data

RM 4463 - MSQL test cases for domain node

[Neel Patel]

Hi,

Please find attached patch that will add more resql test cases and msql
test cases for domain node.

   - Covered test cases for Length, Precision and Collation.
   - Also added msql test cases.

While writing resql test cases for domain node, I found one more issue
RM-4644 . I have sent separate
patch for the same.

Thanks,
Neel Patel


RM_4463_v2.patch
Description: Binary data

Re: RM 4463 - RESQL test cases for domain node

[Neel Patel]

Hi,

Please find attached patch that will add more resql test cases for domain
node.

   - Covered test cases for Length, Precision and Collation.
   - Also added msql test cases.

While writing resql test cases for domain node, I found one more issue
RM-4644 . I am sending separate
patch for the same.

Thanks,
Neel Patel

On Fri, Jul 12, 2019 at 7:10 PM Dave Page  wrote:

> Thanks, applied.
>
> On Fri, Jul 12, 2019 at 12:31 PM Neel Patel 
> wrote:
>
>> Hi,
>>
>> Please find attached patch for reverse engineering test cases for domain
>> node ( RM #4463 )
>> Do review it and let me know for comments.
>>
>> Thanks,
>> Neel Patel
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_4463_v2.patch
Description: Binary data

Re: [GSoC][New Feature] Editable and Read-only Columns

[Dave Page]

Aditya, can you review this please?

Thanks.

On Thu, Aug 15, 2019 at 8:01 PM Yosry Muhammad  wrote:

> Hi, hackers !
>
> Please find attached a work-in-progress patch adding a new feature to the
> Query Tool on top of updatable result-sets.
>
> This patch allows individual columns of an updatable result-set to be
> editable or read-only. This allows for a wider variety of updatable
> result-sets, for example:
>
> - Result-sets with duplicated columns.
> - Result-sets with renamed columns (if a column is renamed to a primary
> key name, the real primary key can be correctly identified) .
> - Result-sets including columns that are not selected directly from a
> table (e.g concatenation of 2 columns or system columns).
>
> In the above cases, these columns would be read-only while other columns
> of the result-set are editable. Editable/Read-only columns are identified
> by icons and tooltips in the column header.
>
> This is still a work-in-progress, updates to tests and documentation is
> still due. Looking forward to your thoughts and feedback!
>
> Also, do you think the editable/read-only icons should apply in both
> View/Edit Data and Query Tool for consistency? or hidden from View/Edit
> Data as all columns are editable anyway?
>
> Thanks.
>
> --
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Rules. Fixes #46

[Akshay Joshi]

Add Reverse Engineered SQL tests for Rules. Fixes #4600

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=094e5577e8a6165a74f9ac4b375841e7b031e137

Modified Files
--
docs/en_US/release_notes_4_13.rst  |   1 +
.../tests/default/alter_delete_event_rule.sql  |  11 ++
.../tests/default/alter_delete_event_rule_msql.sql |   9 ++
.../tests/default/alter_insert_event_rule.sql  |  12 ++
.../tests/default/alter_insert_event_rule_msql.sql |  10 ++
.../tests/default/alter_update_event_rule.sql  |  12 ++
.../tests/default/alter_update_event_rule_msql.sql |  10 ++
.../tests/default/create_delete_event_rule.sql |   8 ++
.../default/create_delete_event_rule_msql.sql  |   4 +
.../tests/default/create_insert_event_rule.sql |  10 ++
.../default/create_insert_event_rule_msql.sql  |   6 +
.../tests/default/create_update_event_rule.sql |  10 ++
.../default/create_update_event_rule_msql.sql  |   6 +
.../schemas/tables/rules/tests/default/test.json   | 148 +
.../schemas/tables/templates/rules/sql/update.sql  |   3 +-
web/regression/re_sql/tests/test_resql.py  |  26 ++--
16 files changed, 272 insertions(+), 14 deletions(-)

pgAdmin 4 commit: Fix length and precision enable/disable issue when ch

[Akshay Joshi]

Fix length and precision enable/disable issue when changing the data type for 
Domain node. Fixes #4644.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc64ce331a731115ad7722eb878c9528af1af930
Author: Neel Patel 

Modified Files
--
docs/en_US/release_notes_4_13.rst|  3 ++-
.../databases/schemas/domains/static/js/domain.js| 16 
2 files changed, 18 insertions(+), 1 deletion(-)

Re: [Patch]: RM-4644 - Length and Precision control for domain node

[Akshay Joshi]

Thanks patch applied.

On Wed, Aug 21, 2019 at 12:49 PM Neel Patel 
wrote:

> Hi,
>
> Please find attached patch to fix RM-4644 - Length and Precision control
> should enable/disable based on change in data type.
>
> Do review it and let me know for comment.
>
> Thanks,
> Neel Patel
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: RM 4463 - RESQL test cases for domain node

[Akshay Joshi]

Hi Neel

MSQL test case for *create* was not running before. In my last patch I have
fixed that. Applying your patch on latest code not working can you please
fix that and re-send the patch.

On Wed, Aug 21, 2019 at 2:33 PM Neel Patel 
wrote:

> Hi,
>
> Please find attached patch that will add more resql test cases for domain
> node.
>
>- Covered test cases for Length, Precision and Collation.
>- Also added msql test cases.
>
> While writing resql test cases for domain node, I found one more issue
> RM-4644 . I am sending
> separate patch for the same.
>
> Thanks,
> Neel Patel
>
> On Fri, Jul 12, 2019 at 7:10 PM Dave Page  wrote:
>
>> Thanks, applied.
>>
>> On Fri, Jul 12, 2019 at 12:31 PM Neel Patel 
>> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch for reverse engineering test cases for domain
>>> node ( RM #4463 )
>>> Do review it and let me know for comments.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Move schema precondition logic into separate function

[Akshay Joshi]

Move schema precondition logic into separate function for RE-SQL.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7090c02014e375193afac40f9e392443f920acd5

Modified Files
--
web/regression/re_sql/tests/test_resql.py | 65 +++
1 file changed, 41 insertions(+), 24 deletions(-)

Re: You've got to be kidding me... pgAdmin 4 forgets passwords even with a dedicated Firefox profile!

[Avin Kavish]

It's massively entertaining to watch you fail at this. Here are some
alternative things that you can do to improve your productivity in general
that will offset the productivity loses imposed on you by the master
password.
- type faster
- buy a mechanical keyboard
- improve your memory skills so that you can remember a strong master
password, you are a privacy nut without even a password to secure your
database login details? As a privacy nut, aren't you supposed to have
randomly generated pre-hashed passwords memorised? You are very amateur.
- buy a good computer chair

A combination of faster typing, better memory and longer sitting hours will
more than make up for your percepted shortcomings of the world around you.
Actually, no. Nothing is going to help you except some self-reflection on
why you perceive everything around you as hostile intent, but why the rest
of the world doesn't feel as extremistic as you.

On Wed, Aug 21, 2019 at 11:59 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> ++pgadmin-hackers
>
> On Wed, Aug 21, 2019 at 11:51 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> If it is regarding master password, then as per the docs -
>> https://www.pgadmin.org/docs/pgadmin4/latest/master_password.html - *"The
>> master password is not stored anywhere on the physical storage. It is
>> temporarily stored in the application memory and it does not get saved when
>> the application is restarted."*
>>
>> On Wed, Aug 21, 2019 at 11:42 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> You sure you're using "Save Password" checkbox while connecting ?
>>>
>>> [image: Screenshot 2019-08-21 at 11.40.28.png]
>>>
>>> On Wed, Aug 21, 2019 at 11:36 AM  wrote:
>>>
 So I went through the trouble of creating a whole separate "profile" in
 Firefox, just for pgAdmin 4. (If you don't, you constantly have to keep
 re-entering the passwords ten times a day because it forgets them when you
 clear the browser data.)

 To make a long story short, it was a PITA to set up yet another default
 Firefox, full of user-hostile garbage settings and clutter, but I had to do
 it. It was simply *impossible* to keep using pgAdmin 4 with default
 settings when it forces the use of your webbrowser to function, instead of
 having a proper, isolated GUI/window of some kind.

 After a lot of wasted time and energy, sending many e-mails to this
 mailing list and individuals on it, I finally discovered a way to get
 pgAdmin 4 to open my custom profile. Everything seemed to finally be
 solved! I now had pgAdmin 4 always opening in its own, separate Firefox
 instance/profile.

 Well, guess what? I just opened pgAdmin 4 and again it asks for the
 damn password... Even though I have definitely not cleared the data in that
 profile. It seems to not happen immediately, but possibly only after a
 restart of the system. I don't know what causes it, but pgAdmin 4 must be
 storing the passwords/settings in a very flimsy and unreliable and "shared"
 manner. Or maybe Firefox is technically at fault with all its own bugs...
 But then again, pgAdmin 4 shouldn't be using Firefox in the first place!

 So now I'm back at square one again: I have a database management tool
 which requires constant inputting of (empty) passwords and just won't
 remember them if I do "unknown series of actions" (reset normal profile's
 data and reboot?). I *hate* that extra click and yes, it does matter. It
 makes me really angry every time I have to open that stupid thing and get
 interrupted by that idiotic prompt for passwords, no matter how many times
 I tell it to save it and I don't clear the profile's data.

 Why can't people just make software that works and doesn't harass the
 user these days? Is it too much to ask for? Isn't it already bad enough
 that we then have to do all the *actual* work, on top of fighting with our
 software to even function *at all*? Seriously. This is absurd.

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>