Re: Minor Readme changes
Hi, On Thu, Aug 15, 2019 at 10:06 PM Тараканов Андрей wrote: > Hi, guys! > > What about some minor Readme changes? > https://github.com/postgres/pgadmin4/pull/25 > > Many users try to install https://hub.docker.com/r/dpage/pgadmin4 on > servers with disabled IPv6 and can't understand why it's not starting. Some > readme changes could help them. > > The documentation link for your reference https://www.pgadmin.org/docs/pgadmin4/4.11/container_deployment.html Thanks, Khushboo > -- > Andy >
pgAdmin 4 commit: 1) Added new python test that checks the transaction
1) Added new python test that checks the transaction status after executing queries and saving data when auto-commit is on/off. 2) Some refactoring of previously written python tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=663e8382f3971487fc2b006392af285c274b04a1 Author: Yosry Muhammad Modified Files -- ..._query_utils.py => execute_query_test_utils.py} | 0 .../sqleditor/tests/test_transaction_status.py | 339 + .../tests/test_is_query_resultset_updatable.py | 35 ++- .../utils/tests/test_save_changed_data.py | 36 ++- 4 files changed, 375 insertions(+), 35 deletions(-)
Re: Query Tool JS Minimal Refactoring
Hi Yosry Jasmine tests are failing, can you please fix those and resend the patch. On Fri, Aug 16, 2019 at 11:23 PM Yosry Muhammad wrote: > Hi hackers, > > Please find attached a patch with minimal refactoring of: > web/pgadmin/tools/sqleditor/static/js/sqleditor.js > > This includes merging 2 redundant functions into one and renaming some > functions to have more expressive and consistent names. > > Please review ! > Thanks. > -- > *Yosry Muhammad Yosry* > > Computer Engineering student, > The Faculty of Engineering, > Cairo University (2021). > Class representative of CMP 2021. > https://www.linkedin.com/in/yosrym93/ > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Transaction Status Python Tests
Thanks patch applied. On Sat, Aug 17, 2019 at 6:22 PM Yosry Muhammad wrote: > Hi Hackers, > > Please find attached a patch including new python test that checks the > transaction status after executing queries and saving data when auto-commit > is on/off. It also includes some refactoring of previously written python > tests. > > Please review ! > Thanks. Regards. > > -- > *Yosry Muhammad Yosry* > > Computer Engineering student, > The Faculty of Engineering, > Cairo University (2021). > Class representative of CMP 2021. > https://www.linkedin.com/in/yosrym93/ > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fix issue where Deleting N number of rows makes first
Fix issue where Deleting N number of rows makes first N number of rows disable. Fixes #3605 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=315538062129c1a453bf02b874d3364138bcd023 Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_12.rst | 1 + web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 10 -- 2 files changed, 5 insertions(+), 6 deletions(-)
