pgAdmin 4 commit: Ensure the comment on a Primary Key constraint can be
Ensure the comment on a Primary Key constraint can be edited under the Table node. Fixes #4581 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c29275011a1ec78e61e28521402c794997c27148 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_12.rst | 3 ++- .../schemas/tables/templates/index_constraint/sql/default/update.sql | 4 ++-- .../browser/server_groups/servers/databases/schemas/tables/utils.py | 4 3 files changed, 8 insertions(+), 3 deletions(-)
Re: [pgAdmin4][Patch] - RM 4581 - Can not edit comments of primary key constraint under table node
Thanks, patch applied. On Thu, Aug 8, 2019 at 7:11 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #4581 - Can not edit > comments of primary key constraint under table node. > > Thanks, > Khushboo > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix PEP-8 issue.
Fix PEP-8 issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8331f62e1caa4a26653f5170690e560c9df61423 Modified Files -- .../browser/server_groups/servers/databases/schemas/tables/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Food For Thought
I think there are some lessons to be learnt here, maybe not to be applied immediately but sooner rather than later. https://slack.engineering/rebuilding-slack-on-the-desktop-308d6fe94ae4
[RM- 4575] RE_SQL for Schema
Hi Hackers, PFA the patch for RE-SQL test cases for Schema node. Please review. Regards, Vishal Schema_4575.patch Description: Binary data
[pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error
Hi Hackers, Attached is the patch to fix console error in create step under pgAgent. Code is changed to use bootstrapToggle instead of bootstrapSwitch. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4582.patch Description: Binary data
pgAdmin 4 commit: 1) Add support of Compound Triggers for EPAS 12+. Fix
1) Add support of Compound Triggers for EPAS 12+. Fixes #4144.
2) Ensure enable trigger menu should be visible when trigger is disabled. Fixes
#4578.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=350ffcce7c6ce7eb13f813f343944585aef23717
Modified Files
--
docs/en_US/compound_trigger_dialog.rst | 75 ++
docs/en_US/images/compound_trigger_code.png| Bin 0 -> 144267 bytes
docs/en_US/images/compound_trigger_events.png | Bin 0 -> 56064 bytes
docs/en_US/images/compound_trigger_general.png | Bin 0 -> 38321 bytes
docs/en_US/images/compound_trigger_sql.png | Bin 0 -> 93775 bytes
docs/en_US/modifying_tables.rst|1 +
docs/en_US/release_notes_4_12.rst |2 +
.../schemas/tables/compound_triggers/__init__.py | 1017
.../static/img/coll-compound_trigger.svg |1 +
.../static/img/compound_trigger-bad.svg|1 +
.../static/img/compound_trigger.svg|1 +
.../static/js/compound_trigger.js | 412
.../compound_triggers/css/compound_trigger.css | 23 +
.../tables/compound_triggers/tests/__init__.py | 16 +
.../ppas/12_plus/alter_event_comment_code.sql | 26 +
.../ppas/12_plus/create_for_insert_delete.sql | 13 +
.../create_for_insert_update_on_columns.sql| 22 +
.../ppas/12_plus/create_for_insert_with_when.sql | 23 +
.../compound_triggers/tests/ppas/12_plus/test.json | 99 ++
.../tests/test_compound_triggers_add.py| 134 +++
.../tests/test_compound_triggers_delete.py | 98 ++
.../test_compound_triggers_delete_multiple.py | 112 +++
.../tests/test_compound_triggers_put.py| 134 +++
.../tables/compound_triggers/tests/utils.py| 137 +++
.../sql/ppas/12_plus}/backend_support.sql |0
.../compound_triggers/sql/ppas/12_plus/create.sql | 26 +
.../sql/ppas/12_plus}/delete.sql |0
.../sql/ppas/12_plus}/enable_disable_trigger.sql |0
.../sql/ppas/12_plus}/get_columns.sql |0
.../sql/ppas/12_plus}/get_oid.sql |0
.../sql/ppas/12_plus}/get_parent.sql |0
.../compound_triggers/sql/ppas/12_plus/nodes.sql | 10 +
.../sql/ppas/12_plus/properties.sql| 22 +
.../compound_triggers/sql/ppas/12_plus/update.sql | 40 +
.../triggers/sql/{ => gpdb}/9.1_plus/get_oid.sql |0
.../triggers/sql/{ => gpdb}/9.1_plus/nodes.sql |0
.../sql/{ => gpdb}/9.1_plus/properties.sql |2 +-
.../triggers/sql/{ => gpdb}/default/alter.sql |0
.../triggers/sql/gpdb/default/backend_support.sql |9 +
.../triggers/sql/{ => gpdb}/default/create.sql |0
.../templates/triggers/sql/gpdb/default/delete.sql |1 +
.../sql/gpdb/default/enable_disable_trigger.sql|2 +
.../triggers/sql/gpdb/default/get_columns.sql |6 +
.../triggers/sql/gpdb/default/get_oid.sql |4 +
.../triggers/sql/gpdb/default/get_parent.sql |5 +
.../{ => gpdb}/default/get_triggerfunctions.sql|0
.../triggers/sql/{ => gpdb}/default/nodes.sql |0
.../triggers/sql/{ => gpdb}/default/properties.sql |0
.../triggers/sql/{ => gpdb}/default/update.sql | 12 +-
.../triggers/sql/{ => pg}/10_plus/create.sql |0
.../triggers/sql/{ => pg}/10_plus/properties.sql |2 +-
.../templates/triggers/sql/pg/9.1_plus/get_oid.sql |5 +
.../templates/triggers/sql/pg/9.1_plus/nodes.sql |9 +
.../triggers/sql/pg/9.1_plus/properties.sql| 23 +
.../templates/triggers/sql/pg/default/alter.sql|9 +
.../triggers/sql/pg/default/backend_support.sql|9 +
.../templates/triggers/sql/pg/default/create.sql | 32 +
.../templates/triggers/sql/pg/default/delete.sql |1 +
.../sql/pg/default/enable_disable_trigger.sql |2 +
.../triggers/sql/pg/default/get_columns.sql|6 +
.../templates/triggers/sql/pg/default/get_oid.sql |4 +
.../triggers/sql/pg/default/get_parent.sql |5 +
.../sql/pg/default/get_triggerfunctions.sql| 15 +
.../templates/triggers/sql/pg/default/nodes.sql|7 +
.../triggers/sql/pg/default/properties.sql |1 +
.../templates/triggers/sql/pg/default/update.sql | 50 +
.../templates/triggers/sql/ppas/10_plus/create.sql | 36 +
.../triggers/sql/ppas/10_plus/properties.sql | 25 +
.../templates/triggers/sql/ppas/12_plus/nodes.sql | 10 +
.../triggers/sql/ppas/12_plus/properties.sql | 26 +
.../triggers/sql/ppas/9.1_plus/get_oid.sql |5 +
.../templates/triggers/sql/ppas/9.1_plus/nodes.sql |9 +
.../triggers/sql/ppas/9.1_plus/properties.sql | 23 +
.../templates/triggers/sql/ppas/default/alter.sql |9 +
.../triggers/sql/ppas/default/backend_support.sql |9 +
.../templates/triggers/sql/ppas/default/create.sql | 32 +
.../templates/triggers/sql/ppas/default/
pgAdmin 4 commit: Fix console error when changing kind(SQL/BATCH) for p
Fix console error when changing kind(SQL/BATCH) for pgAgent job step. Fixes #4582 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1281f5cd6cd5c6631c6e26bf1f04e78f25f2e975 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_12.rst | 3 ++- .../servers/pgagent/steps/static/js/pga_jobstep.js | 18 -- web/pgadmin/static/scss/_backgrid.overrides.scss | 4 3 files changed, 10 insertions(+), 15 deletions(-)
Re: [pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error
Thanks patch applied. On Thu, Aug 8, 2019 at 4:40 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix console error in create step under pgAgent. > Code is changed to use bootstrapToggle instead of bootstrapSwitch. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin] Remove hard-source-webpack-plugin
Hi Hackers, We do not need hard-source-webpack-plugin as webpack 4 is fast enough. It is creating more problems than solving and sometimes we have remove the generated directory to build correctly. Attached is the patch to remove it. In addition to this, I have also changed werkzeug logging level from logging.INFO to config.CONSOLE_LOG_LEVEL (which is WARNING by default). This will reduce the size of log generated by pgAdmin considerably. Messages like - [08/Aug/2019 16:32:58] "POST /settings/store HTTP/1.1" 200 will not be logged. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" remove.hardsource.wepack.patch Description: Binary data
Re: [RM- 4575] RE_SQL for Schema
Hi Vishal Following are my review comments: - Test cases for Schemas are not executing at all, we need to change the logic. - test.json file is not aligned properly. - Don't specify the namespaceowner/grantee/grantor as a hardcoded value to 'enterprisedb'. - Don't specify the hardcode value for "oid": 40970. On Thu, Aug 8, 2019 at 4:23 PM Vishal Sawale wrote: > Hi Hackers, > > PFA the patch for RE-SQL test cases for Schema node. Please review. > > Regards, > Vishal > > > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Add support for OpenSSL 1.1.1 to the Windows installe
Add support for OpenSSL 1.1.1 to the Windows installer build. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f667f5761e73de70befb8bedb5586cf6a988ec9 Modified Files -- Make.bat | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)
Creating control sliders
Hi hackers, I am working on a patch introducing improvements and new features to the query history. I would like to add a slider controller to show/hide queries generated by pgAdmin from the query history. These sliders are used in several places such as preferences, table dialogs, etc. Can someone guide me through this? Thanks. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/
pgAdmin 4 commit: Set the Werkzeug logger to the same log level as the
Set the Werkzeug logger to the same log level as the rest of the app. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bfca1e3ac8ead03304aa533bdb6e250c0d22622a Author: Aditya Toshniwal Modified Files -- web/pgadmin/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Remove HardSourceWebpackPlugin as WebPack 4 is fast e
Remove HardSourceWebpackPlugin as WebPack 4 is fast enough and it causes more problems than it solves. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99b51f8f20e534b8c79da69af5ea79627355c725 Author: Aditya Toshniwal Modified Files -- libraries.txt | 181 -- web/package.json | 1 - web/webpack.config.js | 15 - web/yarn.lock | 64 ++ 4 files changed, 95 insertions(+), 166 deletions(-)
Re: [pgAdmin] Remove hard-source-webpack-plugin
Thanks, applied. On Thu, Aug 8, 2019 at 2:18 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > We do not need hard-source-webpack-plugin as webpack 4 is fast enough. It > is creating more problems than solving and sometimes we have remove the > generated directory to build correctly. > Attached is the patch to remove it. > > In addition to this, I have also changed werkzeug logging level from > logging.INFO to config.CONSOLE_LOG_LEVEL (which is WARNING by default). > This will reduce the size of log generated by pgAdmin considerably. > Messages like - > [08/Aug/2019 16:32:58] "POST /settings/store HTTP/1.1" 200 will not be > logged. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Query Tool - Cell Double Click Fix
Hi hackers,
Please find attached a fix of a bug where users could not double click to
expand the contents of a cell if the resultset was not editable.
Please review.
Thanks.
--
*Yosry Muhammad Yosry*
Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
https://www.linkedin.com/in/yosrym93/
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index 4e1302d7b..0121348e9 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -713,7 +713,7 @@ define('tools.querytool', [
*/
// This function is responsible to create and render the SlickGrid.
-render_grid: function(collection, columns, is_editable, client_primary_key, rows_affected, is_explain_plan) {
+render_grid: function(collection, columns, is_editable, client_primary_key, rows_affected) {
var self = this;
self.handler.numberOfModifiedCells = 0;
@@ -833,7 +833,7 @@ define('tools.querytool', [
}
var grid_options = {
-editable: is_editable || is_explain_plan,
+editable: true,
enableAddRow: is_editable,
enableCellNavigation: true,
enableColumnReorder: false,
@@ -2481,7 +2481,6 @@ define('tools.querytool', [
&& data.types[0] && data.types[0].typname === 'json') {
/* json is sent as text, parse it */
explain_data_json = JSON.parse(data.result[0][0]);
- self.is_explain_plan = true;
}
if (explain_data_json && explain_data_json[0] &&
@@ -2497,7 +2496,7 @@ define('tools.querytool', [
function() {
self.gridView.render_grid(
explain_data_array, self.columns, self.can_edit,
-self.client_primary_key, 0, self.is_explain_plan
+self.client_primary_key, 0
);
// Make sure - the 'Explain' panel is visible, before - we
// start rendering the grid.
pgAdmin 4 commit: Fix double click issue to expand the contents of a ce
Fix double click issue to expand the contents of a cell if the resultset was not editable. Fixes #4585 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b618dfe286146c3c8db73de834eda60e8a12d556 Author: Yosry Muhammad Modified Files -- docs/en_US/release_notes_4_12.rst | 3 ++- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 7 +++ 2 files changed, 5 insertions(+), 5 deletions(-)
Re: Query Tool - Cell Double Click Fix
Thanks patch applied. On Thu, Aug 8, 2019 at 9:18 PM Yosry Muhammad wrote: > Hi hackers, > > Please find attached a fix of a bug where users could not double click to > expand the contents of a cell if the resultset was not editable. > > Please review. > Thanks. > -- > *Yosry Muhammad Yosry* > > Computer Engineering student, > The Faculty of Engineering, > Cairo University (2021). > Class representative of CMP 2021. > https://www.linkedin.com/in/yosrym93/ > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
