pgAdmin 4 commit: Allow enhanced cookie protection to be disabled for c
Allow enhanced cookie protection to be disabled for compatibility with dynamically addressed hosting environments. Fixes #4566 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee8fec6d7fbcfe529fa9b6e7dbf8e1fd95a71ba6 Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_12.rst | 1 + web/config.py | 10 ++ web/pgadmin/__init__.py | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-)
[pgAdmin][RM4570] Tree improvement to improve speed of finding a node
Hi Hackers, Attached is a tiny but very effective patch to improve the speed of finding a node using path (used internally). If you right click or just click on a node, internally the node is traversed using its path. But currently, it compares with the path of all the open nodes to find a match. So if you 1000+ tables and the tables node is open and if you click on a view, the view path is compared with all the 1000+ tables (and with any other open nodes above) before arriving to path. You're at bad luck if you have more open servers above. Code is changed to check if the path of node to be found starts with the current node path. If it doesn't match, why bother the children's of current node. This change will not show much effect for small data, but it does matter for large servers. One more change is to remove unnecessary calls to find node and use the data available with Main Menu -> Object to enable/disable node context menu items. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4570.patch Description: Binary data
pgAdmin 4 commit: Add a --modules option to the RE-SQL test suite to al
Add a --modules option to the RE-SQL test suite to allow testing of specific object types. Fixes #4560 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db7a2e30234b078b1ed53084933cd2e9477a3882 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_12.rst | 1 + web/pgadmin/utils/route.py| 8 +++- web/regression/README | 3 +++ web/regression/re_sql/tests/test_resql.py | 13 ++--- web/regression/runtests.py| 6 +- 5 files changed, 26 insertions(+), 5 deletions(-)
Re: [pgAdmin][RM4560] Allow RE-SQL test cases to be run for a module using --modules
Thanks, applied. On Tue, Aug 6, 2019 at 5:56 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will allow to RE-SQL to run for certain modules using a > command line flag --modules foo,bar. > Added the info to README. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
[pgAdmin][RM4554] RE-SQL for trigger functions
Hi Hackers, Attached is the patch to add RE-SQL test cases for trigger functions. I've also fixed few spacing issues here and there in SQLs generated. This patch also includes fix for https://redmine.postgresql.org/issues/4565 Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4554_4565.patch Description: Binary data
pgAdmin 4 commit: Add an optimisation to the internal code responsible
Add an optimisation to the internal code responsible for searching for treeview nodes. Fixes #4570 Attached is a tiny but very effective patch to improve the speed of finding a node using path (used internally). If you right click or just click on a node, internally the node is traversed using its path. But currently, it compares with the path of all the open nodes to find a match. So if you 1000+ tables and the tables node is open and if you click on a view, the view path is compared with all the 1000+ tables (and with any other open nodes above) before arriving to path. You're at bad luck if you have more open servers above. Code is changed to check if the path of node to be found starts with the current node path. If it doesn't match, why bother the children's of current node. This change will not show much effect for small data, but it does matter for large servers. One more change is to remove unnecessary calls to find node and use the data available with Main Menu -> Object to enable/disable node context menu items. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6800b1f7234ebce329f5603859c1b995a767bd55 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_12.rst | 1 + web/pgadmin/browser/static/js/menu.js | 7 ++- web/pgadmin/static/js/tree/tree.js| 9 + 3 files changed, 16 insertions(+), 1 deletion(-)
Re: [pgAdmin][RM4570] Tree improvement to improve speed of finding a node
Thanks, patch applied. On Tue, Aug 6, 2019 at 1:10 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny but very effective patch to improve the speed of > finding a node using path (used internally). > If you right click or just click on a node, internally the node is > traversed using its path. But currently, it compares with the path of all > the open nodes to find a match. > So if you 1000+ tables and the tables node is open and if you click on a > view, the view path is compared with all the 1000+ tables (and with any > other open nodes above) before arriving to path. You're at bad luck if you > have more open servers above. > > Code is changed to check if the path of node to be found starts with the > current node path. If it doesn't match, why bother the children's of > current node. > This change will not show much effect for small data, but it does matter > for large servers. > > One more change is to remove unnecessary calls to find node and use the > data available with Main Menu -> Object to enable/disable node context menu > items. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add Reverse Engineered SQL tests for Trigger Function
Add Reverse Engineered SQL tests for Trigger Functions. Fixes #4554 Fix the reverse engineered SQL for trigger functions with the WINDOW option selected. Fixes #4565 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9cdb3b40abdf8270696ab5d05d5352e05984b161 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_12.rst | 4 +- .../trigger_functions/pg/sql/11_plus/create.sql| 10 +- .../pg/sql/11_plus/properties.sql | 4 +- .../trigger_functions/pg/sql/11_plus/update.sql| 2 +- .../trigger_functions/pg/sql/9.2_plus/create.sql | 9 +- .../trigger_functions/pg/sql/9.2_plus/update.sql | 4 +- .../trigger_functions/pg/sql/9.5_plus/create.sql | 10 +- .../trigger_functions/pg/sql/9.5_plus/update.sql | 2 +- .../trigger_functions/pg/sql/default/create.sql| 4 +- .../trigger_functions/pg/sql/default/update.sql| 2 +- .../ppas/sql/11_plus/properties.sql| 4 +- .../trigger_functions/ppas/sql/9.2_plus/create.sql | 10 +- .../trigger_functions/ppas/sql/9.2_plus/update.sql | 2 +- .../trigger_functions/ppas/sql/9.5_plus/create.sql | 10 +- .../trigger_functions/ppas/sql/9.5_plus/update.sql | 2 +- .../trigger_functions/ppas/sql/default/create.sql | 4 +- .../trigger_functions/ppas/sql/default/update.sql | 2 +- .../tests/pg/default/alter_ptrig_comment.sql | 18 ++ .../tests/pg/default/alter_ptrig_set_1.sql | 18 ++ .../tests/pg/default/alter_ptrig_set_2.sql | 19 +++ .../tests/pg/default/alter_ptrig_set_3.sql | 20 +++ .../tests/pg/default/create_event_trigger_full.sql | 24 +++ .../tests/pg/default/create_plain_trigger.sql | 15 ++ .../tests/pg/default/create_plain_trigger_full.sql | 24 +++ .../tests/pg/default/test_trigger_functions.json | 182 + .../tests/ppas/default/alter_ptrig_comment.sql | 18 ++ .../tests/ppas/default/alter_ptrig_set_1.sql | 18 ++ .../tests/ppas/default/alter_ptrig_set_2.sql | 19 +++ .../tests/ppas/default/alter_ptrig_set_3.sql | 20 +++ .../ppas/default/create_event_trigger_full.sql | 20 +++ .../tests/ppas/default/create_plain_trigger.sql| 15 ++ .../ppas/default/create_plain_trigger_full.sql | 20 +++ .../tests/ppas/default/test_trigger_functions.json | 162 ++ 33 files changed, 657 insertions(+), 40 deletions(-)
Re: [pgAdmin][RM4554] RE-SQL for trigger functions
Thanks, applied. On Tue, Aug 6, 2019 at 1:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add RE-SQL test cases for trigger functions. > I've also fixed few spacing issues here and there in SQLs generated. > > This patch also includes fix for > https://redmine.postgresql.org/issues/4565 > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Improve message wording.
Improve message wording. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bfb05d3f9f13a650f77f2a0010228168269d7080 Modified Files -- .../xss_checks_panels_and_query_tool_test.py | 16 1 file changed, 8 insertions(+), 8 deletions(-)
pgAdmin 4 commit: Further message tweak.
Further message tweak. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee2099d9c61d693ee4c57fc9b762864954fe3e15 Modified Files -- web/pgadmin/feature_tests/xss_checks_panels_and_query_tool_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [GSoC] Query History Integration with updatable query resultsets and improvements
Hi Seems to work well :-). A few comments: - Should we have an icon by the non-generated queries (the lightning flash) and the COMMITs etc (the commit/rollback icon as appropriate) as well? I think just having the icon for generated queries looks a little odd. - PEP-8 checks failed: pycodestyle --config=.pycodestyle web/ web/pgadmin/tools/sqleditor/utils/tests/test_save_changed_data.py:119: [E251] unexpected spaces around keyword / parameter equals web/pgadmin/tools/sqleditor/utils/tests/test_save_changed_data.py:214: [E251] unexpected spaces around keyword / parameter equals 2 E251 unexpected spaces around keyword / parameter equals 2 make: *** [check-pep8] Error 1 Aditya; can you cast your eyes over it as well please? Thanks! On Tue, Aug 6, 2019 at 1:16 AM Yosry Muhammad wrote: > Hi Dave and Hackers, > > Please find attached a work-in-progress patch with the following > modifications to the query history: > > 1- Queries generated by pgAdmin in Save Data operations are now recorded > in query history. This includes transaction control commands such as > 'COMMIT, ROLLBACK, SAVEPOINT, etc.' > > 2- Queries are now recorded in a correct (mogrified) form after parameters > injection - as opposed to older versions < 4.10. They also appear with the > correct start time (they used to appear with the start time of the > previously executed query - a bug I found). > > 3- Save Data Queries are visually distinguishable in the query history. > > 4- Save Data Queries can be shown/hidden from history using a button. > > 5- Query Tool and View Data now share a common history - this makes more > sense now as data changes can be done from both modes. I had a thought to > remove the Query History from View Data mode entirely, but I thought it > might be useful for some users? I don't know. > > I am done with all the functionality code, what is left is the design of > the toggling button/checkbox. For now, I am using an empty button at the > end of the toolbar (next to download button) for experimental purposes. > > Do you think a button or a checkbox is more appropriate? If a button, I > would need a design to use. If a checkbox, I am going to need more help as > I am not so good with the design parts. Where should it be placed ( I am > thinking above the list of history entries) ? How should it be styled? > > For now, I will start working on tests and documentation updates for this. > Looking forward to your feedback and comments ! > > P.S I have done a lot of refactoring especially in save_data_changes.py, I > would really appreciate it if someone reviewed these changes. > > Thanks! > -- > *Yosry Muhammad Yosry* > > Computer Engineering student, > The Faculty of Engineering, > Cairo University (2021). > Class representative of CMP 2021. > https://www.linkedin.com/in/yosrym93/ > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [GSoC] Query History Integration with updatable query resultsets and improvements
Hi, On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > Hi > > Seems to work well :-). A few comments: > > - Should we have an icon by the non-generated queries (the lightning > flash) and the COMMITs etc (the commit/rollback icon as appropriate) as > well? I think just having the icon for generated queries looks a little odd. > I am sorry I don't quite understand. Do you mean having an icon to show/hide user queries as well? I believe a checkbox is more appropriate anyway, maybe placed right above the history entries. I am going to need a design of the checkbox or styling guidlines though. > - PEP-8 checks failed: > > pycodestyle --config=.pycodestyle web/ > web/pgadmin/tools/sqleditor/utils/tests/test_save_changed_data.py:119: > [E251] unexpected spaces around keyword / parameter equals > web/pgadmin/tools/sqleditor/utils/tests/test_save_changed_data.py:214: > [E251] unexpected spaces around keyword / parameter equals > 2 E251 unexpected spaces around keyword / parameter equals > 2 > make: *** [check-pep8] Error 1 > It's okay I am still not done with the patch. Thanks .
Re: [GSoC] Query History Integration with updatable query resultsets and improvements
Hi, On Tue, Aug 6, 2019, 6:46 PM Yosry Muhammad wrote: > Hi, > > On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > >> Hi >> >> Seems to work well :-). A few comments: >> >> - Should we have an icon by the non-generated queries (the lightning >> flash) and the COMMITs etc (the commit/rollback icon as appropriate) as >> well? I think just having the icon for generated queries looks a little odd. >> > > I am sorry I don't quite understand. Do you mean having an icon to > show/hide user queries as well? I believe a checkbox is more appropriate > anyway, maybe placed right above the history entries. I am going to need a > design of the checkbox or styling guidlines though. > Another idea that came to my mind is to use a dropdown menu checkbox just next to the save data icon. Similar to auto-commot and auto-rollback checkboxs in the dropdown menu next to the execute (flash) icon. What do you think is better? This, or a checkbox right above the history entries?
Re: [pgAdmin][RM4554] RE-SQL for trigger functions
Hi Hackers, I've improved the output messages to add more detail for trigger functions RE-SQL test cases. Attached is the patch. On Tue, Aug 6, 2019 at 6:58 PM Dave Page wrote: > Thanks, applied. > > On Tue, Aug 6, 2019 at 1:57 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to add RE-SQL test cases for trigger functions. >> I've also fixed few spacing issues here and there in SQLs generated. >> >> This patch also includes fix for >> https://redmine.postgresql.org/issues/4565 >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4554.messages.patch Description: Binary data
New versions "What's new"
Hi Hackers, I have noticed a lot of users are unaware of new features or changes that are made from one version to another. Maybe a "What's new" pop up window can be added, showing when the user opens the app for the first time after an upgrade? Does something similar already exist? Thanks.
Re: New versions "What's new"
If this were github, I'd press the thumbs up button, but here is the next best thing. 👍 On Wed, Aug 7, 2019 at 11:35 AM Yosry Muhammad wrote: > Hi Hackers, > > I have noticed a lot of users are unaware of new features or changes that > are made from one version to another. > > Maybe a "What's new" pop up window can be added, showing when the user > opens the app for the first time after an upgrade? Does something similar > already exist? > > Thanks. > > >
pgAdmin 4 commit: Revert the changes done by commit id - f8baa9e5620e25
Revert the changes done by commit id - f8baa9e5620e250329ce0ff45fcff802f31a1bbd
(old commit from electron branch) which had overridden the changes made to
electron2 branch.
Branch
--
electron2
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3dedadb20acd97665c5d9086ca81a30073474f69
Modified Files
--
.gitignore | 1 +
electron/assets/icons/{darwin => }/pgAdmin4.icns | Bin
electron/assets/icons/{windows => }/pgAdmin4.ico | Bin
electron/assets/icons/{linux => }/pgAdmin4.png | Bin
electron/index.html |19 -
electron/package-lock.json | 14878 -
electron/package.json| 8 +-
electron/src/index.html |10 -
electron/src/index.js| 336 +-
electron/src/logger.js | 8 +-
electron/test/index.js |40 -
electron/yarn.lock |14 +-
12 files changed, 15120 insertions(+), 194 deletions(-)
Re: New versions "What's new"
Thanks, Avin ! On Wed, Aug 7, 2019, 8:09 AM Avin Kavish wrote: > If this were github, I'd press the thumbs up button, but here is the next > best thing. 👍 > > On Wed, Aug 7, 2019 at 11:35 AM Yosry Muhammad wrote: > >> Hi Hackers, >> >> I have noticed a lot of users are unaware of new features or changes that >> are made from one version to another. >> >> Maybe a "What's new" pop up window can be added, showing when the user >> opens the app for the first time after an upgrade? Does something similar >> already exist? >> >> Thanks. >> >> >>
