pgAdmin 4 commit: Improve error output for the RE-SQL tests.

2019-07-16 Thread Dave Page
Improve error output for the RE-SQL tests.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aed6b9e6361af187bd3966087d0468fb412dbf0e

Modified Files
--
web/regression/re_sql/tests/test_resql.py | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)



Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node

2019-07-16 Thread Dave Page
Hi

On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for the RE-SQL and modified SQL tests for
> check constraint node.
>
> For the table child nodes, *create table endpoint *with proper data is
> required in the JSON file.
> I have introduced one new parameter named *store_table_id* in the table
> create endpoint, so the created table ID will be stored for the rest of the
> scenarios
>

This breaks the type tests :-(

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node

2019-07-16 Thread Khushboo Vashi
Hi Dave,

On Tue, Jul 16, 2019 at 2:05 PM Dave Page  wrote:

> Hi
>
> On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch for the RE-SQL and modified SQL tests for
>> check constraint node.
>>
>> For the table child nodes, *create table endpoint *with proper data is
>> required in the JSON file.
>> I have introduced one new parameter named *store_table_id* in the table
>> create endpoint, so the created table ID will be stored for the rest of the
>> scenarios
>>
>
> This breaks the type tests :-(
>
> Fixed.
Please find the attached updated patch.

Thanks,
Khushboo

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


resql_check_constraint_v1.patch
Description: Binary data


pgAdmin 4 commit: Fix typo

2019-07-16 Thread Dave Page
Fix typo

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=beb06a4c76cb6796f22dc7adbf03b22c54b3ddd6

Modified Files
--
web/pgadmin/setup/data_directory.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)