[pgAdmin4][Patch]: RM 3996 "Error dropping Schedule" message displayed if drop schedule through property section
Hi Hackers, Attached is the patch to fix RM 3996 "Error dropping Schedule" message displayed if drop schedule through property section. Added regression test cases for delete multiple pgAgent Job, multiple schedules and multiple steps. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_3996.patch Description: Binary data
pgAdmin 4 commit: Fix some minor UI issues on IE11. Fixes #4462
Fix some minor UI issues on IE11. Fixes #4462 Includes some Jasmine test case fixes from Ganesh. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=20a5899c7d4192d0ffb695366f3db3a090de0610 Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_11.rst | 3 ++- web/pgadmin/static/js/backgrid.pgadmin.js | 5 + web/pgadmin/static/scss/_pgadmin.style.scss| 11 +++ .../javascript/dialog_tab_navigator_spec.js| 23 ++ 4 files changed, 33 insertions(+), 9 deletions(-)
Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
Thanks - committed as the IE fixes, with the Jasmine stuff as a bonus :-) On Thu, Jul 11, 2019 at 7:40 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch for jasmine tests fix. Patch also includes > fixes for edit/delete cell focus on IE by Murtuza. > > Regards, > > Ganesh Jaybhay > > On Thu, Jul 11, 2019 at 3:49 PM Dave Page wrote: > >> Hi Ganesh, >> >> It looks like this has broken the Jasmine tests (which I admit I forgot >> to run before committing). Can you fix ASAP please? >> >> Thanks. >> >> On Thu, Jul 11, 2019 at 10:14 AM Dave Page wrote: >> >>> Thanks - patch applied with some doc tweaks. >>> >>> No need for a new ticket! >>> >>> On Thu, Jul 11, 2019 at 7:00 AM Ganesh Jaybhay < >>> ganesh.jayb...@enterprisedb.com> wrote: >>> Hi Dave, Ticket number 3919 refers to keyboard accessibility issues for sub-node control and back grid but this patch covers only sub-node control. Should I create new one? I have added the screenshot having newly added shortcut and updated keyboard shortcut rst file. Also moved the code changes from backgrid.js to backgrid.pgadmin.js. Please find the attached updated patch. Regards, Ganesh Jaybhay On Tue, Jul 9, 2019 at 9:28 PM Dave Page wrote: > Hi, > > What's the ticket number for this? That's a fair amount of code for a > one-line description. There are also no doc changes describing how to > navigate the sub-node control that I can see. > > Also; instead of changing the repo used for backgrid, can we not > un-vendorise it? > > On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay < > ganesh.jayb...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for keyboard accessibility of sub-node control. >> It also covers sub-node dialog forward/backward tab navigation with >> shortcuts. >> >> Kindly review. >> >> Regards, >> Ganesh Jaybhay >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix an error that could be seen when editing column p
Fix an error that could be seen when editing column privileges. Fixes #4389 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed01274f7b95caeba4943d550792abf265fea7f8 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_4_11.rst | 1 + .../servers/databases/schemas/tables/__init__.py | 16 +++- .../templates/columns/sql/10_plus/update.sql | 16 ++-- .../templates/columns/sql/9.2_plus/update.sql | 16 ++-- .../tables/templates/tables/sql/10_plus/create.sql | 2 +- .../tables/templates/tables/sql/12_plus/create.sql | 2 +- .../tables/tests/test_column_privileges_put.py | 96 ++ .../servers/databases/schemas/tables/utils.py | 7 -- 8 files changed, 127 insertions(+), 29 deletions(-)
Re: [GSoC] Finalized First Patch
On Fri, Jul 12, 2019 at 5:57 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Yosry, > > On Thu, Jul 11, 2019 at 6:50 PM Yosry Muhammad wrote: > >> Hi Khushboo, >> Please find an updated patch attached with the mentioned import line >> removed. >> >> Looks good to me. > >> On Thu, Jul 11, 2019 at 6:45 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad >>> wrote: >>> Hi, On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Some points I missed: > 1. I assumed that in this patch modification in case of OIDs= True > (without primary key) has not considered as that is not working. > This is not implemented yet. I will work on that in a following patch soon enough. Okay. >>> 2. As we are already showing the changed Data prompt on closing the > Query Tool, do we really need the Uncommitted Transaction prompt? > This is needed when auto-commit is off. Saving changes in the data grid is performed as part of the ongoing transaction (or a new one if none is ongoing). After saving the data changes the user should still commit the current transaction for the changes to be commited to the database. This feature is also useful in general when auto-commit is off as users may forget to commit ongoing transactions. One thing I have noticed, when I add a new row and delete it >>> immediately without saving it and try to close the query tool, the >>> uncommitted prompt is coming. >>> In my opinion, it should not come, what do you think? >>> >>> We should disable the prompt if auto-commit and auto-rollback both are >>> enabled. >>> >> >> The uncommited prompt does not keep track of what the user has done so >> far, it only checks for the current transaction status. If a current >> transaction is ongoing, the prompt comes up. If you added a new row then >> deleted it without saving, the transaction status is not affected, you must >> have done a previous operation and had auto-commit turned off (probably the >> select statement). >> if auto-commit & auto-rollback are both enabled then there won't be any >> ongoing transaction at any point, thus, the prompt will never come up. >> >> Exactly, my point is. It should not prompt if auto-commit & auto-rollback > both are enabled, but it is coming. Please see the attached video. > Agreed - this should be fixed. If auto-commit is turned off, it should also prompt to commit if the user hit Save in the prior step I think. Maybe reversing that prompt makes more sense in general - prompting to save rather than discard is quite normal; think about text editors etc. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix dropping of pgAgent schedules through the Job pro
Fix dropping of pgAgent schedules through the Job properties. Fixes #3996 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29fd83dc6c5ee5c00d1b1f89261b23195878a2cc Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_4_11.rst | 1 + .../servers/pgagent/schedules/__init__.py | 26 ++ .../pgagent/schedules/static/js/pga_schedule.js| 1 + .../servers/pgagent/steps/__init__.py | 26 ++ .../servers/pgagent/steps/static/js/pga_jobstep.js | 1 + .../pgagent/tests/test_pgagent_delete_multiple.py | 47 ++ .../tests_pgagent_delete_multiple_schedules.py | 56 ++ .../tests/tests_pgagent_delete_multiple_steps.py | 54 + 8 files changed, 194 insertions(+), 18 deletions(-)
[pgAdmin4][Patch] : RE-SQL tests for Collation node
Hi, Please find the attached patch for the RE-SQL tests for collation node. This patch also includes the *modified SQL tests* as well as fixes for the RE-SQL in the collation node which I found while implementing this. To add the modified SQL tests, 2 optional parameters are introduced in the JSON file, i.e. *msql_endpoint* and *expected_msql_file.* These parameters need to be included in the Alter scenarios. I have modified the RE-SQL framework to support modified SQL. Thanks, Khushboo resql_collation.patch Description: Binary data
Re: [GSoC] Finalized First Patch
I will look into it and get back to you. Thanks ! On Fri, Jul 12, 2019, 11:20 AM Dave Page wrote: > > > On Fri, Jul 12, 2019 at 5:57 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> On Thu, Jul 11, 2019 at 6:50 PM Yosry Muhammad >> wrote: >> >>> Hi Khushboo, >>> Please find an updated patch attached with the mentioned import line >>> removed. >>> >>> Looks good to me. >> >>> On Thu, Jul 11, 2019 at 6:45 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi, On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad wrote: > Hi, > > On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Some points I missed: >> 1. I assumed that in this patch modification in case of OIDs= True >> (without primary key) has not considered as that is not working. >> > > This is not implemented yet. I will work on that in a following patch > soon enough. > > Okay. > 2. As we are already showing the changed Data prompt on closing the >> Query Tool, do we really need the Uncommitted Transaction prompt? >> > > This is needed when auto-commit is off. Saving changes in the data > grid is performed as part of the ongoing transaction (or a new one if none > is ongoing). After saving the data changes the user should still commit > the > current transaction for the changes to be commited to the database. This > feature is also useful in general when auto-commit is off as users may > forget to commit ongoing transactions. > > One thing I have noticed, when I add a new row and delete it immediately without saving it and try to close the query tool, the uncommitted prompt is coming. In my opinion, it should not come, what do you think? We should disable the prompt if auto-commit and auto-rollback both are enabled. >>> >>> The uncommited prompt does not keep track of what the user has done so >>> far, it only checks for the current transaction status. If a current >>> transaction is ongoing, the prompt comes up. If you added a new row then >>> deleted it without saving, the transaction status is not affected, you must >>> have done a previous operation and had auto-commit turned off (probably the >>> select statement). >>> if auto-commit & auto-rollback are both enabled then there won't be any >>> ongoing transaction at any point, thus, the prompt will never come up. >>> >>> Exactly, my point is. It should not prompt if auto-commit & >> auto-rollback both are enabled, but it is coming. Please see the attached >> video. >> > > Agreed - this should be fixed. > > If auto-commit is turned off, it should also prompt to commit if the user > hit Save in the prior step I think. Maybe reversing that prompt makes more > sense in general - prompting to save rather than discard is quite normal; > think about text editors etc. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: [pgAdmin4][Patch]: RM 3996 "Error dropping Schedule" message displayed if drop schedule through property section
Thanks, applied. On Fri, Jul 12, 2019 at 9:29 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM 3996 "Error dropping Schedule" message > displayed if drop schedule through property section. Added regression test > cases for delete multiple pgAgent Job, multiple schedules and multiple > steps. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix wording.
Fix wording. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3dd1e8e10216243b05b205e6769eabbdce0c13cd Modified Files -- .../maintenance/tests/test_maintenance_create_job_unit_test.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Re: RE-SQL tests patch for packages node
Hi Dave, Please find the modified patch for packages as test cases were failing on some servers. Thanks! On Thu, Jul 11, 2019 at 1:53 PM Dave Page wrote: > Thanks, applied. > > On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Navnath >> >> I have tested the patch and it is not working for EPAS 9.4, 9.5 and 9.6. >> Attached is the modified patch which fix the issue. >> Please work on child node (functions, procedure and variables) of >> Packages on top of modified patch. >> >> On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh < >> navnath.gad...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> I have attached the patch for RE-SQL test cases for *Packages* node. >>> >>> Thanks! >>> >>> -- >>> *Regards,* >>> *Navnath Gadakh* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- *Regards,* *Navnath Gadakh* re_sql_packages_tests_v2.patch Description: Binary data
Re: RE-SQL tests patch for packages node
Thanks, applied. On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the modified patch for packages as test cases were > failing on some servers. > Thanks! > > > On Thu, Jul 11, 2019 at 1:53 PM Dave Page > wrote: > >> Thanks, applied. >> >> On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Navnath >>> >>> I have tested the patch and it is not working for EPAS 9.4, 9.5 and 9.6. >>> Attached is the modified patch which fix the issue. >>> Please work on child node (functions, procedure and variables) of >>> Packages on top of modified patch. >>> >>> On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh < >>> navnath.gad...@enterprisedb.com> wrote: >>> Hi Dave, I have attached the patch for RE-SQL test cases for *Packages* node. Thanks! -- *Regards,* *Navnath Gadakh* >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > -- > *Regards,* > *Navnath Gadakh* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake
pgAdmin 4 commit: Fix re-sql tests for packages on EPAS 9.4-9.6.
Fix re-sql tests for packages on EPAS 9.4-9.6. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce8a2bb2664dd30ba2f7629d185b4047883c5627 Author: Navnath Gadakh Modified Files -- .../tests/ppas/10_plus/alter_package_headers_and_comment.sql | 10 +- .../tests/ppas/10_plus/create_package_with_all_options.sql | 5 - .../databases/schemas/packages/tests/ppas/10_plus/test.json| 7 --- .../tests/ppas/9.2_plus/alter_package_headers_and_comment.sql | 10 +- .../tests/ppas/9.2_plus/create_package_with_all_options.sql| 5 - .../databases/schemas/packages/tests/ppas/9.2_plus/test.json | 8 web/regression/re_sql/tests/test_resql.py | 1 - 7 files changed, 34 insertions(+), 12 deletions(-)
Re: [pgAdmin4][Patch] : RE-SQL tests for Collation node
Hi On Fri, Jul 12, 2019 at 10:46 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for the RE-SQL tests for collation node. > This patch also includes the *modified SQL tests* as well as fixes for > the RE-SQL in the collation node which I found while implementing this. > > To add the modified SQL tests, 2 optional parameters are introduced in the > JSON file, i.e. > *msql_endpoint* and *expected_msql_file.* > These parameters need to be included in the Alter scenarios. > > I have modified the RE-SQL framework to support modified SQL. > This fails on EPAS 9.4: ... 2019-07-12 11:35:09,672: ERROR flask.app: Failed to execute query (execute_scalar) for the server #5 - DB:test_db_18bdb (Query-id: 9091709): Error Message:ERROR: role "postgres" does not exist Create Collation... FAIL Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line 205, in execute_test_case self.assertEquals(response.status_code, 200) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 1338, in deprecated_func return original_func(*args, **kwargs) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 839, in assertEqual assertion_func(first, second, msg=msg) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 832, in _baseAssertEqual raise self.failureException(msg) AssertionError: 500 != 200 ERROR I guess we need to create a role first? Also, please keep your error messages consistent with the others, e.g. "... FAIL" instead of " ..FAIL". Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch] : RE-SQL tests for Collation node
Hi Dave, Please find the attached updated patch. On Fri, Jul 12, 2019 at 4:07 PM Dave Page wrote: > Hi > > On Fri, Jul 12, 2019 at 10:46 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for the RE-SQL tests for collation node. >> This patch also includes the *modified SQL tests* as well as fixes for >> the RE-SQL in the collation node which I found while implementing this. >> >> To add the modified SQL tests, 2 optional parameters are introduced in >> the JSON file, i.e. >> *msql_endpoint* and *expected_msql_file.* >> These parameters need to be included in the Alter scenarios. >> >> I have modified the RE-SQL framework to support modified SQL. >> > > This fails on EPAS 9.4: > > ... 2019-07-12 11:35:09,672: ERROR flask.app: Failed to execute query > (execute_scalar) for the server #5 - DB:test_db_18bdb (Query-id: 9091709): > Error Message:ERROR: role "postgres" does not exist > > Create Collation... FAIL > Traceback (most recent call last): > File > "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line > 205, in execute_test_case > self.assertEquals(response.status_code, 200) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 1338, in deprecated_func > return original_func(*args, **kwargs) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 839, in assertEqual > assertion_func(first, second, msg=msg) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 832, in _baseAssertEqual > raise self.failureException(msg) > AssertionError: 500 != 200 > ERROR > > Fixed. > I guess we need to create a role first? > > Also, please keep your error messages consistent with the others, e.g. > "... FAIL" instead of " ..FAIL". > > Removed. > Thanks! > > Thanks, Khushboo > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > resql_collation_v1.patch Description: Binary data
RM 4463 - RESQL test cases for domain node
Hi, Please find attached patch for reverse engineering test cases for domain node ( RM #4463 ) Do review it and let me know for comments. Thanks, Neel Patel RM_4463.patch Description: Binary data
pgAdmin 4 commit: Rename horribly named function.
Rename horribly named function. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4d5a687b95915892d925aa81a0f86a116be64c Modified Files -- web/pgadmin/tools/backup/__init__.py| 6 +++--- web/pgadmin/tools/backup/tests/test_backup_create_job_unit_test.py | 4 ++-- .../tools/backup/tests/test_check_utility_exists_route_backup.py| 6 +++--- web/pgadmin/tools/backup/tests/test_create_backup_job.py| 4 ++-- web/pgadmin/tools/import_export/__init__.py | 6 +++--- .../tests/test_check_utility_exists_route_import_export.py | 6 +++--- web/pgadmin/tools/maintenance/__init__.py | 6 +++--- .../tests/test_check_utility_exists_route_maintenance.py| 6 +++--- web/pgadmin/tools/maintenance/tests/test_create_maintenance_job.py | 4 ++-- .../maintenance/tests/test_maintenance_create_job_unit_test.py | 4 ++-- web/pgadmin/tools/restore/__init__.py | 6 +++--- .../tools/restore/tests/test_check_utility_exists_route_restore.py | 6 +++--- web/pgadmin/tools/restore/tests/test_create_restore_job.py | 4 ++-- .../tools/restore/tests/test_restore_create_job_unit_test.py| 4 ++-- web/pgadmin/utils/__init__.py | 2 +- web/regression/python_test_utils/test_utils.py | 4 ++-- 16 files changed, 39 insertions(+), 39 deletions(-)
pgAdmin 4 commit: Fix external utility tests to run on Windows
Fix external utility tests to run on Windows Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b5ca0771573de12db660addb73400a2d0794c4f Modified Files -- web/pgadmin/tools/backup/tests/test_backup_create_job_unit_test.py| 4 web/pgadmin/tools/backup/tests/test_create_backup_job.py | 4 web/pgadmin/tools/maintenance/tests/test_create_maintenance_job.py| 4 .../tools/maintenance/tests/test_maintenance_create_job_unit_test.py | 4 web/pgadmin/tools/restore/tests/test_create_restore_job.py| 4 web/pgadmin/tools/restore/tests/test_restore_create_job_unit_test.py | 4 6 files changed, 24 insertions(+)
pgAdmin 4 commit: Add Reverse Engineered SQL tests for Collations. Fixe
Add Reverse Engineered SQL tests for Collations. Fixes #4464 This also adds the ability to test the msql output in ALTER steps. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e6f4c0082d0a20b89138ee50f435d00defeec9 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_11.rst | 1 + .../databases/schemas/collations/__init__.py | 29 .../templates/collations/sql/default/delete.sql| 2 +- .../templates/collations/sql/default/get_name.sql | 2 +- .../collations/tests/default/alter_collation.sql | 12 .../collations/tests/default/create_collation.sql | 12 .../collations/tests/default/msql_collation.sql| 5 ++ .../schemas/collations/tests/default/test.json | 37 +++ web/regression/re_sql/tests/test_resql.py | 77 ++ 9 files changed, 160 insertions(+), 17 deletions(-)
Re: [pgAdmin4][Patch] : RE-SQL tests for Collation node
Thanks, applied. On Fri, Jul 12, 2019 at 11:54 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached updated patch. > > On Fri, Jul 12, 2019 at 4:07 PM Dave Page wrote: > >> Hi >> >> On Fri, Jul 12, 2019 at 10:46 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch for the RE-SQL tests for collation node. >>> This patch also includes the *modified SQL tests* as well as fixes for >>> the RE-SQL in the collation node which I found while implementing this. >>> >>> To add the modified SQL tests, 2 optional parameters are introduced in >>> the JSON file, i.e. >>> *msql_endpoint* and *expected_msql_file.* >>> These parameters need to be included in the Alter scenarios. >>> >>> I have modified the RE-SQL framework to support modified SQL. >>> >> >> This fails on EPAS 9.4: >> >> ... 2019-07-12 11:35:09,672: ERROR flask.app: Failed to execute query >> (execute_scalar) for the server #5 - DB:test_db_18bdb (Query-id: 9091709): >> Error Message:ERROR: role "postgres" does not exist >> >> Create Collation... FAIL >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line >> 205, in execute_test_case >> self.assertEquals(response.status_code, 200) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 1338, in deprecated_func >> return original_func(*args, **kwargs) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 839, in assertEqual >> assertion_func(first, second, msg=msg) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 832, in _baseAssertEqual >> raise self.failureException(msg) >> AssertionError: 500 != 200 >> ERROR >> >> Fixed. > >> I guess we need to create a role first? >> >> Also, please keep your error messages consistent with the others, e.g. >> "... FAIL" instead of " ..FAIL". >> >> Removed. > >> Thanks! >> >> > Thanks, > Khushboo > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add Reverse Engineered SQL tests for Domains. Fixes #
Add Reverse Engineered SQL tests for Domains. Fixes #4463 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88ab6db9769023485354e967f9f0f7288df5b1fb Author: Neel Patel Modified Files -- docs/en_US/release_notes_4_11.rst | 1 + .../domains/tests/default/alter_domain_comment.sql | 16 + .../default/alter_domain_default_expression.sql| 15 + .../domains/tests/default/alter_domain_name.sql| 15 + .../tests/default/alter_domain_null_type.sql | 15 + .../domains/tests/default/create_domain.sql| 16 + .../schemas/domains/tests/default/test.json| 69 ++ 7 files changed, 147 insertions(+)
Re: RM 4463 - RESQL test cases for domain node
Thanks, applied. On Fri, Jul 12, 2019 at 12:31 PM Neel Patel wrote: > Hi, > > Please find attached patch for reverse engineering test cases for domain > node ( RM #4463 ) > Do review it and let me know for comments. > > Thanks, > Neel Patel > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
