pgAdmin 4 commit: Modified the creation logic of custom schema and adde
Modified the creation logic of custom schema and added support for schema id in re_sql test framework. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4ac1e804e1b943a2ef8db71c06fb7b982096585 Author: Khushboo Vashi Modified Files -- web/regression/re_sql/tests/test_resql.py | 72 --- 1 file changed, 47 insertions(+), 25 deletions(-)
pgAdmin 4 commit: 1) Ensure re_sql tests should not abort at the first
1) Ensure re_sql tests should not abort at the first failure, it should run all
the test cases.
2) Added place holder for owner, so we won't need to create separate pg/ppas
folder just because of change in the owner name.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a9d8f01aa49a92612be11b6589220186bb55645
Modified Files
--
.../{pg => }/9.3_plus/alter_fdw_change_opt2.sql| 2 +-
.../tests/{pg => }/9.3_plus/alter_fdw_comment.sql | 2 +-
.../{pg/default => 9.3_plus}/alter_fdw_opt1.sql| 2 +-
.../{pg/default => 9.3_plus}/alter_fdw_opt2.sql| 2 +-
.../tests/{pg => }/9.3_plus/alter_fdw_rename.sql | 2 +-
.../{pg => }/9.3_plus/alter_fdw_validator.sql | 2 +-
.../tests/{pg => }/9.3_plus/create_fdw.sql | 2 +-
.../tests/{pg => }/9.3_plus/test.json | 1 -
.../{pg => }/default/alter_fdw_change_opt2.sql | 2 +-
.../tests/{pg => }/default/alter_fdw_comment.sql | 2 +-
.../{pg/9.3_plus => default}/alter_fdw_opt1.sql| 2 +-
.../{pg/9.3_plus => default}/alter_fdw_opt2.sql| 2 +-
.../tests/{pg => }/default/alter_fdw_rename.sql| 2 +-
.../tests/{pg => }/default/alter_fdw_validator.sql | 2 +-
.../tests/{pg => }/default/create_fdw.sql | 2 +-
.../tests/{pg => }/default/test.json | 1 -
.../tests/9.3_plus/create_trusted_language.sql | 11 +++
.../tests/9.3_plus/create_untrusted_language.sql | 11 +++
.../databases/languages/tests/9.3_plus/test.json | 43 +
web/regression/re_sql/tests/test_resql.py | 105 ++---
20 files changed, 170 insertions(+), 30 deletions(-)
pgAdmin 4 commit: Remove some files which was committed by mistake.
Remove some files which was committed by mistake. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f085460453abaae2f0fcdc5ef0adc16e92d00f77 Modified Files -- .../tests/9.3_plus/create_trusted_language.sql | 11 -- .../tests/9.3_plus/create_untrusted_language.sql | 11 -- .../databases/languages/tests/9.3_plus/test.json | 43 -- 3 files changed, 65 deletions(-)
Re: RE-SQL test patch for extension node
Hi I have a sneaking suspicion that the work Akshay and Khushboo have been doing might have broken this :-( Create Extension with all options..OK ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): Error Message:ERROR: schema "test_extension_schema" does not exist Alter Extension version..FAIL Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line 230, in execute_test_case self.assertEquals(response.status_code, 200) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 1338, in deprecated_func return original_func(*args, **kwargs) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 839, in assertEqual assertion_func(first, second, msg=msg) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 832, in _baseAssertEqual raise self.failureException(msg) AssertionError: 500 != 200 On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope wrote: > Hi Dave, > > Please find updated patch with *sslinfo.* > > On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: > >> Hi >> >> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >> nagesh.dh...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> Please review attached patch for RE-SQL test cases for *extension* >>> node. >>> >> >> Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel >> contrib module has finally been removed. >> >> Perhaps use sslinfo? That seems less likely to go away anytime soon. >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: RE-SQL test patch for extension node
Thanks, applied! On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhope wrote: > Hi Dave, > > On Tue, Jul 9, 2019 at 4:54 PM Dave Page wrote: > >> Hi >> >> I have a sneaking suspicion that the work Akshay and Khushboo have been >> doing might have broken this :-( >> > > Yup, earlier we were able to create a schema if not exists while running > *alter > *test cases. As this capability is remove alter test case for extension > was failing. > I have fixed the test case, PFA updated patch. > > >> Create Extension with all options..OK >> ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query >> (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): >> Error Message:ERROR: schema "test_extension_schema" does not exist >> >> Alter Extension version..FAIL >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line >> 230, in execute_test_case >> self.assertEquals(response.status_code, 200) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 1338, in deprecated_func >> return original_func(*args, **kwargs) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 839, in assertEqual >> assertion_func(first, second, msg=msg) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 832, in _baseAssertEqual >> raise self.failureException(msg) >> AssertionError: 500 != 200 >> >> >> On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope < >> nagesh.dh...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find updated patch with *sslinfo.* >>> >>> On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: >>> Hi On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < nagesh.dh...@enterprisedb.com> wrote: > Hi Hackers, > Please review attached patch for RE-SQL test cases for *extension* > node. > Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel contrib module has finally been removed. Perhaps use sslinfo? That seems less likely to go away anytime soon. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add RE-SQL tests for Extensions. Fixes #4453
Add RE-SQL tests for Extensions. Fixes #4453 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=84b712a0082eb141c08f34a3836f33cdd35b8d06 Author: Nagesh Dhope Modified Files -- docs/en_US/release_notes_4_11.rst | 1 + .../tests/default/alter_extension_schema.sql | 7 +++ .../tests/default/alter_extension_version.sql | 7 +++ .../default/create_extension_with_all_options.sql | 7 +++ .../create_extension_with_default_schema.sql | 7 +++ .../databases/extensions/tests/default/tests.json | 59 ++ 6 files changed, 88 insertions(+)
pgAdmin 4 commit: Fix typo
Fix typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a56e47c5ce467863632036cd9cad7f9476306e5 Modified Files -- docs/en_US/server_deployment.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Add an example Traefik configuration.
Add an example Traefik configuration. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf0d53bc2cb9dca30277f421debd03a42914aa9d Modified Files -- docs/en_US/container_deployment.rst | 33 - 1 file changed, 32 insertions(+), 1 deletion(-)
Re: RE-SQL test patch for extension node
Hi Dave, Please find updated patch with *sslinfo.* On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: > Hi > > On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope > wrote: > >> Hi Hackers, >> Please review attached patch for RE-SQL test cases for *extension* node. >> > > Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel > contrib module has finally been removed. > > Perhaps use sslinfo? That seems less likely to go away anytime soon. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > extension_resql_tests_v2.patch Description: Binary data
[pgAdmin4][patch] Reverse engineering sql test cases for FTS configuration
Hi Hackers, Please find the attached patch for reverse engineering sql test cases of FTS configuration. Kindly review. Regards, Ganesh Jaybhay re_sql_fts_configuration.patch Description: Binary data
Re: RE-SQL test patch for extension node
Hi Dave, On Tue, Jul 9, 2019 at 4:54 PM Dave Page wrote: > Hi > > I have a sneaking suspicion that the work Akshay and Khushboo have been > doing might have broken this :-( > Yup, earlier we were able to create a schema if not exists while running *alter *test cases. As this capability is remove alter test case for extension was failing. I have fixed the test case, PFA updated patch. > Create Extension with all options..OK > ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query > (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): > Error Message:ERROR: schema "test_extension_schema" does not exist > > Alter Extension version..FAIL > Traceback (most recent call last): > File > "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line > 230, in execute_test_case > self.assertEquals(response.status_code, 200) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 1338, in deprecated_func > return original_func(*args, **kwargs) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 839, in assertEqual > assertion_func(first, second, msg=msg) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 832, in _baseAssertEqual > raise self.failureException(msg) > AssertionError: 500 != 200 > > > On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope > wrote: > >> Hi Dave, >> >> Please find updated patch with *sslinfo.* >> >> On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: >> >>> Hi >>> >>> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >>> nagesh.dh...@enterprisedb.com> wrote: >>> Hi Hackers, Please review attached patch for RE-SQL test cases for *extension* node. >>> >>> Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel >>> contrib module has finally been removed. >>> >>> Perhaps use sslinfo? That seems less likely to go away anytime soon. >>> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > extension_resql_tests_v3.patch Description: Binary data
Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
Hi, What's the ticket number for this? That's a fair amount of code for a one-line description. There are also no doc changes describing how to navigate the sub-node control that I can see. Also; instead of changing the repo used for backgrid, can we not un-vendorise it? On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for keyboard accessibility of sub-node control. It > also covers sub-node dialog forward/backward tab navigation with shortcuts. > > Kindly review. > > Regards, > Ganesh Jaybhay > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add Reverse Engineered SQL tests for FTS Configuratio
Add Reverse Engineered SQL tests for FTS Configurations. Fixes #4454 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7d6966d603eab805ea6cbc76bf1a28766a3c412 Author: Ganesh Jaybhay Modified Files -- docs/en_US/release_notes_4_11.rst | 1 + .../tests/default/alter_fts_conf_add_comment.sql | 9 ++ .../tests/default/alter_fts_conf_add_token.sql | 10 +++ .../tests/default/alter_fts_conf_remove_token.sql | 25 ++ .../tests/default/alter_fts_conf_rename.sql| 10 +++ .../tests/default/create_fts_conf.sql | 7 ++ .../tests/default/create_fts_conf_def1.sql | 7 ++ .../tests/default/create_fts_conf_def2.sql | 26 ++ .../fts_configurations/tests/default/test.json | 99 ++ 9 files changed, 194 insertions(+)
Re: [pgAdmin4][patch] Reverse engineering sql test cases for FTS configuration
Thanks, committed. On Tue, Jul 9, 2019 at 2:29 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for reverse engineering sql test cases of > FTS configuration. > Kindly review. > > Regards, > Ganesh Jaybhay > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [GSoC] Finalized First Patch
Hi Yosry, I liked the way you have refactored the code at some places in the JS file and made it cleaner. Here are some points: 1. The table (including partition table) with a single column having that column primary key is editable but the save button is disabled, so, ultimately I can't save the data. Note: The table should be empty to reproduce this issue. 2. command.py - The check_updatable_results_pkeys function calling the poll function and checks the ASYNC_OK, I think this is not required as this function is called from the poll function from the sqleditor/__init__.py *if the status of the polling is if ASYNC_OK*. So, I think this is overhead but if you have considered another scenario then let me know. 3. In the Preferences, the label of the keyboard shortcut "Save Data Changes" should be "Save data changes". 4. Dave has already mentioned about the commented code, so I do agree we should remove it. 5. I didn't find the doc updates for the keyboard shortcuts in the Preferences module as well as related to this feature. Am I missing something? Keep doing wonderful work for pgAdmin. :) Thanks, Khushboo On Fri, Jul 5, 2019 at 4:31 PM Dave Page wrote: > Hi > > On Fri, Jul 5, 2019 at 6:28 AM Yosry Muhammad wrote: > >> - The patch won't apply with "git apply" and only partially applies with >>> patch -p0. Please "git add" all your changes and new files in your repo, >>> and then run "git diff --cached --binary", which should create a usable >>> patch. You can then un-stage your changes. >>> >>> >> That was due to new image. I made an applicable one with the below >> modifications, please find it attached. >> > > Thanks! > > >> >> >>> - execute_query_utils.py is somewhat lacking in file header and any >>> comments. >>> >>> >> Added. >> >> - There is commented-out code in sqleditor.js >>> >> >> This is the call that adds queries that are generated by pgAdmin to the >> query history. I commented it instead of removing it as I will add it later >> with some modifications when I add the checkbox. >> > > Sure, but we won't commit commented-out code. It just makes things messy > until such time as it gets used (or more often, does not). > > >> - On reflection, I don't think the "Data saved successfully, you still >>> need to commit changes to the database." is prominent enough - in testing, >>> I found it very easy to miss. That might also be compounded by the fact >>> that "Alert on uncommitted transactions?" doesn't seem to be working for >>> me. I get the "Save text" prompt to save the query text, but if I say no to >>> that, the Query Tool instance closes with no further warning, despite >>> having a transaction in progress. >>> >> >> I made a separate notification for the uncommitted save to make it more >> visible, check it out. >> > > That's definitely clearer now. It avoids the "blindness" caused by the > fact that you always get the green message. > > >> I tried the scenario you provided and the uncommitted alert worked fine, >> could you please try again and tell me the exact scenario where that >> happened? >> > > Hmm, it's working fine for me today too. Definitely wasn't yesterday > though! > > I'm going to make some minor tweaks to the wording of the docs before I > commit (as well as removing the commented-out code), but I think this is > good to go, once it's had another review. Khushboo, please take a look as > soon as you can. > > Thanks! > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
