[pgAdmin][RM4404] Feature tests

2019-07-03 Thread Aditya Toshniwal
Hi Hackers,

I have added GUI test case for testing string primary keys. Also,
refactored existing code to reuse code snippets.
Tested on Chrome and Firefox.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM4404.feature_test.patch
Description: Binary data


Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Akshay Joshi
Hi Murtuza

I have tested the patch and I think below string should be modified:
Server(Type: #ppas) is not supported for the Resource Groups module -
Skipped
Server version(12) is not supported for the Resource Groups module -
Skipped

It misleads, that server type 'ppas' is not supported for the Resource
Group, it should be changed to "Resource groups are not supported by PG -
Skipped". Similarly for version string should be ''Resource groups are not
supported by PPAS server less/greater than "

Apart from the above code looks good to me.

On Wed, Jul 3, 2019 at 9:23 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA updated patch.
>
> Please note that our framework considers test cases from all the modules
> as one single test case, If we need module wise detailed summary report for
> the reverse engineered SQL tests then we may have to change the framework.
>
>
> Regards,
> Murtuza
>
>
> On Tue, Jul 2, 2019 at 5:52 PM Dave Page  wrote:
>
>> Hi
>>
>> On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> ++ Attaching patch
>>>
>>> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Please find the updated patch,

 - Added a mechanism to check for supported minimum/maximum version and
 a server type in the framework.

>>>
>> There's still a problem with this I'm afraid - it says in the summary
>> that the re_sql test cases were all skipped, which is not the case. I think
>> we should just skip the irrelevant tests in the re_sql module, but not mark
>> the entire module as being skipped:
>>
>
>> =Running the test cases for 'Regression - PG 11'=
>>
>> runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
>>
>> Reverse Engineered SQL Test Cases
>>
>>
>> Create IMPLICIT Cast
>>
>> Alter IMPLICIT Cast
>>
>> Drop IMPLICIT Cast
>>
>> Create EXPLICIT Cast
>>
>> Alter EXPLICIT Cast
>>
>> Drop EXPLICIT Cast
>>
>>  ... skipped 'Server(Type: #ppas) is not supported for the Resource
>> Groups module'
>>
>>
>> --
>>
>> Ran 1 test in 0.480s
>>
>>
>> OK (skipped=1)
>>
>>
>> ==
>>
>> Test Result Summary
>>
>> ==
>>
>>
>> Regression - PG 11:
>>
>>
>> 0 tests passed
>>
>> 0 tests failed
>>
>> 1 test skipped:
>>
>> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)
>>
>>
>> ==
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


[pgAdmin][RM4318] Change CSS cursors to reflect locked layout level

2019-07-03 Thread Aditya Toshniwal
Hi Hackers,

Attached is the patch to update wcDocker to latest version where the fix
for changing CSS cursors when layout is locked is merged.

Do not forget to yarn install before bundle.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM4318.patch
Description: Binary data


Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Dave Page
Hi

On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi 
wrote:

> Hi Murtuza
>
> I have tested the patch and I think below string should be modified:
> Server(Type: #ppas) is not supported for the Resource Groups module -
> Skipped
> Server version(12) is not supported for the Resource Groups module -
> Skipped
>
> It misleads, that server type 'ppas' is not supported for the Resource
> Group, it should be changed to "Resource groups are not supported by PG -
> Skipped". Similarly for version string should be ''Resource groups are not
> supported by PPAS server less/greater than "
>

Agreed.


>
>> Please note that our framework considers test cases from all the modules
>> as one single test case, If we need module wise detailed summary report for
>> the reverse engineered SQL tests then we may have to change the framework.
>>
>
We're just treating all the re-sql tests as one test in the higher-level
suite. Maybe we'd want to change that in the future, but I think it's fine
for now.


>
>>
>> Regards,
>> Murtuza
>>
>>
>> On Tue, Jul 2, 2019 at 5:52 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 ++ Attaching patch

 On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find the updated patch,
>
> - Added a mechanism to check for supported minimum/maximum version and
> a server type in the framework.
>

>>> There's still a problem with this I'm afraid - it says in the summary
>>> that the re_sql test cases were all skipped, which is not the case. I think
>>> we should just skip the irrelevant tests in the re_sql module, but not mark
>>> the entire module as being skipped:
>>>
>>
>>> =Running the test cases for 'Regression - PG 11'=
>>>
>>> runTest
>>> (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
>>>
>>> Reverse Engineered SQL Test Cases
>>>
>>>
>>> Create IMPLICIT Cast
>>>
>>> Alter IMPLICIT Cast
>>>
>>> Drop IMPLICIT Cast
>>>
>>> Create EXPLICIT Cast
>>>
>>> Alter EXPLICIT Cast
>>>
>>> Drop EXPLICIT Cast
>>>
>>>  ... skipped 'Server(Type: #ppas) is not supported for the Resource
>>> Groups module'
>>>
>>>
>>> --
>>>
>>> Ran 1 test in 0.480s
>>>
>>>
>>> OK (skipped=1)
>>>
>>>
>>> ==
>>>
>>> Test Result Summary
>>>
>>> ==
>>>
>>>
>>> Regression - PG 11:
>>>
>>>
>>> 0 tests passed
>>>
>>> 0 tests failed
>>>
>>> 1 test skipped:
>>>
>>> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)
>>>
>>>
>>> ==
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


[pgAdmin][RM4429] Drag and Drop name in query tool is not working for Firefox browser

2019-07-03 Thread Aditya Toshniwal
Hi Hackers,

Attached is the patch to fix drag and drop issue on firefox. Had to make
few code changes required by firefox explicitly :/

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM4429.patch
Description: Binary data


pgAdmin 4 commit: Add EXPLAIN options for SETTINGS and SUMMARY. Fixes #

2019-07-03 Thread Dave Page
Add EXPLAIN options for SETTINGS and SUMMARY. Fixes #4335
Prevent flickering of large tooltips on the Graphical EXPLAIN canvas. Fixes 
#4224
EXPLAIN options should be Query Tool instance-specific. Fixes #4395

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0340b8fb28702e057974a2a68a30443e52d3
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/images/query_output_explain.png | Bin 54806 -> 86037 bytes
docs/en_US/images/query_output_explain_details.png | Bin 73994 -> 124416 bytes
docs/en_US/query_tool.rst  |   6 +-
docs/en_US/release_notes.rst   |   1 +
docs/en_US/release_notes_4_11.rst  |  18 +++
web/pgadmin/misc/static/explain/css/explain.css|   1 -
web/pgadmin/misc/static/explain/js/explain.js  |  22 +--
.../misc/static/explain/js/explain_statistics.js   | 140 +++
web/pgadmin/static/js/keyboard_shortcuts.js|   3 +-
.../static/js/sqleditor/query_tool_actions.js  |  33 ++---
.../static/js/sqleditor/query_tool_preferences.js  |  14 ++
web/pgadmin/tools/datagrid/__init__.py |   9 +-
web/pgadmin/tools/datagrid/static/js/datagrid.js   |   7 +-
.../tools/datagrid/templates/datagrid/index.html   |  15 ++-
web/pgadmin/tools/sqleditor/__init__.py|  33 -
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 148 +
.../sqleditor/sql/10_plus/explain_plan.sql |  17 +--
.../sqleditor/sql/12_plus/explain_plan.sql |  18 +++
.../sqleditor/sql/9.2_plus/explain_plan.sql|  13 +-
.../sqleditor/sql/default/explain_plan.sql |  14 +-
.../sqleditor/tests/test_explain_plan_templates.py |  52 ++--
.../sqleditor/utils/query_tool_preferences.py  |  12 ++
.../tools/templates/sql/macros/utils.macros|   3 +
.../misc/explain/explain_statistics_spec.js|  34 +
.../sqleditor/query_tool_actions_spec.js   |  55 +++-
25 files changed, 422 insertions(+), 246 deletions(-)



Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-07-03 Thread Dave Page
Thanks, applied.

On Tue, Jul 2, 2019 at 8:38 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the updated patch. The SUMMARY data will be visible on hover
> over the top-right icon along JIT stats and Triggers (if any).
> I'm not sure where does SETTINGS data come in plan output for PGv12. But
> the query is executed with correct options if required.
> Docs updated.
>
> Also, I have fixed a tooltip flickering issue with this patch (#4224)
>
> Kindly review.
>
> On Fri, Jun 28, 2019 at 10:15 PM Dave Page  wrote:
>
>> Hi
>>
>> On Fri, Jun 28, 2019 at 9:27 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the updated patch to fix the review comments of trailing
>>> mail.
>>> Kindly review.
>>>
>>
>> So where is the summary supposed to be displayed? It's now requesting it
>> from the server, and it's in the JSON response, but isn't displayed
>> anywhere that I can see.
>>
>>
>>>
>>> On Thu, Jun 27, 2019 at 4:49 PM Dave Page  wrote:
>>>
 Hi

 On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> On Wed, Jun 26, 2019 at 8:22 PM Dave Page  wrote:
>
>> Hi
>>
>> Something isn't working correctly - I turned on the summary option,
>> and this is the query that was run when I hit the EXPLAIN button:
>>
>> EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING
>> False,SUMMARY False,BUFFERS False) select * from pg_tables
>>
>
>> Aside from the formatting (s/True/true, s/False/false, missing spaces
>> etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle
>> caches, rebundled etc.
>>
> I think I misunderstood the documents -
> https://www.postgresql.org/docs/12/sql-explain.html. Few of the
> parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will
> make the changes, along with formatting to existing codes as well.
>

 I'm not sure that explains why the summary option is set to *false* for
 an EXPLAIN action, but anyway, please make sure it works :-)


>
>> Shouldn't there also be documentation updates?
>>
> Yeah. (I always miss that :/)
>
>>
>> On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to add support for SETTINGS(v12+) and
>>> SUMMARY(v10+) explain options. These options will be visible only if
>>> version is supported.
>>>
>>> I have also created and fixed RM4395. The explain options changed on
>>> one query tool should not change explain options on other query tools or
>>> preferences. The initial values will be taken from preferences are 
>>> usual.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgAdmin 4 commit: Add more comprehensive feature tests for the data gri

2019-07-03 Thread Dave Page
Add more comprehensive feature tests for the data grid editor.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4bc4475cda632ffe1ac912b9f42af18d7d8af48
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/feature_tests/locators.py  |   1 +
web/pgadmin/feature_tests/test_data.json   |  29 +++-
web/pgadmin/feature_tests/view_data_dml_queries.py | 148 +
3 files changed, 119 insertions(+), 59 deletions(-)



Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Murtuza Zabuawala
Hi,

PFA updated patch with corrections in the print messages.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Wed, Jul 3, 2019 at 5:36 PM Dave Page  wrote:

> Hi
>
> On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi 
> wrote:
>
>> Hi Murtuza
>>
>> I have tested the patch and I think below string should be modified:
>> Server(Type: #ppas) is not supported for the Resource Groups module -
>> Skipped
>> Server version(12) is not supported for the Resource Groups module -
>> Skipped
>>
>> It misleads, that server type 'ppas' is not supported for the Resource
>> Group, it should be changed to "Resource groups are not supported by PG -
>> Skipped". Similarly for version string should be ''Resource groups are not
>> supported by PPAS server less/greater than "
>>
>
> Agreed.
>
>
>>
>>> Please note that our framework considers test cases from all the modules
>>> as one single test case, If we need module wise detailed summary report for
>>> the reverse engineered SQL tests then we may have to change the framework.
>>>
>>
> We're just treating all the re-sql tests as one test in the higher-level
> suite. Maybe we'd want to change that in the future, but I think it's fine
> for now.
>
>
>>
>>>
>>> Regards,
>>> Murtuza
>>>
>>>
>>> On Tue, Jul 2, 2019 at 5:52 PM Dave Page  wrote:
>>>
 Hi

 On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> ++ Attaching patch
>
> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find the updated patch,
>>
>> - Added a mechanism to check for supported minimum/maximum version
>> and a server type in the framework.
>>
>
 There's still a problem with this I'm afraid - it says in the summary
 that the re_sql test cases were all skipped, which is not the case. I think
 we should just skip the irrelevant tests in the re_sql module, but not mark
 the entire module as being skipped:

>>>
 =Running the test cases for 'Regression - PG
 11'=

 runTest
 (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)

 Reverse Engineered SQL Test Cases


 Create IMPLICIT Cast

 Alter IMPLICIT Cast

 Drop IMPLICIT Cast

 Create EXPLICIT Cast

 Alter EXPLICIT Cast

 Drop EXPLICIT Cast

  ... skipped 'Server(Type: #ppas) is not supported for the Resource
 Groups module'


 --

 Ran 1 test in 0.480s


 OK (skipped=1)


 ==

 Test Result Summary

 ==


 Regression - PG 11:


 0 tests passed

 0 tests failed

 1 test skipped:

 ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)


 ==

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_4415_v3.diff
Description: Binary data


Re: [pgAdmin][RM4404] Feature tests

2019-07-03 Thread Dave Page
Thanks, applied.

On Wed, Jul 3, 2019 at 8:26 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> I have added GUI test case for testing string primary keys. Also,
> refactored existing code to reuse code snippets.
> Tested on Chrome and Firefox.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgAdmin 4 commit: Add RE-SQL tests for Roles and Resource Groups. Fixes

2019-07-03 Thread Dave Page
Add RE-SQL tests for Roles and Resource Groups. Fixes #4415

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=588e3814d157c6af75092876ebbf05f386ccf16b
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/release_notes_4_11.rst  |   2 +
.../servers/resource_groups/__init__.py|  45 
.../resource_groups/sql/{ => default}/create.sql   |   0
.../resource_groups/sql/{ => default}/delete.sql   |   0
.../resource_groups/sql/{ => default}/getoid.sql   |   0
.../resource_groups/sql/{ => default}/nodes.sql|   0
.../sql/{ => default}/properties.sql   |   0
.../resource_groups/sql/{ => default}/update.sql   |   2 +-
.../tests/default/alter_resource_group_name.sql|   8 ++
.../tests/default/alter_resource_group_options.sql |   8 ++
.../tests/default/create_resource_group.sql|   8 ++
.../resource_groups/tests/default/test.json|  48 
.../tests/9.1_plus/alter_role_description.sql  |  12 ++
.../roles/tests/9.1_plus/alter_role_name.sql   |  12 ++
.../roles/tests/9.1_plus/alter_role_options.sql|  15 +++
.../tests/9.1_plus/alter_user_description.sql  |  15 +++
.../roles/tests/9.1_plus/alter_user_name.sql   |  15 +++
.../roles/tests/9.1_plus/alter_user_options.sql|  12 ++
.../servers/roles/tests/9.1_plus/create_role.sql   |  10 ++
.../servers/roles/tests/9.1_plus/create_user.sql   |  13 +++
.../servers/roles/tests/9.1_plus/test.json | 124 +
.../tests/9.4_plus/alter_role_description.sql  |  12 ++
.../roles/tests/9.4_plus/alter_role_name.sql   |  12 ++
.../roles/tests/9.4_plus/alter_role_options.sql|  12 ++
.../tests/9.4_plus/alter_user_description.sql  |  12 ++
.../roles/tests/9.4_plus/alter_user_name.sql   |  12 ++
.../roles/tests/9.4_plus/alter_user_options.sql|  12 ++
.../servers/roles/tests/9.4_plus/create_role.sql   |  10 ++
.../servers/roles/tests/9.4_plus/create_user.sql   |  10 ++
.../servers/roles/tests/9.4_plus/test.json | 124 +
web/regression/python_test_utils/test_utils.py |   2 +
web/regression/re_sql/tests/test_resql.py  |  71 +++-
web/regression/runtests.py |   1 +
33 files changed, 612 insertions(+), 27 deletions(-)



Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Dave Page
Thanks, applied.

On Wed, Jul 3, 2019 at 2:30 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA updated patch with corrections in the print messages.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Wed, Jul 3, 2019 at 5:36 PM Dave Page  wrote:
>
>> Hi
>>
>> On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Murtuza
>>>
>>> I have tested the patch and I think below string should be modified:
>>> Server(Type: #ppas) is not supported for the Resource Groups module -
>>> Skipped
>>> Server version(12) is not supported for the Resource Groups module -
>>> Skipped
>>>
>>> It misleads, that server type 'ppas' is not supported for the Resource
>>> Group, it should be changed to "Resource groups are not supported by PG -
>>> Skipped". Similarly for version string should be ''Resource groups are not
>>> supported by PPAS server less/greater than "
>>>
>>
>> Agreed.
>>
>>
>>>
 Please note that our framework considers test cases from all the
 modules as one single test case, If we need module wise detailed summary
 report for the reverse engineered SQL tests then we may have to change the
 framework.

>>>
>> We're just treating all the re-sql tests as one test in the higher-level
>> suite. Maybe we'd want to change that in the future, but I think it's fine
>> for now.
>>
>>
>>>

 Regards,
 Murtuza


 On Tue, Jul 2, 2019 at 5:52 PM Dave Page  wrote:

> Hi
>
> On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> ++ Attaching patch
>>
>> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find the updated patch,
>>>
>>> - Added a mechanism to check for supported minimum/maximum version
>>> and a server type in the framework.
>>>
>>
> There's still a problem with this I'm afraid - it says in the summary
> that the re_sql test cases were all skipped, which is not the case. I 
> think
> we should just skip the irrelevant tests in the re_sql module, but not 
> mark
> the entire module as being skipped:
>

> =Running the test cases for 'Regression - PG
> 11'=
>
> runTest
> (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
>
> Reverse Engineered SQL Test Cases
>
>
> Create IMPLICIT Cast
>
> Alter IMPLICIT Cast
>
> Drop IMPLICIT Cast
>
> Create EXPLICIT Cast
>
> Alter EXPLICIT Cast
>
> Drop EXPLICIT Cast
>
>  ... skipped 'Server(Type: #ppas) is not supported for the Resource
> Groups module'
>
>
> --
>
> Ran 1 test in 0.480s
>
>
> OK (skipped=1)
>
>
> ==
>
> Test Result Summary
>
> ==
>
>
> Regression - PG 11:
>
>
> 0 tests passed
>
> 0 tests failed
>
> 1 test skipped:
>
> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)
>
>
> ==
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company