Re: Feature request: Redshift Support

2019-06-30 Thread Khushboo Vashi
Hi Thomas,

On Fri, Jun 28, 2019 at 11:07 PM  wrote:

> Hi
>
> I'd like to take a moment to say that I am a huge fan of this software.
>
> I would like to suggest a feature:
> As a Postgres user I would like to use PGADMIN4 to connect to Amazon
> Redshift.
> I chose Redshift because it is pretty much Postgres (like).
>
> Please create a feature request @
https://redmine.postgresql.org/projects/pgadmin4/  we need to check the
feasibility.

Thanks,
Khushboo

All the best
> Thomas
>
>
>
> Sent from my Samsung Galaxy smartphone.
>


RE-SQL tests for Roles & Resource Group nodes

2019-06-30 Thread Murtuza Zabuawala
Hi,

PFA patch to add RE-SQL tests for Roles & Resource Group nodes.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_4415.diff
Description: Binary data


Re: [GSoC] Help with Jasmine Tests

2019-06-30 Thread Aditya Toshniwal
Hi Yosry,

On Sat, Jun 29, 2019 at 8:54 PM Yosry Muhammad  wrote:

> Hi all,
>
> I am writing tests for my initial patch of my Google Summer of Code
> project, which allows editing of SQL queries results (if they are
> updatable).
>
Please go through this page here -
https://jasmine.github.io/tutorials/your_first_suite
This will help you kick start with Jasmin test cases.

>
> I am trying to write a test for the sqleditor that checks that if
> _render() function (in sqleditor.js) is called with w query results that
> include primary keys, then the grid should be editable (I need to check
> grid options, gridView.grid.getOptions() ).
>
> I also want to check that if the user edits a cell in the grid, the Save
> Data button (new button) is enabled. Is this feasible ?
>
This is similar to what is done in -
web/regression/javascript/sqleditor/execute_query_spec.js  for btn-flash.

>
> Can anyone help me? I am new to front-end tests. In the sqleditor test I
> have seen, a spy is created for the SqlEditor to see if specific functions
> are called, but I want the actual _render() function to run (to call
> render_grid() of the gridView). In other words, I need to test the code
> inside_render() function.
>
Currently, _render is not directly testable using jasmine test cases. You
need to break down the code to make it more testable. You can read through
articles like -
https://hackernoon.com/how-to-refactor-unwieldy-untestable-code-4a73d75cb80a
to get an idea. An example in pgAdmin would be
web/pgadmin/static/js/sqleditor/execute_query.js

>
> Thanks a lot.
>
> --
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"