[pgAdmin][RM4407] White page on PG admin 4.9 when locale is French
Hi Hackers, Attached is the patch to fix an issue where the rendered utils.js breaks when locale is French. The French characters can have single quotes. Code is changed to use double quotes around the strings. The patch was sent to the user facing this, and the issue was resolved for him. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4407.patch Description: Binary data
pgAdmin 4 commit: Properly escape dragged node text. Fixes #4139
Properly escape dragged node text. Fixes #4139 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=24ec882f45b86f824545ceb4a7e4b510c35bc5d0 Author: Aditya Toshniwal Modified Files -- web/pgadmin/static/js/tree/tree.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin][RM4407] White page on PG admin 4.9 when locale is French
Thanks, applied. On Fri, Jun 28, 2019 at 7:04 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix an issue where the rendered utils.js breaks > when locale is French. The French characters can have single quotes. Code > is changed to use double quotes around the strings. > > The patch was sent to the user facing this, and the issue was resolved for > him. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix a quoting issue that caused a blank UI to be disp
Fix a quoting issue that caused a blank UI to be displayed when running in French. Fixes #4407 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64d31b9d3f128bf97ad41d6852fbc39708f7ad22 Modified Files -- docs/en_US/release_notes_4_10.rst | 3 ++- web/pgadmin/browser/templates/browser/js/utils.js | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-)
Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
Hi Hackers, Attached is the updated patch to fix the review comments of trailing mail. Kindly review. On Thu, Jun 27, 2019 at 4:49 PM Dave Page wrote: > Hi > > On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: >> >>> Hi >>> >>> Something isn't working correctly - I turned on the summary option, and >>> this is the query that was run when I hit the EXPLAIN button: >>> >>> EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING >>> False,SUMMARY False,BUFFERS False) select * from pg_tables >>> >> >>> Aside from the formatting (s/True/true, s/False/false, missing spaces >>> etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle >>> caches, rebundled etc. >>> >> I think I misunderstood the documents - >> https://www.postgresql.org/docs/12/sql-explain.html. Few of the >> parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will >> make the changes, along with formatting to existing codes as well. >> > > I'm not sure that explains why the summary option is set to *false* for an > EXPLAIN action, but anyway, please make sure it works :-) > > >> >>> Shouldn't there also be documentation updates? >>> >> Yeah. (I always miss that :/) >> >>> >>> On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+) explain options. These options will be visible only if version is supported. I have also created and fixed RM4395. The explain options changed on one query tool should not change explain options on other query tools or preferences. The initial values will be taken from preferences are usual. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4335_4395_v2.patch Description: Binary data
pgAdmin 4 commit: Update version for release
Update version for release Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=252429df50a27a7a6499358441f703463dbac796 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
pgAdmin 4 commit: update the release date and message catalogs
update the release date and message catalogs Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6c6b4a15abbc82636a22126ae15f891001ca71d Modified Files -- docs/en_US/release_notes_4_10.rst |2 +- web/pgadmin/messages.pot | 212 ++-- .../translations/de/LC_MESSAGES/messages.mo| Bin 150140 -> 150172 bytes .../translations/de/LC_MESSAGES/messages.po| 212 ++-- .../translations/es/LC_MESSAGES/messages.mo| Bin 154783 -> 154815 bytes .../translations/es/LC_MESSAGES/messages.po| 212 ++-- .../translations/fr/LC_MESSAGES/messages.mo| Bin 170745 -> 159753 bytes .../translations/fr/LC_MESSAGES/messages.po| 1243 ++-- .../translations/ja/LC_MESSAGES/messages.mo| Bin 166501 -> 166533 bytes .../translations/ja/LC_MESSAGES/messages.po| 212 ++-- .../translations/ko/LC_MESSAGES/messages.mo| Bin 152447 -> 152479 bytes .../translations/ko/LC_MESSAGES/messages.po| 212 ++-- .../translations/pl/LC_MESSAGES/messages.mo| Bin 150167 -> 150199 bytes .../translations/pl/LC_MESSAGES/messages.po| 212 ++-- .../translations/ru/LC_MESSAGES/messages.mo| Bin 186363 -> 186395 bytes .../translations/ru/LC_MESSAGES/messages.po| 212 ++-- .../translations/zh/LC_MESSAGES/messages.mo| Bin 138274 -> 138306 bytes .../translations/zh/LC_MESSAGES/messages.po| 663 +-- 18 files changed, 1727 insertions(+), 1665 deletions(-)
pgAdmin4 v4.10 candidate builds
Hi All, Due to an showstopper issue found in pgAdmin v4.9, we will have to release pgAdmin4 v4.10 early. Candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-06-28-1/ Fahar, can you please verify it for release on Tuesday (2nd July). -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
Hi On Fri, Jun 28, 2019 at 9:27 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to fix the review comments of trailing mail. > Kindly review. > So where is the summary supposed to be displayed? It's now requesting it from the server, and it's in the JSON response, but isn't displayed anywhere that I can see. > > On Thu, Jun 27, 2019 at 4:49 PM Dave Page wrote: > >> Hi >> >> On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: >>> Hi Something isn't working correctly - I turned on the summary option, and this is the query that was run when I hit the EXPLAIN button: EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING False,SUMMARY False,BUFFERS False) select * from pg_tables >>> Aside from the formatting (s/True/true, s/False/false, missing spaces etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle caches, rebundled etc. >>> I think I misunderstood the documents - >>> https://www.postgresql.org/docs/12/sql-explain.html. Few of the >>> parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will >>> make the changes, along with formatting to existing codes as well. >>> >> >> I'm not sure that explains why the summary option is set to *false* for >> an EXPLAIN action, but anyway, please make sure it works :-) >> >> >>> Shouldn't there also be documentation updates? >>> Yeah. (I always miss that :/) >>> On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add support for SETTINGS(v12+) and > SUMMARY(v10+) explain options. These options will be visible only if > version is supported. > > I have also created and fixed RM4395. The explain options changed on > one query tool should not change explain options on other query tools or > preferences. The initial values will be taken from preferences are usual. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Feature request: Redshift Support
Hi I'd like to take a moment to say that I am a huge fan of this software. I would like to suggest a feature: As a Postgres user I would like to use PGADMIN4 to connect to Amazon Redshift. I chose Redshift because it is pretty much Postgres (like). All the best Thomas Sent from my Samsung Galaxy smartphone.
