Getting Involved
Hello, I am currently a college student studying computer science who is interested in getting involved with the pgadmin community. Is there any particular functionality or anything I can do to get started and contribute? Best Regards, Alex Kim
Re: Getting Involved
Hi Alex, On Wed, Jun 26, 2019 at 1:29 PM Alex Kim wrote: > Hello, > > I am currently a college student studying computer science who is > interested in getting involved with the pgadmin community. Is there any > particular functionality or anything I can do to get started and contribute? > > Please refer the pgAdmin 4 Redmine board https://redmine.postgresql.org/projects/pgadmin4/issues. You can start with any small issue you are comfortable with. If you are good at the frontend then pick any UI related small issue. Please go through the project contribution guide https://www.pgadmin.org/docs/pgadmin4/dev/contributions.html to have more idea about the coding standard and all. Thanks, Khushboo Best Regards, > Alex Kim >
Re: [GSoC][Patch] Automatic Mode Detection V1
Hi,
On Wed, Jun 26, 2019 at 10:35 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Yosry,
>
> On Tue, Jun 25, 2019 at 8:46 PM Yosry Muhammad wrote:
>
>> Hi,
>>
>>
>> OK. Yosry, How about storing the mogirfied query in the cookie/session
>>> when the query is executed and then modifying query history storing logic
>>> to use it when called ? This way you will not need to change any parsing
>>> when query history is displayed.
>>>
--
>>>
>> My problem is not where to store the mogrified query, I can just replace
>> the sql sent with the response to saving the data with the mogrified one.
>> In order to produce the mogrified query in the first place I need a
>> psycopg2.cursor object, but I only have access to a Connection object (the
>> wrapper, not the actual psycopg2.connection object). Should I modify that
>> wrapper Connection class to add a mogirfy function? or just get a cursor
>> using the psycopg2.connection object like this: conn.conn.cursor() - which
>> doesn't seem right. Thoughts?
>>
> That would be the way. But I think
> web/pgadmin/utils/driver/psycopg2/cursor.py will be corrrect place to add
> the mogrify function. Please note, psycopg2 does not support (,),% in the
> parameter names. So if the column names has any of these characters,
> mogrify might fail. Although it is handled with pgadmin_alias (line 493 -
> web/pgadmin/tools/sqleditor/__init__.py), please test this case as well.
>
You can also get the last executed SQL in psycopg2 -
http://initd.org/psycopg/docs/cursor.html#cursor.query. May be this can be
used.
>
>> Also, could you please help me with the selenium TimeoutException in the
>> feature tests? 3 tests are failing because of that exception and I am not
>> sure what is it related to. I am attaching the feature test log file in
>> this email if you would like to take a look on it.
>>
> Can you check on latest chrome and chromdriver. You can check the
> chromedriver version as below. Your venv should have the chromedriver
> binary.
>
> (pypg37) laptop207:pgadmin4 adityatoshniwal$ chromedriver --version
> ChromeDriver 75.0.3770.8
> (681f24ea911fe754973dda2fdc6d2a2e159dd300-refs/branch-heads/3770@{#40})
>
>>
>> Thanks !
>>
>>
>> --
>> *Yosry Muhammad Yosry*
>>
>> Computer Engineering student,
>> The Faculty of Engineering,
>> Cairo University (2021).
>> Class representative of CMP 2021.
>> https://www.linkedin.com/in/yosrym93/
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Re: [GSoC][Patch] Automatic Mode Detection V1
Hi On Tue, Jun 25, 2019 at 11:20 AM Yosry Muhammad wrote: > > > On Tue, Jun 25, 2019 at 1:09 PM Dave Page wrote: > >> >> - What else is missing from this patch to make it applicable ? I would like to produce a release-ready patch if possible. If so, I can continue working on the project on following patches, I just want to know what is the minimum amount of work needed to make this patch release-ready (especially that changes are being made in the master branch that require me to re-edit parts of the code that I have written before to keep things in-sync). >>> @Dave Page is the right person to answer this. >>> >> >> It needs: >> >> - A code complete feature (or infrastructure/refactoring ready for a >> feature), that is acceptable to us. Seems like this is 90% there for an >> initial commit. >> - Documentation updates. >> - Tests for the new feature to ensure it works without needing manual >> testing. >> - To pass all existing tests (which may be modified if appropriate). >> >> > > Could you tell me what is missing from this patch (in terms of features - > other than tests) to be acceptable? I will start working on the tests once > the patch is complete. The patch passes all the existing tests except for 3 > feature tests that fail due to a TimeoutException in selenium. I do not > know what this is about I hope Aditya will help me with it. > Here are the issues I think should be fixed first: - I think the Save button should be moved to the left of the Find button. It makes more sense to be near the Save Query button. - Umm, that's about it, bar the history issue. The quick fix there might be to hide the internal queries for now as previously discussed, but I do this the checkbox to include them (in their mogrified state) should be included as part of the overall project. Note that I haven't done in-depth testing. Once the patch is committed (and about now is a good time, as we're at the beginning of the release cycle), we'll get our QA guy to see if he can find any issues we've missed. > > Also, do you mean code documentation or documentation for the users? Could > you point me towards the related parts? > User documentation. I would expect at least one screenshot update due to the new button on the toolbar (probably more - please check for others that need updating), as well as updates to at least: editgrid.rst query_tool.rst query_tool_toolbar.rst Great work! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
Hi On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow tree nodes to be dragged and dropped in > query editor wherever you take the drop cursor. The drop text will be fully > qualified and double quoted if required. > For functions/procedures it will drop the the label stripping away the > parameter names, with empty pair of round brackets. It will also set the > focus cursor inside the brackets if there were params otherwiser to the end > of text. > For adding a node type, you need to register it in browser.js along with a > callback function which will return drop text along with cursor positioning > and selection. Currently, I have registered for "table partition type > sequence package view mview foreign_table edbvar schema column edbfunc > function edbproc procedure". > > Please note, the drag design customisation is not supported in IE. > I think for functions/procedures, we should include placeholders for the parameters, so the user has a hint about what they need to fill in to complete the call. Also; shouldn't there be a doc update? Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
Hi, On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: > Hi > > On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to allow tree nodes to be dragged and dropped in >> query editor wherever you take the drop cursor. The drop text will be fully >> qualified and double quoted if required. >> For functions/procedures it will drop the the label stripping away the >> parameter names, with empty pair of round brackets. It will also set the >> focus cursor inside the brackets if there were params otherwiser to the end >> of text. >> For adding a node type, you need to register it in browser.js along with >> a callback function which will return drop text along with cursor >> positioning and selection. Currently, I have registered for "table >> partition type sequence package view mview foreign_table edbvar schema >> column edbfunc function edbproc procedure". >> >> Please note, the drag design customisation is not supported in IE. >> > > I think for functions/procedures, we should include placeholders for the > parameters, so the user has a hint about what they need to fill in to > complete the call. > I can fill in the parameter names same as tree node, with cursor selection on all the params ? > > Also; shouldn't there be a doc update? > Yeah :/ Should there be any screenshots ? > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
On Wed, Jun 26, 2019 at 7:28 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to allow tree nodes to be dragged and dropped in >>> query editor wherever you take the drop cursor. The drop text will be fully >>> qualified and double quoted if required. >>> For functions/procedures it will drop the the label stripping away the >>> parameter names, with empty pair of round brackets. It will also set the >>> focus cursor inside the brackets if there were params otherwiser to the end >>> of text. >>> For adding a node type, you need to register it in browser.js along with >>> a callback function which will return drop text along with cursor >>> positioning and selection. Currently, I have registered for "table >>> partition type sequence package view mview foreign_table edbvar schema >>> column edbfunc function edbproc procedure". >>> >>> Please note, the drag design customisation is not supported in IE. >>> >> >> I think for functions/procedures, we should include placeholders for the >> parameters, so the user has a hint about what they need to fill in to >> complete the call. >> > I can fill in the parameter names same as tree node, with cursor selection > on all the params ? > Can you select the first one, and put the cursor in front of it? > >> Also; shouldn't there be a doc update? >> > Yeah :/ > Should there be any screenshots ? > I don't see much need. Thanks. > >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
Hi, On Wed, Jun 26, 2019 at 5:06 PM Dave Page wrote: > > > On Wed, Jun 26, 2019 at 7:28 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch to allow tree nodes to be dragged and dropped in query editor wherever you take the drop cursor. The drop text will be fully qualified and double quoted if required. For functions/procedures it will drop the the label stripping away the parameter names, with empty pair of round brackets. It will also set the focus cursor inside the brackets if there were params otherwiser to the end of text. For adding a node type, you need to register it in browser.js along with a callback function which will return drop text along with cursor positioning and selection. Currently, I have registered for "table partition type sequence package view mview foreign_table edbvar schema column edbfunc function edbproc procedure". Please note, the drag design customisation is not supported in IE. >>> >>> I think for functions/procedures, we should include placeholders for the >>> parameters, so the user has a hint about what they need to fill in to >>> complete the call. >>> >> I can fill in the parameter names same as tree node, with cursor >> selection on all the params ? >> > > Can you select the first one, and put the cursor in front of it? > Yes. Will do that. So that, just after drop if the user types anything it will replace the first param name. > > >> >>> Also; shouldn't there be a doc update? >>> >> Yeah :/ >> Should there be any screenshots ? >> > > I don't see much need. > Cool. > > Thanks. > > >> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
On Wed, Jun 26, 2019 at 7:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 26, 2019 at 5:06 PM Dave Page wrote: > >> >> >> On Wed, Jun 26, 2019 at 7:28 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: >>> Hi On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow tree nodes to be dragged and dropped in > query editor wherever you take the drop cursor. The drop text will be > fully > qualified and double quoted if required. > For functions/procedures it will drop the the label stripping away the > parameter names, with empty pair of round brackets. It will also set the > focus cursor inside the brackets if there were params otherwiser to the > end > of text. > For adding a node type, you need to register it in browser.js along > with a callback function which will return drop text along with cursor > positioning and selection. Currently, I have registered for "table > partition type sequence package view mview foreign_table edbvar schema > column edbfunc function edbproc procedure". > > Please note, the drag design customisation is not supported in IE. > I think for functions/procedures, we should include placeholders for the parameters, so the user has a hint about what they need to fill in to complete the call. >>> I can fill in the parameter names same as tree node, with cursor >>> selection on all the params ? >>> >> >> Can you select the first one, and put the cursor in front of it? >> > Yes. Will do that. So that, just after drop if the user types anything it > will replace the first param name. > Right. > >> >>> Also; shouldn't there be a doc update? >>> Yeah :/ >>> Should there be any screenshots ? >>> >> >> I don't see much need. >> > Cool. > :-) > >> Thanks. >> >> >>> Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
[pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
Hi Hackers, Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+) explain options. These options will be visible only if version is supported. I have also created and fixed RM4395. The explain options changed on one query tool should not change explain options on other query tools or preferences. The initial values will be taken from preferences are usual. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4335_4395.patch Description: Binary data
Re: [GSoC][Patch] Automatic Mode Detection V1
Hi, On Wed, Jun 26, 2019 at 1:01 PM Dave Page wrote: > > >>> - What else is missing from this patch to make it applicable ? I would > like to produce a release-ready patch if possible. If so, I can continue > working on the project on following patches, I just want to know what is > the minimum amount of work needed to make this patch release-ready > (especially that changes are being made in the master branch that require > me to re-edit parts of the code that I have written before to keep things > in-sync). > @Dave Page is the right person to answer this. >>> >>> It needs: >>> >>> - A code complete feature (or infrastructure/refactoring ready for a >>> feature), that is acceptable to us. Seems like this is 90% there for an >>> initial commit. >>> - Documentation updates. >>> - Tests for the new feature to ensure it works without needing manual >>> testing. >>> - To pass all existing tests (which may be modified if appropriate). >>> >>> >> >> Could you tell me what is missing from this patch (in terms of features - >> other than tests) to be acceptable? I will start working on the tests once >> the patch is complete. The patch passes all the existing tests except for 3 >> feature tests that fail due to a TimeoutException in selenium. I do not >> know what this is about I hope Aditya will help me with it. >> > > Here are the issues I think should be fixed first: > > - I think the Save button should be moved to the left of the Find button. > It makes more sense to be near the Save Query button. > > - Umm, that's about it, bar the history issue. The quick fix there might > be to hide the internal queries for now as previously discussed, but I do > this the checkbox to include them (in their mogrified state) should be > included as part of the overall project. > > Note that I haven't done in-depth testing. Once the patch is committed > (and about now is a good time, as we're at the beginning of the release > cycle), we'll get our QA guy to see if he can find any issues we've missed. > > >> >> Also, do you mean code documentation or documentation for the users? >> Could you point me towards the related parts? >> > > User documentation. I would expect at least one screenshot update due to > the new button on the toolbar (probably more - please check for others that > need updating), as well as updates to at least: > > editgrid.rst > query_tool.rst > query_tool_toolbar.rst > > Great work! > > I will disable the generated queries for now, then for the next patch I will work on (optionally) including them (mogrified). Should I send a patch with the completed work then start working on the tests and documentation (for it to get reviewed)? or wait until the patch is complete with tests and documentation? Thanks all ! -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/
Re: [GSoC][Patch] Automatic Mode Detection V1
On Wed, Jun 26, 2019 at 11:46 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
> On Wed, Jun 26, 2019 at 10:35 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>>
>> My problem is not where to store the mogrified query, I can just replace
>>> the sql sent with the response to saving the data with the mogrified one.
>>> In order to produce the mogrified query in the first place I need a
>>> psycopg2.cursor object, but I only have access to a Connection object (the
>>> wrapper, not the actual psycopg2.connection object). Should I modify that
>>> wrapper Connection class to add a mogirfy function? or just get a cursor
>>> using the psycopg2.connection object like this: conn.conn.cursor() - which
>>> doesn't seem right. Thoughts?
>>>
>> That would be the way. But I think
>> web/pgadmin/utils/driver/psycopg2/cursor.py will be corrrect place to add
>> the mogrify function. Please note, psycopg2 does not support (,),% in
>> the parameter names. So if the column names has any of these characters,
>> mogrify might fail. Although it is handled with pgadmin_alias (line 493
>> - web/pgadmin/tools/sqleditor/__init__.py), please test this case as well.
>>
> You can also get the last executed SQL in psycopg2 -
> http://initd.org/psycopg/docs/cursor.html#cursor.query. May be this can
> be used.
>
The cursor wrapper class (DictCursor) is exclusively used by the connection
wrapper class (at web/pgadmin/utils/driver/psycopg2/connection.py) as a
cursor factory. I think the mogrify function will need to be implemented in
both classes, as the Connection class is the one that is used throughout
the code - no code uses cursors directly. What do you think?
The use of cursor.query will not be possible as this is a property of the
cursor, not the connection. I will need to call cursor.query on the exact
cursor that was used to execute the query, which is not accessible in this
case.
Thanks a lot for your help !
>>> Also, could you please help me with the selenium TimeoutException in the
>>> feature tests? 3 tests are failing because of that exception and I am not
>>> sure what is it related to. I am attaching the feature test log file in
>>> this email if you would like to take a look on it.
>>>
>> Can you check on latest chrome and chromdriver. You can check the
>> chromedriver version as below. Your venv should have the chromedriver
>> binary.
>>
>> (pypg37) laptop207:pgadmin4 adityatoshniwal$ chromedriver --version
>> ChromeDriver 75.0.3770.8
>> (681f24ea911fe754973dda2fdc6d2a2e159dd300-refs/branch-heads/3770@{#40})
>>
>>>
>>>
>>>
The version I have is actually 75.0.3770.90. Could the more recent version
be causing the problem ?
Thanks and regards.
--
*Yosry Muhammad Yosry*
Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
https://www.linkedin.com/in/yosrym93/
Re: [GSoC][Patch] Automatic Mode Detection V1
Hi On Wed, Jun 26, 2019 at 8:20 AM Yosry Muhammad wrote: > Hi, > > On Wed, Jun 26, 2019 at 1:01 PM Dave Page wrote: > >> >> - What else is missing from this patch to make it applicable ? I would >> like to produce a release-ready patch if possible. If so, I can continue >> working on the project on following patches, I just want to know what is >> the minimum amount of work needed to make this patch release-ready >> (especially that changes are being made in the master branch that require >> me to re-edit parts of the code that I have written before to keep things >> in-sync). >> > @Dave Page is the right person to answer this. > It needs: - A code complete feature (or infrastructure/refactoring ready for a feature), that is acceptable to us. Seems like this is 90% there for an initial commit. - Documentation updates. - Tests for the new feature to ensure it works without needing manual testing. - To pass all existing tests (which may be modified if appropriate). >>> >>> Could you tell me what is missing from this patch (in terms of features >>> - other than tests) to be acceptable? I will start working on the tests >>> once the patch is complete. The patch passes all the existing tests except >>> for 3 feature tests that fail due to a TimeoutException in selenium. I do >>> not know what this is about I hope Aditya will help me with it. >>> >> >> Here are the issues I think should be fixed first: >> >> - I think the Save button should be moved to the left of the Find button. >> It makes more sense to be near the Save Query button. >> >> - Umm, that's about it, bar the history issue. The quick fix there might >> be to hide the internal queries for now as previously discussed, but I do >> this the checkbox to include them (in their mogrified state) should be >> included as part of the overall project. >> >> Note that I haven't done in-depth testing. Once the patch is committed >> (and about now is a good time, as we're at the beginning of the release >> cycle), we'll get our QA guy to see if he can find any issues we've missed. >> >> >>> >>> Also, do you mean code documentation or documentation for the users? >>> Could you point me towards the related parts? >>> >> >> User documentation. I would expect at least one screenshot update due to >> the new button on the toolbar (probably more - please check for others that >> need updating), as well as updates to at least: >> >> editgrid.rst >> query_tool.rst >> query_tool_toolbar.rst >> >> Great work! >> >> > I will disable the generated queries for now, then for the next patch I > will work on (optionally) including them (mogrified). Should I send a patch > with the completed work then start working on the tests and documentation > (for it to get reviewed)? or wait until the patch is complete with tests > and documentation? > We always want to commit the docs and tests along with the code so we don't get in a situation where they later get missed or omitted. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
Hi Something isn't working correctly - I turned on the summary option, and this is the query that was run when I hit the EXPLAIN button: EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING False,SUMMARY False,BUFFERS False) select * from pg_tables Aside from the formatting (s/True/true, s/False/false, missing spaces etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle caches, rebundled etc. Shouldn't there also be documentation updates? On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+) > explain options. These options will be visible only if version is supported. > > I have also created and fixed RM4395. The explain options changed on one > query tool should not change explain options on other query tools or > preferences. The initial values will be taken from preferences are usual. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Getting Involved
Hi Khushboo, Thank you very much! On Wed, Jun 26, 2019 at 2:11 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Alex, > > On Wed, Jun 26, 2019 at 1:29 PM Alex Kim wrote: > >> Hello, >> >> I am currently a college student studying computer science who is >> interested in getting involved with the pgadmin community. Is there any >> particular functionality or anything I can do to get started and contribute? >> >> Please refer the pgAdmin 4 Redmine board > https://redmine.postgresql.org/projects/pgadmin4/issues. > You can start with any small issue you are comfortable with. > If you are good at the frontend then pick any UI related small issue. > > Please go through the project contribution guide > https://www.pgadmin.org/docs/pgadmin4/dev/contributions.html to have more > idea about the coding standard and all. > > Thanks, > Khushboo > > Best Regards, >> Alex Kim >> >
Re: Getting Involved
On Thu, Jun 27, 2019 at 1:00 AM Alex Kim wrote: > Hi Khushboo, > > Thank you very much! > > You are welcome. Please make sure to change the status of the task to IN PROGRESS on which you will start working. > On Wed, Jun 26, 2019 at 2:11 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Alex, >> >> On Wed, Jun 26, 2019 at 1:29 PM Alex Kim wrote: >> >>> Hello, >>> >>> I am currently a college student studying computer science who is >>> interested in getting involved with the pgadmin community. Is there any >>> particular functionality or anything I can do to get started and contribute? >>> >>> Please refer the pgAdmin 4 Redmine board >> https://redmine.postgresql.org/projects/pgadmin4/issues. >> You can start with any small issue you are comfortable with. >> If you are good at the frontend then pick any UI related small issue. >> >> Please go through the project contribution guide >> https://www.pgadmin.org/docs/pgadmin4/dev/contributions.html to have >> more idea about the coding standard and all. >> >> Thanks, >> Khushboo >> >> Best Regards, >>> Alex Kim >>> >>
Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
Hi, On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: > Hi > > Something isn't working correctly - I turned on the summary option, and > this is the query that was run when I hit the EXPLAIN button: > > EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING > False,SUMMARY False,BUFFERS False) select * from pg_tables > > Aside from the formatting (s/True/true, s/False/false, missing spaces > etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle > caches, rebundled etc. > I think I misunderstood the documents - https://www.postgresql.org/docs/12/sql-explain.html. Few of the parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will make the changes, along with formatting to existing codes as well. > > Shouldn't there also be documentation updates? > Yeah. (I always miss that :/) > > On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+) >> explain options. These options will be visible only if version is supported. >> >> I have also created and fixed RM4395. The explain options changed on one >> query tool should not change explain options on other query tools or >> preferences. The initial values will be taken from preferences are usual. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
