[pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-13 Thread Akshay Joshi
Hi Hackers

I have implemented the new test framework to test the Reverse Engineering
SQL. I have integrated it as a part of API/Regression test suite. It will
work when we run all the test cases or module wise test case.

*How it works*: Attached patch contains the generic framework to read all
the JSON files from the *tests->version based (example 9.6_plus, 10_plus or
default) folder. *Run all the test scenarios present in the JSON file in
sequential order.

Format of the JSON file is mentioned in
"web/pgadmin/browser/server_groups/servers/databases/casts/tests/default/test.json"

For expected SQL we will have following two options:

   - Provide the expected sql in scenario itself as parameter *"expected_sql"
   : ""*.
   - Create a output file with any name in the same directory where the
   JSON file resides and specify the parameter "*expected_sql_file": ""*

Attached patch contains both the above mentioned examples.

Please review it.

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Test_Re_SQL.patch
Description: Binary data


pgAdmin 4 commit: Fix syntax error for Default value of column. It is a

2019-06-13 Thread Akshay Joshi
Fix syntax error for Default value of column. It is a regression of #4253

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=04328b76bab8cb56d80c9aaf47fbbc3160bf76f4

Modified Files
--
.../databases/schemas/tables/templates/tables/sql/10_plus/create.sql| 2 +-
.../databases/schemas/tables/templates/tables/sql/12_plus/create.sql| 2 +-
.../databases/schemas/tables/templates/tables/sql/default/create.sql| 2 +-
.../schemas/tables/templates/tables/sql/gpdb_5.0_plus/create.sql| 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)



Re: [pgAdmin][RM4357] Connection restoration issue after restart and refresh pgadmin page

2019-06-13 Thread Akshay Joshi
Thanks patch applied.

On Thu, Jun 13, 2019 at 11:53 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix connection restoration issue when pgAdmin
> server is restarted and the page is refreshed. Note that, this happens when
> master password is disabled.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Fix connection restoration issue when pgAdmin server

2019-06-13 Thread Akshay Joshi
Fix connection restoration issue when pgAdmin server is restarted and the page 
is refreshed. Fixes #4357

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82bd94e696408005ba45aff7d880ec35e7ebaa09
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_9.rst  | 3 ++-
web/pgadmin/utils/driver/psycopg2/__init__.py | 9 +
2 files changed, 7 insertions(+), 5 deletions(-)