Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-28 Thread Aditya Toshniwal
Hi,

On Thu, May 23, 2019 at 1:31 PM Dave Page  wrote:

> Hi,
>
> On further testing, this doesn't seem to be working as expected.
> Alt+Shift+] or [ in the query tool are typing ’ and ” and not changing the
> tab. If I switch to a non-input tab (e.g. History), they still don't work.
>
I am not able to simulate the quotes problem, but I have made a few
corrections to fix the switching.
Attached is the updated patch, kindly review.

>
> Alt+Shift+Tab changes the panel successfully though, and does cause the
> flash as expected.
>
> I'm using Chrome 74.0.3729.131 on Mojave.
>
> On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Attached is the updated patch with doc changes.
>>
>> On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> On Tue, May 21, 2019 at 5:32 PM Dave Page  wrote:
>>>
 Hi

 On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the accessibility issue in query tool.
>
> The query tool can be completely restructured unlike previously where
> query tool used to stick at top and other tabs in the bottom.
> - I have added a new shortcut to switch between frames if in query
> tool the tab positions are changed. On switching the frames, the frame 
> will
> blink to show it is focussed.
> - In the frame, you can switch tab same as previous. The tabs in SQL
> editor are cyclic now, which means if you execute shortcut to go right on
> the last tab then it will cycle to first tab.
> - I have also changed the default shortcut to switch between tabs from
> Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we have in
> browser tabs.
> - Similar changes done for debugger also.
>

 Shouldn't there be documentation changes to go with this?

>>> Yes, definitely :P
>>> Will send the updated patch.
>>>

 Otherwise, it seems to work :-)

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM4195_v3.patch
Description: Binary data


pgAdmin4 v4.7 candidate builds

2019-05-28 Thread Akshay Joshi
Hi All,

pgAdmin4 v4.7 candidate builds and source can be found at https://developer.
pgadmin.org/builds/2019-05-28-1/

Fahar, can you please verify it for release on Thursday.

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Japanese translation (June 2019)

2019-05-28 Thread fn ln
Hello.
Updated translation for version 4.7 is in attachment.
messages.pot was taken from git a936f708.


pgadmin4-ja-jun2019.7z
Description: Binary data


Re: pgAdmin4 v4.7 candidate builds

2019-05-28 Thread Fahar Abbas
Hi Akshay,

Here is the showstopper issue:
https://redmine.postgresql.org/issues/4298

On Tue, May 28, 2019 at 1:53 PM Akshay Joshi 
wrote:

> Hi All,
>
> pgAdmin4 v4.7 candidate builds and source can be found at
> https://developer.pgadmin.org/builds/2019-05-28-1/
>
> Fahar, can you please verify it for release on Thursday.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: *live:fahar.abbas*
Website: www.enterprisedb.com


pgAdmin 4 commit: Fix fatal error on launch of pgAdmin4. Fixes #4298

2019-05-28 Thread Akshay Joshi
Fix fatal error on launch of pgAdmin4. Fixes #4298

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9fdf68d55965592117e972a8c7726bcaa64b8fd7
Author: Ashesh Vashi 

Modified Files
--
web/pgadmin/misc/__init__.py | 2 ++
1 file changed, 2 insertions(+)



pgAdmin 4 commit: Update Japanese translation.

2019-05-28 Thread Akshay Joshi
Update Japanese translation.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12186a0fd6329c964313bbe961633627f8dda1dd
Author: Identifier Anonymous 

Modified Files
--
.../translations/ja/LC_MESSAGES/messages.mo| Bin 165355 -> 165727 bytes
.../translations/ja/LC_MESSAGES/messages.po|  32 +++--
2 files changed, 17 insertions(+), 15 deletions(-)



Re: Japanese translation (June 2019)

2019-05-28 Thread Akshay Joshi
Thanks patch applied.

On Tue, May 28, 2019 at 4:06 PM fn ln  wrote:

> Hello.
> Updated translation for version 4.7 is in attachment.
> messages.pot was taken from git a936f708.
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


French translation for 4.7

2019-05-28 Thread fred . escallier

hi 
...and here the fr updated from messages.pot taken from git a936f708 . 
Fred 



messages.tar.xz
Description: application/xz-compressed-tar


Re: pgAdmin4 v4.7 candidate builds

2019-05-28 Thread Akshay Joshi
Hi All,

On Tue, May 28, 2019 at 4:16 PM Fahar Abbas 
wrote:

> Hi Akshay,
>
> Here is the showstopper issue:
> https://redmine.postgresql.org/issues/4298
>

   Issue has been fixed. New installers and source can be found
https://developer.pgadmin.org/builds/2019-05-28-2/
   Please verify it for release.


> On Tue, May 28, 2019 at 1:53 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All,
>>
>> pgAdmin4 v4.7 candidate builds and source can be found at
>> https://developer.pgadmin.org/builds/2019-05-28-1/
>>
>> Fahar, can you please verify it for release on Thursday.
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Fahar Abbas
> QMG
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803
> Mobile: +92-333-5409707
> Skype ID: *live:fahar.abbas*
> Website: www.enterprisedb.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Doc builds now need the cryptography module.

2019-05-28 Thread Dave Page
Doc builds now need the cryptography module.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=91595593d3fad315c24b67ff1298f1742507d642

Modified Files
--
pkg/docker/Dockerfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Looks like we also need build tools for the cryptogra

2019-05-28 Thread Dave Page
Looks like we also need build tools for the cryptography module.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=307637b96958c2d4ac7136778b7b3ba10508edd4

Modified Files
--
pkg/docker/Dockerfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Argh, they are Alpine packages, not Python.

2019-05-28 Thread Dave Page
Argh, they are Alpine packages, not Python.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=991f667f9fa7d08bada2f6f9d35e08d69f4e9439

Modified Files
--
pkg/docker/Dockerfile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



pgAdmin 4 commit: build-deps doesn't exist any more.

2019-05-28 Thread Dave Page
build-deps doesn't exist any more.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f340cd044b32ba01db9a69283b032cf085a64108

Modified Files
--
pkg/docker/Dockerfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Also need openssl-dev

2019-05-28 Thread Dave Page
Also need openssl-dev

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2fa849dc2611d5a72a2c8030b204d9233e8143ee

Modified Files
--
pkg/docker/Dockerfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Update French translation.

2019-05-28 Thread Akshay Joshi
Update French translation.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dad0d690db646ed09a8c531b275e7d89750080a8
Author: Fred Escallier 

Modified Files
--
.../translations/fr/LC_MESSAGES/messages.mo|  Bin 158720 -> 170020 bytes
.../translations/fr/LC_MESSAGES/messages.po| 1068 ++--
2 files changed, 513 insertions(+), 555 deletions(-)



Re: French translation for 4.7

2019-05-28 Thread Akshay Joshi
Thanks patch applied.

On Tue, May 28, 2019 at 5:28 PM  wrote:

> hi
> ...and here the fr updated from messages.pot taken from git a936f708.
> Fred
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*