pgAdmin 4 commit: Urgh. Typo.

2019-04-21 Thread Aditya Toshniwal
Urgh. Typo.

(cherry picked from commit 4ac064de42e80cc8313900eab51567011c9cb0b0)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31d62e5c41b69b3edbe7e5d288fe40021f3955ae
Author: Dave Page 

Modified Files
--
web/pgadmin/setup/tests/test_permissions.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Depend on psycopg2-binary in the Python wheel, rather

2019-04-21 Thread Aditya Toshniwal
Depend on psycopg2-binary in the Python wheel, rather than psycopg2. Fixes #4165

(cherry picked from commit ded446fe8aedfea9d7f2cb7c8a804cc48424d591)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=00699f09f103c2a9b1cb9c39b869235bcd9ffa47
Author: Dave Page 

Modified Files
--
docs/en_US/release_notes_4_6.rst | 1 +
pkg/pip/setup_pip.py | 5 +
2 files changed, 6 insertions(+)



pgAdmin 4 commit: Fix skip on Windows.

2019-04-21 Thread Aditya Toshniwal
Fix skip on Windows.

(cherry picked from commit 94e1820ccdd23daa88aaf8782d2013af4d354ef4)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f166a8830f1637e40661efd4588320ce872ccfb4
Author: Dave Page 

Modified Files
--
web/pgadmin/setup/tests/test_permissions.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Add tests for the CSV download.

2019-04-21 Thread Aditya Toshniwal
Add tests for the CSV download.

(cherry picked from commit a25bb2b7db72799cf97523d0bdca67a3e1bc7e92)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac86f786b98f2143b87e6f7b5b77100fc2e5ebce
Author: Murtuza Zabuawala 

Modified Files
--
.../tests/test_download_csv_query_tool.py  | 135 +
1 file changed, 135 insertions(+)



pgAdmin 4 commit: Ensure sanity of the permissions on the storage and s

2019-04-21 Thread Aditya Toshniwal
Ensure sanity of the permissions on the storage and session directories and the 
config database. Fixes #4182

(cherry picked from commit d728ee7436be86917f3cfac1c7f109ed521b1fe4)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9dba0ad58ebb5a0b6acec4d9b6d2b2651e02ddd
Author: Dave Page 

Modified Files
--
docs/en_US/release_notes_4_6.rst|  3 ++-
web/pgadmin/__init__.py |  2 ++
web/pgadmin/setup/data_directory.py |  2 ++
web/pgadmin/setup/tests/test_permissions.py | 35 +
web/setup.py|  2 ++
5 files changed, 43 insertions(+), 1 deletion(-)



pgAdmin 4 commit: Ensure that confirmation dialog should be popped up b

2019-04-21 Thread Aditya Toshniwal
Ensure that confirmation dialog should be popped up before reload of query tool 
or debugger
if it is opened in a new browser tab. Fixes #4101

(cherry picked from commit 49b318c39e932b81472f2b186c3d242fedd41f2d)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cef12fde73c0e9159fa66152412a05ee23bd1095

Modified Files
--
docs/en_US/release_notes_4_6.rst   |  1 +
web/pgadmin/browser/static/js/browser.js   |  9 ++--
web/pgadmin/tools/datagrid/__init__.py |  2 +-
web/pgadmin/tools/datagrid/static/js/datagrid.js   |  2 +-
.../tools/datagrid/templates/datagrid/index.html   | 22 +++-
web/pgadmin/tools/debugger/static/js/debugger.js   | 12 +--
.../tools/debugger/templates/debugger/direct.html  | 24 +-
7 files changed, 52 insertions(+), 20 deletions(-)



pgAdmin 4 commit: Skip the permissions test on Windows which doesn't su

2019-04-21 Thread Aditya Toshniwal
Skip the permissions test on Windows which doesn't support Unix style file 
permissions.

(cherry picked from commit 2ef71cf7495c6724bf27ff24bab35aa34678fe3d)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=901b1badad5f1c06cbd4c96f8f9d76a1028c178a
Author: Dave Page 

Modified Files
--
web/pgadmin/setup/tests/test_permissions.py | 5 +
1 file changed, 5 insertions(+)



pgAdmin 4 commit: Fixed 'Location cannot be empty' error when open Tabl

2019-04-21 Thread Aditya Toshniwal
Fixed 'Location cannot be empty' error when open Tablespace properties. Fixes 
#4134

(cherry picked from commit d96f453e7f708f0254ddf9462b7bd651b4a8a3c1)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7788d4bfc0c82bce000bd698e4e115386b47750a

Modified Files
--
docs/en_US/release_notes_4_6.rst | 1 +
.../server_groups/servers/tablespaces/static/js/tablespace.js| 5 +++--
.../browser/server_groups/servers/templates/macros/variable.macros   | 4 +---
3 files changed, 5 insertions(+), 5 deletions(-)



pgAdmin 4 commit: Update French translation.

2019-04-21 Thread Aditya Toshniwal
Update French translation.

(cherry picked from commit fd3337024f7ecbe75568d8ba5e88d8199f5953c2)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b024f97fbb01281424af9a8a4a1b75beb527d8e
Author: Fred Escallier 

Modified Files
--
.../translations/fr/LC_MESSAGES/messages.mo| Bin 157367 -> 157512 bytes
.../translations/fr/LC_MESSAGES/messages.po| 976 ++---
2 files changed, 472 insertions(+), 504 deletions(-)



pgAdmin 4 commit: 1) Added support for Default Partition. Fixes #3938

2019-04-21 Thread Aditya Toshniwal
1) Added support for Default Partition. Fixes #3938
2) Ensure that record should be add/edited for root partition table with 
primary keys. Fixes #4104

(cherry picked from commit a9d964b5ca04bbe00bf5585d5c19bdfdf603c8a9)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19230aac881de2dc65b8a40306bc0a878a88d0e7
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/images/table_partition.png  | Bin 267206 -> 253015 bytes
docs/en_US/release_notes_4_6.rst   |   2 +
docs/en_US/table_dialog.rst|   3 +-
.../schemas/tables/static/js/partition.utils.js|  44 --
.../databases/schemas/tables/static/js/table.js|  51 -
.../schemas/tables/tests/test_table_add.py |  26 +++
.../servers/databases/schemas/tables/utils.py  |  34 ++
.../sqleditor/sql/11_plus/primary_keys.sql |   8 
8 files changed, 121 insertions(+), 47 deletions(-)



pgAdmin 4 commit: Ensure that parameters of procedures for EPAS server

2019-04-21 Thread Aditya Toshniwal
Ensure that parameters of procedures for EPAS server 10 and below should be 
set/reset properly. Fixes #4161

(cherry picked from commit 9c3925e44821f218448c4d60faa2af7fee7dfb7d)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a42d073a13c1978323f2ddcf28ba0d5f583
Author: Akshay Joshi 

Modified Files
--
docs/en_US/release_notes_4_6.rst   |  3 ++-
.../functions/templates/procedure/ppas/sql/9.5_plus/update.sql |  4 ++--
.../functions/templates/procedure/ppas/sql/9.6_plus/update.sql |  4 ++--
.../schemas/templates/macros/functions/variable.macros | 10 --
4 files changed, 14 insertions(+), 7 deletions(-)



pgAdmin 4 commit: 1) Ensure that JSON strings as comments should be add

2019-04-21 Thread Aditya Toshniwal
1) Ensure that JSON strings as comments should be added properly for all the 
objects. Fixes #3582
2) Fixed alignment issue of columns in definition section of Index node. Fixes 
#4121

(cherry picked from commit 024cfd2fab969df0ed4062177451b83eb814f4b8)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=abb20e5d9279ea077d777237084f02a5323a9673

Modified Files
--
docs/en_US/release_notes_4_6.rst|  2 ++
.../server_groups/servers/databases/__init__.py |  7 ++-
.../databases/foreign_data_wrappers/__init__.py |  7 ++-
.../foreign_servers/__init__.py |  7 ++-
.../servers/databases/languages/__init__.py |  7 ++-
.../servers/databases/schemas/__init__.py   |  7 ++-
.../databases/schemas/collations/__init__.py|  7 ++-
.../schemas/fts_configurations/__init__.py  |  7 ++-
.../databases/schemas/fts_dictionaries/__init__.py  |  7 ++-
.../databases/schemas/fts_parsers/__init__.py   |  7 ++-
.../databases/schemas/fts_templates/__init__.py |  7 ++-
.../servers/databases/schemas/sequences/__init__.py |  7 ++-
.../servers/databases/schemas/tables/__init__.py| 21 ++---
.../tables/constraints/check_constraint/__init__.py | 14 --
.../constraints/exclusion_constraint/__init__.py| 14 --
.../tables/constraints/foreign_key/__init__.py  | 14 --
.../tables/constraints/index_constraint/__init__.py | 14 --
.../databases/schemas/tables/indexes/__init__.py| 14 --
.../schemas/tables/indexes/static/js/index.js   |  1 +
.../databases/schemas/tables/triggers/__init__.py   | 14 --
.../servers/databases/schemas/views/__init__.py |  7 ++-
.../server_groups/servers/tablespaces/__init__.py   |  7 ++-
22 files changed, 171 insertions(+), 28 deletions(-)



pgAdmin 4 commit: Improvement for 'beforeunload' event, bind the event

2019-04-21 Thread Akshay Joshi
Improvement for 'beforeunload' event, bind the event only from where it is 
required.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05ae33003056c866bafaf891c920696e48609286
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/browser/static/js/browser.js   | 41 --
web/pgadmin/tools/debugger/static/js/direct.js |  2 ++
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  2 ++
3 files changed, 26 insertions(+), 19 deletions(-)



pgAdmin 4 commit: Ensure we create a DMG file that's compatible with ma

2019-04-21 Thread Aditya Toshniwal
Ensure we create a DMG file that's compatible with macOS 10.10+

(cherry picked from commit 1a192109d62a8bc84ec44388ece94eff70db530a)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae963fcd0f0bf8570dfee5266023368302c06c6a
Author: Dave Page 

Modified Files
--
pkg/mac/create-dmg.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: 1) Fix an issue where Deleting N number of rows makes

2019-04-21 Thread Aditya Toshniwal
1) Fix an issue where Deleting N number of rows makes first N number of rows 
disable. Fixes #3605
2) Ensure that on clicking Delete button should not delete rows immediately 
from the database server,
   it should be deleted when Save button will be clicked. Fixes #2392

(cherry picked from commit 0b47d1dbf6d808c8e5d225dc3b8f4806a15e62e3)

Branch
--
electron2

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ded688b65bd5bea65ce538a91ac3cc0b15f2ccc
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_4_6.rst   |  2 +
web/pgadmin/static/js/selection/set_staged_rows.js |  2 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 64 --
.../tools/sqleditor/static/scss/_sqleditor.scss| 15 +
4 files changed, 52 insertions(+), 31 deletions(-)



Re: [pgAdmin][patch] browser beforeunload event code improvements

2019-04-21 Thread Akshay Joshi
Thanks patch applied.

On Fri, Apr 19, 2019 at 5:58 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch as an improvement for before unload event setting.
> Changes are done to bind event beforeunload only where required, unlike
> previously where just loading browser.js would bind the events which might
> kill its reusability.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


[pgAdmin4][Patch] - RM 4087 - Default sequence privileges does not show update grant

2019-04-21 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the RM #4087 - Default sequence
privileges does not show update grant.

Thanks,
Khushboo


RM_4087.patch
Description: Binary data


pgAdmin 4 commit: Fixed 'Increment value cannot be empty' error for exi

2019-04-21 Thread Akshay Joshi
Fixed 'Increment value cannot be empty' error for existing tables. Fixes #4160

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5452bff49e1b35705274711e603d5cb01be62a6a
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_4_6.rst |  1 +
.../databases/schemas/tables/columns/static/js/column.js | 12 +++-
2 files changed, 12 insertions(+), 1 deletion(-)



Re: [pgAdmin4][Patch] - RM 4160 - (Re-)Edit column properties blocked to "Increment value cannot be empty" error.

2019-04-21 Thread Akshay Joshi
Thanks patch applied.

On Fri, Apr 19, 2019 at 11:10 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #4160 - (Re-)Edit column
> properties blocked to "Increment value cannot be empty" error.
>
> Thanks,
> Khushboo
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Fix an issue where 'GRANT UPDATE' sql should be displ

2019-04-21 Thread Akshay Joshi
Fix an issue where 'GRANT UPDATE' sql should be displayed for default sequence 
privileges. Fixes #4087

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecded183338192ff6110c8e16da6823511d9d6f9
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_4_6.rst| 1 +
.../databases/schemas/templates/catalog/pg/9.1_plus/allowed_privs.json  | 2 +-
.../databases/schemas/templates/catalog/pg/9.2_plus/allowed_privs.json  | 2 +-
.../schemas/templates/catalog/ppas/9.1_plus/allowed_privs.json  | 2 +-
.../schemas/templates/catalog/ppas/9.2_plus/allowed_privs.json  | 2 +-
.../databases/schemas/templates/schema/gpdb_5.0_plus/allowed_privs.json | 2 +-
.../databases/schemas/templates/schema/pg/9.2_plus/allowed_privs.json   | 2 +-
.../databases/schemas/templates/schema/pg/default/allowed_privs.json| 2 +-
.../databases/schemas/templates/schema/ppas/9.1_plus/allowed_privs.json | 2 +-
.../databases/schemas/templates/schema/ppas/9.2_plus/allowed_privs.json | 2 +-
.../databases/templates/databases/sql/9.2_plus/allowed_privs.json   | 2 +-
.../databases/templates/databases/sql/default/allowed_privs.json| 2 +-
12 files changed, 12 insertions(+), 11 deletions(-)



Re: [pgAdmin4][Patch] - RM 4087 - Default sequence privileges does not show update grant

2019-04-21 Thread Akshay Joshi
Thanks patch applied.

On Mon, Apr 22, 2019 at 11:48 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #4087 - Default sequence
> privileges does not show update grant.
>
> Thanks,
> Khushboo
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*