pgAdmin 4 commit: 1) Added support for Default Partition. Fixes #3938
1) Added support for Default Partition. Fixes #3938 2) Ensure that record should be add/edited for root partition table with primary keys. Fixes #4104 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9d964b5ca04bbe00bf5585d5c19bdfdf603c8a9 Author: Khushboo Vashi Modified Files -- docs/en_US/images/table_partition.png | Bin 267206 -> 253015 bytes docs/en_US/release_notes_4_6.rst | 2 + docs/en_US/table_dialog.rst| 3 +- .../schemas/tables/static/js/partition.utils.js| 44 -- .../databases/schemas/tables/static/js/table.js| 51 - .../schemas/tables/tests/test_table_add.py | 26 +++ .../servers/databases/schemas/tables/utils.py | 34 ++ .../sqleditor/sql/11_plus/primary_keys.sql | 8 8 files changed, 121 insertions(+), 47 deletions(-)
Re: [pgAdmin4][Patch] - RM 4104 & RM 3938 - Partition table fixes
Thanks patch applied. On Thu, Apr 11, 2019 at 11:30 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > On Thu, Apr 4, 2019 at 7:02 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Below are the review comments: >> >>- Can you please add the help message for 'Default' in note control >>as we do have for 'From/To' control. Also strings are not properly aligned >>in the note control for Partition Keys and Partitions. >> >> Fixed. > >> >>- Update the documentation and screenshot with the new changes. >> >> Done. > >> >>- Found one issue, Steps to reproduce: >>- Create a partition table with range partition and one child >> partition of type 'Default'. >> - Open the properties dialog of the newly created partition table >> and add new child partition with 'Default' = No. Insert all the >> required >> field 'Name', 'From' and 'To', still save button is disabled. I am not >> able >> to create a new child partition. >> >> Fixed > >> >>- If possible can you please fix the RM #*3327* which seems to be a >>small fix, with the same patch. >> >> This fix will affect all the subnode controls as the code is generic. I > will handle this separately. > > Thanks, > Khushboo > >> >> On Wed, Apr 3, 2019 at 3:42 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix: >>> >>> 1. # 4104 - Edit data tables with primary key spanning multiple >>> columns [Partition table] >>> Issue: The partition table having multiple primary keys are not editable >>> from the View data. >>> 2. # 3938 - Properties of table with default partition not displayed >>> Issue: The DEFAULT partition is not supported introduced in PG 11. >>> >>> Thanks, >>> Khushboo >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Depend on psycopg2-binary in the Python wheel, rather
Depend on psycopg2-binary in the Python wheel, rather than psycopg2. Fixes #4165 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ded446fe8aedfea9d7f2cb7c8a804cc48424d591 Modified Files -- docs/en_US/release_notes_4_6.rst | 1 + pkg/pip/setup_pip.py | 5 + 2 files changed, 6 insertions(+)
little messages update
hello for upcoming release Fred messages-fr.tar.xz Description: application/xz-compressed-tar
[pgAdmin4] Add API tests for Download CSV route in query tool
Hi, PFA patch to add API tests for Download CSV route in query tool. > python runtests.py --pkg tools.sqleditor.tests --exclude feature_tests -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company download_csv_tests.diff Description: Binary data
pgAdmin 4 commit: Configuration page added to change port, python and a
Configuration page added to change port, python and app paths.
Branch
--
electron2
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2d1761febe055e350c3c6881facbdee50d203eb
Modified Files
--
electron/package.json| 3 +
electron/src/configure_store.js | 65
electron/src/configure_ui.html | 68
electron/src/configure_ui.js | 47 ++
electron/src/index.js| 277 +++
electron/src/{index.html => loader.html} | 0
electron/yarn.lock | 12 ++
7 files changed, 402 insertions(+), 70 deletions(-)
pgAdmin 4 commit: Update French translation.
Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd3337024f7ecbe75568d8ba5e88d8199f5953c2 Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 157367 -> 157512 bytes .../translations/fr/LC_MESSAGES/messages.po| 976 ++--- 2 files changed, 472 insertions(+), 504 deletions(-)
Re: little messages update
Thanks, committed! On Thu, Apr 11, 2019 at 10:44 AM wrote: > hello > for upcoming release > Fred > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4] Add API tests for Download CSV route in query tool
Hi On Thu, Apr 11, 2019 at 12:21 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add API tests for Download CSV route in query tool. > > python runtests.py --pkg tools.sqleditor.tests --exclude feature_tests > Nice addition, but can you modify it so it doesn't spit the "table doesn't exist" error out to the terminal? We're trying to clean up the test output at the moment. Oh, and it should be this_table_does_not_exist (without the trailing s :-) ) runTest (pgadmin.tools.sqleditor.tests.test_download_csv_query_tool.TestDownloadCSV) Download csv URL with wrong query ... 2019-04-11 13:54:38,710: ERROR flask.app: failed to execute query ((with server cursor) for the server #4 - CONN:3783391 (query-id: 5309318): error message:ERROR: relation "this_table_does_not_exists" does not exist LINE 1: SELECT * FROM this_table_does_not_exists ^ ok -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4] Add API tests for Download CSV route in query tool
Hi Dave, PFA updated patch with suggested changes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 11, 2019 at 6:27 PM Dave Page wrote: > Hi > > On Thu, Apr 11, 2019 at 12:21 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to add API tests for Download CSV route in query tool. >> > python runtests.py --pkg tools.sqleditor.tests --exclude feature_tests >> > > Nice addition, but can you modify it so it doesn't spit the "table doesn't > exist" error out to the terminal? We're trying to clean up the test output > at the moment. > > Oh, and it should be this_table_does_not_exist (without the trailing s :-) > ) > > runTest > (pgadmin.tools.sqleditor.tests.test_download_csv_query_tool.TestDownloadCSV) > Download csv URL with wrong query ... 2019-04-11 13:54:38,710: ERROR > flask.app: failed to execute query ((with server cursor) for the server > #4 - CONN:3783391 (query-id: 5309318): > error message:ERROR: relation "this_table_does_not_exists" does not exist > LINE 1: SELECT * FROM this_table_does_not_exists > ^ > > ok > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > download_csv_tests_v1.diff Description: Binary data
pgAdmin 4 commit: Add tests for the CSV download.
Add tests for the CSV download. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a25bb2b7db72799cf97523d0bdca67a3e1bc7e92 Author: Murtuza Zabuawala Modified Files -- .../tests/test_download_csv_query_tool.py | 135 + 1 file changed, 135 insertions(+)
Re: [pgAdmin4] Add API tests for Download CSV route in query tool
Thanks - committed! On Thu, Apr 11, 2019 at 3:30 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch with suggested changes. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Thu, Apr 11, 2019 at 6:27 PM Dave Page wrote: > >> Hi >> >> On Thu, Apr 11, 2019 at 12:21 PM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to add API tests for Download CSV route in query tool. >>> > python runtests.py --pkg tools.sqleditor.tests --exclude feature_tests >>> >> >> Nice addition, but can you modify it so it doesn't spit the "table >> doesn't exist" error out to the terminal? We're trying to clean up the test >> output at the moment. >> >> Oh, and it should be this_table_does_not_exist (without the trailing s >> :-) ) >> >> runTest >> (pgadmin.tools.sqleditor.tests.test_download_csv_query_tool.TestDownloadCSV) >> Download csv URL with wrong query ... 2019-04-11 13:54:38,710: ERROR >> flask.app: failed to execute query ((with server cursor) for the server >> #4 - CONN:3783391 (query-id: 5309318): >> error message:ERROR: relation "this_table_does_not_exists" does not exist >> LINE 1: SELECT * FROM this_table_does_not_exists >> ^ >> >> ok >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
