pgAdmin 4 commit: Fixed pep8 issue

2019-04-05 Thread Akshay Joshi
Fixed pep8 issue

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bff6c7157ca0e96daa22bc313ff4c27630fb8c7

Modified Files
--
web/pgadmin/feature_tests/xss_checks_roles_control_test.py | 1 +
1 file changed, 1 insertion(+)



pgAdmin 4 commit: Added recommended ESLinter checks. Fixes #4142

2019-04-05 Thread Akshay Joshi
Added recommended ESLinter checks. Fixes #4142

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=84ecffa4d9d0965f46bdef8a074f44475d8d79a2
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/release_notes_4_5.rst   | 1 +
web/.eslintrc.js   | 5 +
.../servers/databases/schemas/tables/columns/static/js/column.js   | 1 -
web/pgadmin/browser/static/js/browser.js   | 1 -
web/pgadmin/help/static/js/help.js | 2 +-
web/pgadmin/static/js/pgadmin.js   | 7 ++-
6 files changed, 13 insertions(+), 4 deletions(-)



Re: [pgAdmin4][RM#4142] Add the recommended ESLinter checks again.

2019-04-05 Thread Akshay Joshi
Thanks patch applied.

On Fri, Apr 5, 2019 at 11:49 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Issue: We removed recommended ESLinter checking with RM#4019 commit.
>
> If you see now ESLint is no longer complaining about many issues which are
> listed here https://eslint.org/docs/rules/ and marked as [✓].
> Simple test case is to add debugger; statement in JS code and run linter,
> we can see that linter is not complaining about it, earlier it was.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


[pgAdmin4][RM#4138] Allow us to set the dropdown body when rendering Select2 control

2019-04-05 Thread Murtuza Zabuawala
Hi,

PFA minor patch to fix the issue where Select2 dropdown position
incorrectly in some cases.
Ref: https://select2.org/troubleshooting/common-problems

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_4138.diff
Description: Binary data


GSoC Student - Help needed

2019-04-05 Thread Yosry Muhammad
Dear pgadmin developers,

I am a student applying to GSoC this year, specifically the query tool
automatic mode switching project.

I just finished my exams so I am short in time. I would very much
appreciate it if anyone is willing to contact me privately to give me an
overview of how the sql editor works and help me understand the relevant
parts of the code if I get stuck. I already cloned the project and ran it
successfully and I am a user of pgadmin.

I understand if you are all too busy for this.
Thanks in advance.
Regards.