Japanese translation (April 2019)
Hello. Updated Japanese translation (based on git 04/01/2019; a019e2de6f) is in attachment. pgadmin4-ja-apr2019.7z Description: Binary data
[pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues
Hi, Please find the attached patch to fix the RM 4048 - Disable auto-fill on all dialogues. Thanks, Khushboo RM_4048.patch Description: Binary data
[GSoC 2019 Proposal] - pgAdmin4 Graphing Query Tool
Hello, I am a GSoC 2019 aspirant and would like to work on the project entitled 'pgAdmin4 Graphing Query Tool'. I have submitted an initial draft of my proposal through the Summer of Code website but I would greatly appreciate any kind of feedback on the current draft. I believe it will help me in improving the final proposal. The link to the draft is - https://docs.google.com/document/d/10x_c3HsOEQuDbL6zB8fjk6_9BqP8L1zvhe62h613Ruc/edit?usp=drivesdk Thanks in advance! Regards, Ritom
Some fixes for api and features tests
Hi Hackers, Please find here attached patch for following - usage of randomised name for database/role creation(unit test, feature test). - code to maximised browser window before start of execution - reduce the default time to wait for element if user does not implicitly provide the information. - Correction in comment for toggle_open_tables_node function Please review the patch and apply. -- Thanks, Usman Muzaffar QA Team EnterpriseDB Corporation pgadmin_tests_v1.patch Description: Binary data
pgAdmin 4 commit: Updated French tanslation.
Updated French tanslation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=badbbade0844a689e9709cab1a29b1132f55eee4 Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 157401 -> 157506 bytes .../translations/fr/LC_MESSAGES/messages.po| 1216 ++-- 2 files changed, 592 insertions(+), 624 deletions(-)
Re: franslation update
Thanks, applied. On Mon, Apr 1, 2019 at 12:01 PM wrote: > hello > here's the fr translation for upcoming release > Fred > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Updated Japanese tanslation.
Updated Japanese tanslation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb12b2e2fc320bca848488d1c512d2dd77d8a702 Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 163934 -> 164159 bytes .../translations/ja/LC_MESSAGES/messages.po| 102 ++--- 2 files changed, 51 insertions(+), 51 deletions(-)
Re: Japanese translation (April 2019)
Thanks, applied. On Tue, Apr 2, 2019 at 8:53 AM fn ln wrote: > Hello. > Updated Japanese translation (based on git 04/01/2019; a019e2de6f) is in > attachment. > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues
Hi On Tue, Apr 2, 2019 at 10:37 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 4048 - Disable auto-fill on > all dialogues. > I guess the additions in server.js were for testing? Many of those fields didn't make sense to have autocomplete enabled, and some were specifically the ones that were annoying me. That said... this doesn't actually work for me in Chrome. A little investigation reveals this is a common annoyance. Some versions ignore autocomplete="off" but will accept autocomplete="nope" (or some other random string), whilst versions such as the one I'm running right now (72.0.3626.121 on macOS) ignore both. Apparently, that's sort of how it's supposed to work: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill After some experimentation, the one thing that worked for me (except on the password field of the server dialog, which I can live with) was setting it to "new-password". I've attached an updated patch. Can you take a look and try it out on the browsers you have please? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4048_v2.patch Description: Binary data
Re: [pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues
On Tue, Apr 2, 2019 at 8:00 PM Dave Page wrote: > Hi > > On Tue, Apr 2, 2019 at 10:37 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM 4048 - Disable auto-fill on >> all dialogues. >> > > I guess the additions in server.js were for testing? Many of those fields > didn't make sense to have autocomplete enabled, and some were specifically > the ones that were annoying me. > > This is not for testing, as per the RM, disable the autocomplete for all the dialogues except server dialogue and Login page. > That said... this doesn't actually work for me in Chrome. A little > investigation reveals this is a common annoyance. Some versions ignore > autocomplete="off" but will accept autocomplete="nope" (or some other > random string), whilst versions such as the one I'm running right now > (72.0.3626.121 > on macOS) ignore both. Apparently, that's sort of how it's supposed to > work: > https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill > > After some experimentation, the one thing that worked for me (except on > the password field of the server dialog, which I can live with) was setting > it to "new-password". > > I've attached an updated patch. Can you take a look and try it out on the > browsers you have please? > > I will check. > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: Some fixes for api and features tests
Hi
On Tue, Apr 2, 2019 at 1:33 PM Usman Muzaffar <
usman.muzaf...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Please find here attached patch for following
>
>- usage of randomised name for database/role creation(unit test,
>feature test).
>- code to maximised browser window before start of execution
>- reduce the default time to wait for element if user does not
>implicitly provide the information.
>- Correction in comment for toggle_open_tables_node function
>
> Please review the patch and apply.
>
Running with this, I got a couple of errors in the
PGUtilitiesMaintenanceFeatureTest, which ended up leaving their
notification dialogues present for the remainder of the run, as well as an
error in CopySelectedQueryResultsFeatureTest:
==
ERROR: runTest
(pgadmin.feature_tests.copy_selected_query_results_feature_test.CopySelectedQueryResultsFeatureTest)
Copy rows, column using button and keyboard shortcut
--
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/copy_selected_query_results_feature_test.py",
line 51, in runTest
self._copies_rows()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/copy_selected_query_results_feature_test.py",
line 63, in _copies_rows
"//*[contains(@class, 'slick-row')]/*[1]").click()
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/selenium/webdriver/remote/webelement.py",
line 80, in click
self._execute(Command.CLICK_ELEMENT)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/selenium/webdriver/remote/webelement.py",
line 628, in _execute
return self._parent.execute(command, params)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 312, in execute
self.error_handler.check_response(response)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 242, in check_response
raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: unknown error:
Element ... is not
clickable at point (318, 800). Other element would receive the click:
(Session info: chrome=73.0.3683.86)
(Driver info: chromedriver=2.45.615355
(d5698f682d8b2742017df6c81e0bd8e6a3063189),platform=Mac OS X 10.14.3 x86_64)
==
FAIL: runTest
(pgadmin.feature_tests.pg_utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTest)
Test for PG maintenance: database
--
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py",
line 69, in runTest
self._verify_command()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py",
line 88, in _verify_command
self.assertEquals(status, "Successfully completed.")
AssertionError: 'Started' != 'Successfully completed.'
- Started
+ Successfully completed.
==
FAIL: runTest
(pgadmin.feature_tests.pg_utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTest)
Test for PG maintenance: table
--
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py",
line 69, in runTest
self._verify_command()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py",
line 88, in _verify_command
self.assertEquals(status, "Successfully completed.")
AssertionError: 'Failed (exit code: 2).' != 'Successfully completed.'
- Failed (exit code: 2).
+ Successfully completed.
==
FAIL: runTest
(pgadmin.feature_tests.pg_utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTest)
Test for XSS in maintenance dialog
--
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py",
line 69, in runTest
self._verify_command()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py",
line 104, in _verify_command
'Maintenance detailed window'
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py",
line 131, in _check_escaped_characters
1, "{0} might be vulnerable to XSS ".format(source)
AssertionError: Maintenance detailed window might be vulnerable to XSS
--
Ran 18 tests in 314.841s
FAILED (failures=3, errors=1)
===
Re: [pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues
On Tue, Apr 2, 2019 at 4:00 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 2, 2019 at 8:22 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Apr 2, 2019 at 8:00 PM Dave Page wrote: >> >>> Hi >>> >>> On Tue, Apr 2, 2019 at 10:37 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi, Please find the attached patch to fix the RM 4048 - Disable auto-fill on all dialogues. >>> >>> I guess the additions in server.js were for testing? Many of those >>> fields didn't make sense to have autocomplete enabled, and some were >>> specifically the ones that were annoying me. >>> >>> This is not for testing, as per the RM, disable the autocomplete for >> all the dialogues except server dialogue and Login page. >> >>> That said... this doesn't actually work for me in Chrome. A little >>> investigation reveals this is a common annoyance. Some versions ignore >>> autocomplete="off" but will accept autocomplete="nope" (or some other >>> random string), whilst versions such as the one I'm running right now >>> (72.0.3626.121 >>> on macOS) ignore both. Apparently, that's sort of how it's supposed to >>> work: >>> https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill >>> >>> After some experimentation, the one thing that worked for me (except on >>> the password field of the server dialog, which I can live with) was setting >>> it to "new-password". >>> >>> I've attached an updated patch. Can you take a look and try it out on >>> the browsers you have please? >>> >>> >> I will check. >> > It didn't work for me. Please see the attached screen-shot. > Tested on Chrome Version 73.0.3683.86 (Official Build) (64-bit) > Sigh. I think there are actually two issues here: - Auto-complete (which you see) - Auto-fill (which I see) The former being the list of possible options being presented (I only see that for the password), and the latter being the control pre-filled with a value, and coloured to indicate that. I wonder if both need to be handled in different ways? FWIW, it's the auto-fill that's really annoying for me, as that requires me to change a value rather than just ignoring a suggestion. > > Thanks, > Khushboo > >> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Relabel the Save button on the datagrid text editor t
Relabel the Save button on the datagrid text editor to avoid confusion with the actual Save button that updates the database. Fixes #4131 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f706f7ed0cffa23b411fc35876f007b1c704d7bc Modified Files -- docs/en_US/release_notes.rst | 1 + docs/en_US/release_notes_4_5.rst | 18 ++ web/pgadmin/static/js/slickgrid/editors.js | 21 +++-- 3 files changed, 30 insertions(+), 10 deletions(-)
Re: [pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues
On Tue, Apr 2, 2019 at 9:25 PM Dave Page wrote: > > > On Tue, Apr 2, 2019 at 4:00 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Apr 2, 2019 at 8:22 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Tue, Apr 2, 2019 at 8:00 PM Dave Page wrote: >>> Hi On Tue, Apr 2, 2019 at 10:37 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 4048 - Disable auto-fill > on all dialogues. > I guess the additions in server.js were for testing? Many of those fields didn't make sense to have autocomplete enabled, and some were specifically the ones that were annoying me. This is not for testing, as per the RM, disable the autocomplete for >>> all the dialogues except server dialogue and Login page. >>> That said... this doesn't actually work for me in Chrome. A little investigation reveals this is a common annoyance. Some versions ignore autocomplete="off" but will accept autocomplete="nope" (or some other random string), whilst versions such as the one I'm running right now (72.0.3626.121 on macOS) ignore both. Apparently, that's sort of how it's supposed to work: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill After some experimentation, the one thing that worked for me (except on the password field of the server dialog, which I can live with) was setting it to "new-password". I've attached an updated patch. Can you take a look and try it out on the browsers you have please? >>> I will check. >>> >> It didn't work for me. Please see the attached screen-shot. >> Tested on Chrome Version 73.0.3683.86 (Official Build) (64-bit) >> > > Sigh. I think there are actually two issues here: > > - Auto-complete (which you see) > - Auto-fill (which I see) > > The former being the list of possible options being presented (I only see > that for the password), and the latter being the control pre-filled with a > value, and coloured to indicate that. > Only chrome gives the options to autofill below listed fields. Other browsers only save username and password and accordingly they autofill the value for the password. [image: image.png] > > I wonder if both need to be handled in different ways? > We can set autocomplete to off (or whatever we want to set) which is also not 100 % supported by all the browsers but for the autofill, we need to just disable it from the browser settings. > > FWIW, it's the auto-fill that's really annoying for me, as that requires > me to change a value rather than just ignoring a suggestion. > > >> >> Thanks, >> Khushboo >> >>> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
