pgAdmin 4 commit: Fix custom autovacuum configuration for Materialized
Fix custom autovacuum configuration for Materialized Views. Fixes #4110 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d286bada5cad95d2b42c9190ab3fcb4eccafa65d Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_4_4.rst | 1 + .../servers/databases/schemas/static/js/schema.js | 52 ++- .../partition/sql/gpdb/5_plus/properties.sql | 12 ++-- .../partition/sql/pg/10_plus/properties.sql| 12 ++-- .../partition/sql/ppas/10_plus/properties.sql | 12 ++-- .../templates/table/sql/10_plus/properties.sql | 12 ++-- .../templates/table/sql/9.1_plus/properties.sql| 12 ++-- .../templates/table/sql/default/properties.sql | 12 ++-- .../tables/templates/table/sql/default/update.sql | 76 +- .../table/sql/gpdb_5.0_plus/properties.sql | 12 ++-- .../servers/databases/schemas/tables/utils.py | 36 ++ .../servers/databases/schemas/views/__init__.py| 15 + .../templates/mview/pg/9.3_plus/sql/properties.sql | 14 ++-- .../templates/mview/pg/9.3_plus/sql/update.sql | 15 ++--- .../templates/mview/pg/9.4_plus/sql/properties.sql | 14 ++-- .../templates/mview/pg/9.4_plus/sql/update.sql | 15 ++--- .../mview/ppas/9.3_plus/sql/properties.sql | 14 ++-- .../templates/mview/ppas/9.3_plus/sql/update.sql | 15 ++--- 18 files changed, 225 insertions(+), 126 deletions(-)
Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."
Thanks, patch applied. The Jenkins jobs should kick in shortly, following which the release candidates can be built. On Fri, Mar 29, 2019 at 3:06 PM Akshay Joshi wrote: > Hi Dave/Hackers > > On Fri, Mar 29, 2019 at 7:50 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Fri, Mar 29, 2019 at 7:41 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Hackers, I have started working on RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View." and while working I have figured out following issues: - Reset some/all the parameter for table and toast table is not implemented. - Value of "Custom auto-vacuum?" is not retrieved and set properly. - When user set the "Custom auto-vacuum?" to "Yes" and none of the parameter is set previously then set the value of "Enabled?" control to "Yes". - Alignment of Table and remove extra margin from "Parameters" tab. Attached is the patch to fix all the above issues. Added API test cases. Please review it. >>> >>> I set the autovacuum_enabled=true and autovacuum_analyze_scale_factor=1 >>> on the test mview, but only the enabled setting is reflected when I re-open >>> the properties dialogue. Other settings seems to be fine - it's just >>> autovacuum_analyze_scale_factor that's broken. >>> >>> It's also not shown in the reverse-engineered SQL - neither is >>> autovacuum_enabled. >>> >> >>This looks like a old issue, not because of this patch. Will check and >> work on it. >> > >Fixed both the above issue, its an old issue. Problem is with > regular expression to fetch the 'autovacuum_analyze_scale_factor' and other > similar parameters too. Attached is the modified patch please review it. > >> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."
On Mon, Apr 1, 2019 at 2:19 PM Dave Page wrote: > Thanks, patch applied. The Jenkins jobs should kick in shortly, following > which the release candidates can be built. > Sure. > > On Fri, Mar 29, 2019 at 3:06 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave/Hackers >> >> On Fri, Mar 29, 2019 at 7:50 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Fri, Mar 29, 2019 at 7:41 PM Dave Page wrote: >>> Hi On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > I have started working on RM #4110 "Updating 'Custom auto-vacuum?' > property throws error for Materialized View." and while working I have > figured out following issues: > >- Reset some/all the parameter for table and toast table is not >implemented. >- Value of "Custom auto-vacuum?" is not retrieved and set properly. >- When user set the "Custom auto-vacuum?" to "Yes" and none of the >parameter is set previously then set the value of "Enabled?" control to >"Yes". >- Alignment of Table and remove extra margin from "Parameters" >tab. > > Attached is the patch to fix all the above issues. Added API test > cases. > Please review it. > I set the autovacuum_enabled=true and autovacuum_analyze_scale_factor=1 on the test mview, but only the enabled setting is reflected when I re-open the properties dialogue. Other settings seems to be fine - it's just autovacuum_analyze_scale_factor that's broken. It's also not shown in the reverse-engineered SQL - neither is autovacuum_enabled. >>> >>>This looks like a old issue, not because of this patch. Will check >>> and work on it. >>> >> >>Fixed both the above issue, its an old issue. Problem is with >> regular expression to fetch the 'autovacuum_analyze_scale_factor' and other >> similar parameters too. Attached is the modified patch please review it. >> >>> Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Update message catalogs.
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a019e2de6fb07da8bc58ebb91778df76cd2d5d7f Modified Files -- web/pgadmin/messages.pot | 8655 .../translations/de/LC_MESSAGES/messages.mo| Bin 148461 -> 148353 bytes .../translations/de/LC_MESSAGES/messages.po| 9144 + .../translations/es/LC_MESSAGES/messages.mo| Bin 153345 -> 153165 bytes .../translations/es/LC_MESSAGES/messages.po| 9370 + .../translations/fr/LC_MESSAGES/messages.mo| Bin 157591 -> 157401 bytes .../translations/fr/LC_MESSAGES/messages.po| 10122 ++- .../translations/ja/LC_MESSAGES/messages.mo| Bin 164203 -> 163934 bytes .../translations/ja/LC_MESSAGES/messages.po| 9324 + .../translations/ko/LC_MESSAGES/messages.mo| Bin 150936 -> 150815 bytes .../translations/ko/LC_MESSAGES/messages.po| 9288 + .../translations/pl/LC_MESSAGES/messages.mo| Bin 148695 -> 148490 bytes .../translations/pl/LC_MESSAGES/messages.po| 9313 + .../translations/ru/LC_MESSAGES/messages.mo| Bin 186369 -> 185547 bytes .../translations/ru/LC_MESSAGES/messages.po| 9318 + .../translations/zh/LC_MESSAGES/messages.mo| Bin 127714 -> 127755 bytes .../translations/zh/LC_MESSAGES/messages.po| 9092 + 17 files changed, 65469 insertions(+), 18157 deletions(-)
pgAdmin 4 commit: Update version for release.
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f23f729c611b0130cdb69f3c979c204e48cfb4d Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
pgAdmin 4 commit: Add missing files.
Add missing files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=614c66940ad1f58598184d4c7f37983b131a4629 Modified Files -- .../schemas/tables/tests/test_table_parameters.py | 136 +++ .../schemas/views/tests/test_mviews_parameters.py | 147 + 2 files changed, 283 insertions(+)
franslation update
hello here's the fr translation for upcoming release Fred messages-fr.tar.xz Description: application/xz-compressed-tar
pgAdmin4 v4.4 candidate builds
Hi All, pgAdmin4 v4.4 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-04-01-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: GSoC proposal for pgAdmin 4 bytea support
Thank you Dave, I have modified my proposal according to your feedback on detecting media types. Haoran On Mon, Apr 1, 2019 at 2:09 AM Dave Page wrote: > Hi > > On Mon, Apr 1, 2019 at 3:12 AM Haoran Yu wrote: > >> Dear PostgreSQL community, >> >> I have submitted a proposal for the project pgAdmin 4 bytea support. The >> project discusses storing media content (images, audio, video) as bytea. >> However, I have a quick question. What does bytea data look like typically >> when storing media content? What I had in mind is, media contents that uses >> MIME type, which are rendered as part of HTML. For example, the following >> is rendered as a red dot: >> >> 'data:image/png;base64,iVBORw0KGgoNSUhEUgUA >> AAAFCAYAAACNbyblHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO >> 9TXL0Y4OHwBJRU5ErkJggg==’ >> >> This string is decoded to bytea, and I stored it in a bytea column. >> >> What are some other examples of using bytea to store media content, not >> necessarily using the MIME type? Is there a way to detect the type of these >> media (audio, image) stored in bytea? >> > > When I have stored small media items in bytea columns in the past, I just > stored the data. I vaguely recall I did store the mime type in another > column, but that may not be the case in all scenarios (e.g. when a system > is designed to store only PNGs). I think you should assume it's raw data > only, and try to determine the file type by examining the data; > > e.g > > PNG files have an 8 byte signature: > http://www.libpng.org/pub/png/spec/1.2/PNG-Structure.html > MPEG files have identifying information in the frame header that you may > be able to use: http://mpgedit.org/mpgedit/mpeg_format/MP3Format.html > JPEG images have identifying markers: > https://en.wikipedia.org/wiki/JPEG_File_Interchange_Format > > etc. > > >> Another question I had is, I read that there are performance-related >> issues for storing media in bytea. Are there practical ways to store bytea >> data that does not face performance-related issues? For example, storing >> large media content using multiple bytea parts, and reassembling them >> together once retrieved from the database? >> > > Not that I'm aware of. For larger objects, most people store them > externally (which of course loses ACID properties). There are certainly > applications for storing smaller objects directly in the database though - > and some folks have done work in the past with index types and > operators/functions for finding and comparing images for example, so there > are also benefits other than ACID to storing data in this way. > > BTW; for pgAdmin related GSoC questions, you'd do better to ask on > pgadmin-hack...@postgresql.org. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
