Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not present when seeing generated SQL from a table
Hi Hackers,
I missed few SQLs for partition tables, gpdb, ppas and other pg versions :(
Attached is the patch to include those.
Kindly review.
On Thu, Mar 28, 2019 at 9:54 PM Dave Page wrote:
> Thanks, applied.
>
> On Thu, Mar 28, 2019 at 2:00 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Just to mention, the patch also fixes RM2627, RM4058.
>>
>> On Wed, Mar 27, 2019 at 6:25 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch which fixes the issue where comments added in
>>> child table on inherited columns where not showing in reverse engineered
>>> SQL.
>>>
>>> I have also made changes to show column details of inherited columns of
>>> table, as well as for "of type" tables similar to pgAdmin3. eg-
>>> CREATE TABLE public.inhactortest
>>> (
>>> -- Inherited from table public.actor: actor_id integer NOT NULL DEFAULT
>>> nextval('actor_actor_id_seq'::regclass),
>>> -- Inherited from table public.actor: first_name character varying(45)
>>> COLLATE pg_catalog."default" NOT NULL,
>>> -- Inherited from table public.actor: last_name character varying(45)
>>> COLLATE pg_catalog."default" NOT NULL,
>>> -- Inherited from table public.test_table: col1 integer,
>>> -- Inherited from table public.test_table: col2 "char",
>>> -- Inherited from table public.test_table: col3 character varying
>>> COLLATE pg_catalog."default",
>>> owncol integer
>>> )
>>> INHERITS (public.actor, public.test_table)
>>> WITH (
>>> OIDS = FALSE
>>> )
>>> TABLESPACE pg_default;
>>>
>>> ALTER TABLE public.inhactortest
>>> OWNER to postgres;
>>>
>>> COMMENT ON COLUMN public.inhactortest.actor_id
>>> IS 'in child c';
>>> --
>>>
>>> Kindly review.
>>>
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
RM4037.part2.patch
Description: Binary data
Feature Tests query tool: unnecessary print statement removal
Hi Hackers, Please find here attached patch for feature tests. It contains following fix - removal of unnecessary print statement from Query_tool_test -- Thanks, Usman Muzaffar QA Team EnterpriseDB Corporation query_tool_test_v1.patch Description: Binary data
Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."
Hi On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi wrote: > Hi Hackers, > > I have started working on RM #4110 "Updating 'Custom auto-vacuum?' > property throws error for Materialized View." and while working I have > figured out following issues: > >- Reset some/all the parameter for table and toast table is not >implemented. >- Value of "Custom auto-vacuum?" is not retrieved and set properly. >- When user set the "Custom auto-vacuum?" to "Yes" and none of the >parameter is set previously then set the value of "Enabled?" control to >"Yes". >- Alignment of Table and remove extra margin from "Parameters" tab. > > Attached is the patch to fix all the above issues. Added API test cases. > Please review it. > I set the autovacuum_enabled=true and autovacuum_analyze_scale_factor=1 on the test mview, but only the enabled setting is reflected when I re-open the properties dialogue. Other settings seems to be fine - it's just autovacuum_analyze_scale_factor that's broken. It's also not shown in the reverse-engineered SQL - neither is autovacuum_enabled. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."
On Fri, Mar 29, 2019 at 7:41 PM Dave Page wrote: > Hi > > On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I have started working on RM #4110 "Updating 'Custom auto-vacuum?' >> property throws error for Materialized View." and while working I have >> figured out following issues: >> >>- Reset some/all the parameter for table and toast table is not >>implemented. >>- Value of "Custom auto-vacuum?" is not retrieved and set properly. >>- When user set the "Custom auto-vacuum?" to "Yes" and none of the >>parameter is set previously then set the value of "Enabled?" control to >>"Yes". >>- Alignment of Table and remove extra margin from "Parameters" tab. >> >> Attached is the patch to fix all the above issues. Added API test cases. >> Please review it. >> > > I set the autovacuum_enabled=true and autovacuum_analyze_scale_factor=1 on > the test mview, but only the enabled setting is reflected when I re-open > the properties dialogue. Other settings seems to be fine - it's just > autovacuum_analyze_scale_factor that's broken. > > It's also not shown in the reverse-engineered SQL - neither is > autovacuum_enabled. > This looks like a old issue, not because of this patch. Will check and work on it. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Display errors during CSV download from the Query Too
Display errors during CSV download from the Query Tool in the UI rather than putting them in the CSV file. Fixes #4085 Ensure the toolbar buttons are properly reset following a CSV download in the Query Tool. Fixes #4096 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7627e9c699eda9f5b8baf0cc37dce9d130de4a99 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_4.rst | 2 + web/pgadmin/tools/sqleditor/__init__.py| 16 +-- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 146 - web/pgadmin/utils/driver/psycopg2/connection.py| 6 + 4 files changed, 101 insertions(+), 69 deletions(-)
Re: [pgAdmin4][RM4085] CSV download should show error messages in messages tab and not in the CSV file
Thanks, patch applied. On Fri, Mar 29, 2019 at 4:50 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to handle Postgres or other errors gracefully when > clicked on download CSV. PostgresSQL errors will be shown in messages tab > similar to normal SQL execute. > > The patch also covers RM4082 (a patch is available for this on hackers, > but this is an improved version :P. Actually I had already started working > on this ) and RM4096. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch] - RM 4082 - Download CSV error displayed for procedure and functions with create script
Sorry Khushboo - I went with Aditya's patch. On Thu, Mar 28, 2019 at 1:18 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #4082 - Download CSV error > displayed for procedure and functions with create script. > > The error message in case of any error while downloading the CSV file was > blank, so now it has been displayed. > > Thanks, > Khushboo > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Missed a bug :-(
Missed a bug :-( Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be313bb17b321bfc684205c6131493fe4f75e604 Modified Files -- docs/en_US/release_notes_4_4.rst | 1 + 1 file changed, 1 insertion(+)
pgAdmin 4 commit: Remove a debug statement.
Remove a debug statement. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5965bc9107d261eecc217d584f0a51b708f0cd21 Author: Khushboo Vashi Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 1 - 1 file changed, 1 deletion(-)
Re: [pgAdmin4][Patch] - Minor patch to remove javascript debugger
Thanks, applied. On Fri, Mar 29, 2019 at 6:43 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to remove the javascript debugger from the > code. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add some SQL updates to handle inherited column marke
Add some SQL updates to handle inherited column markers/comments that were missed in the previous commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55c6f5205d9891ab9972bc1238c2f26a9d19869d Author: Aditya Toshniwal Modified Files -- .../schemas/tables/templates/partition/sql/gpdb/5_plus/properties.sql | 1 + .../schemas/tables/templates/partition/sql/pg/10_plus/properties.sql | 1 + .../tables/templates/partition/sql/ppas/10_plus/properties.sql| 1 + .../databases/schemas/tables/templates/table/sql/10_plus/create.sql | 4 ++-- .../databases/schemas/tables/templates/table/sql/default/create.sql | 2 +- .../schemas/tables/templates/table/sql/default/properties.sql | 1 + .../schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql | 4 ++-- .../schemas/tables/templates/table/sql/gpdb_5.0_plus/properties.sql | 1 + 8 files changed, 10 insertions(+), 5 deletions(-)
Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not present when seeing generated SQL from a table
Thanks - applied.
On Fri, Mar 29, 2019 at 7:42 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> I missed few SQLs for partition tables, gpdb, ppas and other pg versions :(
> Attached is the patch to include those.
>
> Kindly review.
>
> On Thu, Mar 28, 2019 at 9:54 PM Dave Page wrote:
>
>> Thanks, applied.
>>
>> On Thu, Mar 28, 2019 at 2:00 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Just to mention, the patch also fixes RM2627, RM4058.
>>>
>>> On Wed, Mar 27, 2019 at 6:25 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
Hi Hackers,
Attached is the patch which fixes the issue where comments added in
child table on inherited columns where not showing in reverse engineered
SQL.
I have also made changes to show column details of inherited columns of
table, as well as for "of type" tables similar to pgAdmin3. eg-
CREATE TABLE public.inhactortest
(
-- Inherited from table public.actor: actor_id integer NOT NULL DEFAULT
nextval('actor_actor_id_seq'::regclass),
-- Inherited from table public.actor: first_name character varying(45)
COLLATE pg_catalog."default" NOT NULL,
-- Inherited from table public.actor: last_name character varying(45)
COLLATE pg_catalog."default" NOT NULL,
-- Inherited from table public.test_table: col1 integer,
-- Inherited from table public.test_table: col2 "char",
-- Inherited from table public.test_table: col3 character varying
COLLATE pg_catalog."default",
owncol integer
)
INHERITS (public.actor, public.test_table)
WITH (
OIDS = FALSE
)
TABLESPACE pg_default;
ALTER TABLE public.inhactortest
OWNER to postgres;
COMMENT ON COLUMN public.inhactortest.actor_id
IS 'in child c';
--
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: Feature Tests query tool: unnecessary print statement removal
Thanks - applied. On Fri, Mar 29, 2019 at 2:11 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for feature tests. It contains following > fix > >- removal of unnecessary print statement from Query_tool_test > > > > -- > > > Thanks, > > Usman Muzaffar > QA Team > EnterpriseDB Corporation > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Remove unnecessary print statement in the regression
Remove unnecessary print statement in the regression tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2aabf6270a22cd7e3005f315cd9315c61ba7efa Author: Usman Muzaffar Modified Files -- web/pgadmin/feature_tests/query_tool_journey_test.py | 1 - 1 file changed, 1 deletion(-)
Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."
Hi Dave/Hackers On Fri, Mar 29, 2019 at 7:50 PM Akshay Joshi wrote: > > > On Fri, Mar 29, 2019 at 7:41 PM Dave Page wrote: > >> Hi >> >> On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> I have started working on RM #4110 "Updating 'Custom auto-vacuum?' >>> property throws error for Materialized View." and while working I have >>> figured out following issues: >>> >>>- Reset some/all the parameter for table and toast table is not >>>implemented. >>>- Value of "Custom auto-vacuum?" is not retrieved and set properly. >>>- When user set the "Custom auto-vacuum?" to "Yes" and none of the >>>parameter is set previously then set the value of "Enabled?" control to >>>"Yes". >>>- Alignment of Table and remove extra margin from "Parameters" tab. >>> >>> Attached is the patch to fix all the above issues. Added API test cases. >>> Please review it. >>> >> >> I set the autovacuum_enabled=true and autovacuum_analyze_scale_factor=1 >> on the test mview, but only the enabled setting is reflected when I re-open >> the properties dialogue. Other settings seems to be fine - it's just >> autovacuum_analyze_scale_factor that's broken. >> >> It's also not shown in the reverse-engineered SQL - neither is >> autovacuum_enabled. >> > >This looks like a old issue, not because of this patch. Will check and > work on it. > Fixed both the above issue, its an old issue. Problem is with regular expression to fetch the 'autovacuum_analyze_scale_factor' and other similar parameters too. Attached is the modified patch please review it. > >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_4110_v2.patch Description: Binary data
