"yarn run pep8" excludes config file
Hi Hackers After latest pull when I run "*yarn run pep8*" from *web* directory it is not working properly. Path of the ".pycodestyle" config file is not correct in package.json. Attached is the patch to fix that. Please review it -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* fix_pycodestyle_path.patch Description: Binary data
pgAdmin 4 commit: Fix the PEP8 yarn runner
Fix the PEP8 yarn runner Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=096220ece9504c15a06d2b5519dce25b008dc057 Modified Files -- web/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: "yarn run pep8" excludes config file
On Fri, Mar 22, 2019 at 8:52 AM Akshay Joshi wrote: > Hi Hackers > > After latest pull when I run "*yarn run pep8*" from *web* directory it is > not working properly. Path of the ".pycodestyle" config file is not correct > in package.json. Attached is the patch to fix that. > Wow, why do we even have a pep8 check in there? Anyway, I've committed a fix, but changed it to run in the same directories as the Makefile scans, otherwise it would have picked up staging directories for builds and they can contain venvs with other Python modules in them. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Use the user's full email address (not just the usern
Use the user's full email address (not just the username part) as the basis for the storage directory name.. Fixes #3887 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae23f146d1063a3fac7195d8caffd79b6c0004d0 Modified Files -- docs/en_US/release_notes_4_4.rst | 22 +- web/pgadmin/utils/paths.py | 20 ++-- 2 files changed, 39 insertions(+), 3 deletions(-)
Re: [pgAdmin] - RM-3936 -Feature tests patch
Hi
Also, can you fix the encoding test patches to use a randomised database
name while you're at it? Jenkins just fell over due to concurrency issues.
Thanks.
On Thu, Mar 21, 2019 at 12:21 PM Dave Page wrote:
> Hi
>
> Awesome job (and they're much faster now!) - patch committed (but there's
> still work to do :-( ). Here are my thoughts:
>
> - The first time I ran the tests, a couple failed. This was because the
> external process output dialogue was too big for the screen (when I ran on
> a large screen and maximised the browser instance, the tests all passed).
> We may need to change the default size/position of the output dialogue, and
> perhaps maximise the browser window at launch (though I think the tests
> *must* run on a minimum screen size of 1024x768).
>
> - The process notifier dialogues should be explicitly closed at the end of
> each test. I ended up with a screen full of them after all the tests had
> run.
>
> - I saw one error (probably caused by a failing test) which complained
> that test_role already existed. That name should probably be randomised.
>
> - The test output is really messy. I'd like to have some standard
> functions for printing the output so it looks more like:
>
> runTest
> (pgadmin.feature_tests.pg_utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTest)
> * Test for PG maintenance: table... PASS
> runTest
> (pgadmin.feature_tests.pg_utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTest)
> * Test for XSS in maintenance dialog... PASS
> runTest
> (pgadmin.feature_tests.query_tool_auto_complete_tests.QueryToolAutoCompleteFeatureTest)
> Query tool auto complete feature tests ...
> * Auto complete ALTER keyword... PASS
> * Auto complete BEGIN keyword... FAIL
> * Auto complete CASCADED keyword... PASS
>
> The runTest messages are all consistent anyway, and iirc, they all come
> from the test framework. So maybe we need something like:
>
> print_test_note(note="Query tool auto complete feature test")
> print("%s" % note)
>
> print_subtest_name(name="Auto complete CASCADED keyword")
> print("%s... " % name, end='')
>
> print_subtest_result(status)
> print("PASS" if status else "FAIL")
>
> It may seem trivial, but having neat, consistent output will make the test
> results much easier for us to read.
>
> Thanks!
>
>
> On Thu, Mar 21, 2019 at 11:14 AM Usman Muzaffar <
> usman.muzaf...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find here attached patch for feature tests. Due to intermittent
>> failures on jenkins and some other system, following fixes are done(but not
>> limited to them only as other small fixes are also done)
>>
>>- tree toggle issue
>>- Query tool inteliSence issue eg. when there is only one option and
>>drop down is not shown
>>- Backup and restore windows locator changes
>>- Fixes required due to resolving rm # 4041
>>- Dependent tab not showing data sometime, so refreshed the page and
>>handled it
>>- Due to change of logic for auto commit, did the required changes
>>- Due to fix of RM 4062, did the required workaround which broke the
>>test case.
>>
>> --
>>
>>
>> Thanks,
>>
>> Usman Muzaffar
>> QA Team
>> EnterpriseDB Corporation
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: RM3887 - User storage home folder collision
Thanks to you and Khushboo. Committed. On Fri, Mar 22, 2019 at 5:04 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Looks good to me. > > On Thu, Mar 21, 2019 at 10:41 PM Dave Page wrote: > >> Here's a patch to fix and repair $SUBJECT. >> >> Anyone see any issues with it? >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
[pgAdmin4][Patch]: RM #4100 Unable to create sequence with Increment, Start, Minimum and Maximum value
Hi Hackers, Attached is the patch to fix RM #4100 "Unable to create sequence with Increment, Start, Minimum and Maximum value". Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_4100.patch Description: Binary data
pgAdmin 4 commit: Fix SQL help for EPAS 10+, and refactor the URL gener
Fix SQL help for EPAS 10+, and refactor the URL generation code into a testable function. Fixes #4099 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce073a28562a3045ac86ae65eefeeed3b65f Modified Files -- docs/en_US/release_notes_4_4.rst | 1 + .../servers/pgagent/steps/static/js/pga_jobstep.js | 2 +- web/pgadmin/browser/static/js/browser.js | 20 +++- web/pgadmin/browser/static/js/node.js | 27 +-- web/pgadmin/help/__init__.py | 2 +- web/pgadmin/help/static/js/help.js | 27 +++ web/regression/javascript/help/help_spec.js| 56 ++ web/webpack.shim.js| 1 + 8 files changed, 106 insertions(+), 30 deletions(-)
pgAdmin 4 commit: Ensure sequences can be created with increment, start
Ensure sequences can be created with increment, start, minimum and maximum options set. Fixes #4100 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=212ca01506f02d62bedc37d5c6af8f209b7486cc Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_4_4.rst| 3 ++- .../servers/databases/schemas/sequences/__init__.py | 15 ++- .../sequences/templates/sequence/sql/default/create.sql | 14 +++--- .../schemas/sequences/tests/test_sequence_add.py| 17 - 4 files changed, 19 insertions(+), 30 deletions(-)
Re: [pgAdmin4][Patch]: RM #4100 Unable to create sequence with Increment, Start, Minimum and Maximum value
Thanks, patch applied. On Fri, Mar 22, 2019 at 1:51 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #4100 "Unable to create sequence with > Increment, Start, Minimum and Maximum value". > > Please review it. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
