pgAdmin 4 commit: Update wcDocker to fix the issue where the Scratch Pa
Update wcDocker to fix the issue where the Scratch Pad grows in size if the results panel is resized. Fixes #3968 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=61f11aa4fcbf223c00ddab5fcf03d8808ef2bef3 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_4.rst | 1 + web/package.json | 2 +- web/yarn.lock| 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-)
Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)
Thanks, applied. Do we still need our fork of wcDocker? Also, please let me know when you're running low on things to do in this sprint (not including schema diff). I have one other issue I'd like to get worked on ASAP. Thanks! On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix > resize issue in wcDocker is merged. Attached patch will update the version > of wcDocker and fix the issue in pgAdmin4. > Do not forget to yarn install. > > Kindly review. > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)
Hi, On Thu, Mar 21, 2019 at 2:51 PM Dave Page wrote: > Thanks, applied. > > Do we still need our fork of wcDocker? > Yes we do. pgAdmin depends on changes done on forked wcDocker. > > Also, please let me know when you're running low on things to do in this > sprint (not including schema diff). I have one other issue I'd like to get > worked on ASAP. > Yeah, please let me know. I am available. > > Thanks! > > On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix >> resize issue in wcDocker is merged. Attached patch will update the version >> of wcDocker and fix the issue in pgAdmin4. >> Do not forget to yarn install. >> >> Kindly review. >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"
Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)
On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, Mar 21, 2019 at 2:51 PM Dave Page wrote: > >> Thanks, applied. >> >> Do we still need our fork of wcDocker? >> > Yes we do. pgAdmin depends on changes done on forked wcDocker. > >> >> Also, please let me know when you're running low on things to do in this >> sprint (not including schema diff). I have one other issue I'd like to get >> worked on ASAP. >> > Yeah, please let me know. I am available. > Cool - https://redmine.postgresql.org/issues/4084 I'd like to discuss first though - are you available in the next 5 or 10 minutes > >> Thanks! >> >> On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix >>> resize issue in wcDocker is merged. Attached patch will update the version >>> of wcDocker and fix the issue in pgAdmin4. >>> Do not forget to yarn install. >>> >>> Kindly review. >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)
Hi, On Thu, Mar 21, 2019 at 3:08 PM Dave Page wrote: > > > On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, Mar 21, 2019 at 2:51 PM Dave Page wrote: >> >>> Thanks, applied. >>> >>> Do we still need our fork of wcDocker? >>> >> Yes we do. pgAdmin depends on changes done on forked wcDocker. >> >>> >>> Also, please let me know when you're running low on things to do in this >>> sprint (not including schema diff). I have one other issue I'd like to get >>> worked on ASAP. >>> >> Yeah, please let me know. I am available. >> > > Cool - https://redmine.postgresql.org/issues/4084 > > I'd like to discuss first though - are you available in the next 5 or 10 > minutes > Will be available after 30 mins (have meeting) :/ > > >> >>> Thanks! >>> >>> On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix resize issue in wcDocker is merged. Attached patch will update the version of wcDocker and fix the issue in pgAdmin4. Do not forget to yarn install. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"
Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)
On Thu, Mar 21, 2019 at 9:41 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, Mar 21, 2019 at 3:08 PM Dave Page wrote: > >> >> >> On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, Mar 21, 2019 at 2:51 PM Dave Page wrote: >>> Thanks, applied. Do we still need our fork of wcDocker? >>> Yes we do. pgAdmin depends on changes done on forked wcDocker. >>> Also, please let me know when you're running low on things to do in this sprint (not including schema diff). I have one other issue I'd like to get worked on ASAP. >>> Yeah, please let me know. I am available. >>> >> >> Cool - https://redmine.postgresql.org/issues/4084 >> >> I'd like to discuss first though - are you available in the next 5 or 10 >> minutes >> > Will be available after 30 mins (have meeting) :/ > Just realised so do I. I'll ping you... -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised
Hi Dave, On Wed, Mar 20, 2019 at 8:37 PM Dave Page wrote: > Hi > > On Wed, Mar 20, 2019 at 7:30 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM #4030 - IDENTITY column not >> recognised. >> - Added support for IDENTITY column for PostgreSQL >= 10.0 >> > > A few issues unfortunately: > > - There's an extra space in the generated SQL for an identity column on a > table, right before the end comma (in both the CREATE and reverse > engineered SQL. > > - I cannot make an IDENTITY column a primary key through the UI, nor does > it reverse-engineer that property in the SQL if I create it via SQL (it > does properly set the switch value though). > This issue has already been logged earlier, but I will fix this with this patch. > > - After creating an IDENTITY column, there should be a dependency on the > sequence, but I don't see this listed. > If the *Show System Object* is enabled, then only you can see. > > - We should consider the auto-created sequence a system object, and hide > it in the treeview by default as it's an implementation detail. > How, can I identify those as a system object? I tried but couldn't find a way. > > - If I click on an IDENTITY column in the treeview, the reverse-engineered > SQL just shows the plain datatype. > Fixed. > > - Can we reasonably support the sequence_options clause? > I will look into it. > > Thanks. > > Thanks, Khushboo > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised
Hi On Thu, Mar 21, 2019 at 9:52 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Mar 20, 2019 at 8:37 PM Dave Page wrote: > >> Hi >> >> On Wed, Mar 20, 2019 at 7:30 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the RM #4030 - IDENTITY column >>> not recognised. >>> - Added support for IDENTITY column for PostgreSQL >= 10.0 >>> >> >> A few issues unfortunately: >> >> - There's an extra space in the generated SQL for an identity column on a >> table, right before the end comma (in both the CREATE and reverse >> engineered SQL. >> >> - I cannot make an IDENTITY column a primary key through the UI, nor does >> it reverse-engineer that property in the SQL if I create it via SQL (it >> does properly set the switch value though). >> > This issue has already been logged earlier, but I will fix this with this > patch. > >> >> - After creating an IDENTITY column, there should be a dependency on the >> sequence, but I don't see this listed. >> > If the *Show System Object* is enabled, then only you can see. > Hmm, OK. I turned on "Show System Objects" and I do now see the dependencies. Something seems funky though: - The sequence has a dependency of the column - The sequence is dependent on the table Shouldn't they both be dependencies? It's the table and column that needs the sequence. - The sequence is only listed as a dependent of the column (which is the opposite of what is seen on the sequence, as you'd expect), but it doesn't show that it's dependent on the table, in the same way that a table lists a schema as a dependency. Is our SQL messed up here, or is PostgreSQL listing things in a funky way? I'd expect to see: When clicking on the sequence: - Dependencies should list the schema. - Dependents should list the table and column. When clicking on the column: - Dependencies should list the sequence. - Dependents should list the table. I grant you it's confusing and open to interpretation though. I think as long as we're definitely listing things as PG tracks them, it's all good. > >> - We should consider the auto-created sequence a system object, and hide >> it in the treeview by default as it's an implementation detail. >> > How, can I identify those as a system object? I tried but couldn't find a > way. > Check if there's a dependency on a column. > >> - If I click on an IDENTITY column in the treeview, the >> reverse-engineered SQL just shows the plain datatype. >> > Fixed. > >> >> - Can we reasonably support the sequence_options clause? >> > I will look into it. > Thanks. > >> Thanks. >> >> Thanks, > Khushboo > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Regarding DDL in pgadmin
[please keep messages on-list] On Thu, Mar 21, 2019 at 10:16 AM Travis wrote: > Thanks a lot! > > yeah rev eng sucks. > > I'm currently going through the source code, can you kindly point me to > the module where the rev engineering is already being done.? > Most of the heavy lifting will be done in __init__.py in https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=tree;f=web/pgadmin/browser/server_groups/servers/databases/schemas/tables. The re-construction of the SQL is done using templates in the templates sub-directory. Start at the sql(self, gid, sid, did, scid, tid) function and work back from there. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
[pgAdmin] - RM-3936 -Feature tests patch
Hi Hackers, Please find here attached patch for feature tests. Due to intermittent failures on jenkins and some other system, following fixes are done(but not limited to them only as other small fixes are also done) - tree toggle issue - Query tool inteliSence issue eg. when there is only one option and drop down is not shown - Backup and restore windows locator changes - Fixes required due to resolving rm # 4041 - Dependent tab not showing data sometime, so refreshed the page and handled it - Due to change of logic for auto commit, did the required changes - Due to fix of RM 4062, did the required workaround which broke the test case. -- Thanks, Usman Muzaffar QA Team EnterpriseDB Corporation RM3936_v2.patch Description: Binary data
pgAdmin 4 commit: Tidy up table formatting in the docs. Thanks to Susan
Tidy up table formatting in the docs. Thanks to Susan Douglas for the tips! Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f22503ad2f6797d4c967ea749ee2cbe74d1880f Modified Files -- docs/en_US/desktop_deployment.rst | 26 + docs/en_US/keyboard_shortcuts.rst | 7 +++ docs/en_US/query_tool_toolbar.rst | 57 ++-- docs/en_US/tabbed_browser.rst | 110 -- docs/en_US/table_dialog.rst | 68 --- 5 files changed, 147 insertions(+), 121 deletions(-)
pgAdmin 4 commit: Many fixes to the stability of the feature tests, inc
Many fixes to the stability of the feature tests, including: tree toggle issue Query tool inteliSence issue eg. when there is only one option and drop down is not shown Backup and restore windows locator changes Fixes required due to resolving rm # 4041 Dependent tab not showing data sometime, so refreshed the page and handled it Due to change of logic for auto commit, did the required changes Due to fix of RM 4062, did the required workaround which broke the test case. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be26fc540ce7b9eb9a948e971f0641cb9148b64e Author: Usman Muzaffar Modified Files -- web/pgadmin/browser/static/js/frame.js | 2 +- web/pgadmin/feature_tests/browser_tool_bar_test.py | 2 +- .../copy_selected_query_results_feature_test.py| 3 - web/pgadmin/feature_tests/file_manager_test.py | 23 +- .../feature_tests/pg_datatype_validation_test.py | 9 +- .../pg_utilities_backup_restore_test.py| 21 +- .../feature_tests/pg_utilities_maintenance_test.py | 2 +- .../query_tool_auto_complete_tests.py | 17 +- .../feature_tests/query_tool_journey_test.py | 55 +++-- web/pgadmin/feature_tests/query_tool_tests.py | 273 ++--- web/pgadmin/feature_tests/test_data.json | 4 +- web/pgadmin/feature_tests/view_data_dml_queries.py | 18 +- .../xss_checks_panels_and_query_tool_test.py | 19 +- web/pgadmin/tools/datagrid/static/js/datagrid.js | 28 ++- web/pgadmin/utils/route.py | 9 +- web/regression/README | 8 + web/regression/feature_utils/pgadmin_page.py | 194 --- .../python_test_utils/test_gui_helper.py | 16 +- web/regression/requirements.txt| 4 +- web/regression/runtests.py | 11 +- 20 files changed, 497 insertions(+), 221 deletions(-)
Re: [pgAdmin] - RM-3936 -Feature tests patch
Hi
Awesome job (and they're much faster now!) - patch committed (but there's
still work to do :-( ). Here are my thoughts:
- The first time I ran the tests, a couple failed. This was because the
external process output dialogue was too big for the screen (when I ran on
a large screen and maximised the browser instance, the tests all passed).
We may need to change the default size/position of the output dialogue, and
perhaps maximise the browser window at launch (though I think the tests
*must* run on a minimum screen size of 1024x768).
- The process notifier dialogues should be explicitly closed at the end of
each test. I ended up with a screen full of them after all the tests had
run.
- I saw one error (probably caused by a failing test) which complained that
test_role already existed. That name should probably be randomised.
- The test output is really messy. I'd like to have some standard functions
for printing the output so it looks more like:
runTest
(pgadmin.feature_tests.pg_utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTest)
* Test for PG maintenance: table... PASS
runTest
(pgadmin.feature_tests.pg_utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTest)
* Test for XSS in maintenance dialog... PASS
runTest
(pgadmin.feature_tests.query_tool_auto_complete_tests.QueryToolAutoCompleteFeatureTest)
Query tool auto complete feature tests ...
* Auto complete ALTER keyword... PASS
* Auto complete BEGIN keyword... FAIL
* Auto complete CASCADED keyword... PASS
The runTest messages are all consistent anyway, and iirc, they all come
from the test framework. So maybe we need something like:
print_test_note(note="Query tool auto complete feature test")
print("%s" % note)
print_subtest_name(name="Auto complete CASCADED keyword")
print("%s... " % name, end='')
print_subtest_result(status)
print("PASS" if status else "FAIL")
It may seem trivial, but having neat, consistent output will make the test
results much easier for us to read.
Thanks!
On Thu, Mar 21, 2019 at 11:14 AM Usman Muzaffar <
usman.muzaf...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Please find here attached patch for feature tests. Due to intermittent
> failures on jenkins and some other system, following fixes are done(but not
> limited to them only as other small fixes are also done)
>
>- tree toggle issue
>- Query tool inteliSence issue eg. when there is only one option and
>drop down is not shown
>- Backup and restore windows locator changes
>- Fixes required due to resolving rm # 4041
>- Dependent tab not showing data sometime, so refreshed the page and
>handled it
>- Due to change of logic for auto commit, did the required changes
>- Due to fix of RM 4062, did the required workaround which broke the
>test case.
>
> --
>
>
> Thanks,
>
> Usman Muzaffar
> QA Team
> EnterpriseDB Corporation
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add new file missed in last commit.
Add new file missed in last commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33693734fc99806f047bdff08bfae070ce9f93ff Author: Usman Muzaffar Modified Files -- web/pgadmin/feature_tests/locators.py | 22 ++ 1 file changed, 22 insertions(+)
pgAdmin 4 commit: Fix PEP-8 issues.
Fix PEP-8 issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b2b5629a012a278437232f231bf31ae39cc24235 Modified Files -- .../feature_tests/pg_utilities_backup_restore_test.py | 3 --- .../feature_tests/query_tool_auto_complete_tests.py| 12 ++-- web/pgadmin/feature_tests/query_tool_journey_test.py | 6 +++--- web/pgadmin/feature_tests/query_tool_tests.py | 11 +-- web/regression/feature_utils/pgadmin_page.py | 14 +++--- 5 files changed, 21 insertions(+), 25 deletions(-)
pgAdmin 4 commit: Don't use old-style variable notation.
Don't use old-style variable notation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17464aa0343383afd22d2006e69172f17001c3b0 Modified Files -- pkg/docker/build.sh | 20 +++--- pkg/mac/build.sh| 160 ++-- pkg/mac/codesign-bundle.sh | 2 +- pkg/mac/codesign-dmg.sh | 10 +-- pkg/mac/complete-bundle.sh | 150 - pkg/mac/create-dmg.sh | 32 - pkg/mac/framework-config.sh | 2 +- pkg/pip/build.sh| 34 +- pkg/src/build.sh| 46 ++--- 9 files changed, 228 insertions(+), 228 deletions(-)
pgAdmin 4 commit: Fix indent.
Fix indent. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=89784413dd375b98e4816952786430804d5bfb6c Modified Files -- docs/en_US/pgagent_install.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Improve the German translation for Backup Server, per
Improve the German translation for Backup Server, per H Re. Fixes #4090 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83bb07e01dd403fedd40c2fbfbc6254cbacd930e Modified Files -- docs/en_US/release_notes_4_4.rst | 1 + .../translations/de/LC_MESSAGES/messages.mo| Bin 148463 -> 148461 bytes .../translations/de/LC_MESSAGES/messages.po| 2 +- 3 files changed, 2 insertions(+), 1 deletion(-)
RM3887 - User storage home folder collision
Here's a patch to fix and repair $SUBJECT. Anyone see any issues with it? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3887.diff Description: Binary data
Re: RM3887 - User storage home folder collision
Hi Dave, On Thu, Mar 21, 2019 at 10:41 PM Dave Page wrote: > Here's a patch to fix and repair $SUBJECT. > > Anyone see any issues with it? > > Looks good to me. Thanks, Khushboo > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: RM3887 - User storage home folder collision
Looks good to me. On Thu, Mar 21, 2019 at 10:41 PM Dave Page wrote: > Here's a patch to fix and repair $SUBJECT. > > Anyone see any issues with it? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"
